Re: Broken/Flaky Tests

[Hubert Sun]

While it may be frustrating to have 15 changes queued up, the goal is to
get the builds green. Allowing changes that are deemed low risk won't help
this cause. Let's concentrate on addressing the build issues

as
quickly as possible.

Hubert

On Fri, Jun 1, 2018 at 11:18 AM Thomas Tauber-Marshall <
tmarsh...@cloudera.com> wrote:

> So while its definitely better, there are still a large number of failing
> builds. We've been hit by at least: IMPALA-6642
> , IMPALA-6956
> , IMPALA-7101
>  and IMPALA-3040
> 
> all within the last day, along with some mysterious crashes that I haven't
> filed anything for with Apache yet as there's very little info about what's
> actually going on. There are still multiple builds that haven't been green
> in over a month.
> 
>
> Of course, if we hold commits for too long, there's a danger that when we
> open things back up a bunch of changes will all land at the same time and
> destabilize the builds again, putting back in the same situation. So, I
> would say at a minimum that any changes that are relatively minor and low
> risk can go in now.
>
> My preference would be to hold off on major changes until we have more
> stability.
>
> On Fri, Jun 1, 2018 at 10:30 AM Lars Volker  wrote:
>
> > Hi Thomas,
> >
> > Can you give an update on where we are with the builds?
> >
> > We currently have ~15 changes with a +2:
> >
> >
> https://gerrit.cloudera.org/#/q/status:open+project:Impala-ASF+branch:master+label:Code-Review%253D2
> >
> > Thanks, Lars
> >
> > On Fri, May 25, 2018 at 5:20 PM, Henry Robinson 
> wrote:
> >
> > > +1 - thanks for worrying about build health.
> > >
> > > On 25 May 2018 at 17:18, Jim Apple  wrote:
> > >
> > > > Sounds good to me. Thanks for taking ownership!
> > > >
> > > > On Fri, May 25, 2018 at 5:10 PM Thomas Tauber-Marshall <
> > > > tmarsh...@cloudera.com> wrote:
> > > >
> > > > > Hey Impala community,
> > > > >
> > > > > There seems to have been an unusually large number of flaky or
> broken
> > > > tests
> > > > > <
> > > > > https://issues.apache.org/jira/browse/IMPALA-7073?jql=
> > > > project%20%3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%
> > > > 22In%20Progress%22%2C%20Reopened)%20AND%20labels%
> > > > 20in%20(flaky%2C%20broken-build)
> > > > > >
> > > > > cropping up in the last few weeks. I'd like to suggest that we hold
> > off
> > > > on
> > > > > merging new changes that aren't related to fixing those testing
> > issues
> > > > for
> > > > > at least a few days until things become more stable.
> > > > >
> > > > > Does anyone have any objections? If not, I'll send out another
> email
> > > when
> > > > > more of the issues have been addressed.
> > > > >
> > > > > Thanks,
> > > > > Thomas Tauber-Marshall
> > > > >
> > > >
> > >
> >
>

Re: jenkins.impala.io account

[Michael Brown]

Ahh no, it doesn't do that. Currently you have to go back and check the job
status yourself.

I guess we could change the "dry run" part only to be about doing the
commit portion and still always mark whether verified.

On Fri, Jun 1, 2018 at 11:43 AM, Todd Lipcon  wrote:

> On Fri, Jun 1, 2018 at 11:37 AM, Michael Brown  wrote:
>
> > Thanks for taking an interest!
> >
> > Is https://jenkins.impala.io/job/gerrit-verify-dryrun-external/ suitable
> > for you? It's open to all contributors. It's just a wrapper around
> > gerrit-verify-dryrun, sans commit-after-passing-build bit.
> >
>
> Will this give the proper "+1 verified" mark on a gerrit such that it can
> be committed?
>
> -Todd
>
>
> > On Fri, Jun 1, 2018 at 11:35 AM, Todd Lipcon  wrote:
> >
> > > Hey folks,
> > >
> > > Would someone mind generating an account for me on the Impala jenkins
> > > server so I can run gerrit verify jobs?
> > >
> > > Though I'm officially a committer (due to participation as a mentor
> > during
> > > incubation) I'm not yet an experienced patch contributor, so I'll be
> > > prudent with my review/commit privileges.
> > >
> > > Thanks
> > > -Todd
> > > --
> > > Todd Lipcon
> > > Software Engineer, Cloudera
> > >
> >
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>

Re: jenkins.impala.io account

[Todd Lipcon]

On Fri, Jun 1, 2018 at 11:37 AM, Michael Brown  wrote:

> Thanks for taking an interest!
>
> Is https://jenkins.impala.io/job/gerrit-verify-dryrun-external/ suitable
> for you? It's open to all contributors. It's just a wrapper around
> gerrit-verify-dryrun, sans commit-after-passing-build bit.
>

Will this give the proper "+1 verified" mark on a gerrit such that it can
be committed?

-Todd


> On Fri, Jun 1, 2018 at 11:35 AM, Todd Lipcon  wrote:
>
> > Hey folks,
> >
> > Would someone mind generating an account for me on the Impala jenkins
> > server so I can run gerrit verify jobs?
> >
> > Though I'm officially a committer (due to participation as a mentor
> during
> > incubation) I'm not yet an experienced patch contributor, so I'll be
> > prudent with my review/commit privileges.
> >
> > Thanks
> > -Todd
> > --
> > Todd Lipcon
> > Software Engineer, Cloudera
> >
>



-- 
Todd Lipcon
Software Engineer, Cloudera

Re: jenkins.impala.io account

[Michael Brown]

Thanks for taking an interest!

Is https://jenkins.impala.io/job/gerrit-verify-dryrun-external/ suitable
for you? It's open to all contributors. It's just a wrapper around
gerrit-verify-dryrun, sans commit-after-passing-build bit.

On Fri, Jun 1, 2018 at 11:35 AM, Todd Lipcon  wrote:

> Hey folks,
>
> Would someone mind generating an account for me on the Impala jenkins
> server so I can run gerrit verify jobs?
>
> Though I'm officially a committer (due to participation as a mentor during
> incubation) I'm not yet an experienced patch contributor, so I'll be
> prudent with my review/commit privileges.
>
> Thanks
> -Todd
> --
> Todd Lipcon
> Software Engineer, Cloudera
>

Re: Broken/Flaky Tests

[Lars Volker]

Hi Thomas,

Can you give an update on where we are with the builds?

We currently have ~15 changes with a +2:
https://gerrit.cloudera.org/#/q/status:open+project:Impala-ASF+branch:master+label:Code-Review%253D2

Thanks, Lars

On Fri, May 25, 2018 at 5:20 PM, Henry Robinson  wrote:

> +1 - thanks for worrying about build health.
>
> On 25 May 2018 at 17:18, Jim Apple  wrote:
>
> > Sounds good to me. Thanks for taking ownership!
> >
> > On Fri, May 25, 2018 at 5:10 PM Thomas Tauber-Marshall <
> > tmarsh...@cloudera.com> wrote:
> >
> > > Hey Impala community,
> > >
> > > There seems to have been an unusually large number of flaky or broken
> > tests
> > > <
> > > https://issues.apache.org/jira/browse/IMPALA-7073?jql=
> > project%20%3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%
> > 22In%20Progress%22%2C%20Reopened)%20AND%20labels%
> > 20in%20(flaky%2C%20broken-build)
> > > >
> > > cropping up in the last few weeks. I'd like to suggest that we hold off
> > on
> > > merging new changes that aren't related to fixing those testing issues
> > for
> > > at least a few days until things become more stable.
> > >
> > > Does anyone have any objections? If not, I'll send out another email
> when
> > > more of the issues have been addressed.
> > >
> > > Thanks,
> > > Thomas Tauber-Marshall
> > >
> >
>