[Patch Ready] Add support for reading ORC complex types
Hi all, I'm excited that we can support reading ORC complex types (IMPALA-6503) now! I just finish the patch. As a community developer, I can't discuss with you Cloudera folks in real. It may be hard to make codes clear via comments for a big patch, so I wrote a doc about the implementation: https://docs.google.com/document/d/10Gzcge57VUOQ0ZQWfWiIW9cUix8_FumMewl0Gja3ZA4 (I may need to add more details, please let me know) Patch link: https://gerrit.cloudera.org/#/c/12168/ Have passed pre-review-test: https://jenkins.impala.io/job/pre-review-test/269/ Hopes you can take some time to review it. Thanks! Quanlong
Re: [Patch Ready] Add support for reading ORC complex types
"As a community developer, I can't discuss with you Cloudera folks in real." Do you mean in-person? Because if you mean "real", we want to strive to have dev@impala.apache.org be very real. In particular, I and others I work with at Cloudera, often in the same building, have discussions (that we could have in person) here on dev@ instead in order to do community work in the open. Some other communities, like Parquet, will have regularly scheduled face-to-face meetings over videoconferencing. Time zones are hard, of course, but this is something we could try if someone wants to take charge of organizing it, recruiting people to come, sending out notes, etc. In the meantime, let's all work to make dev@ and gerrit great places to have productive discussions. Thanks for making the google doc, BTW: I think that's really helpful for large and complex patches. On Mon, Jan 7, 2019 at 7:28 AM Quanlong Huang wrote: > Hi all, > > I'm excited that we can support reading ORC complex types (IMPALA-6503) > now! > > I just finish the patch. As a community developer, I can't discuss with you > Cloudera folks in real. It may be hard to make codes clear via comments for > a big patch, so I wrote a doc about the implementation: > > https://docs.google.com/document/d/10Gzcge57VUOQ0ZQWfWiIW9cUix8_FumMewl0Gja3ZA4 > (I may need to add more details, please let me know) > > Patch link: https://gerrit.cloudera.org/#/c/12168/ > Have passed pre-review-test: > https://jenkins.impala.io/job/pre-review-test/269/ > > Hopes you can take some time to review it. > > Thanks! > Quanlong >
Re: [Patch Ready] Add support for reading ORC complex types
Sorry for my words that may make you uncomfortable... Yes, I mean in-person because it's more efficient. I thought you have many discussions and meetings about the design, roadmap or planning. But different time zones are really an obstacle. Having discussions face to face is not quite realistic. Maybe we can start another thread to discuss the interaction of the Impala community, e.g. regular meetings (via Slack or WeChat), roadmap and planning discussion, etc. Thanks for all your efforts to make the community grow! On Tue, Jan 8, 2019 at 6:07 AM Jim Apple wrote: > "As a community developer, I can't discuss with you Cloudera folks in > real." > > Do you mean in-person? Because if you mean "real", we want to strive to > have dev@impala.apache.org be very real. In particular, I and others I > work > with at Cloudera, often in the same building, have discussions (that we > could have in person) here on dev@ instead in order to do community work > in > the open. > > Some other communities, like Parquet, will have regularly scheduled > face-to-face meetings over videoconferencing. Time zones are hard, of > course, but this is something we could try if someone wants to take charge > of organizing it, recruiting people to come, sending out notes, etc. > > In the meantime, let's all work to make dev@ and gerrit great places to > have productive discussions. > > Thanks for making the google doc, BTW: I think that's really helpful for > large and complex patches. > > On Mon, Jan 7, 2019 at 7:28 AM Quanlong Huang > wrote: > > > Hi all, > > > > I'm excited that we can support reading ORC complex types (IMPALA-6503) > > now! > > > > I just finish the patch. As a community developer, I can't discuss with > you > > Cloudera folks in real. It may be hard to make codes clear via comments > for > > a big patch, so I wrote a doc about the implementation: > > > > > https://docs.google.com/document/d/10Gzcge57VUOQ0ZQWfWiIW9cUix8_FumMewl0Gja3ZA4 > > (I may need to add more details, please let me know) > > > > Patch link: https://gerrit.cloudera.org/#/c/12168/ > > Have passed pre-review-test: > > https://jenkins.impala.io/job/pre-review-test/269/ > > > > Hopes you can take some time to review it. > > > > Thanks! > > Quanlong > > >
Re: [Patch Ready] Add support for reading ORC complex types
I think it's an excellent idea to have a face-to-face video meeting with the larger community on this mailing list. It might not be convenient to have a regular schedule due to time zone constraints, but a one-off to say "hi", introduce each other, and have a discussion would be helpful. I can start a thread to see who's in which TZ and to find a good time. On Mon, Jan 7, 2019 at 5:53 PM Quanlong Huang wrote: > Sorry for my words that may make you uncomfortable... Yes, I mean in-person > because it's more efficient. I thought you have many discussions and > meetings about the design, roadmap or planning. But different time zones > are really an obstacle. Having discussions face to face is not quite > realistic. > > Maybe we can start another thread to discuss the interaction of the Impala > community, e.g. regular meetings (via Slack or WeChat), roadmap and > planning discussion, etc. > > Thanks for all your efforts to make the community grow! > > On Tue, Jan 8, 2019 at 6:07 AM Jim Apple wrote: > > > "As a community developer, I can't discuss with you Cloudera folks in > > real." > > > > Do you mean in-person? Because if you mean "real", we want to strive to > > have dev@impala.apache.org be very real. In particular, I and others I > > work > > with at Cloudera, often in the same building, have discussions (that we > > could have in person) here on dev@ instead in order to do community work > > in > > the open. > > > > Some other communities, like Parquet, will have regularly scheduled > > face-to-face meetings over videoconferencing. Time zones are hard, of > > course, but this is something we could try if someone wants to take > charge > > of organizing it, recruiting people to come, sending out notes, etc. > > > > In the meantime, let's all work to make dev@ and gerrit great places to > > have productive discussions. > > > > Thanks for making the google doc, BTW: I think that's really helpful for > > large and complex patches. > > > > On Mon, Jan 7, 2019 at 7:28 AM Quanlong Huang > > wrote: > > > > > Hi all, > > > > > > I'm excited that we can support reading ORC complex types (IMPALA-6503) > > > now! > > > > > > I just finish the patch. As a community developer, I can't discuss with > > you > > > Cloudera folks in real. It may be hard to make codes clear via comments > > for > > > a big patch, so I wrote a doc about the implementation: > > > > > > > > > https://docs.google.com/document/d/10Gzcge57VUOQ0ZQWfWiIW9cUix8_FumMewl0Gja3ZA4 > > > (I may need to add more details, please let me know) > > > > > > Patch link: https://gerrit.cloudera.org/#/c/12168/ > > > Have passed pre-review-test: > > > https://jenkins.impala.io/job/pre-review-test/269/ > > > > > > Hopes you can take some time to review it. > > > > > > Thanks! > > > Quanlong > > > > > >
Re: [Patch Ready] Add support for reading ORC complex types
Thanks, Lars! On Tue, Jan 8, 2019 at 1:39 PM Lars Volker wrote: > I think it's an excellent idea to have a face-to-face video meeting with > the larger community on this mailing list. It might not be convenient to > have a regular schedule due to time zone constraints, but a one-off to say > "hi", introduce each other, and have a discussion would be helpful. I can > start a thread to see who's in which TZ and to find a good time. > > On Mon, Jan 7, 2019 at 5:53 PM Quanlong Huang > wrote: > > > Sorry for my words that may make you uncomfortable... Yes, I mean > in-person > > because it's more efficient. I thought you have many discussions and > > meetings about the design, roadmap or planning. But different time zones > > are really an obstacle. Having discussions face to face is not quite > > realistic. > > > > Maybe we can start another thread to discuss the interaction of the > Impala > > community, e.g. regular meetings (via Slack or WeChat), roadmap and > > planning discussion, etc. > > > > Thanks for all your efforts to make the community grow! > > > > On Tue, Jan 8, 2019 at 6:07 AM Jim Apple wrote: > > > > > "As a community developer, I can't discuss with you Cloudera folks in > > > real." > > > > > > Do you mean in-person? Because if you mean "real", we want to strive to > > > have dev@impala.apache.org be very real. In particular, I and others I > > > work > > > with at Cloudera, often in the same building, have discussions (that we > > > could have in person) here on dev@ instead in order to do community > work > > > in > > > the open. > > > > > > Some other communities, like Parquet, will have regularly scheduled > > > face-to-face meetings over videoconferencing. Time zones are hard, of > > > course, but this is something we could try if someone wants to take > > charge > > > of organizing it, recruiting people to come, sending out notes, etc. > > > > > > In the meantime, let's all work to make dev@ and gerrit great places > to > > > have productive discussions. > > > > > > Thanks for making the google doc, BTW: I think that's really helpful > for > > > large and complex patches. > > > > > > On Mon, Jan 7, 2019 at 7:28 AM Quanlong Huang > > > > wrote: > > > > > > > Hi all, > > > > > > > > I'm excited that we can support reading ORC complex types > (IMPALA-6503) > > > > now! > > > > > > > > I just finish the patch. As a community developer, I can't discuss > with > > > you > > > > Cloudera folks in real. It may be hard to make codes clear via > comments > > > for > > > > a big patch, so I wrote a doc about the implementation: > > > > > > > > > > > > > > https://docs.google.com/document/d/10Gzcge57VUOQ0ZQWfWiIW9cUix8_FumMewl0Gja3ZA4 > > > > (I may need to add more details, please let me know) > > > > > > > > Patch link: https://gerrit.cloudera.org/#/c/12168/ > > > > Have passed pre-review-test: > > > > https://jenkins.impala.io/job/pre-review-test/269/ > > > > > > > > Hopes you can take some time to review it. > > > > > > > > Thanks! > > > > Quanlong > > > > > > > > > >
