Re: Wrong Jira id in commit (IMPALA-7147 vs IMPALA-7417)
Thanks for the answers, I have did this change. On Tue, Sep 4, 2018 at 5:18 PM, Lars Volker wrote: > +1, thanks for fixing it. > > On Mon, Sep 3, 2018, 12:16 Brock Noland wrote: > > > I would do this, it's quite courteous for future devs. > > > > "Our current idea is to change IMPALA-7417 > > to be a duplicate of IMPALA-7147, and create a new Jira with > IMPALA-7417's > > original contents." > > > > On Mon, Sep 3, 2018 at 12:12 PM, Csaba Ringhofer < > csringho...@cloudera.com > > > > > wrote: > > > > > Hi folks! > > > > > > We have just discovered (thanks Laszlo), that one of my changes was > > pushed > > > with wrong Jira id in the commit message (it fixed IMPALA-7147, but I > > wrote > > > it as IMPALA-7417, which didn't exist at that time). > > > > > > Luckily there is no commit pushed for IMPALA-7417 yet (it is on > review, > > > and happens to be my commit too). Our current idea is to change > > IMPALA-7417 > > > to be a duplicate of IMPALA-7147, and create a new Jira with > > IMPALA-7417's > > > original contents. > > > > > > Does someone have an idea about the best action in this case? My > concern > > > is that the wrong Jira id can trick some tools and steal some time from > > > people. > > > > > >
Re: Wrong Jira id in commit (IMPALA-7147 vs IMPALA-7417)
+1, thanks for fixing it. On Mon, Sep 3, 2018, 12:16 Brock Noland wrote: > I would do this, it's quite courteous for future devs. > > "Our current idea is to change IMPALA-7417 > to be a duplicate of IMPALA-7147, and create a new Jira with IMPALA-7417's > original contents." > > On Mon, Sep 3, 2018 at 12:12 PM, Csaba Ringhofer > > wrote: > > > Hi folks! > > > > We have just discovered (thanks Laszlo), that one of my changes was > pushed > > with wrong Jira id in the commit message (it fixed IMPALA-7147, but I > wrote > > it as IMPALA-7417, which didn't exist at that time). > > > > Luckily there is no commit pushed for IMPALA-7417 yet (it is on review, > > and happens to be my commit too). Our current idea is to change > IMPALA-7417 > > to be a duplicate of IMPALA-7147, and create a new Jira with > IMPALA-7417's > > original contents. > > > > Does someone have an idea about the best action in this case? My concern > > is that the wrong Jira id can trick some tools and steal some time from > > people. > > >
Re: Wrong Jira id in commit (IMPALA-7147 vs IMPALA-7417)
I would do this, it's quite courteous for future devs. "Our current idea is to change IMPALA-7417 to be a duplicate of IMPALA-7147, and create a new Jira with IMPALA-7417's original contents." On Mon, Sep 3, 2018 at 12:12 PM, Csaba Ringhofer wrote: > Hi folks! > > We have just discovered (thanks Laszlo), that one of my changes was pushed > with wrong Jira id in the commit message (it fixed IMPALA-7147, but I wrote > it as IMPALA-7417, which didn't exist at that time). > > Luckily there is no commit pushed for IMPALA-7417 yet (it is on review, > and happens to be my commit too). Our current idea is to change IMPALA-7417 > to be a duplicate of IMPALA-7147, and create a new Jira with IMPALA-7417's > original contents. > > Does someone have an idea about the best action in this case? My concern > is that the wrong Jira id can trick some tools and steal some time from > people. >
Wrong Jira id in commit (IMPALA-7147 vs IMPALA-7417)
Hi folks! We have just discovered (thanks Laszlo), that one of my changes was pushed with wrong Jira id in the commit message (it fixed IMPALA-7147, but I wrote it as IMPALA-7417, which didn't exist at that time). Luckily there is no commit pushed for IMPALA-7417 yet (it is on review, and happens to be my commit too). Our current idea is to change IMPALA-7417 to be a duplicate of IMPALA-7147, and create a new Jira with IMPALA-7417's original contents. Does someone have an idea about the best action in this case? My concern is that the wrong Jira id can trick some tools and steal some time from people.
