Re: [DISCUSS] Release of 0.9.1

2019-12-18 Thread jincheng sun
I see, thanks for your explanation for IOTDB-300[1] and double check the
IOTDB-268[2] Jialin! :)

Best,
Jincheng
@sunjincheng121 

[1] https://issues.apache.org/jira/browse/IOTDB-300
[2] https://issues.apache.org/jira/browse/IOTDB-268


Jialin Qiao  于2019年12月18日周三 下午3:47写道:

> Hi,
>
> IOTDB-300 is already fixed in 0.9.0. It is a bug introduced in
> 0.9.0-SNAPSHOT, therefore it is not included in the Release_Notes from
> 0.8.0 to 0.9.0.
>
> If I don't misunderstand, IOTDB-268 is not a blocker issue that affects the
> running of spark-iotdb-connector module. It is just a new feature that
> wants a new format of timestamp in spark-iotdb-connector.
>
> Thanks,
> Jialin Qiao
>
> jincheng sun  于2019年12月18日周三 下午3:23写道:
>
> > +1 for release IoTDB 0.9.1 as IOTDB-300 is very important fix.
> >
> > And I think the blocker issue [1] should be contains in 0.9.1, or someone
> > should check is whether a blocker issue.
> >
> > What do you think?
> >
> > Best,
> > Jincheng
> > @sunjincheng121 
> >
> > [1] [IOTDB-268] When using spark-iotdb-connector, the read time is
> > timestamp
> > 
> >
> > Lei Rui  于2019年12月18日周三 下午2:30写道:
> >
> > > Hi Jialin,
> > >
> > >
> > > That's nice. Thank you.
> > >
> > >
> > > Lei Rui
> > >
> > >
> > > On 12/18/2019 14:25,Jialin Qiao wrote:
> > > Hi,
> > >
> > > That's very kind of you :)  I'd like to offer help and share my
> > experience
> > > if you meet trouble when releasing.
> > >
> > > Thanks,
> > > Jialin Qiao
> > >
> > > Lei Rui  于2019年12月18日周三 下午2:13写道:
> > >
> > > Hi,
> > >
> > >
> > > I want to challenge myself to be the release manager of 0.9.1.
> > >
> > >
> > > Regards,
> > > Lei Rui
> > >
> > >
> > > On 12/17/2019 20:47,Jialin Qiao wrote:
> > > Hi,
> > >
> > > Change list could be inferred from merged PRs in
> > > https://github.com/apache/incubator-iotdb/pulse
> > >
> > > The second, as far as I know, there is no need to do more patches,
> cause
> > I
> > > already cherry-pick all the bug-fix commits, but double-check is
> better.
> > >
> > > Thanks,
> > > Jialin Qiao
> > >
> > > Xiangdong Huang  于2019年12月17日周二 下午8:40写道:
> > >
> > > Hi,
> > >
> > > +1 for releasing 0.9.1.
> > >
> > > Two concerns:
> > >
> > > Actually, when I merge the bug-fix PRs, I also cherry-pick them into
> > > rel/0.9. Therefore, this release will be easier than 0.9.0...
> > >
> > > So, how to maintain the change list?
> > >
> > > The second is similar, how many patches should be involved into 0.9.1?
> > >
> > > Best,
> > > ---
> > > Xiangdong Huang
> > > School of Software, Tsinghua University
> > >
> > > 黄向东
> > > 清华大学 软件学院
> > >
> > >
> > > Jialin Qiao  于2019年12月17日周二 下午8:27写道:
> > >
> > > Hi,
> > >
> > > After releasing 0.9.0, we fixed some bugs that will impact the user
> > > experience. It's time to release 0.9.1, a bug-fix version of 0.9.0. Is
> > > there anyone who wants to be the release manager?
> > >
> > > Actually, when I merge the bug-fix PRs, I also cherry-pick them into
> > > rel/0.9. Therefore, this release will be easier than 0.9.0...
> > >
> > > Thanks,
> > > —
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> > >
> > >
> > >
> > > --
> > > —
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> > >
> > >
> > > --
> > > —
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> >
>
>
> --
> —
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>


Re: Please do me a favor :)

2019-12-18 Thread Jialin Qiao
Hi,

Thanks for reminding, I have finalized the release of 0.9.0, 0.8.1 and
0.8.2.
IOTDB-268 is a new feature and IOTDB-344 is an environmental problem, which
is not a bug inside IoTDB.
They are not solved, so I removed the fixed version in these two issues and
tag the affected version of IOTDB-344 to 0.9.0.
However, I can not assign the affected version of IOTDB-268...  Therefore,
it is left empty.

Thanks,
Jialin Qiao

jincheng sun  于2019年12月18日周三 下午3:41写道:

> Hi PPMC,
>
> When I do some check for prepare of release IoTDB 0.9.1, I double check
> that the IoTDB 0.9.1 is already released[1]. But we do not finalized the
> release version in JIRA.[2].
> I do n’t have permission to operate this action, so I am grateful to anyone
> who has permission to help complete the final release of IoTDB 0.9.0.
>
>
> We also need reset the fix version for [3][4] from the 0.9.0 to 0.9.1. and
> I have not the permission, also need someone's help :)
>
> Best,
> Jincheng
> @sunjincheng121 
>
> [1]
>
> https://lists.apache.org/thread.html/ebf6b2b4f435868a14e89fa3a767f99a0db71f4e22a7acc9a7b5b22b%40%3Cdev.iotdb.apache.org%3E
> [2] https://issues.apache.org/jira/projects/IOTDB/versions/12345966
> [3] https://issues.apache.org/jira/browse/IOTDB-268
> [4] https://issues.apache.org/jira/browse/IOTDB-344
>


-- 
—
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院


Re: [REMINDER] JIRA should be closed after the PR is merged :)

2019-12-18 Thread Jialin Qiao
Hi,

I have gone through the open issues and closed those already fixed, and you
should have received the Jira-report email bombing already :D

Thanks,
Jialin Qiao

jincheng sun  于2019年12月18日周三 下午3:09写道:

> Hi Committers & PPMC,
>
> I found that some of JIRAs have not be close even the PR already merged.
> The first time [1] I thought it was accidentally forgotten, just now found
> [2] have was also forgotten, so let me remind you here.
>
> BTW:
> One suggestion here is: Would be better to left some comments when we close
> the JIRA. such as : Fixed in master: {commit id }, Fixed in 0.9: {commit
> id}.
>
> Feel free to correct me If the reminders and suggestions are not suitable
> for IoTDB :)
>
> What do you think?
>
> Best,
> Jincheng
> @sunjincheng121 
>
> [1] https://issues.apache.org/jira/browse/IOTDB-362
> [2] https://issues.apache.org/jira/browse/IOTDB-365
>


-- 
—
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院


Re: Please do me a favor :)

2019-12-18 Thread jincheng sun
Great, thanks for your kindly help :) Jialin!

Best,
Jincheng
@sunjincheng121 


Jialin Qiao  于2019年12月18日周三 下午4:05写道:

> Hi,
>
> Thanks for reminding, I have finalized the release of 0.9.0, 0.8.1 and
> 0.8.2.
> IOTDB-268 is a new feature and IOTDB-344 is an environmental problem, which
> is not a bug inside IoTDB.
> They are not solved, so I removed the fixed version in these two issues and
> tag the affected version of IOTDB-344 to 0.9.0.
> However, I can not assign the affected version of IOTDB-268...  Therefore,
> it is left empty.
>
> Thanks,
> Jialin Qiao
>
> jincheng sun  于2019年12月18日周三 下午3:41写道:
>
> > Hi PPMC,
> >
> > When I do some check for prepare of release IoTDB 0.9.1, I double check
> > that the IoTDB 0.9.1 is already released[1]. But we do not finalized the
> > release version in JIRA.[2].
> > I do n’t have permission to operate this action, so I am grateful to
> anyone
> > who has permission to help complete the final release of IoTDB 0.9.0.
> >
> >
> > We also need reset the fix version for [3][4] from the 0.9.0 to 0.9.1.
> and
> > I have not the permission, also need someone's help :)
> >
> > Best,
> > Jincheng
> > @sunjincheng121 
> >
> > [1]
> >
> >
> https://lists.apache.org/thread.html/ebf6b2b4f435868a14e89fa3a767f99a0db71f4e22a7acc9a7b5b22b%40%3Cdev.iotdb.apache.org%3E
> > [2] https://issues.apache.org/jira/projects/IOTDB/versions/12345966
> > [3] https://issues.apache.org/jira/browse/IOTDB-268
> > [4] https://issues.apache.org/jira/browse/IOTDB-344
> >
>
>
> --
> —
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>


Re: [REMINDER] JIRA should be closed after the PR is merged :)

2019-12-18 Thread jincheng sun
That's great Jialin! I received a lot of Jira-report emails. It's looks
pretty nice for current JIRAs status. :)

Best,
Jincheng

Jialin Qiao  于2019年12月18日周三 下午4:10写道:

> Hi,
>
> I have gone through the open issues and closed those already fixed, and you
> should have received the Jira-report email bombing already :D
>
> Thanks,
> Jialin Qiao
>
> jincheng sun  于2019年12月18日周三 下午3:09写道:
>
> > Hi Committers & PPMC,
> >
> > I found that some of JIRAs have not be close even the PR already merged.
> > The first time [1] I thought it was accidentally forgotten, just now
> found
> > [2] have was also forgotten, so let me remind you here.
> >
> > BTW:
> > One suggestion here is: Would be better to left some comments when we
> close
> > the JIRA. such as : Fixed in master: {commit id }, Fixed in 0.9: {commit
> > id}.
> >
> > Feel free to correct me If the reminders and suggestions are not suitable
> > for IoTDB :)
> >
> > What do you think?
> >
> > Best,
> > Jincheng
> > @sunjincheng121 
> >
> > [1] https://issues.apache.org/jira/browse/IOTDB-362
> > [2] https://issues.apache.org/jira/browse/IOTDB-365
> >
>
>
> --
> —
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>


[BUILD-FAILURE]: Job 'IoTDB Website [null] [88]'

2019-12-18 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'IoTDB Website [null] [88]':

Check console output at "https://builds.apache.org/job/IoTDB%20Website/88/";>IoTDB Website [null] 
[88]"

Re: [jira] [Closed] (IOTDB-319) java deadlock (not sure how to reproduce)

2019-12-18 Thread Xiangdong Huang
Hi,

Is this issue affected in 0.9.0 and fixed in 0.9.0?

Best,
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Jialin Qiao (Jira)  于2019年12月18日周三 下午3:35写道:

>
>  [
> https://issues.apache.org/jira/browse/IOTDB-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Jialin Qiao closed IOTDB-319.
> -
> Fix Version/s: 0.9.0
>Resolution: Fixed
>
> > java deadlock (not sure how to reproduce)
> > -
> >
> > Key: IOTDB-319
> > URL: https://issues.apache.org/jira/browse/IOTDB-319
> > Project: Apache IoTDB
> >  Issue Type: Bug
> >Affects Versions: 0.9.0
> >Reporter: xiangdong Huang
> >Priority: Major
> >  Labels: hard, pull-request-available
> > Fix For: 0.9.0
> >
> > Attachments: deadlock.out
> >
> >  Time Spent: 20m
> >  Remaining Estimate: 0h
> >
> > Hi,
> > my colleague gives me an IoTDB instance which has no response for
> "select " SQL.
> > (but for Schema query sql, it works).
> > I used jstack to check the process and find a deadlock, you can get the
> detailed info in the attachment.
> >
> > Found one Java-level deadlock:
> > =
> > "pool-2-IoTDB-JDBC-Client-thread-16":
> >  waiting to lock monitor 0x7fdab800ff68 (object 0x0003c7163218,
> a org.apache.iotdb.db.query.control.FileReaderManager),
> >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> > "pool-2-IoTDB-JDBC-Client-thread-3":
> >  waiting for ownable synchronizer 0x0003c6106f40, (a
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
> >  which is held by "MergeThread-0"
> > "MergeThread-0":
> >  waiting to lock monitor 0x7fdab800ff68 (object 0x0003c7163218,
> a org.apache.iotdb.db.query.control.FileReaderManager),
> >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> >
> >
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>


Re: [jira] [Closed] (IOTDB-319) java deadlock (not sure how to reproduce)

2019-12-18 Thread Jialin Qiao
Hi,

Yes, already fixed in 0.9.0-RCx

Jialin Qiao

Xiangdong Huang  于2019年12月18日周三 下午7:37写道:

> Hi,
>
> Is this issue affected in 0.9.0 and fixed in 0.9.0?
>
> Best,
> ---
> Xiangdong Huang
> School of Software, Tsinghua University
>
>  黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao (Jira)  于2019年12月18日周三 下午3:35写道:
>
> >
> >  [
> >
> https://issues.apache.org/jira/browse/IOTDB-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Jialin Qiao closed IOTDB-319.
> > -
> > Fix Version/s: 0.9.0
> >Resolution: Fixed
> >
> > > java deadlock (not sure how to reproduce)
> > > -
> > >
> > > Key: IOTDB-319
> > > URL: https://issues.apache.org/jira/browse/IOTDB-319
> > > Project: Apache IoTDB
> > >  Issue Type: Bug
> > >Affects Versions: 0.9.0
> > >Reporter: xiangdong Huang
> > >Priority: Major
> > >  Labels: hard, pull-request-available
> > > Fix For: 0.9.0
> > >
> > > Attachments: deadlock.out
> > >
> > >  Time Spent: 20m
> > >  Remaining Estimate: 0h
> > >
> > > Hi,
> > > my colleague gives me an IoTDB instance which has no response for
> > "select " SQL.
> > > (but for Schema query sql, it works).
> > > I used jstack to check the process and find a deadlock, you can get the
> > detailed info in the attachment.
> > >
> > > Found one Java-level deadlock:
> > > =
> > > "pool-2-IoTDB-JDBC-Client-thread-16":
> > >  waiting to lock monitor 0x7fdab800ff68 (object 0x0003c7163218,
> > a org.apache.iotdb.db.query.control.FileReaderManager),
> > >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> > > "pool-2-IoTDB-JDBC-Client-thread-3":
> > >  waiting for ownable synchronizer 0x0003c6106f40, (a
> > java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
> > >  which is held by "MergeThread-0"
> > > "MergeThread-0":
> > >  waiting to lock monitor 0x7fdab800ff68 (object 0x0003c7163218,
> > a org.apache.iotdb.db.query.control.FileReaderManager),
> > >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> > >
> > >
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.4#803005)
> >
>


-- 
—
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院


Re: [jira] [Closed] (IOTDB-319) java deadlock (not sure how to reproduce)

2019-12-18 Thread Xiangdong Huang
OK, so it should be affected in 0.9.0-SNAPSHOT and fixed in 0.9.0.

---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Jialin Qiao  于2019年12月18日周三 下午7:56写道:

> Hi,
>
> Yes, already fixed in 0.9.0-RCx
>
> Jialin Qiao
>
> Xiangdong Huang  于2019年12月18日周三 下午7:37写道:
>
> > Hi,
> >
> > Is this issue affected in 0.9.0 and fixed in 0.9.0?
> >
> > Best,
> > ---
> > Xiangdong Huang
> > School of Software, Tsinghua University
> >
> >  黄向东
> > 清华大学 软件学院
> >
> >
> > Jialin Qiao (Jira)  于2019年12月18日周三 下午3:35写道:
> >
> > >
> > >  [
> > >
> >
> https://issues.apache.org/jira/browse/IOTDB-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > ]
> > >
> > > Jialin Qiao closed IOTDB-319.
> > > -
> > > Fix Version/s: 0.9.0
> > >Resolution: Fixed
> > >
> > > > java deadlock (not sure how to reproduce)
> > > > -
> > > >
> > > > Key: IOTDB-319
> > > > URL: https://issues.apache.org/jira/browse/IOTDB-319
> > > > Project: Apache IoTDB
> > > >  Issue Type: Bug
> > > >Affects Versions: 0.9.0
> > > >Reporter: xiangdong Huang
> > > >Priority: Major
> > > >  Labels: hard, pull-request-available
> > > > Fix For: 0.9.0
> > > >
> > > > Attachments: deadlock.out
> > > >
> > > >  Time Spent: 20m
> > > >  Remaining Estimate: 0h
> > > >
> > > > Hi,
> > > > my colleague gives me an IoTDB instance which has no response for
> > > "select " SQL.
> > > > (but for Schema query sql, it works).
> > > > I used jstack to check the process and find a deadlock, you can get
> the
> > > detailed info in the attachment.
> > > >
> > > > Found one Java-level deadlock:
> > > > =
> > > > "pool-2-IoTDB-JDBC-Client-thread-16":
> > > >  waiting to lock monitor 0x7fdab800ff68 (object
> 0x0003c7163218,
> > > a org.apache.iotdb.db.query.control.FileReaderManager),
> > > >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> > > > "pool-2-IoTDB-JDBC-Client-thread-3":
> > > >  waiting for ownable synchronizer 0x0003c6106f40, (a
> > > java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
> > > >  which is held by "MergeThread-0"
> > > > "MergeThread-0":
> > > >  waiting to lock monitor 0x7fdab800ff68 (object
> 0x0003c7163218,
> > > a org.apache.iotdb.db.query.control.FileReaderManager),
> > > >  which is held by "pool-2-IoTDB-JDBC-Client-thread-3"
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian Jira
> > > (v8.3.4#803005)
> > >
> >
>
>
> --
> —
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>


[jira] [Created] (IOTDB-374) Query performance problem when using Python client

2019-12-18 Thread Xiangdong Huang (Jira)
Xiangdong Huang created IOTDB-374:
-

 Summary: Query performance problem when using Python client 
 Key: IOTDB-374
 URL: https://issues.apache.org/jira/browse/IOTDB-374
 Project: Apache IoTDB
  Issue Type: Bug
Affects Versions: 0.9.0
Reporter: Xiangdong Huang
 Fix For: 0.9.0
 Attachments: autovis-iotdb.py

Hi,

One of my colleagues reports an abnormal status of IoTDB  when running IoTDB 
more than 20 hours.

1. The user uses Python Library to access IoTDB.

2. The user writes data per 100ms. The users creates connection and close the 
connection every time (comments: the behavior is not recommended)

 

3. The user query data per 100ms. The users creates connection and close the 
connection every time (comments: the behavior is not recommended)

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (IOTDB-374) Query performance problem when using Python client

2019-12-18 Thread Xiangdong Huang (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiangdong Huang closed IOTDB-374.
-
Fix Version/s: (was: 0.9.0)
   Resolution: Not A Bug

> Query performance problem when using Python client 
> ---
>
> Key: IOTDB-374
> URL: https://issues.apache.org/jira/browse/IOTDB-374
> Project: Apache IoTDB
>  Issue Type: Bug
>Affects Versions: 0.9.0
>Reporter: Xiangdong Huang
>Priority: Major
> Attachments: iotdb_query_test.py
>
>
> Hi,
> One of my colleagues reports an abnormal status of IoTDB  when running IoTDB 
> more than 20 hours.
> 1. The user uses Python Library to access IoTDB.
> 2. The user writes data per 100ms. The users creates connection and close the 
> connection every time (comments: the behavior is not recommended)
>  
> 3. The user query data per 100ms. The users creates connection and close the 
> connection every time (comments: the behavior is not recommended)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread Jialin Qiao (Jira)
Jialin Qiao created IOTDB-375:
-

 Summary: Bug in parameter adapter
 Key: IOTDB-375
 URL: https://issues.apache.org/jira/browse/IOTDB-375
 Project: Apache IoTDB
  Issue Type: Bug
Affects Versions: 0.9.0, 0.10.0-SNAPSHOT
Reporter: Jialin Qiao


I set enable_parameter_adapter to true and use the default memory setting.

 

After starting IoTDB, I set one storage group root.sg1 and create timeseries, 
the service rejects the creating after 66777 is created. However, the log only 
says that "IoTDB system load is too large to add timeseries". We could hint 
more, such as increase memory or disable the enable_parameter_adapter in 
iotdb-engine.properties.

 

Then, I execute delete storage group root.sg1 and redo the above operations.

 

This time, only 34988 was successfully created. (This is the bug, we should be 
able to create 66777 timeseries again)

 

After restart IoTDB, it recalculates the timeseries one-by-one and prints a lot 
of debug logs. I suggest accepting the register without checking parameters 
because it is already checked before.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread Jialin Qiao
Hi,

This is a crucial problem that most of our users may face, and it will
leave them a bad impression of IoTDB.
We need to quickly fix this problem, whether by relaxing the check, giving
more hints, or disabling the parameter by default.

Thanks,
Jialin Qiao

Jialin Qiao (Jira)  于2019年12月19日周四 下午12:58写道:

> Jialin Qiao created IOTDB-375:
> -
>
>  Summary: Bug in parameter adapter
>  Key: IOTDB-375
>  URL: https://issues.apache.org/jira/browse/IOTDB-375
>  Project: Apache IoTDB
>   Issue Type: Bug
> Affects Versions: 0.9.0, 0.10.0-SNAPSHOT
> Reporter: Jialin Qiao
>
>
> I set enable_parameter_adapter to true and use the default memory setting.
>
>
>
> After starting IoTDB, I set one storage group root.sg1 and create
> timeseries, the service rejects the creating after 66777 is created.
> However, the log only says that "IoTDB system load is too large to add
> timeseries". We could hint more, such as increase memory or disable the
> enable_parameter_adapter in iotdb-engine.properties.
>
>
>
> Then, I execute delete storage group root.sg1 and redo the above
> operations.
>
>
>
> This time, only 34988 was successfully created. (This is the bug, we
> should be able to create 66777 timeseries again)
>
>
>
> After restart IoTDB, it recalculates the timeseries one-by-one and prints
> a lot of debug logs. I suggest accepting the register without checking
> parameters because it is already checked before.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>


-- 
—
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院


Re: [jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread Xiangdong Huang
Hi,

> After restart IoTDB, it recalculates the timeseries one-by-one and prints
a lot of debug logs. I suggest accepting the register without checking
parameters because it is already checked before.

What is the meaning of "I suggest accepting the register without checking
parameters because it is already checked before" for the restart process?

Best,

---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Jialin Qiao  于2019年12月19日周四 下午1:04写道:

> Hi,
>
> This is a crucial problem that most of our users may face, and it will
> leave them a bad impression of IoTDB.
> We need to quickly fix this problem, whether by relaxing the check, giving
> more hints, or disabling the parameter by default.
>
> Thanks,
> Jialin Qiao
>
> Jialin Qiao (Jira)  于2019年12月19日周四 下午12:58写道:
>
> > Jialin Qiao created IOTDB-375:
> > -
> >
> >  Summary: Bug in parameter adapter
> >  Key: IOTDB-375
> >  URL: https://issues.apache.org/jira/browse/IOTDB-375
> >  Project: Apache IoTDB
> >   Issue Type: Bug
> > Affects Versions: 0.9.0, 0.10.0-SNAPSHOT
> > Reporter: Jialin Qiao
> >
> >
> > I set enable_parameter_adapter to true and use the default memory
> setting.
> >
> >
> >
> > After starting IoTDB, I set one storage group root.sg1 and create
> > timeseries, the service rejects the creating after 66777 is created.
> > However, the log only says that "IoTDB system load is too large to add
> > timeseries". We could hint more, such as increase memory or disable the
> > enable_parameter_adapter in iotdb-engine.properties.
> >
> >
> >
> > Then, I execute delete storage group root.sg1 and redo the above
> > operations.
> >
> >
> >
> > This time, only 34988 was successfully created. (This is the bug, we
> > should be able to create 66777 timeseries again)
> >
> >
> >
> > After restart IoTDB, it recalculates the timeseries one-by-one and prints
> > a lot of debug logs. I suggest accepting the register without checking
> > parameters because it is already checked before.
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.4#803005)
> >
>
>
> --
> —
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>


Re: [jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread Jialin Qiao
It is in the restart process, the check could be omitted.


[jira] [Created] (IOTDB-376) Metric module is not enabled when calling executeQueryStatement()

2019-12-18 Thread Xiangdong Huang (Jira)
Xiangdong Huang created IOTDB-376:
-

 Summary: Metric module is not enabled when calling 
executeQueryStatement()
 Key: IOTDB-376
 URL: https://issues.apache.org/jira/browse/IOTDB-376
 Project: Apache IoTDB
  Issue Type: Bug
Affects Versions: 0.8.2, 0.8.1, 0.9.0, 0.8.0
Reporter: Xiangdong Huang


The metric module can records at most 200 recent query sqls, using 
127.0.0.1:8181 to access the module.

However, it effects only when users call executeStatement().

When users call executeQueryStatement(), the related module is not called to 
update the records.

It is easy to fix, just copy some codes in executeStatement() method  to 
executeQueryStatement():
{code:java}
// code placeholder
sqlArgument = new SqlArgument(resp, physicalPlan, statement, startTime, 
endTime);
sqlArgumentsList.add(sqlArgument);
if (sqlArgumentsList.size() > MAX_SIZE) {
  sqlArgumentsList.subList(0, DELETE_SIZE).clear();
}
{code}
Of course,  put the above codes into a new function and let executeStatement() 
and executeQueryStatement() (and maybe some other functions) call the new 
function is a good choice.

 

By the way, it is a good idea if we can set MAX_SIZE in the configuration file.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread Xiangdong Huang
1. Is there any side-effect if you remove it?
2. How to solve the incorrect evaluation when you delete some time series
is still not mentioned.

---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Jialin Qiao  于2019年12月19日周四 下午2:16写道:

> It is in the restart process, the check could be omitted.
>


Re: [jira] [Created] (IOTDB-375) Bug in parameter adapter

2019-12-18 Thread 李天安
Hi ,

I have noticed this issue.

The incorrect evaluation is a bug in the function of deleting storage group, 
and deleting timeseries doesn’t have this issue.

While deleting sg, it just subtracts the num of sg in 
IoTDBConfigDynamicAdapter, but not subtracts the sum of timeseries in 
IoTDBConfigDynamicAdapter which leads to the incorrect evaluation. This is easy 
to fix.

What's more, removing debug logs while restarting the system doesn't have any 
side-effect.

I have pulled a pr to fix this issue. The link is 
https://github.com/apache/incubator-iotdb/pull/669 
.

Best Regards,
—
Tianan Li
School of Software, Tsinghua University

李天安
清华大学 软件学院

> 2019年12月19日 下午2:43,Xiangdong Huang  > 写道:
> 
> 1. Is there any side-effect if you remove it?
> 2. How to solve the incorrect evaluation when you delete some time series
> is still not mentioned.
> 
> ---
> Xiangdong Huang
> School of Software, Tsinghua University
> 
> 黄向东
> 清华大学 软件学院
> 
> 
> Jialin Qiao mailto:qiaojia...@apache.org>> 
> 于2019年12月19日周四 下午2:16写道:
> 
>> It is in the restart process, the check could be omitted.
>> 
> 



[jira] [Created] (IOTDB-377) how to excute 'show devices' and 'show timeseries' in python?

2019-12-18 Thread qinhaiqiang (Jira)
qinhaiqiang created IOTDB-377:
-

 Summary: how to excute 'show devices' and 'show timeseries' in 
python?
 Key: IOTDB-377
 URL: https://issues.apache.org/jira/browse/IOTDB-377
 Project: Apache IoTDB
  Issue Type: New Feature
Reporter: qinhaiqiang


I want to excute  'show devices' and 'show timeseries' with python. Can you add 
new funtion for that?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)