self-introduction by Guanfei Guo

[????????]

Hi, I'm Guanfei Guo, from Yonyou.My jira id: guoguanfei
My Confluence id: guoguanfei



Thanks.

回复: Code style check enabled: Wildcard import is forbidden

[Eric Pai]

Now style check of the codes in test folders is activated as well.

-邮件原件-
发件人: Eric Pai  
发送时间: 2022年4月22日 12:16
收件人: dev@iotdb.apache.org
主题: Code style check enabled: Wildcard import is forbidden

Hi, all,

The google-java-format is just a code formatter, which cannot apply some rules 
to code semantic. Only a formatter cannot help codes become better.

So we plan to enable the linter, checkstyle, which has already been integrated 
in the validation stage to let the codes developed by different contributors 
obey the same style ruleset.

Currently the AvoidStarImport rule is activated and the following commits 
cannot use wildcard import like  `import java.io.*` any more. This will not 
affect any release branches.

All the existed violations have been fixed in [1]. Please rebase the master 
branch to make sure that the codes in your local branch can pass the style 
check.

Someone may be disrupted by IDEA default style configuration, so you can 
reference the code style section of the latest contributor guide page[2] and 
find the solutions.

If anyone has good code style rules in practice, welcome to contribute them to 
checkstyle.xml 😊


[1] 
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fiotdb%2Fpull%2F5622&data=05%7C01%7C%7Cf768d7ecf1484aa1cd3a08da2416e266%7C84df9e7fe9f640afb435%7C1%7C0%7C637861977954472450%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QeMN4tSn4hnVIMrLGMd8X9Sp1p%2F6ZpcVPhIvVqV7q5M%3D&reserved=0
[2] 
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiotdb.apache.org%2FDevelopment%2FContributeGuide.html&data=05%7C01%7C%7Cf768d7ecf1484aa1cd3a08da2416e266%7C84df9e7fe9f640afb435%7C1%7C0%7C637861977954472450%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o%2BoAhQfkk7X8SaaKMzcZ47QtrP8F6Gr824J007351MI%3D&reserved=0

I submitted an physical plan serialization issue?? IOTDB-2936??

[????]

The serialization type uses the enumeration ordinal, which can easily cause 
deserialization failures if the order of the enumeration objects changes.

Therefore, the constant value int should be used for each type

eg??
@Override
public void serializeImpl(ByteBuffer buffer)
{ int type = PhysicalPlanType.INSERT.ordinal(); buffer.put((byte) type); 
subSerialize(buffer); }
@Override
public void serializeImpl(ByteBuffer buffer)
{ int type = PhysicalPlanType.BATCHINSERT.ordinal(); buffer.put((byte) type); 
subSerialize(buffer, 0, rowCount); }
Improvement:

@Override
public void serializeImpl(ByteBuffer buffer)
{ int type = PhysicalPlanType.INSERT.type; buffer.put((byte) type); 
subSerialize(buffer); }
@Override
public void serializeImpl(ByteBuffer buffer)
{ int type = PhysicalPlanType.BATCHINSERT.type; buffer.put((byte) type); 
subSerialize(buffer, 0, rowCount); }



Best,

gongning