[jira] [Commented] (ISIS-537) Convert Wicket viewer to use Bootstrap, so that it can be themed.
[ https://issues.apache.org/jira/browse/ISIS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224205#comment-14224205 ] ASF subversion and git services commented on ISIS-537: -- Commit 803159fe3751440e9ebc5eddd8498409a74c0f27 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=803159f ] ISIS-537: removed defunct/commented out code and unused parameters. Also, since an ActionPrompt is always available (from the page), this change in effect deprecates/obsoletes the support for non-modal dialogs for action parameter forms. Convert Wicket viewer to use Bootstrap, so that it can be themed. - Key: ISIS-537 URL: https://issues.apache.org/jira/browse/ISIS-537 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 forked to https://github.com/martin-g/isis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-537) Convert Wicket viewer to use Bootstrap, so that it can be themed.
[ https://issues.apache.org/jira/browse/ISIS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224204#comment-14224204 ] ASF subversion and git services commented on ISIS-537: -- Commit 9de5ba8e958c0e4ad3be2fe2e64c12a054959135 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9de5ba8 ] ISIS-537: working towards additional links on panel title for (property) member groups * factored out the code that builds the list of links * changed way that ActionPromptProvider is derived (CollectionPanel need no longer implement directly, can lazily determine from Page when required) * NB: some code clean up of redundant/commented out code still required. Convert Wicket viewer to use Bootstrap, so that it can be themed. - Key: ISIS-537 URL: https://issues.apache.org/jira/browse/ISIS-537 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 forked to https://github.com/martin-g/isis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-537) Convert Wicket viewer to use Bootstrap, so that it can be themed.
[ https://issues.apache.org/jira/browse/ISIS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224206#comment-14224206 ] ASF subversion and git services commented on ISIS-537: -- Commit d099b31f52e13c259a5be7abf281b075b49ad467 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d099b31 ] ISIS-537: now adds additional links to property member group (though have disabled again until fix layout issues and add facet to allow more fine-grained placement). Convert Wicket viewer to use Bootstrap, so that it can be themed. - Key: ISIS-537 URL: https://issues.apache.org/jira/browse/ISIS-537 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 forked to https://github.com/martin-g/isis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-537) Convert Wicket viewer to use Bootstrap, so that it can be themed.
[ https://issues.apache.org/jira/browse/ISIS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224203#comment-14224203 ] ASF subversion and git services commented on ISIS-537: -- Commit b4bd7a4ffa6511480d0173378232bfc47045fda5 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b4bd7a4 ] ISIS-537: render (none) for references that are null. Convert Wicket viewer to use Bootstrap, so that it can be themed. - Key: ISIS-537 URL: https://issues.apache.org/jira/browse/ISIS-537 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 forked to https://github.com/martin-g/isis -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-512) Wicket: render icons for actions (if available)
[ https://issues.apache.org/jira/browse/ISIS-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225188#comment-14225188 ] Martin Grigorov commented on ISIS-512: -- Is this implemented with the new support for Font Awesome icons part of ISIS-537 ? Wicket: render icons for actions (if available) --- Key: ISIS-512 URL: https://issues.apache.org/jira/browse/ISIS-512 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 If a resource is available, then render an icon for the action. Possibly also define an annotation (eg to indicate whether to show the icon, the label or the iconlabel. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-510) Help page overlay (a la ? in gmail)
[ https://issues.apache.org/jira/browse/ISIS-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225195#comment-14225195 ] Martin Grigorov commented on ISIS-510: -- What information that overlay should show ? Keyboard shortcuts ?! At the moment I think there are only Alt+[ and Alt+] . Help page overlay (a la ? in gmail) --- Key: ISIS-510 URL: https://issues.apache.org/jira/browse/ISIS-510 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-489) Allow logging to be configured using JMX
[ https://issues.apache.org/jira/browse/ISIS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225206#comment-14225206 ] Martin Grigorov commented on ISIS-489: -- At $daily job we use Logback as SLF4J impl and https://github.com/wicketstuff/core/blob/master/jdk-1.7-parent/wicketstuff-logback-parent/wicketstuff-logback/src/main/java/org/wicketstuff/logback/ConfiguratorPage.java to change the log level per logger via web interface. Is moving from log4j to logback an option ? It is possible that Log4J 1.x/2.x also provide something similar in their internal APIs. Let me know and I'll research! Allow logging to be configured using JMX Key: ISIS-489 URL: https://issues.apache.org/jira/browse/ISIS-489 Project: Isis Issue Type: Improvement Components: Core, Viewer: Wicket Affects Versions: viewer-wicket-1.2.0, core-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0, core-2.0.0 eg using logging-jmx-service, perhaps? See also: ISIS-490, convert to using slf4j -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-439) Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225208#comment-14225208 ] Martin Grigorov commented on ISIS-439: -- Isn't this already implemented ? I have seen Add/Remove action links for collections here and there. Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action. - Key: ISIS-439 URL: https://issues.apache.org/jira/browse/ISIS-439 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-556) Re-enable maven-enforcer-plugin before merging ISIS-537 branch to master
[ https://issues.apache.org/jira/browse/ISIS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved ISIS-556. -- Resolution: Fixed Fix Version/s: (was: viewer-wicket-2.0.0) viewer-wicket-1.8.0 Re-enable maven-enforcer-plugin before merging ISIS-537 branch to master Key: ISIS-556 URL: https://issues.apache.org/jira/browse/ISIS-556 Project: Isis Issue Type: Sub-task Components: Tool Reporter: Martin Grigorov Assignee: Dan Haywood Fix For: viewer-wicket-1.8.0 Maven Enforcer plugin breaks the build when some transitive dependency of dependency A has different version than the same artifact coming as transitive dependency from dependency B. [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @ isis-viewer-wicket-ui --- [WARNING] Dependency convergence error for org.webjars:jquery:1.9.0 paths to dependency are: +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3 +-org.webjars:bootstrap:3.0.0 +-org.webjars:jquery:1.9.0 and +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3 +-org.webjars:jquery-ui:1.10.2-1 +-org.webjars:jquery:1.9.1 This slows down the development and we need to disable it in branch ISIS-537. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-439) Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225214#comment-14225214 ] Dan Haywood commented on ISIS-439: -- No, those are separate actions that just happened to be associated with the collection. It's a subtle point, but the Isis programming model for collections defines: CollectionElement getCollection() setCollection(CollectionElement) addToCollection(Element) removeFromCollection(Element) With validateAddToCollection(), validateRemoveFromCollection() etc also being supported methods. In the metamodel there is only one member on the ObjectSpec, namely an instance of OneToManyAssociation; this member has facets representing the ability to add/remove. ~~~ In contrast, when we right: CollectionElement getCollection() setCollection(CollectionElement) addCollection(Element) // @MemberOrder(name=collection) to render close to the collection removeCollection(Element) // @MemberOrder(name=collection) to render close to the collection Then there are three members on the ObjectSpec: the OneToManyAssociation and two ObjectActions. ~~ The above notwithstanding, in Isis 2.0 it may make sense to get rid of the idea of mutable collections; the amount of code that the developer writes is almost identical (and is one less concept for the developer to understand), and it would simplify some of the code in Isis. Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action. - Key: ISIS-439 URL: https://issues.apache.org/jira/browse/ISIS-439 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-784) Change Wicket viewer to get rid of edit mode, instead allow individual fields to be edited by clicking on them (similar to the way that JIRA works).
[ https://issues.apache.org/jira/browse/ISIS-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225220#comment-14225220 ] Martin Grigorov commented on ISIS-784: -- Do you like http://vitalets.github.io/x-editable/demo-bs3.html?c=inline ? Wicket-Bootstrap has integration with it. Change Wicket viewer to get rid of edit mode, instead allow individual fields to be edited by clicking on them (similar to the way that JIRA works). Key: ISIS-784 URL: https://issues.apache.org/jira/browse/ISIS-784 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-784) Change Wicket viewer to get rid of edit mode, instead allow individual fields to be edited by clicking on them (similar to the way that JIRA works).
[
https://issues.apache.org/jira/browse/ISIS-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225245#comment-14225245
]
Jeroen van der Wal commented on ISIS-784:
-
I think that looks nice. We could make the changeXXX method be associated with
an getXXX if available. Something like this:
public class Something {
private String street;
private String city;
... setters + getters ...
public String getAddress() {
return getStreet() + , + getCity();
}
public void changeAddress() { final String street, final String city) {
setStreet(street);
setCity(city);
}
}
Currently this shows a modal window which is fine for now. Perhaps for Isis
3.0? ;-)
Change Wicket viewer to get rid of edit mode, instead allow individual fields
to be edited by clicking on them (similar to the way that JIRA works).
Key: ISIS-784
URL: https://issues.apache.org/jira/browse/ISIS-784
Project: Isis
Issue Type: New Feature
Components: Viewer: Wicket
Affects Versions: viewer-wicket-1.4.1
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-2.0.0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-439) Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225261#comment-14225261 ] Jeroen van der Wal commented on ISIS-439: - Agree that it's better to remove mutable collections from the programming model since it's not compatible with decoupling using contributed collections. Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action. - Key: ISIS-439 URL: https://issues.apache.org/jira/browse/ISIS-439 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-819) Wicket viewer should show the environment details so can distinguish if running in productnio vs UAT/systest/dev etc
[ https://issues.apache.org/jira/browse/ISIS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225266#comment-14225266 ] Martin Grigorov commented on ISIS-819: -- Please check https://github.com/apache/isis/pull/10 Wicket viewer should show the environment details so can distinguish if running in productnio vs UAT/systest/dev etc Key: ISIS-819 URL: https://issues.apache.org/jira/browse/ISIS-819 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: core-1.5.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.9.0 original idea: A nice way to do this might be to use a diagonal banner in the corner, like the fork me on github banners that are everywhere these days. alternative suggestion (preferable, probably): put this in the footer/navbar, so that doesn't hide a menu item at the top. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-876) Action prompt dialog box rendering when title too long...
[ https://issues.apache.org/jira/browse/ISIS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated ISIS-876: - Attachment: longer-title-in-action-prompt-537.png This seems to be fixed with ISIS-537. See the screenshot. Action prompt dialog box rendering when title too long... - Key: ISIS-876 URL: https://issues.apache.org/jira/browse/ISIS-876 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.6.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 Attachments: isis-to-raise-1.png, longer-title-in-action-prompt-537.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-876) Action prompt dialog box rendering when title too long...
[ https://issues.apache.org/jira/browse/ISIS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated ISIS-876: - Fix Version/s: (was: viewer-wicket-2.0.0) viewer-wicket-1.8.0 Action prompt dialog box rendering when title too long... - Key: ISIS-876 URL: https://issues.apache.org/jira/browse/ISIS-876 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.6.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 Attachments: isis-to-raise-1.png, longer-title-in-action-prompt-537.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-690) 'Show all' button for tables.
[ https://issues.apache.org/jira/browse/ISIS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225334#comment-14225334 ] Martin Grigorov commented on ISIS-690: -- Possible solution: https://github.com/apache/isis/pull/11 'Show all' button for tables. - Key: ISIS-690 URL: https://issues.apache.org/jira/browse/ISIS-690 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.3.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.9.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-690) 'Show all' button for tables.
[ https://issues.apache.org/jira/browse/ISIS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated ISIS-690: - Fix Version/s: (was: viewer-wicket-1.9.0) viewer-wicket-1.8.0 'Show all' button for tables. - Key: ISIS-690 URL: https://issues.apache.org/jira/browse/ISIS-690 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.3.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ISIS-439) Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225214#comment-14225214 ] Dan Haywood edited comment on ISIS-439 at 11/26/14 5:52 AM: No, those are separate actions that just happened to be associated with the collection. It's a subtle point, but the Isis programming model for collections defines: CollectionElement getCollection() setCollection(CollectionElement) addToCollection(Element) removeFromCollection(Element) With validateAddToCollection(), validateRemoveFromCollection() etc also being supported methods. In the metamodel there is only one member on the ObjectSpec, namely an instance of OneToManyAssociation; this member has facets representing the ability to add/remove. ~~~ In contrast, when we write: CollectionElement getCollection() setCollection(CollectionElement) addCollection(Element) // @MemberOrder(name=collection) to render close to the collection removeCollection(Element) // @MemberOrder(name=collection) to render close to the collection Then there are three members on the ObjectSpec: the OneToManyAssociation and two ObjectActions. ~~ The above notwithstanding, in Isis 2.0 it may make sense to get rid of the idea of mutable collections; the amount of code that the developer writes is almost identical (and is one less concept for the developer to understand), and it would simplify some of the code in Isis. was (Author: danhaywood): No, those are separate actions that just happened to be associated with the collection. It's a subtle point, but the Isis programming model for collections defines: CollectionElement getCollection() setCollection(CollectionElement) addToCollection(Element) removeFromCollection(Element) With validateAddToCollection(), validateRemoveFromCollection() etc also being supported methods. In the metamodel there is only one member on the ObjectSpec, namely an instance of OneToManyAssociation; this member has facets representing the ability to add/remove. ~~~ In contrast, when we right: CollectionElement getCollection() setCollection(CollectionElement) addCollection(Element) // @MemberOrder(name=collection) to render close to the collection removeCollection(Element) // @MemberOrder(name=collection) to render close to the collection Then there are three members on the ObjectSpec: the OneToManyAssociation and two ObjectActions. ~~ The above notwithstanding, in Isis 2.0 it may make sense to get rid of the idea of mutable collections; the amount of code that the developer writes is almost identical (and is one less concept for the developer to understand), and it would simplify some of the code in Isis. Wicket viewer should support mutable collections - ie with an implicit 'add' and 'remove' action. - Key: ISIS-439 URL: https://issues.apache.org/jira/browse/ISIS-439 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
