[jira] [Resolved] (ISIS-1018) Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated
[ https://issues.apache.org/jira/browse/ISIS-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved ISIS-1018. --- Resolution: Fixed Fix Version/s: viewer-wicket-1.8.0 Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated Key: ISIS-1018 URL: https://issues.apache.org/jira/browse/ISIS-1018 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 While testing Wicket 6.19.0 with Isis I've found that most menu items were not displayed. The reason was that since http://issues.apache.org/jira/browse/WICKET-5775 Wicket(-auth-roles) replaces the http session after successful login to prevent session fixation attacks. This leads to problems with Shiro authorizations later because Shiro is not notified about the replacement and keeps using the old http session data. https://issues.apache.org/jira/browse/SHIRO-170?focusedCommentId=13108301page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13108301 suggests how to do session replacement with Shiro. With session replacement with Shiro or without any replacement I suggest to make Wicket's Session#replaceSession() a no-op method to avoid any similar problems in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1018) Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated
[ https://issues.apache.org/jira/browse/ISIS-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296558#comment-14296558 ] ASF subversion and git services commented on ISIS-1018: --- Commit 8c13404ec166e666ef905c81f32480931e414dbc in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8c13404 ] ISIS-1018 Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated Key: ISIS-1018 URL: https://issues.apache.org/jira/browse/ISIS-1018 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 While testing Wicket 6.19.0 with Isis I've found that most menu items were not displayed. The reason was that since http://issues.apache.org/jira/browse/WICKET-5775 Wicket(-auth-roles) replaces the http session after successful login to prevent session fixation attacks. This leads to problems with Shiro authorizations later because Shiro is not notified about the replacement and keeps using the old http session data. https://issues.apache.org/jira/browse/SHIRO-170?focusedCommentId=13108301page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13108301 suggests how to do session replacement with Shiro. With session replacement with Shiro or without any replacement I suggest to make Wicket's Session#replaceSession() a no-op method to avoid any similar problems in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1018) Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated
Martin Grigorov created ISIS-1018: - Summary: Do not allow http session replacement in Wicket because Shiro knowledge becomes outdated Key: ISIS-1018 URL: https://issues.apache.org/jira/browse/ISIS-1018 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov While testing Wicket 6.19.0 with Isis I've found that most menu items were not displayed. The reason was that since http://issues.apache.org/jira/browse/WICKET-5775 Wicket(-auth-roles) replaces the http session after successful login to prevent session fixation attacks. This leads to problems with Shiro authorizations later because Shiro is not notified about the replacement and keeps using the old http session data. https://issues.apache.org/jira/browse/SHIRO-170?focusedCommentId=13108301page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13108301 suggests how to do session replacement with Shiro. With session replacement with Shiro or without any replacement I suggest to make Wicket's Session#replaceSession() a no-op method to avoid any similar problems in the future. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296605#comment-14296605
]
ASF subversion and git services commented on ISIS-968:
--
Commit 2a5db0c5fbd14237fb53bf292d54f3bcf4b16841 in isis's branch
refs/heads/ISIS-968 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2a5db0c ]
ISIS-968: extending @DomainService(nature=...).
Also deprecating @NotInServiceMenu.
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-928) Isis 1.8.0 release tasks
[ https://issues.apache.org/jira/browse/ISIS-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296604#comment-14296604 ] ASF subversion and git services commented on ISIS-928: -- Commit 4caf5c894d86bba498a5e40bed3625a0e8d20096 in isis's branch refs/heads/ISIS-968 from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4caf5c8 ] ISIS-928: tiny change to fixture script framework, making ExecutionContext#lookup(...) public and deprecating FixtureScript#lookup(...). Isis 1.8.0 release tasks Key: ISIS-928 URL: https://issues.apache.org/jira/browse/ISIS-928 Project: Isis Issue Type: Task Components: Core, Viewer: Wicket Affects Versions: archetype-todoapp-1.7.0, archetype-simpleapp-1.7.0, viewer-wicket-1.7.0, core-1.7.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: archetype-todoapp-1.8.0, archetype-simpleapp-1.8.0, viewer-wicket-1.8.0, core-1.8.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296606#comment-14296606
]
ASF subversion and git services commented on ISIS-968:
--
Commit aa8d2f3c4b6c35d16a9f69bcdf154822d08ea8a9 in isis's branch
refs/heads/ISIS-968 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aa8d2f3 ]
ISIS-968: adding unit tests, updates to the todo app.
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-1020) Dropdown window opens top left of the screen
[ https://issues.apache.org/jira/browse/ISIS-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeroen van der Wal updated ISIS-1020: - Description: This is reporducable in IE11, I have created a screencast to demonstrate https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing Dropdown window opens top left of the screen Key: ISIS-1020 URL: https://issues.apache.org/jira/browse/ISIS-1020 Project: Isis Issue Type: Bug Components: Viewer: Wicket Reporter: Jeroen van der Wal Assignee: Dan Haywood This is reporducable in IE11, I have created a screencast to demonstrate https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1020) Dropdown window opens top left of the screen
[ https://issues.apache.org/jira/browse/ISIS-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeroen van der Wal updated ISIS-1020: - Description: I have created a screencast to demonstrate in Estatio: https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing This is reproducible in both IE11 and Chrome. was:This is reporducable in IE11, I have created a screencast to demonstrate https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing Affects Version/s: viewer-wicket-1.8.0 Dropdown window opens top left of the screen Key: ISIS-1020 URL: https://issues.apache.org/jira/browse/ISIS-1020 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.8.0 Reporter: Jeroen van der Wal Assignee: Dan Haywood I have created a screencast to demonstrate in Estatio: https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing This is reproducible in both IE11 and Chrome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1020) Dropdown window opens top left of the screen
Jeroen van der Wal created ISIS-1020: Summary: Dropdown window opens top left of the screen Key: ISIS-1020 URL: https://issues.apache.org/jira/browse/ISIS-1020 Project: Isis Issue Type: Bug Components: Viewer: Wicket Reporter: Jeroen van der Wal Assignee: Dan Haywood -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1021) suppress/disable the link in the first column of a table (CollectionProperty)
ARI created ISIS-1021:
-
Summary: suppress/disable the link in the first column of a table
(CollectionProperty)
Key: ISIS-1021
URL: https://issues.apache.org/jira/browse/ISIS-1021
Project: Isis
Issue Type: New Feature
Components: Viewer: Wicket
Affects Versions: viewer-wicket-1.7.0
Reporter: ARI
Assignee: Dan Haywood
Goal:
Suppress/disable the link in the first column of a table (CollectionProperty)
for marked DomainObjects.
Proposal:
- Add a new field to the @DomainObjectLayout like openable/viewable.
- Special handling of title columns in CollectionContentsAsAjaxTablePanel /
and/or ObjectAdapterTitleColumn, e.g. EntityIconAndTitlePanel
Background:
I have a complex entity which is displayed in tables in different places.
In one place I want to show a subset of properties only. For this
projection I made a special in-memory object, which wraps the complex
entity and has getters for the subset of properties only. How can I mark
this inmemory object to be not openable, or with other words how do i
suppress/disable the link in the first column.
Dan/Martins QuickFix was:
The column is added at
https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
and I see no way how to suppress the addition in current master branch.
The column is marked with title-column CSS class so it is easy to hide
with: visibility:hidden;, but I'm not sure how easy is to detect on which
page to apply this CSS rule.
If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
#cssClass() special method that may be used to set a custom CSS class. See
http://issues.apache.org/jira/browse/ISIS-1000
Am 26.01.2015 um 23:11 schrieb Dan Haywood d...@haywood-associates.co.uk:
+1 to Martin's answer, there is no configuration setting but it is possible
to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
For example, the todo app uses #cssClass() so that completed todo items are
shown in a table with a strikethrough. This comes from the done CSS
class:
public String cssClass() { return !isComplete() ? todo : done; }
In webapp/css/application.css, if we add:
tr.done a {
pointer-events: none;
cursor: default;
}
and in webapp/scripts/application.js, if we add:
$(document).ready(function() {
$('tr.done a').click(function() { return false; });
});
then the icon for each completed item cannot be clicked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-1021) suppress/disable the link in the first column of a table (CollectionProperty)
[
https://issues.apache.org/jira/browse/ISIS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ARI updated ISIS-1021:
--
Description:
Goal:
Suppress/disable the link in the first column of a table (CollectionProperty)
for marked DomainObjects.
Proposal:
- Add a new field to the @DomainObjectLayout like openable/viewable.
- Special handling of title columns in CollectionContentsAsAjaxTablePanel /
ObjectAdapterTitleColumn / EntityIconAndTitlePanel
Background:
I have a complex entity which is displayed in tables in different places.
In one place I want to show a subset of properties only. For this
projection I made a special in-memory object, which wraps the complex
entity and has getters for the subset of properties only. How can I mark
this inmemory object to be not openable, or with other words how do i
suppress/disable the link in the first column.
Dan/Martins QuickFix was:
The column is added at
https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
and I see no way how to suppress the addition in current master branch.
The column is marked with title-column CSS class so it is easy to hide
with: visibility:hidden;, but I'm not sure how easy is to detect on which
page to apply this CSS rule.
If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
#cssClass() special method that may be used to set a custom CSS class. See
http://issues.apache.org/jira/browse/ISIS-1000
Am 26.01.2015 um 23:11 schrieb Dan Haywood d...@haywood-associates.co.uk:
+1 to Martin's answer, there is no configuration setting but it is possible
to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
For example, the todo app uses #cssClass() so that completed todo items are
shown in a table with a strikethrough. This comes from the done CSS
class:
public String cssClass() { return !isComplete() ? todo : done; }
In webapp/css/application.css, if we add:
tr.done a {
pointer-events: none;
cursor: default;
}
and in webapp/scripts/application.js, if we add:
$(document).ready(function() {
$('tr.done a').click(function() { return false; });
});
then the icon for each completed item cannot be clicked.
was:
Goal:
Suppress/disable the link in the first column of a table (CollectionProperty)
for marked DomainObjects.
Proposal:
- Add a new field to the @DomainObjectLayout like openable/viewable.
- Special handling of title columns in CollectionContentsAsAjaxTablePanel /
and/or ObjectAdapterTitleColumn, e.g. EntityIconAndTitlePanel
Background:
I have a complex entity which is displayed in tables in different places.
In one place I want to show a subset of properties only. For this
projection I made a special in-memory object, which wraps the complex
entity and has getters for the subset of properties only. How can I mark
this inmemory object to be not openable, or with other words how do i
suppress/disable the link in the first column.
Dan/Martins QuickFix was:
The column is added at
https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
and I see no way how to suppress the addition in current master branch.
The column is marked with title-column CSS class so it is easy to hide
with: visibility:hidden;, but I'm not sure how easy is to detect on which
page to apply this CSS rule.
If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
#cssClass() special method that may be used to set a custom CSS class. See
http://issues.apache.org/jira/browse/ISIS-1000
Am 26.01.2015 um 23:11 schrieb Dan Haywood d...@haywood-associates.co.uk:
+1 to Martin's answer, there is no configuration setting but it is possible
to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
For example, the todo app uses #cssClass() so that completed todo items are
shown in a table with a strikethrough. This comes from the done CSS
class:
public String cssClass() { return !isComplete() ? todo : done; }
In webapp/css/application.css, if we add:
tr.done a {
pointer-events: none;
cursor: default;
}
and in webapp/scripts/application.js, if we add:
$(document).ready(function() {
$('tr.done a').click(function() { return false; });
});
then the icon for each completed item cannot be clicked.
suppress/disable the link in the first column of a table (CollectionProperty)
-
Key: ISIS-1021
URL: https://issues.apache.org/jira/browse/ISIS-1021
Project: Isis
Issue Type: New Feature
Components: Viewer: Wicket
Affects Versions:
[jira] [Updated] (ISIS-1020) Dropdown window opens top left of the screen
[ https://issues.apache.org/jira/browse/ISIS-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1020: -- Fix Version/s: viewer-wicket-1.8.0 Dropdown window opens top left of the screen Key: ISIS-1020 URL: https://issues.apache.org/jira/browse/ISIS-1020 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.8.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 I have created a screencast to demonstrate in Estatio: https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing This is reproducible in both IE11 and Chrome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1016) Make it possible to use brand logo instead of plain text in the header
[ https://issues.apache.org/jira/browse/ISIS-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296754#comment-14296754 ] Dan Haywood commented on ISIS-1016: --- Could the logo also be shown on the sign-in page? Make it possible to use brand logo instead of plain text in the header -- Key: ISIS-1016 URL: https://issues.apache.org/jira/browse/ISIS-1016 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 It would be good to be possible to use an image instead of plain text for the top-left corner of the header. See http://getbootstrap.com/components/#navbar-brand-image -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297016#comment-14297016
]
ASF subversion and git services commented on ISIS-968:
--
Commit bfea0e6052cda41e21a46831f363143ea09c8691 in isis's branch
refs/heads/ISIS-968 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfea0e6 ]
ISIS-968: @ActionLayout(contributed=...) support.
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (ISIS-1016) Make it possible to use brand logo instead of plain text in the header
[ https://issues.apache.org/jira/browse/ISIS-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reopened ISIS-1016: --- Make it possible to use brand logo instead of plain text in the header -- Key: ISIS-1016 URL: https://issues.apache.org/jira/browse/ISIS-1016 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 It would be good to be possible to use an image instead of plain text for the top-left corner of the header. See http://getbootstrap.com/components/#navbar-brand-image -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1021) suppress/disable the link in the first column of a table (CollectionProperty)
[
https://issues.apache.org/jira/browse/ISIS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296753#comment-14296753
]
Dan Haywood commented on ISIS-1021:
---
Yes, this seems like the correct approach.
Will need a new facet (NotOpenableFacet or perhaps TableOnlyFacet) and a
corresponding FacetFactory.
The Wicket viewer will need to check for the presence of this facet and
suppress the column if there.
~~~
A couple of complications:
- by default, if an action returns a list that has a single object, then as a
convenience the viewer shows that object rather than the table. This
behaviour would need tobe suppressed.
- conversely, if an action were to return a single object that is not-openable,
then what should the system do? It could return an error message, or perhaps
it could dynamically convert to returning a list containing that single object
suppress/disable the link in the first column of a table (CollectionProperty)
-
Key: ISIS-1021
URL: https://issues.apache.org/jira/browse/ISIS-1021
Project: Isis
Issue Type: New Feature
Components: Viewer: Wicket
Affects Versions: viewer-wicket-1.7.0
Reporter: ARI
Assignee: Dan Haywood
Goal:
Suppress/disable the link in the first column of a table (CollectionProperty)
for marked DomainObjects.
Proposal:
- Add a new field to the @DomainObjectLayout like openable/viewable.
- Special handling of title columns in CollectionContentsAsAjaxTablePanel /
ObjectAdapterTitleColumn / EntityIconAndTitlePanel
Background:
I have a complex entity which is displayed in tables in different places.
In one place I want to show a subset of properties only. For this
projection I made a special in-memory object, which wraps the complex
entity and has getters for the subset of properties only. How can I mark
this inmemory object to be not openable, or with other words how do i
suppress/disable the link in the first column.
Dan/Martins QuickFix was:
The column is added at
https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
and I see no way how to suppress the addition in current master branch.
The column is marked with title-column CSS class so it is easy to hide
with: visibility:hidden;, but I'm not sure how easy is to detect on which
page to apply this CSS rule.
If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
#cssClass() special method that may be used to set a custom CSS class. See
http://issues.apache.org/jira/browse/ISIS-1000
Am 26.01.2015 um 23:11 schrieb Dan Haywood d...@haywood-associates.co.uk:
+1 to Martin's answer, there is no configuration setting but it is possible
to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
For example, the todo app uses #cssClass() so that completed todo items are
shown in a table with a strikethrough. This comes from the done CSS
class:
public String cssClass() { return !isComplete() ? todo : done; }
In webapp/css/application.css, if we add:
tr.done a {
pointer-events: none;
cursor: default;
}
and in webapp/scripts/application.js, if we add:
$(document).ready(function() {
$('tr.done a').click(function() { return false; });
});
then the icon for each completed item cannot be clicked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Updated] (ISIS-1020) Dropdown window opens top left of the screen
Uitstekend! On 29 January 2015 at 12:57, Dan Haywood (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/ISIS-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1020: -- Fix Version/s: viewer-wicket-1.8.0 Dropdown window opens top left of the screen Key: ISIS-1020 URL: https://issues.apache.org/jira/browse/ISIS-1020 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.8.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Fix For: viewer-wicket-1.8.0 I have created a screencast to demonstrate in Estatio: https://drive.google.com/file/d/0B2jd2Sl73mDBZ0lqYUhtVjVRamc/view?usp=sharing This is reproducible in both IE11 and Chrome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1012) Use the same date and time format across tables and fields
[ https://issues.apache.org/jira/browse/ISIS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297375#comment-14297375 ] ASF subversion and git services commented on ISIS-1012: --- Commit 5441f5114a9dff6529f608d650ad5e753ca8be14 in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5441f51 ] ISIS-1012 Preserve the datePattern for DateConverterForJavaSqlTimestamp. It could be used as a fallback Use the same date and time format across tables and fields -- Key: ISIS-1012 URL: https://issues.apache.org/jira/browse/ISIS-1012 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Attachments: screenshot-1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1012) Use the same date and time format across tables and fields
[ https://issues.apache.org/jira/browse/ISIS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297377#comment-14297377 ] ASF subversion and git services commented on ISIS-1012: --- Commit 82f891bc31937e85e03878d23658a6b8c7a7ed64 in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=82f891b ] ISIS-1012 Use the current user session locale for the converter in Select2 text provider Use the same date and time format across tables and fields -- Key: ISIS-1012 URL: https://issues.apache.org/jira/browse/ISIS-1012 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Attachments: screenshot-1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1015) DataNucleus doesn't support LocalDateTime
[
https://issues.apache.org/jira/browse/ISIS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297379#comment-14297379
]
ASF subversion and git services commented on ISIS-1015:
---
Commit 27dcb7634e512fb3283239fd477430040b18fb69 in isis's branch
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27dcb76 ]
ISIS-1012 ISIS-1015 Update the TODO
DataNucleus doesn't support LocalDateTime
-
Key: ISIS-1015
URL: https://issues.apache.org/jira/browse/ISIS-1015
Project: Isis
Issue Type: Sub-task
Components: Core: Objectstore: JDO
Affects Versions: core-1.8.0
Reporter: Martin Grigorov
Assignee: Dan Haywood
Priority: Minor
Fix For: core-2.0.0
While debugging ISIS-1012 I've found that Kitchensink app doesn't behave
correctly for Joda-Time's LocalDateTime:
org.apache.isis.viewer.wicket.ui.components.scalars.jodatime.JodaLocalDateTimePanel
doesn't show the scalar value.
Partially the problem has been solved by moving
{code}
@javax.jdo.annotations.Persistent(defaultFetchGroup=true)
{code}
next to
{code}
@Column(allowsNull = true)
{code}
applied on the property getters.
But it appeared that the actual problem is that DataNucleus 3.x and 4.x do
not support Joda-Time's LocalDateTime. There is support for Joda-Time's
LocalDate and JSR310/ThreeTen/JDK8 LocalDateTime though.
This ticket is to document the bug. Since there is no urgent need for
supporting this type its priority is set to Minor.
Thanks to Dan for the directions!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1012) Use the same date and time format across tables and fields
[ https://issues.apache.org/jira/browse/ISIS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297378#comment-14297378 ] ASF subversion and git services commented on ISIS-1012: --- Commit 27dcb7634e512fb3283239fd477430040b18fb69 in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=27dcb76 ] ISIS-1012 ISIS-1015 Update the TODO Use the same date and time format across tables and fields -- Key: ISIS-1012 URL: https://issues.apache.org/jira/browse/ISIS-1012 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Attachments: screenshot-1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1012) Use the same date and time format across tables and fields
[ https://issues.apache.org/jira/browse/ISIS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297376#comment-14297376 ] ASF subversion and git services commented on ISIS-1012: --- Commit e2b684bcedc19037b8ff5b3677893bc19fe0afbd in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e2b684b ] ISIS-1012 Fix the name used in JodaLocalDateTimeValueSemanticsProvider#toString() Use the same date and time format across tables and fields -- Key: ISIS-1012 URL: https://issues.apache.org/jira/browse/ISIS-1012 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Jeroen van der Wal Assignee: Martin Grigorov Attachments: screenshot-1.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-928) Isis 1.8.0 release tasks
[ https://issues.apache.org/jira/browse/ISIS-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298298#comment-14298298 ] ASF subversion and git services commented on ISIS-928: -- Commit b919f2ad49b93f82563716d3490c9cf697c2e495 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b919f2a ] ISIS-928: tiny change to fixture script framework, making ExecutionContext#lookup(...) public and deprecating FixtureScript#lookup(...). Isis 1.8.0 release tasks Key: ISIS-928 URL: https://issues.apache.org/jira/browse/ISIS-928 Project: Isis Issue Type: Task Components: Core, Viewer: Wicket Affects Versions: archetype-todoapp-1.7.0, archetype-simpleapp-1.7.0, viewer-wicket-1.7.0, core-1.7.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: archetype-todoapp-1.8.0, archetype-simpleapp-1.8.0, viewer-wicket-1.8.0, core-1.8.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298299#comment-14298299
]
ASF subversion and git services commented on ISIS-968:
--
Commit 2dc30cfa4c4114e005e89f77d1873bf41edf1ade in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2dc30cf ]
ISIS-968: extending @DomainService(nature=...).
Also deprecating @NotInServiceMenu.
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298300#comment-14298300
]
ASF subversion and git services commented on ISIS-968:
--
Commit b72dd11c90b1d98a3723ed0dffbf2eb92f108335 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b72dd11 ]
ISIS-968: adding unit tests, updates to the todo app.
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298302#comment-14298302
]
ASF subversion and git services commented on ISIS-968:
--
Commit 63957e2e8556871c15bd011371f4de4c3d4d745c in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63957e2 ]
Merge branch 'ISIS-968'
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ISIS-968) Rationalize handling of menu actions and contributed actions
[
https://issues.apache.org/jira/browse/ISIS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-968.
--
Resolution: Fixed
Rationalize handling of menu actions and contributed actions
Key: ISIS-968
URL: https://issues.apache.org/jira/browse/ISIS-968
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: core-1.8.0
Currently we have the following annotations:
* on the domain service: @Hidden - to hide all actions (still in the
metamodel); nb: this has been deprecated in ISIS-970 with no replacement
* on the action: @NotContributed to suppress being contributed, optionally
@NotContributed(As.ASSOCIATION) or @NotContributed(As.ACTION); is still in
menu
* on the action: @NotInServiceMenu to suppress being in menu; can still be
contributed.
This is all somewhat clumsy, and the negative @NotXxx annotations are
confusing to read (@NotContributed(As.Xxx) in particular).
~~~
In Naked Objects MVC they distinguish between three different types of
service:
- menu services (actions are on menus and are contributed)
- contributions (actions are only ever contributed)
- system services (actions never appear on menu or are contributed).
This separation works well; domain-level system services (typically
factories and repositories) are injected into the view-level menu or
contribution services.
~~~
This ticket proposes:
Extend @DomainService to characterize the nature of each domain (similar to
NO MVC):
{code}
@DomainService(nature=VIEW | VIEW_MENU | VIEW_CONTRIBUTIONS | DOMAIN )
{code}
where:
* VIEW = current behaviour, and the default
* VIEW_MENU = actions are not contributed
* VIEW_CONTRIBUTIONS = in other words actions are not in service menu
* DOMAIN = are not shown in view ie actions implicitly hidden
In addition, extend @ActionLayout to include further UI hints:
{code}
@ActionLayout(
contributedAs= ACTION|ASSOCIATION|BOTH // default is BOTH;
equivalent (inverse of) the current @NotContributed(As.Xxx)
)
{code}
which for domain service of VIEW or VIEW_CONTRIBUTIONS can restrict the
contribution if required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
