[jira] [Commented] (ISIS-970) Introduce new annotations to collect together all non-UI (layout) hints, and deprecate old annotations
[
https://issues.apache.org/jira/browse/ISIS-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318214#comment-14318214
]
ASF subversion and git services commented on ISIS-970:
--
Commit d697a68714acbcb3ad938631da0c845b1a962550 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d697a68 ]
ISIS-970: updating built-in services to use new (non-deprecated) annotations.
Also:
- new ActionInvocationContext (replacement for Bulk.InvocationContext) was not
marked as @RequestScoped, now is.
- new IsisApplibModule to contain domain event super classes
- automatically registering BookmarkHolderAssociationContributions, and
BookmarkHolderActionContributions, updating to emit domain events
- adding missing javadoc for EmailNotificationService, UserRegistrationService
-
Introduce new annotations to collect together all non-UI (layout) hints, and
deprecate old annotations
--
Key: ISIS-970
URL: https://issues.apache.org/jira/browse/ISIS-970
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: core-1.7.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: core-1.8.0
specifically:
{code}
@DomainObject(
auditing = ENABLED etc. (AuditingPolicy)// instead of @Audited
publishing = ENABLED etc. (PublishingPolicy)// instead of
@PublishedObject
publishingPayloadFactory = SomePayloadFactory.class // instead of
@PublishedObject(payloadFactory=...)
autoCompleteRepository = SomeRepository.class // instead of
@AutoComplete(repository=...)
autoCompleteAction = autoComplete // instead of
@AutoComplete(action=...)
bounded = true|false// instead of
@Bounded. takes precedence over autoComplete
editing = ENABLED etc (EditingPolicy) // instead of
@Immutable
editingDisabledReason = ... // instead of Always
disabled message inferred from @Immutable
objectType = CUS // instead of
@ObjectType
nature = JDO_ENTITY | EXTERNAL_ENTITY | VIEW_MODEL// instead of
@ViewModel, defaults to JDO_ENTITY
)
{code}
and
{code}
@Property(
domainEvent = ToDoItem.DueBy.class// instead of
@PropertyInteraction
hidden = Where.NOWHERE etc// instead of
@Hidden(where=...); ignore the When enum
editing = ENABLED etc (EditingPolicy) // instead of @Disabled; ignore
Where and When enums
editingDisabledReason = ... // instead of
@Disabled(reason=...)
maxLength = 20// instead of @MaxLength;
default of -1 indicates not specified
mustSatisfy = {SomeSpecification.class} // instead of @MustSatisfy
notPersisted = true|false // instead of @NotPersisted;
defaults to false
optional = DEFAULT|TRUE|FALSE // instead of @Optional and
@Mandatory.
regexPattern = .+\@.+ // instead of
@RegEx(validation=...)
regexPatternFlags = 1 // superset of
@RegEx(caseSensitive=...)
)
{code}
where cardinality defaults to mandatory unless Column(allowsNull=true) is
set.
and
{code}
@Collection(
domainEvent = ToDoItem.Dependencies.class // instead of
@CollectionInteraction
hidden = Where.NOWHERE etc// instead of
@Hidden(where=...); ignore the When enum
editing = ENABLED etc (EditingPolicy) // instead of @Disabled; ignore
Where and When enums
editingDisabledReason = ... // instead of
@Disabled(reason=...)
typeOf = OrderLine.class // instead of @TypeOf
)
{code}
and
{code}
@Action(
domainEvent = ToDoItem.Completed.class // instead of
@ActionInteraction
hidden = Where.NOWHERE etc // instead of
@Hidden(where=...); ignore the When enum
semantics = Semantics.SAFE etc. // instead of
@ActionSemantics
invokeOn = InvokeOn.OBJECTS_AND_COLLECTIONS // instead of @Bulk
and @Bulk(appliesTo=...)
command = ENABLED|DISABLED|AS_CONFIGURED// instead of @Command
commandPersistence = Persistence.PERSISTED // instead of
@Command(persistence=...)
commandExecuteIn = ExecuteIn.FOREGROUND // instead of
@Command(executeIn=...)
publishing = ENABLED etc. (PublishingPolicy)// instead of
@PublishedAction
publishingPayloadFactory = SomePayloadFactory.class // instead of
@PublishedAction(payloadFactory=...)
restrictTo = Environment.DEVELOPMENT//
[jira] [Commented] (ISIS-1030) Not possible for a declarative view model (@ViewModel) to reference another view model/
[ https://issues.apache.org/jira/browse/ISIS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318213#comment-14318213 ] ASF subversion and git services commented on ISIS-1030: --- Commit 28df2aecb8fb5f9a671a66b9170f2274392284b6 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=28df2ae ] ISIS-1030: further view model fix in the rehydration... ... of a view model that references another view model Not possible for a declarative view model (@ViewModel) to reference another view model/ --- Key: ISIS-1030 URL: https://issues.apache.org/jira/browse/ISIS-1030 Project: Isis Issue Type: Bug Components: Core Affects Versions: viewer-wicket-1.7.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 The issue is that the view model facet uses BookmarkService to encode any non-value types as bookmarks that are, in essence, interpreted as being persistent entities. The fix is to enhance the Bookmark so that it distinguishes between persistent vs viewmodels, and can pass this to RootOid when rehydrating. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-690) 'Show all' button for tables.
[ https://issues.apache.org/jira/browse/ISIS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318295#comment-14318295 ] Jörg Rade commented on ISIS-690: IMHO is this solved by the 'show all' link. 'Show all' button for tables. - Key: ISIS-690 URL: https://issues.apache.org/jira/browse/ISIS-690 Project: Isis Issue Type: New Feature Components: Viewer: Wicket Affects Versions: viewer-wicket-1.3.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1030) Not possible for a declarative view model (@ViewModel) to reference another view model/
[ https://issues.apache.org/jira/browse/ISIS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318212#comment-14318212 ] ASF subversion and git services commented on ISIS-1030: --- Commit a2127cb9d985a5893e5e2439f8207f395d7d8827 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a2127cb ] ISIS-1030: fix for view models to reference other view model. Not possible for a declarative view model (@ViewModel) to reference another view model/ --- Key: ISIS-1030 URL: https://issues.apache.org/jira/browse/ISIS-1030 Project: Isis Issue Type: Bug Components: Core Affects Versions: viewer-wicket-1.7.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 The issue is that the view model facet uses BookmarkService to encode any non-value types as bookmarks that are, in essence, interpreted as being persistent entities. The fix is to enhance the Bookmark so that it distinguishes between persistent vs viewmodels, and can pass this to RootOid when rehydrating. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1030) Not possible for a declarative view model (@ViewModel) to reference another view model/
[ https://issues.apache.org/jira/browse/ISIS-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318182#comment-14318182 ] Martin Grigorov commented on ISIS-1030: --- I think this fix can be merged to master. Everything works fine here. Not possible for a declarative view model (@ViewModel) to reference another view model/ --- Key: ISIS-1030 URL: https://issues.apache.org/jira/browse/ISIS-1030 Project: Isis Issue Type: Bug Components: Core Affects Versions: viewer-wicket-1.7.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.8.0 The issue is that the view model facet uses BookmarkService to encode any non-value types as bookmarks that are, in essence, interpreted as being persistent entities. The fix is to enhance the Bookmark so that it distinguishes between persistent vs viewmodels, and can pass this to RootOid when rehydrating. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-171) Add-on module to allow domain entities to send emails.
[
https://issues.apache.org/jira/browse/ISIS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318307#comment-14318307
]
Jörg Rade commented on ISIS-171:
Isn't this solved with 1.8.0?
Add-on module to allow domain entities to send emails.
--
Key: ISIS-171
URL: https://issues.apache.org/jira/browse/ISIS-171
Project: Isis
Issue Type: New Feature
Components: Add-ons
Reporter: Dan Haywood
Priority: Minor
Fix For: core-2.0.0
Provide a standalone implementation of an email service that can be
registered as a hidden service, and injected into domain objects so that they
are able to send emails.
The signature of the interface would be something like:
[Hidden]
public interface EmailService {
void sendEmail(MessageDetails details) throws MessageException;
}
where MessageDetails holds the from, to, cc, bcc, the subject, the content,
any attachments etc
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (ISIS-1031) Filter and pagination on tables
[ https://issues.apache.org/jira/browse/ISIS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned ISIS-1031: - Assignee: Martin Grigorov (was: Dan Haywood) Filter and pagination on tables --- Key: ISIS-1031 URL: https://issues.apache.org/jira/browse/ISIS-1031 Project: Isis Issue Type: New Feature Components: Core Affects Versions: viewer-wicket-1.7.0, core-1.7.0 Reporter: Joshua Kamau Assignee: Martin Grigorov Priority: Minor Labels: filter, grid, pagination It should be possible to show pagination in the tables possibly with configurable page size. It should also be nice to have ability to filter entities in a table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1031) Filter and pagination on tables
[
https://issues.apache.org/jira/browse/ISIS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318412#comment-14318412
]
Jeroen van der Wal commented on ISIS-1031:
--
Pagination has always been available. It can be configured using the
CollectionLayout#paged annotation [1]. The defaults can be set in the
isis.properties file:
{code}
isis.viewers.paged.standalone=30
isis.viewers.paged.parented=10
{code}
[1]
http://isis.apache.org/reference/recognized-annotations/CollectionLayout.html
Filter and pagination on tables
---
Key: ISIS-1031
URL: https://issues.apache.org/jira/browse/ISIS-1031
Project: Isis
Issue Type: New Feature
Components: Core
Affects Versions: viewer-wicket-1.7.0, core-1.7.0
Reporter: Joshua Kamau
Assignee: Martin Grigorov
Priority: Minor
Labels: filter, grid, pagination
It should be possible to show pagination in the tables possibly with
configurable page size. It should also be nice to have ability to filter
entities in a table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ISIS-1031) Filter and pagination on tables
Joshua Kamau created ISIS-1031: -- Summary: Filter and pagination on tables Key: ISIS-1031 URL: https://issues.apache.org/jira/browse/ISIS-1031 Project: Isis Issue Type: New Feature Components: Core Affects Versions: core-1.7.0, viewer-wicket-1.7.0 Reporter: Joshua Kamau Assignee: Dan Haywood Priority: Minor It should be possible to show pagination in the tables possibly with configurable page size. It should also be nice to have ability to filter entities in a table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1032) Contract test for bidirectional relationship can't handle overridden methods
Jeroen van der Wal created ISIS-1032: Summary: Contract test for bidirectional relationship can't handle overridden methods Key: ISIS-1032 URL: https://issues.apache.org/jira/browse/ISIS-1032 Project: Isis Issue Type: Improvement Components: Core Affects Versions: core-1.7.0 Reporter: Jeroen van der Wal Assignee: Jeroen van der Wal Priority: Minor Fix For: core-1.8.0 The contract tests search for methods with a specific name. It asserts to find one but when the method is overridden in a test it finds more then one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
