[jira] [Commented] (ISIS-1759) Always calling getXxx() and hideXxx() both decreases performance of application (?)
[ https://issues.apache.org/jira/browse/ISIS-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252694#comment-16252694 ] ASF subversion and git services commented on ISIS-1759: --- Commit 80c72bdb567a1c4321457f09b53c4f2291af88ac in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=80c72bd ] ISIS-1759: adds special casing so that @DomainObject#cssClass does not trump cssClass() method, but still allowing @DomainObject#cssClassUiEvent to have priority over them both > Always calling getXxx() and hideXxx() both decreases performance of > application (?) > --- > > Key: ISIS-1759 > URL: https://issues.apache.org/jira/browse/ISIS-1759 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.16.0 > > > as per > https://lists.apache.org/thread.html/6eb586e378bf239891189791b214f0a4b44e12ae4f1ddd0c49478d78@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ISIS-1759) Always calling getXxx() and hideXxx() both decreases performance of application (?)
[ https://issues.apache.org/jira/browse/ISIS-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1759. --- Resolution: Fixed > Always calling getXxx() and hideXxx() both decreases performance of > application (?) > --- > > Key: ISIS-1759 > URL: https://issues.apache.org/jira/browse/ISIS-1759 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.16.0 > > > as per > https://lists.apache.org/thread.html/6eb586e378bf239891189791b214f0a4b44e12ae4f1ddd0c49478d78@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (ISIS-1758) cssClass() not working any more if css class definition exists on DomainObjectLayout
[ https://issues.apache.org/jira/browse/ISIS-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1758: - Assignee: Dan Haywood > cssClass() not working any more if css class definition exists on > DomainObjectLayout > > > Key: ISIS-1758 > URL: https://issues.apache.org/jira/browse/ISIS-1758 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > > as per > https://lists.apache.org/thread.html/2f228e10680b7f65a520c1bf47042ec8bba14602e61b9b56d90393b3@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ISIS-1769) Mixin to navigate to equivalent REST API URL for each domain object.
[ https://issues.apache.org/jira/browse/ISIS-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1769. --- Resolution: Fixed > Mixin to navigate to equivalent REST API URL for each domain object. > > > Key: ISIS-1769 > URL: https://issues.apache.org/jira/browse/ISIS-1769 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1769) Mixin to navigate to equivalent REST API URL for each domain object.
[ https://issues.apache.org/jira/browse/ISIS-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252663#comment-16252663 ] ASF subversion and git services commented on ISIS-1769: --- Commit a81ab04a05305e5188964551c1d769319a55e2b0 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a81ab04 ] ISIS-1769: adds openRestApi mixin for Object. > Mixin to navigate to equivalent REST API URL for each domain object. > > > Key: ISIS-1769 > URL: https://issues.apache.org/jira/browse/ISIS-1769 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (ISIS-1769) Mixin to navigate to equivalent REST API URL for each domain object.
[ https://issues.apache.org/jira/browse/ISIS-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1769: - Assignee: Dan Haywood > Mixin to navigate to equivalent REST API URL for each domain object. > > > Key: ISIS-1769 > URL: https://issues.apache.org/jira/browse/ISIS-1769 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1714) AppManifestAbstract#withConfigurationProperty overwrites value set by -D system property.
[ https://issues.apache.org/jira/browse/ISIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252617#comment-16252617 ] ASF subversion and git services commented on ISIS-1714: --- Commit 7c95d76c72d1243999277fff85e330889ee13f23 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7c95d76 ] ISIS-1714: default implementation of UserProfileService. > AppManifestAbstract#withConfigurationProperty overwrites value set by -D > system property. > - > > Key: ISIS-1714 > URL: https://issues.apache.org/jira/browse/ISIS-1714 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1714) AppManifestAbstract#withConfigurationProperty overwrites value set by -D system property.
[ https://issues.apache.org/jira/browse/ISIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252614#comment-16252614 ] ASF subversion and git services commented on ISIS-1714: --- Commit 7c95d76c72d1243999277fff85e330889ee13f23 in isis's branch refs/heads/ISIS-1759 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7c95d76 ] ISIS-1714: default implementation of UserProfileService. > AppManifestAbstract#withConfigurationProperty overwrites value set by -D > system property. > - > > Key: ISIS-1714 > URL: https://issues.apache.org/jira/browse/ISIS-1714 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1759) Always calling getXxx() and hideXxx() both decreases performance of application (?)
[ https://issues.apache.org/jira/browse/ISIS-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252616#comment-16252616 ] ASF subversion and git services commented on ISIS-1759: --- Commit 003f830d53c96d5b4405641bc47b38298868e665 in isis's branch refs/heads/ISIS-1759 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=003f830 ] ISIS-1759: suppresses superfluous calls to obtain value of property if the property is hidden anyway > Always calling getXxx() and hideXxx() both decreases performance of > application (?) > --- > > Key: ISIS-1759 > URL: https://issues.apache.org/jira/browse/ISIS-1759 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.16.0 > > > as per > https://lists.apache.org/thread.html/6eb586e378bf239891189791b214f0a4b44e12ae4f1ddd0c49478d78@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (ISIS-1746) Provide a default implementation of UserProfileService so that don't need special case logic in each viewer.
[ https://issues.apache.org/jira/browse/ISIS-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1746: - Assignee: Dan Haywood > Provide a default implementation of UserProfileService so that don't need > special case logic in each viewer. > > > Key: ISIS-1746 > URL: https://issues.apache.org/jira/browse/ISIS-1746 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.16.0 > > > currently don't have a default impl; the docs say: > If the method returns null or throws an exception then the framework will > default to using the current user name. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1710) AppManifestAbstract#withAdditionalServices replaces rather than appends.
[ https://issues.apache.org/jira/browse/ISIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252615#comment-16252615 ] ASF subversion and git services commented on ISIS-1710: --- Commit 629289008ec55a5b56895a7ddde1903fd2a70e39 in isis's branch refs/heads/ISIS-1759 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6292890 ] ISIS-1710: fixes NPE if no prior list of services > AppManifestAbstract#withAdditionalServices replaces rather than appends. > > > Key: ISIS-1710 > URL: https://issues.apache.org/jira/browse/ISIS-1710 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > > Unlike withAdditionalModules, that appends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1710) AppManifestAbstract#withAdditionalServices replaces rather than appends.
[ https://issues.apache.org/jira/browse/ISIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252618#comment-16252618 ] ASF subversion and git services commented on ISIS-1710: --- Commit 629289008ec55a5b56895a7ddde1903fd2a70e39 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6292890 ] ISIS-1710: fixes NPE if no prior list of services > AppManifestAbstract#withAdditionalServices replaces rather than appends. > > > Key: ISIS-1710 > URL: https://issues.apache.org/jira/browse/ISIS-1710 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > > Unlike withAdditionalModules, that appends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (ISIS-1759) Always calling getXxx() and hideXxx() both decreases performance of application (?)
[ https://issues.apache.org/jira/browse/ISIS-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1759: - Assignee: Dan Haywood > Always calling getXxx() and hideXxx() both decreases performance of > application (?) > --- > > Key: ISIS-1759 > URL: https://issues.apache.org/jira/browse/ISIS-1759 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.16.0 > > > as per > https://lists.apache.org/thread.html/6eb586e378bf239891189791b214f0a4b44e12ae4f1ddd0c49478d78@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ISIS-1710) AppManifestAbstract#withAdditionalServices replaces rather than appends.
[ https://issues.apache.org/jira/browse/ISIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1710. --- Resolution: Fixed > AppManifestAbstract#withAdditionalServices replaces rather than appends. > > > Key: ISIS-1710 > URL: https://issues.apache.org/jira/browse/ISIS-1710 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > > Unlike withAdditionalModules, that appends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1710) AppManifestAbstract#withAdditionalServices replaces rather than appends.
[ https://issues.apache.org/jira/browse/ISIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251791#comment-16251791 ] ASF subversion and git services commented on ISIS-1710: --- Commit af07e749a3bc830fdcb1fb4b47cd31df5e389de8 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=af07e74 ] ISIS-1710: append to existing list of services if using AppManifest's withAdditionalServices > AppManifestAbstract#withAdditionalServices replaces rather than appends. > > > Key: ISIS-1710 > URL: https://issues.apache.org/jira/browse/ISIS-1710 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > > Unlike withAdditionalModules, that appends. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ISIS-1767) JEE 7+ Support
[ https://issues.apache.org/jira/browse/ISIS-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1767: - Description: Collective tasks for Java EE 7+ support. Designated branch ... {code}dev/2.0.0/ISIS-1767-jee-7{code} +Tests+ * *Server*: JEE 7+ implementation (or similar), launched with JDK8 (Version 1.8.0_152); for deployment we use the HelloWorld artifact 1.15.1 with minor modifications * *fat-war*: deploy all dependencies with single war (hsqldb in memory) * *skinny-war*: prepare container with shared libraries and shared domain objects, deploy only a subset of domain classes with single war (hsqldb in memory) * *restEasy*: check whether restEasy responds * managed connection pool (*con.pool*): use mysql db connection pool managed by the JEE container and provided via JNDI * domain events (*dom.events*): test whether domain events are emitted and handled using AxonFramework's SimpleEventBus * *swagger-ui*: test whether the static index.html from swagger-ui is served and verify that a request for '//restful/swagger/private' returns a JSON, that has the 'basePath' set to '//restful' * *redeploy*: test whether all previous tests succeed if we do a deploy-undeply-deploy process ||Server ||fat-war ||skinny-war ||restEasy ||con.pool ||dom.events ||swagger-ui||redeploy|| |Payara (full 4.1.2.173) |{color:green}*OK*{color} |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:red}*FAILED*(6){color}| |Payara (web 4.1.2.173) |{color:green}*OK*{color} |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:red}*FAILED*(6){color}| |Glassfish (full 4.1.2) |*OK*(1) |*OK*(1) |{color:green}*OK*{color}|todo |{color:green}*OK*{color}|{color:green}*OK*{color}|todo| |Glassfish (web 5.0.1 beta)|{color:green}*OK*{color} |{color:green}*OK*{color}|{color:red}*FAILED*(5){color}|todo |{color:green}*OK*{color}|{color:red}*FAILED*(5){color}|todo| |Glassfish (full 5.0) |{color:red}*FAILED*(2){color}|todo |todo|todo|todo |todo|todo| |Wildfly (full 11.0.0)|{color:red}*FAILED*(3){color}|todo |todo|todo|todo |todo|todo| |TomEE (plume 7.0.4) |*OK*(4) |todo |{color:green}*OK*{color}|todo|todo |todo|todo| Notes: (1) Guava version conflict: GF 4.2.1 has Guava-13, Isis has Guava-19; WORKAROUND modify your glassfish installation ... * in glassfish/modules/ replace guava.jar with that which comes packaged with Payara-4.1.2.173 (Guava-19) * you need to clear the OSGI cache: delete the folder glassfish/domains/domainXXX/osgi-cache/felix (2) ON-HOLD waiting for GF 5.0.1 release! class-loading issues with Hibernate Validator, though library is included in war ... java.lang.ClassNotFoundException: org.joda.time.ReadableInstant; using patch https://github.com/hibernate/hibernate-validator/pull/857/files does not help: introduces new class-loading issues; (3) class-loading issues, though library is included in war ... javax.persistence.PersistenceException: WFLYJPA0057: PersistenceProvider 'org.apache.isis.core.webapp.jee.PersistenceUnitNoopProvider' not found; (4) requires CXF to be disabled, see https://stackoverflow.com/questions/41496204/tomee-7-0-2-how-to-disable-cxf-rs throws exceptions on undeploy (5) org.jboss.resteasy.spi.UnhandledException: java.lang.AbstractMethodError: javax.ws.rs.core.Response$ResponseBuilder.status(ILjava/lang/String;)Ljavax/ws/rs/core/Response$ResponseBuilder; at org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:77) ... Caused by: java.lang.AbstractMethodError: javax.ws.rs.core.Response$ResponseBuilder.status(ILjava/lang/String;)Ljavax/ws/rs/core/Response$ResponseBuilder; at javax.ws.rs.core.Response$ResponseBuilder.status(Response.java:921) ... (6) dedicated issue https://issues.apache.org/jira/browse/ISIS-1754 throws org.datanucleus.metadata.InvalidClassMetaDataException was: Collective tasks for Java EE 7+ support. Designated branch ... {code}dev/2.0.0/ISIS-1767-jee-7{code} +Tests+ * *Server*: JEE 7+ implementation (or similar), launched with JDK8 (Version 1.8.0_152); for deployment we use the HelloWorld artifact 1.15.1 with minor modifications * *fat-war*: deploy all dependencies with single war (hsqldb in memory) * *skinny-war*: prepare container with shared libraries and shared
[jira] [Updated] (ISIS-1754) JEE Support - ClassLoading Issues
[ https://issues.apache.org/jira/browse/ISIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1754: - Description: Skinny-war and fat-war deployments work as long as the JEE server is in a state, where DataNucleus (5.1) was not yet loaded by any class-loader. (e.g. nothing deployed, and fresh boot of JEE server) Once DN is loaded by the JEE any subsequent deployment will fail with org.datanucleus.metadata.InvalidClassMetaDataException. was: Skinny-war and fat-war deployments work as long as the JEE server is in a state, where DataNucleus (5.1) was not yet loaded by any class-loader. (e.g. nothing deployed, and fresh boot of JEE server) Once DN is loaded by the JEE any subsequent deployment will fail. > JEE Support - ClassLoading Issues > - > > Key: ISIS-1754 > URL: https://issues.apache.org/jira/browse/ISIS-1754 > Project: Isis > Issue Type: Improvement >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > Skinny-war and fat-war deployments work as long as the JEE server is in a > state, where DataNucleus (5.1) was not yet loaded by any class-loader. (e.g. > nothing deployed, and fresh boot of JEE server) > Once DN is loaded by the JEE any subsequent deployment will fail with > org.datanucleus.metadata.InvalidClassMetaDataException. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ISIS-1754) JEE Support - ClassLoading Issues
[ https://issues.apache.org/jira/browse/ISIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1754: - Description: Skinny-war and fat-war deployments work as long as the JEE server is in a state, where DataNucleus (5.1) was not yet loaded by any class-loader. (e.g. nothing deployed, and fresh boot of JEE server) Once DN is loaded by the JEE any subsequent deployment will fail. was: as per https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E Class.forName(...), so we need a plug-able class-loading mechanism. (What worked for me is Thread.currentThread().getContextClassLoader().loadClass(...)). Unfortunately this applies also to DataNucleus. So I had to patch their class loading mechanism. (Sounds dramatic, but was just a single line of code.) > JEE Support - ClassLoading Issues > - > > Key: ISIS-1754 > URL: https://issues.apache.org/jira/browse/ISIS-1754 > Project: Isis > Issue Type: Improvement >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > Skinny-war and fat-war deployments work as long as the JEE server is in a > state, where DataNucleus (5.1) was not yet loaded by any class-loader. (e.g. > nothing deployed, and fresh boot of JEE server) > Once DN is loaded by the JEE any subsequent deployment will fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ISIS-1754) JEE Support - ClassLoading Issues
[ https://issues.apache.org/jira/browse/ISIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1754: - Summary: JEE Support - ClassLoading Issues (was: JEE Support - replace Class.forName with TCL.loadClass (+ patching DN)) > JEE Support - ClassLoading Issues > - > > Key: ISIS-1754 > URL: https://issues.apache.org/jira/browse/ISIS-1754 > Project: Isis > Issue Type: Improvement >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > as per > https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E > Class.forName(...), so we need a plug-able class-loading mechanism. > (What worked for me is > Thread.currentThread().getContextClassLoader().loadClass(...)). > Unfortunately this applies also to DataNucleus. So I had to patch their > class loading mechanism. (Sounds dramatic, but was just a single line of > code.) -- This message was sent by Atlassian JIRA (v6.4.14#64029)