[jira] [Updated] (ISIS-743) Remove the concept of transient objects and of @NotPersistable; instead we have view models.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-743:
-
Fix Version/s: (was: 2.2.0)
   2.0.0-M3

> Remove the concept of transient objects and of @NotPersistable; instead we 
> have view models.
> 
>
> Key: ISIS-743
> URL: https://issues.apache.org/jira/browse/ISIS-743
> Project: Isis
>  Issue Type: Wish
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
> Attachments: Design-1.PNG, Design-2.PNG
>
>
> For discussion; but think that view models supercede our earlier ideas of 
> transient objects etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1702) [DUPLICATE] Infer @Programmatic on methods within @DomainService(nature=DOMAIN)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1702.
-
Resolution: Duplicate

> [DUPLICATE] Infer @Programmatic on methods within 
> @DomainService(nature=DOMAIN)
> ---
>
> Key: ISIS-1702
> URL: https://issues.apache.org/jira/browse/ISIS-1702
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> to remove some boilerplate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ISIS-1702) [DUPLICATE] Infer @Programmatic on methods within @DomainService(nature=DOMAIN)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-1702:
-

 Assignee: Dan Haywood
Fix Version/s: (was: 2.2.0)
   1.17.0
  Summary: [DUPLICATE] Infer @Programmatic on methods within 
@DomainService(nature=DOMAIN)  (was: Infer @Programmatic on methods within 
@DomainService(nature=DOMAIN))

> [DUPLICATE] Infer @Programmatic on methods within 
> @DomainService(nature=DOMAIN)
> ---
>
> Key: ISIS-1702
> URL: https://issues.apache.org/jira/browse/ISIS-1702
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> to remove some boilerplate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1694) Docs: hints and tips for writing view models: use Lombok

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1694:
--
Fix Version/s: (was: 2.2.0)
   2.0.0

> Docs: hints and tips for writing view models: use Lombok
> 
>
> Key: ISIS-1694
> URL: https://issues.apache.org/jira/browse/ISIS-1694
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Trivial
> Fix For: 2.0.0
>
>
> {code}
> @NoArgsConstructor
> @AllArgsConstructor
> public class IncomingInvoiceDownloadManager {
> @Getter
> private LocalDate fromInputDate;
> @Getter
> private LocalDate toInputDate;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1734) Enhance TitleService, return an enhanced TitleBuffer that uses TitleService for new appendTitleOf(...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1734:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Enhance TitleService, return an enhanced TitleBuffer that uses TitleService 
> for new appendTitleOf(...)
> --
>
> Key: ISIS-1734
> URL: https://issues.apache.org/jira/browse/ISIS-1734
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> thus:
> TitleBuffer buffer = titleService.newBuffer();



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1563) Remove support in Memento (internal class) for transient (JDO) entities

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1563:
--
Fix Version/s: (was: 2.2.0)
   2.0.0-M3

> Remove support in Memento (internal class) for transient (JDO) entities
> ---
>
> Key: ISIS-1563
> URL: https://issues.apache.org/jira/browse/ISIS-1563
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.13.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> This is a legacy from days gone by, but there is no longer any needed to 
> handle this.  Instead, just fail-fast if attempt to create a Memento for a 
> domain entity that is not yet persistent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1757) JEE Support - container-provided connection pools

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1757:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M3

> JEE Support - container-provided connection pools
> -
>
> Key: ISIS-1757
> URL: https://issues.apache.org/jira/browse/ISIS-1757
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> I use JEE container provided connection pools and bind them to  Isis/JDO via 
> JNDI. I'm not an expert on this, but I believe this works  totally sane.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-790) Replace DN Blob/Clob Mappings with Blob/Clob converters

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-790:
-
Fix Version/s: (was: 2.0.0-M5)
   2.0.0-M4

> Replace DN Blob/Clob Mappings with Blob/Clob converters
> ---
>
> Key: ISIS-790
> URL: https://issues.apache.org/jira/browse/ISIS-790
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Objectstore: JDO
>Affects Versions: objectstore-jdo-1.4.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> See ISIS-788 for background on the Blob/Clob converters.  
> ISIS-789 (upgrade to DN 4.0) is a prereq (meaning ISIS-568 for JDK is also).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-722) [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new up" PojoAdapters around pojos as-and-when?

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-722.

Resolution: Duplicate

> [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new 
> up" PojoAdapters around pojos as-and-when?
> 
>
> Key: ISIS-722
> URL: https://issues.apache.org/jira/browse/ISIS-722
> Project: Isis
>  Issue Type: Question
>  Components: Core
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> If we did this, then the next obvious improvement would be to use a javassist 
> to proxy every pojo, so that the pojo itself could provide its own 
> (single-use) PojoAadapter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1663) Metamodel validatoor to check: any method annotated with @Property, @Collection or @Action should be public.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1663:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Metamodel validatoor to check: any method annotated with @Property, 
> @Collection or @Action should be public.
> 
>
> Key: ISIS-1663
> URL: https://issues.apache.org/jira/browse/ISIS-1663
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-722) [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new up" PojoAdapters around pojos as-and-when?

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-722:
-
Fix Version/s: (was: 2.2.0)
   2.0.0-M2
  Summary: [DUPLICATE] For 2.0.0, should we get rid of the identity 
map, and simply "new up" PojoAdapters around pojos as-and-when?  (was: For 
2.0.0, should we get rid of the identity map, and simply "new up" PojoAdapters 
around pojos as-and-when?)

> [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new 
> up" PojoAdapters around pojos as-and-when?
> 
>
> Key: ISIS-722
> URL: https://issues.apache.org/jira/browse/ISIS-722
> Project: Isis
>  Issue Type: Question
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> If we did this, then the next obvious improvement would be to use a javassist 
> to proxy every pojo, so that the pojo itself could provide its own 
> (single-use) PojoAadapter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1898) Use Joda Interval for LocalDate collection parameter

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1898:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Use Joda Interval for LocalDate collection parameter
> 
>
> Key: ISIS-1898
> URL: https://issues.apache.org/jira/browse/ISIS-1898
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Sander Ginn
>Priority: Major
> Fix For: 1.18.0
>
>
> {code:java}
> // code placeholder
> {code}
> To accommodate to the requirement of a {{choicesXxx}}/{{autoCompleteXxx}} 
> method for a collection parameter on an action, it would be useful to be able 
> to return a Joda Interval instead of a collection of LocalDates.
> Furthermore, it is desirable that the available options are offered through 
> the date picker that is currently used for single LocalDate parameters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ISIS-722) [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new up" PojoAdapters around pojos as-and-when?

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-722:


Assignee: Dan Haywood

> [DUPLICATE] For 2.0.0, should we get rid of the identity map, and simply "new 
> up" PojoAdapters around pojos as-and-when?
> 
>
> Key: ISIS-722
> URL: https://issues.apache.org/jira/browse/ISIS-722
> Project: Isis
>  Issue Type: Question
>  Components: Core
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> If we did this, then the next obvious improvement would be to use a javassist 
> to proxy every pojo, so that the pojo itself could provide its own 
> (single-use) PojoAadapter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1806) [WON'T FIX] Reinstate ability to bookmark action invocations

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1806:
--
Fix Version/s: (was: 2.1.0)
   1.18.0

> [WON'T FIX] Reinstate ability to bookmark action invocations 
> -
>
> Key: ISIS-1806
> URL: https://issues.apache.org/jira/browse/ISIS-1806
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> broken in 1.15.0, and commented out in 1.16.0 to avoid user failures.
> The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, 
> which causes the ActionPromptPage to be rendered.  This in turn has a 
> ComponentType of ACTION_PARAMETERS.  
> However, the ActionParametersPromptPanelFactory explicitly does not match for 
> actions that take no arguments, and so the only component found is 
> UnknownPanel which - of course - fails to add the correct 
> ActionParametersPanel component.
> This whole area needs reworking ... the ActionParametersPanel now no-longer 
> supports being invoked with no-args or with populated n-args and 
> automatically resolving to the result of the action invocation.  
> Instead, will need to move the action execution stuff into the implementation 
> of the AbstractLink that is created within the BookmarkedPagesPanel.
> ~~
> or: maybe we just keep this functionality commented out; is it used anyway ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1806) [WON'T FIX] Reinstate ability to bookmark action invocations

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1806:
--
Summary: [WON'T FIX] Reinstate ability to bookmark action invocations   
(was: Reinstate ability to bookmark action invocations )

> [WON'T FIX] Reinstate ability to bookmark action invocations 
> -
>
> Key: ISIS-1806
> URL: https://issues.apache.org/jira/browse/ISIS-1806
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.1.0
>
>
> broken in 1.15.0, and commented out in 1.16.0 to avoid user failures.
> The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, 
> which causes the ActionPromptPage to be rendered.  This in turn has a 
> ComponentType of ACTION_PARAMETERS.  
> However, the ActionParametersPromptPanelFactory explicitly does not match for 
> actions that take no arguments, and so the only component found is 
> UnknownPanel which - of course - fails to add the correct 
> ActionParametersPanel component.
> This whole area needs reworking ... the ActionParametersPanel now no-longer 
> supports being invoked with no-args or with populated n-args and 
> automatically resolving to the result of the action invocation.  
> Instead, will need to move the action execution stuff into the implementation 
> of the AbstractLink that is created within the BookmarkedPagesPanel.
> ~~
> or: maybe we just keep this functionality commented out; is it used anyway ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1788) Reduce the number of calls on a dependent choices field

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1788:
--
Fix Version/s: (was: 2.1.0)
   2.2.0

> Reduce the number of calls on a dependent choices field
> ---
>
> Key: ISIS-1788
> URL: https://issues.apache.org/jira/browse/ISIS-1788
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.2.0
>
>
> , should only be called when the preceding param changes.
> ref: ECP-396 (editSeller on IncomingDocAsViewModel), in-line prompt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1656) Flush auditing/publishing etc to end of the ACTION phase, rather than end of RENDER phase.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1656:
--
Fix Version/s: (was: 2.1.0)
   2.0.0-M5

> Flush auditing/publishing etc to end of the ACTION phase, rather than end of 
> RENDER phase.
> --
>
> Key: ISIS-1656
> URL: https://issues.apache.org/jira/browse/ISIS-1656
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> cf ISIS=1655, whereby we can only flush QueryResultsCache and not the other 
> two transaction-scoped services.
> I think we should probably bring the hook for the auditing etc forward to the 
> beginning of the RENDER phase, ie using the same hook that we have installed 
> TargetRespondListenerToResetQueryResultCache class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1271) Implement a DataNucleus NamingProvider for Isis apps in order to remove some boilerplate.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1271:
--
Fix Version/s: (was: 2.1.0)
   2.0.0-M4

> Implement a DataNucleus NamingProvider for Isis apps in order to remove some 
> boilerplate.
> -
>
> Key: ISIS-1271
> URL: https://issues.apache.org/jira/browse/ISIS-1271
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1294) Support Spring.Data like repositories with automatic implemenation of methods such as findByName or findByStartDateAndStatus

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1294:
--
Fix Version/s: (was: 2.1.0)
   2.0.0-M4

> Support Spring.Data like repositories with automatic implemenation of methods 
> such as findByName or findByStartDateAndStatus
> 
>
> Key: ISIS-1294
> URL: https://issues.apache.org/jira/browse/ISIS-1294
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.11.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-849) Extend DataNucleus integration to also support the JPA API.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-849:
-
Fix Version/s: (was: 2.1.0)
   2.0.0-M4

> Extend DataNucleus integration to also support the JPA API.
> ---
>
> Key: ISIS-849
> URL: https://issues.apache.org/jira/browse/ISIS-849
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Objectstore: JDO
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Timebox this; if it turns out to take too long, then punt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1488) Blobs and Clobs should be automatically ignored for auditing (also ISIS-1489)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1488:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Blobs and Clobs should be automatically ignored for auditing (also ISIS-1489)
> -
>
> Key: ISIS-1488
> URL: https://issues.apache.org/jira/browse/ISIS-1488
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> At the moment the work-around is to annotate with 
> @Property(notPersisted=true).
> See also ISIS-1489 re: the naming of this attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1562) Metamodel validator if forget to annotate @DomainObject(nature=ENTITY) with @PersistenceCapable

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1562:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Metamodel validator if forget to annotate @DomainObject(nature=ENTITY) with 
> @PersistenceCapable
> ---
>
> Key: ISIS-1562
> URL: https://issues.apache.org/jira/browse/ISIS-1562
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.13.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> Also, RepositoryService#persist(...) is a no-op if the domain object passed 
> in is not an entity; this should probably fail-fast.
> This was originally prompted by an obscure message being thrown in 
> Memento#updateFieldsAndResolveState(...), as the result of an entity being 
> treated as transient, because (a) the @PersistenceCapable annotation was 
> accidentally omitted, and (b) a call to RepositoryService#persist(...) just 
> did nothing.
> So, this ticket would be a fail-fast for that scenario.
> {code}
> private void updateFieldsAndResolveState(final ObjectAdapter 
> objectAdapter, final Data data) {
> 
> boolean dataIsTransient = data.getOid().isTransient();
> 
> if (!dataIsTransient) {
>...
> } else if (objectAdapter.isTransient() && dataIsTransient) {
>...
> 
> } else if (objectAdapter.isParentedCollection()) {
>...
> 
> } else {
>// THIS IS THE BRANCH THAT'S TRIGGERED IF @PersistenceCapable IS 
> ACCIDENTALLY OMITTED.
> final ObjectData od = (ObjectData) data;
> if (od.containsField()) {
> throw new IsisException("Resolve state (for " + objectAdapter 
> + ") inconsistent with fact that data exists for fields");
> }
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-790) Replace DN Blob/Clob Mappings with Blob/Clob converters

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-790:
-
Fix Version/s: (was: 2.1.0)
   2.0.0-M5

> Replace DN Blob/Clob Mappings with Blob/Clob converters
> ---
>
> Key: ISIS-790
> URL: https://issues.apache.org/jira/browse/ISIS-790
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Objectstore: JDO
>Affects Versions: objectstore-jdo-1.4.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> See ISIS-788 for background on the Blob/Clob converters.  
> ISIS-789 (upgrade to DN 4.0) is a prereq (meaning ISIS-568 for JDK is also).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2041) LogonFixture is deprecated, replace by FixtureScript

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2041:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M3

> LogonFixture is deprecated, replace by FixtureScript
> 
>
> Key: ISIS-2041
> URL: https://issues.apache.org/jira/browse/ISIS-2041
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1883) Validate that scalar reference parameters (not value types) have a choices or autoComplete.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1883:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Validate that scalar reference parameters (not value types) have a choices or 
> autoComplete.
> ---
>
> Key: ISIS-1883
> URL: https://issues.apache.org/jira/browse/ISIS-1883
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> We do this for collection parameters already (see 
> ActionChoicesForCollectionParameterFacetFactory) but not for scalar reference 
> parameter.
> NOTE: be careful to ignore scalar VALUE parameters (such as string or date); 
> obviously they *aren't* required to have a choices or autoComplete facet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1873) Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then assume veto and log a WARNing.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1873:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then 
> assume veto and log a WARNing.
> 
>
> Key: ISIS-1873
> URL: https://issues.apache.org/jira/browse/ISIS-1873
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> Currently the framework doesn't degrade gracefully.
> For example, had a coding error in a hideXxx() method.
> This resulted in the error page, rather than simply hide the relevant member.
> {code:java}
> org.eclipse.jetty.util.thread.QueuedThreadPool#runJob(QueuedThreadPool.java:672)
> org.eclipse.jetty.util.thread.QueuedThreadPool$2#run(QueuedThreadPool.java:590)
> java.lang.Thread#run(Thread.java:745)
> Caused by:
> java.lang.NullPointerException
> org.isisaddons.module.command.dom.CommandJdo#hideReplayStateFailureReason(CommandJdo.java:386)
> sun.reflect.NativeMethodAccessorImpl#invoke0(NativeMethodAccessorImpl.java:-2)
> sun.reflect.NativeMethodAccessorImpl#invoke(NativeMethodAccessorImpl.java:62)
> sun.reflect.DelegatingMethodAccessorImpl#invoke(DelegatingMethodAccessorImpl.java:43)
> java.lang.reflect.Method#invoke(Method.java:498)
> org.apache.isis.core.commons.lang.MethodExtensions#invoke(MethodExtensions.java:53)
> org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils#invoke(ObjectAdapter.java:38{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1864) Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar model properties after action invocation.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1864:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar 
> model properties after action invocation.
> ---
>
> Key: ISIS-1864
> URL: https://issues.apache.org/jira/browse/ISIS-1864
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> as per 
> [https://lists.apache.org/thread.html/9924509e3d3e0398e230467d80370e2f9d6dc94641aaa402db56c24e@%3Cusers.isis.apache.org%3E]
>  
> I think that the parent EntityModel shouldnt' really have this responsibility 
> of telling each of its child ScalarModel's to reset themselves. Rather, 
> perhaps it should simply instruct the ScalarModels that they are now dirty, 
> so that if and when the ScalarModels are next asked for their state (for 
> re-rendering) they then will query the underlying domain object ... but not 
> before.
>  
> Also, ScalarModel inherits from EntityModel, but I think that's not correct; 
> should factor out a common supertype for both.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1862) Delete CukeGlueBootstrappingAbstract, since of no practicable use.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1862:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M3

> Delete CukeGlueBootstrappingAbstract, since of no practicable use.
> --
>
> Key: ISIS-1862
> URL: https://issues.apache.org/jira/browse/ISIS-1862
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1684) Remove org.apache.isis.applib.fixtures.InstallableFixture, replace with FixtureScripts

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1684:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M3

> Remove org.apache.isis.applib.fixtures.InstallableFixture, replace with 
> FixtureScripts
> --
>
> Key: ISIS-1684
> URL: https://issues.apache.org/jira/browse/ISIS-1684
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1628) MixinFacet doesn't properly create domain events if abstract and invoke via the wrapper (ie during integ tests)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1628:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M5

> MixinFacet doesn't properly create domain events if abstract and invoke via 
> the wrapper (ie during integ tests)
> ---
>
> Key: ISIS-1628
> URL: https://issues.apache.org/jira/browse/ISIS-1628
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> fix, don't use getDeclaredFields, instead getFields (I think... to test)
> ~~~
> because of 
> https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/mixin/MixinFacetAbstract.java#L97
> getDeclaredFields() rather than getFields()
> to reproduce, eg HasDocumentAbstract_categoriseAbstract subclasses.
> 
> Also, necessary to override the method itself in the subclass, else
> https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/wrapper/src/main/java/org/apache/isis/core/wrapper/handlers/DomainObjectInvocationHandler.java#L297
> does not find the actual ObjectActionMixedIn (the mixin's ObjectActionDefault 
> does not match)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1678) Remove org.apache.isis.applib.clock.Clock, replace with org.apache.isis.applib.services.clock.ClockService

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1678:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M5

> Remove org.apache.isis.applib.clock.Clock, replace with 
> org.apache.isis.applib.services.clock.ClockService
> --
>
> Key: ISIS-1678
> URL: https://issues.apache.org/jira/browse/ISIS-1678
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1623) Enhance @MustSatisfy Specification API, pass in the current object as context

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1623:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Enhance @MustSatisfy Specification API, pass in the current object as context
> -
>
> Key: ISIS-1623
> URL: https://issues.apache.org/jira/browse/ISIS-1623
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1350) Refactor/simplify ExceptionRecognitionService to follow chain-of-responsibility pattern.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1350:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> Refactor/simplify ExceptionRecognitionService to follow 
> chain-of-responsibility pattern.
> 
>
> Key: ISIS-1350
> URL: https://issues.apache.org/jira/browse/ISIS-1350
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.11.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> To exploit the fact that we can inject List



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1469) MetaModel validator to detect duplicate schema/table names (read JDO/DN metadata at runtime)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1469:
--
Fix Version/s: (was: 2.0.0)
   1.18.0

> MetaModel validator to detect duplicate schema/table names (read JDO/DN 
> metadata at runtime)
> 
>
> Key: ISIS-1469
> URL: https://issues.apache.org/jira/browse/ISIS-1469
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Objectstore: JDO
>Affects Versions: 1.13.0
>Reporter: Timothy Simecsek
>Priority: Minor
> Fix For: 1.18.0
>
>
> Hi Dan,
> Today I came across a situation that might cause unexpected behavior, finding 
> the real cause was not very easy because the situation showed through various 
> errors, here some that I can remember:
> - Datanucleus enhancer failed with a message that there is duplicate 
> signature&name
> - The same error as above but this time shown once the Unit-Tests started
> - “Unique index or primary key violation” in a domain object which name 
> was a duplicate
> - Missing column exception
> The really sad thing is that we had already two domain objects with the same 
> name for some builds, the error messages started when I started changing one 
> of them.
> We are using autoCreateAll and are specifying table names for some classes as 
> we are working on oracle and facing the limitation of 30 characters:
> {code}
> @javax.jdo.annotations.PersistenceCapable(schema = 
> JdoConstants.A1FF_SCHEMA_NAME, table = "STEP_FIND_DSL_PORT_VULL")
> @javax.jdo.annotations.Inheritance(strategy = InheritanceStrategy.NEW_TABLE)
> {code}
> Therefore I introduced now a test checking for this. Might this be something 
> for Apache ISIS metamodel validation or is that more a thing for Datanucleus?
> {code}
> import java.util.HashSet;
> import java.util.Set;
> import javax.jdo.annotations.Inheritance;
> import javax.jdo.annotations.InheritanceStrategy;
> import javax.jdo.annotations.PersistenceCapable;
> import org.junit.Test;
> import org.reflections.Reflections;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> import a1.oss.FulfillmentAppDomainModule;
> import static org.assertj.core.api.Assertions.assertThat;
> public class DuplicateDefinitionsTest {
> private final static Logger LOG = 
> LoggerFactory.getLogger(DuplicateDefinitionsTest.class);
> @Test
> public void testTableNames() {
> HashSet tableNames = new HashSet<>();
> final Set> persistentClasses = new 
> Reflections(FulfillmentAppDomainModule.class.getPackage().getName())
> .getTypesAnnotatedWith(PersistenceCapable.class);
> for (Class aClass : persistentClasses) {
> // skip this class if it doesn't result in a separate table
> final Inheritance inheritance = (Inheritance) 
> aClass.getAnnotation(Inheritance.class);
> if (inheritance != null && 
> (InheritanceStrategy.SUBCLASS_TABLE.equals(inheritance.strategy())
> || 
> InheritanceStrategy.SUPERCLASS_TABLE.equals(inheritance.strategy(
> continue;
> String tableName = aClass.getSimpleName();
> // if persistent class has annotated tablename
> final PersistenceCapable annotation = (PersistenceCapable) 
> aClass.getAnnotation(PersistenceCapable.class);
> if (annotation != null && !annotation.table().isEmpty()) {
> tableName = annotation.table();
> }
> assertThat(tableNames.add(tableName)).describedAs("Table '" + 
> tableName + "' for class '" + aClass.getSimpleName() + "' is already used by 
> another class")
> .isEqualTo(true);
> }
> assertThat(tableNames.size()).as("No persistent tables 
> found!?").isGreaterThan(0);
> }
> }
> {code}
> Regards Timothy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1345) [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1345.
-

> [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)
> -
>
> Key: ISIS-1345
> URL: https://issues.apache.org/jira/browse/ISIS-1345
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.11.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> In similar vein to previous ticket, pretty sure these aren't needed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-894) Remove @NotPersistable annotation and corresponding facet

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-894:
-
Fix Version/s: (was: 2.0.0)
   2.0.0-M4

> Remove @NotPersistable annotation and corresponding facet
> -
>
> Key: ISIS-894
> URL: https://issues.apache.org/jira/browse/ISIS-894
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> This annotation is a no-op (tested in Wicket and Restful Objects) and should 
> be removed from the applib
> ... perhaps.  Looking again at the code, there's a check in 
> PersistenceSession#makePersistent() and throws exception if attempt to 
> explicitly persist.
> However, JDO might persist anyway due to persistence-by-reachability, so the 
> check would need to be added to the appropriate JDO lifecycle callback.
> As I think all the above is marginal benefit, think we should just remove in 
> 2.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1599) "Set" interface does not work as an action parameter's collection type

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1599:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M2

> "Set" interface does not work as an action parameter's collection  type
> ---
>
> Key: ISIS-1599
> URL: https://issues.apache.org/jira/browse/ISIS-1599
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.14.0
>Reporter: Tadas Giniotis
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> When using a Set as a parameter for an action -> it throws an 
> exception when using that action. The same works correctly when using 
> List.
> {quote}
> ...
>  java.lang.IllegalArgumentException
> argument type mismatch
> sun.reflect.NativeMethodAccessorImpl#invoke0(null:-2)
> sun.reflect.NativeMethodAccessorImpl#invoke(null:-1)
> sun.reflect.DelegatingMethodAccessorImpl#invoke(null:-1)
> java.lang.reflect.Method#invoke(null:-1)
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#invokeMethodElseFromCache(ActionInvocationFacetForDomainEventAbstract.java:408)
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2#execute(ActionInvocationFacetForDomainEventAbstract.java:262)
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2#execute(ActionInvocationFacetForDomainEventAbstract.java:223)
> org.apache.isis.applib.services.iactn.Interaction#executeInternal(Interaction.java:173)
> org.apache.isis.applib.services.iactn.Interaction#execute(Interaction.java:143)
>  
> ...
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1767) JEE 7+ Support

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1767:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M3

> JEE 7+ Support
> --
>
> Key: ISIS-1767
> URL: https://issues.apache.org/jira/browse/ISIS-1767
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> Collective tasks for Java EE 7+ support.
> Designated branch ...
> {code}dev/2.0.0/ISIS-1767-jee-7{code}
> +Tests+
> * *Server*: JEE 7+ implementation (or similar), launched with JDK8 (Version 
> 1.8.0_152); for deployment we use the HelloWorld artifact 1.15.1 with minor 
> modifications
> * *fat-war*: deploy all dependencies with single war (hsqldb in memory)
> * *skinny-war*: prepare container with shared libraries and shared domain 
> objects, deploy only a subset of domain classes with single war (hsqldb in 
> memory)
> * *restEasy*: check whether restEasy responds
> * managed connection pool (*con.pool*): use mysql db connection pool managed 
> by the JEE container and provided via JNDI
> * domain events (*dom.events*): test whether domain events are emitted and 
> handled using AxonFramework's SimpleEventBus
> * *swagger-ui*: test whether the static index.html from swagger-ui is served 
> and verify that a request for '//restful/swagger/private' 
> returns a JSON, that has the 'basePath' set to '//restful'
> * *redeploy*: test whether all previous tests succeed if we do a 
> deploy-undeploy-deploy process
> ||Server  ||fat-war ||skinny-war  
>||restEasy   ||con.pool   ||dom.events 
>   ||swagger-ui||redeploy||
> |Payara (full 4.1.2.173)  |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Payara (web 4.1.2.173)   |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (full 4.1.2)   |*OK*(1)  |*OK*(1)  
>|{color:green}*OK*{color}|todo
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (web 5.0.1 beta)|{color:green}*OK*{color}
> |{color:green}*OK*{color}|*OK*(5)|todo   
> |{color:green}*OK*{color}|{color:green}*OK*{color}|todo|
> |Glassfish (full 5.0) |{color:red}*FAILED*(2){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |Wildfly (full 11.0.0)|{color:red}*FAILED*(3){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |TomEE (plume 7.0.4)  |*OK*(4)  |todo 
>|{color:green}*OK*{color}|todo|todo
> |todo|todo|
> Notes:
> (1) 
> Guava version conflict: GF 4.2.1 has Guava-13, Isis has Guava-19; 
> WORKAROUND modify your glassfish installation ...
> * in glassfish/modules/ replace guava.jar with that which comes packaged with 
> Payara-4.1.2.173 (Guava-19)
> * you need to clear the OSGI cache: delete the folder 
> glassfish/domains/domainXXX/osgi-cache/felix
> (2)
> ON-HOLD waiting for GF 5.0.1 release!
> class-loading issues with Hibernate Validator, though library is included in 
> war ... java.lang.ClassNotFoundException: org.joda.time.ReadableInstant;
> using patch https://github.com/hibernate/hibernate-validator/pull/857/files 
> does not help: introduces new class-loading issues;
> (3)
> class-loading issues, though library is included in war ... 
> javax.persistence.PersistenceException: WFLYJPA0057: PersistenceProvider 
> 'org.apache.isis.core.webapp.jee.PersistenceUnitNoopProvider' not found;
> (4) 
> requires CXF to be disabled, see 
> https://stackoverflow.com/questions/41496204/tomee-7-0-2-how-to-disable-cxf-rs
>  
> throws exceptions on undeploy
> (5)
> JAX-RS API version clash
> requires 4.0.0.Beta1
> see https://issues.apache.org/jira/browse/ISIS-1779
> (6)   
> successfully tested against DN-5.1.5-SNAPSHOT (dedicated issue 
> https://issues.apache.org/jira/browse/ISIS-1754)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1345) [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1345.
---
Resolution: Won't Fix

Let's do this in the context of larger Spring-data refactorings etc.

> [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)
> -
>
> Key: ISIS-1345
> URL: https://issues.apache.org/jira/browse/ISIS-1345
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.11.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> In similar vein to previous ticket, pretty sure these aren't needed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1345) [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1345:
--
Description: 
In similar vein to previous ticket, pretty sure these aren't needed.

 

 

  was:In similar vein to previous ticket, pretty sure these aren't needed.

Summary: [WON'T FIX] Remove the 
PersistenceSession#executeWithTransaction(...)  (was: Remove the 
PersistenceSession#executeWithTransaction(...))

> [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)
> -
>
> Key: ISIS-1345
> URL: https://issues.apache.org/jira/browse/ISIS-1345
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.11.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> In similar vein to previous ticket, pretty sure these aren't needed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1345) [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1345:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-M2

> [WON'T FIX] Remove the PersistenceSession#executeWithTransaction(...)
> -
>
> Key: ISIS-1345
> URL: https://issues.apache.org/jira/browse/ISIS-1345
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.11.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> In similar vein to previous ticket, pretty sure these aren't needed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-888) Remove Wicket viewer action prompt page, instead just rely on action prompt.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-888:
-
Fix Version/s: (was: 2.0.0)
   2.0.0-M4

> Remove Wicket viewer action prompt page, instead just rely on action prompt.
> 
>
> Key: ISIS-888
> URL: https://issues.apache.org/jira/browse/ISIS-888
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> However... we still use the action prompt page for any bookmarked actions 
> that take args.  So would need to figure out what to do with those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-841) Remove mention of a "loading()" callback; this can never fire (for JDO objectstore).

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-841:
-
Fix Version/s: (was: 2.0.0)
   2.0.0-M4

> Remove mention of a "loading()" callback; this can never fire (for JDO 
> objectstore).
> 
>
> Key: ISIS-841
> URL: https://issues.apache.org/jira/browse/ISIS-841
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Objectstore: JDO
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Delete the LoadingCallbackFacet and update documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-399) Remove LogonFixture

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-399:
-
Fix Version/s: (was: 2.0.0)
   2.0.0-M4

> Remove LogonFixture
> ---
>
> Key: ISIS-399
> URL: https://issues.apache.org/jira/browse/ISIS-399
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.1.0
>Reporter: Christian Steinebach
>Priority: Minor
>  Labels: login
> Fix For: 2.0.0-M4
>
>
> was:  LogonFixture does not work in wicket viewer
> detail: Adding LogonAsSvenFixture to isis.properties does not log on Sven.
>  
> Rationale: can use sudoService instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-399) Remove LogonFixture

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-399:
-
Description: 
was:  LogonFixture does not work in wicket viewer

detail: Adding LogonAsSvenFixture to isis.properties does not log on Sven.

 

Rationale: can use sudoService instead.

  was:Adding LogonAsSvenFixture to isis.properties does not log on Sven. 

Summary: Remove LogonFixture  (was: LogonFixture does not work in 
wicket viewer)

> Remove LogonFixture
> ---
>
> Key: ISIS-399
> URL: https://issues.apache.org/jira/browse/ISIS-399
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.1.0
>Reporter: Christian Steinebach
>Priority: Minor
>  Labels: login
> Fix For: 2.0.0
>
>
> was:  LogonFixture does not work in wicket viewer
> detail: Adding LogonAsSvenFixture to isis.properties does not log on Sven.
>  
> Rationale: can use sudoService instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2013) Add support for H2 embedded database.

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734480#comment-16734480
 ] 

ASF subversion and git services commented on ISIS-2013:
---

Commit 97ebc49d80c77922066ee2ccc2bfdfb626a59640 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=97ebc49 ]

ISIS-2013: adds documentation


> Add support for H2 embedded database.
> -
>
> Key: ISIS-2013
> URL: https://issues.apache.org/jira/browse/ISIS-2013
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734481#comment-16734481
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 6ef1d8f15624aa0f5ef840c9a1e2f48d90eeff7f in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6ef1d8f ]

ISIS-1811: updates migration-notes for M2

with TODOs of the stuff to be documented.


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2013) Add support for H2 embedded database.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2013.
-

> Add support for H2 embedded database.
> -
>
> Key: ISIS-2013
> URL: https://issues.apache.org/jira/browse/ISIS-2013
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


AW: [VOTE] Apache Isis 1.17.0 RC3

2019-01-04 Thread Rade, Joerg / Kuehne + Nagel / HAM GI-DP
+1

Nice script!
All I had to do (Windows 7, picky firewall) was adding a certificate for curl, 
see [1].

Thanks -j
[1] 
https://stackoverflow.com/questions/24611640/curl-60-ssl-certificate-unable-to-get-local-issuer-certificate
-Ursprüngliche Nachricht-
Von: Dan Haywood [mailto:d...@haywood-associates.co.uk]
Gesendet: Mittwoch, 2. Januar 2019 11:15
An: dev
Betreff: [VOTE] Apache Isis 1.17.0 RC3

Folks,
I've cut a further release candidate RC3 for Apache Isis Core and the two
archetypes:

* Core 1.17.0
* HelloWorld Archetype 1.17.0
* SimpleApp Archetype 1.17.0

The source code artifacts have been uploaded to staging repositories on
repository.apache.org.
For each zip there is a corresponding signature file (append .asc to the
zip's url).

To verify the source code, you can use the following commands (in an empty
directory):

NEXUSREPONUM=1087
VERSION=1.17.0

curl http://www.apache.org/dist/isis/KEYS > /tmp/KEYS
gpg --import /tmp/KEYS

rm -rf isis-$VERSION*
rm -rf simpleapp-archetype-$VERSION*
rm -rf helloworld-archetype-$VERSION*

curl -O -L
https://raw.githubusercontent.com/apache/isis/06f947ad7a0968c34d8e6941a77e12aa0196cd17/scripts/verify-isis-release.sh

chmod +x ./verify-isis-release.sh
./verify-isis-release.sh $NEXUSREPONUM $VERSION


Assuming this completes successfully, you can then test the two
applications generated from the `simpleapp` and `helloworld` archetypes:

pushd test-simpleapp/myapp
mvn -pl webapp jetty:run
popd

and

pushd test-helloworld/myapp
mvn jetty:run
popd


For more details, see
https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releases

Please verify the release and cast your vote.  The vote will be open for a
minimum of 72 hours.

[ ] +1
[ ]  0
[ ] -1

Kühne + Nagel (AG & Co.) KG
Rechtsform: Kommanditgesellschaft, Bremen HRA 21928, USt-IdNr.: DE 812773878.
Geschäftsleitung Kühne + Nagel (AG & Co.) KG: Holger Ketz (Vors. ), Tom Ban, 
Martin Brinkmann, Matthias Knicky, Nicholas Minde, Johannes Trimborn, Lars 
Wedel, Matthias Weiner.
Persönlich haftende Gesellschafterin: Kühne & Nagel A.G., Rechtsform: 
Aktiengesellschaft nach luxemburgischem Recht, HR-Nr.: B 18745, 
Geschäftsführendes Verwaltungsratsmitglied: Karl Gernandt.
Geschäftsleitung Region Europa: Dr. Hansjörg Rodi (Vors.), Mart Ambur, Tom Ban, 
Dominic Edmonds, Thierry Held, Uwe Hött, Richard Huhn, Holger Ketz, Jan-Hendrik 
Köstergarten, Heiko Schuhmacher.

Wir arbeiten ausschließlich auf Grundlage der Allgemeinen Deutschen 
Spediteurbedingungen 2017 (ADSp 2017). Hinweis: Die ADSp 2017 weichen in Ziffer 
23 hinsichtlich des Haftungshöchstbetrages für Güterschäden (§ 431 HGB) vom 
Gesetz ab, indem sie die Haftung bei multimodalen Transporten unter Einschluss 
einer Seebeförderung und bei unbekanntem Schadenort auf 2 SZR/kg und im Übrigen 
die Regelhaftung von 8,33 SZR/kg zusätzlich auf 1,25 Millionen Euro je 
Schadenfall sowie 2,5 Millionen Euro je Schadenereignis, mindestens aber 2 
SZR/kg, beschränken. Die ADSp sind auf unserer Webseite als Download 
erhältlich. Auf Anfrage senden wir Ihnen diese auch gerne zu.


[jira] [Resolved] (ISIS-2013) Add support for H2 embedded database.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2013.
---
Resolution: Fixed

> Add support for H2 embedded database.
> -
>
> Key: ISIS-2013
> URL: https://issues.apache.org/jira/browse/ISIS-2013
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1899) Release tasks for 1.17.0

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734292#comment-16734292
 ] 

ASF subversion and git services commented on ISIS-1899:
---

Commit 18fce1d83d495fa1560a1cf083a2294ed4efff68 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=18fce1d ]

ISIS-1899: updates STATUS, fixes out-of-date URLs


> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1899) Release tasks for 1.17.0

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734294#comment-16734294
 ] 

ASF subversion and git services commented on ISIS-1899:
---

Commit 74d358651e7dc84761adf61fe797184127fb99f3 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=74d3586 ]

ISIS-1899: fixes menubar - downloadMetaModelXml mentioned twice.


> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2013) Add support for H2 embedded database.

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734293#comment-16734293
 ] 

ASF subversion and git services commented on ISIS-2013:
---

Commit 9cb3fc15b62b5ee44a02101a0184f771195f4ddc in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cb3fc1 ]

ISIS-2013: converts example apps to use h2 instead of hsqldb


> Add support for H2 embedded database.
> -
>
> Key: ISIS-2013
> URL: https://issues.apache.org/jira/browse/ISIS-2013
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1899) Release tasks for 1.17.0

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734291#comment-16734291
 ] 

ASF subversion and git services commented on ISIS-1899:
---

Commit b572e40fc5140a91321bfca5e3d546b02dcb6e74 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b572e40 ]

ISIS-1899: updates STATUS, was missing details of 2.0.0-M1 release


> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1899) Release tasks for 1.17.0

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734289#comment-16734289
 ] 

ASF subversion and git services commented on ISIS-1899:
---

Commit 18fce1d83d495fa1560a1cf083a2294ed4efff68 in isis's branch 
refs/heads/release-1.17.0-RC3 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=18fce1d ]

ISIS-1899: updates STATUS, fixes out-of-date URLs


> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1899) Release tasks for 1.17.0

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734288#comment-16734288
 ] 

ASF subversion and git services commented on ISIS-1899:
---

Commit b572e40fc5140a91321bfca5e3d546b02dcb6e74 in isis's branch 
refs/heads/release-1.17.0-RC3 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b572e40 ]

ISIS-1899: updates STATUS, was missing details of 2.0.0-M1 release


> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734287#comment-16734287
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit b6daaac0b0c822aaa890ea8ea92f7db778258576 in isis's branch 
refs/heads/release-1.17.0-RC3 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b6daaac ]

ISIS-1811: updates docs - minor reformatting


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1823) Config property for disabling footer entirly

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734162#comment-16734162
 ] 

ASF subversion and git services commented on ISIS-1823:
---

Commit c657df80bb4d1ab074a97fa6caa511238c4cf632 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c657df8 ]

ISIS-1823: updates docs for hiding/disabling the footer.


> Config property for disabling footer entirly
> 
>
> Key: ISIS-1823
> URL: https://issues.apache.org/jira/browse/ISIS-1823
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.16.0
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Provide a config property in isis.properties that allows disabling of the 
> footer. This is related to ISIS-1025 but not the same.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2010) Define a formal API for programmatic interactions between modules

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734171#comment-16734171
 ] 

ASF subversion and git services commented on ISIS-2010:
---

Commit 6698f9dbf42148a8289b1c232786f3e4cf0225c4 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6698f9d ]

ISIS-2010: work in progress going through references to DOMAIN

Have added DOMAIN_API, now need to look at existing uses of DOMAIN and see how 
they should be handled.


> Define a formal API for programmatic interactions between modules
> -
>
> Key: ISIS-2010
> URL: https://issues.apache.org/jira/browse/ISIS-2010
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> One idea:
> - NatureOfService.DOMAIN_API vs NatureOfService.DOMAIN (latter interpreted as 
> IMPL)
> For the API, can wrap (and perhaps are auto-wrapped)
> For the IMPL, are not wrapped, and don't introspect the methods to create 
> actions.
> It's not clear to me which of the Isis services should be DOMAIN_API vs 
> DOMAIN.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1955) Allow for ErrorReportingService Tickets to render arbitrary HTML

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734164#comment-16734164
 ] 

ASF subversion and git services commented on ISIS-1955:
---

Commit bc216ba5f41abfcb1128009298ada678e26bc23d in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bc216ba ]

ISIS-1955: updates docs for Ticket, now an interface


> Allow for ErrorReportingService Tickets to render arbitrary HTML
> 
>
> Key: ISIS-1955
> URL: https://issues.apache.org/jira/browse/ISIS-1955
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> 1. Refactor `org.apache.isis.applib.services.error.Ticket` into an interface.
> 2. Add a method `getMarkup()` that provides the html to be rendered.
> 3. Implement as SimpleTicket providing legacy rendering behavior, but 
> allowing to override the actual html formatting.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2010) Define a formal API for programmatic interactions between modules

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2010:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> Define a formal API for programmatic interactions between modules
> -
>
> Key: ISIS-2010
> URL: https://issues.apache.org/jira/browse/ISIS-2010
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> One idea:
> - NatureOfService.DOMAIN_API vs NatureOfService.DOMAIN (latter interpreted as 
> IMPL)
> For the API, can wrap (and perhaps are auto-wrapped)
> For the IMPL, are not wrapped, and don't introspect the methods to create 
> actions.
> It's not clear to me which of the Isis services should be DOMAIN_API vs 
> DOMAIN.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1911) TranslationServicePo: new config option to disable the service

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734163#comment-16734163
 ] 

ASF subversion and git services commented on ISIS-1911:
---

Commit 1a1810f928c6f410d90ce0cbbf9b71690be7a039 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a1810f ]

ISIS-1911: updates docs on disabling translation service po


> TranslationServicePo: new config option to disable the service
> --
>
> Key: ISIS-1911
> URL: https://issues.apache.org/jira/browse/ISIS-1911
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Always stumbling over integration test issues stating, that there is no 
> Application on the current thread, triggered by the PoReader when locating 
> translation resources.
> So adding an option for disabling this service should not harm.
> Usage: 
> {noformat}
> isis.services.translation.po.mode=disable|disabled{noformat}
> Default behavior is not affected by this new option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734168#comment-16734168
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit 1bde83e684959b9405ca3bddb4af7be285818475 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1bde83e ]

ISIS-1978: moves demo test from helloworld to isis-core-webserver

chose isis-core-webserver because it can "see" the rest of the framework, so a 
convenient place to write such "regression" tests.


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734166#comment-16734166
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit b431915df8088517e4ccff21281e7aeb5d121bcd in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b431915 ]

ISIS-1978: updates dependencies for junit and surefire to fix the issue.


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2070) config properties for "where am I" should have "isis.viewer.wicket" as a prefix

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734167#comment-16734167
 ] 

ASF subversion and git services commented on ISIS-2070:
---

Commit 3051878ed1ad05c68aa55b31e2d153bda2b5aec2 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3051878 ]

ISIS-2070: renames 'whereAmI' config properties, with 'isis.viewer.wicket.' 
prefix


> config properties for "where am I" should have "isis.viewer.wicket" as a 
> prefix
> ---
>
> Key: ISIS-2070
> URL: https://issues.apache.org/jira/browse/ISIS-2070
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1974) Reduce time to bootstrap

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734170#comment-16734170
 ] 

ASF subversion and git services commented on ISIS-1974:
---

Commit 13f34641e6fb48ff98327d38fb02eab62a5d4ad2 in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=13f3464 ]

Revert "ISIS-1974: reverts skipping of introspection of actions for domain 
services"

This reverts commit 5e592ac4920af1557bdae35bf67001aa68948db7.


> Reduce time to bootstrap
> 
>
> Key: ISIS-1974
> URL: https://issues.apache.org/jira/browse/ISIS-1974
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734165#comment-16734165
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 9a9fb6646fd9be6bb452c0033519102ad16e7fbc in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9a9fb66 ]

ISIS-1811: updates migration-notes.adoc with TODOs for 2.0.0-M1.


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734169#comment-16734169
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit a1376d7017377f4a06fc9de7c16574d544ef542d in isis's branch 
refs/heads/ISIS-2010 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a1376d7 ]

ISIS-1978: fixes dependency convergence issue


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734156#comment-16734156
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit 1bde83e684959b9405ca3bddb4af7be285818475 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1bde83e ]

ISIS-1978: moves demo test from helloworld to isis-core-webserver

chose isis-core-webserver because it can "see" the rest of the framework, so a 
convenient place to write such "regression" tests.


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2070) config properties for "where am I" should have "isis.viewer.wicket" as a prefix

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734155#comment-16734155
 ] 

ASF subversion and git services commented on ISIS-2070:
---

Commit 3051878ed1ad05c68aa55b31e2d153bda2b5aec2 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3051878 ]

ISIS-2070: renames 'whereAmI' config properties, with 'isis.viewer.wicket.' 
prefix


> config properties for "where am I" should have "isis.viewer.wicket" as a 
> prefix
> ---
>
> Key: ISIS-2070
> URL: https://issues.apache.org/jira/browse/ISIS-2070
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734157#comment-16734157
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit a1376d7017377f4a06fc9de7c16574d544ef542d in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a1376d7 ]

ISIS-1978: fixes dependency convergence issue


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2070) config properties for "where am I" should have "isis.viewer.wicket" as a prefix

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2070.
-

> config properties for "where am I" should have "isis.viewer.wicket" as a 
> prefix
> ---
>
> Key: ISIS-2070
> URL: https://issues.apache.org/jira/browse/ISIS-2070
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1015) [WON'T FIX] DataNucleus doesn't support LocalDateTime

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1015:
--
Summary: [WON'T FIX] DataNucleus doesn't support LocalDateTime  (was: 
DataNucleus doesn't support LocalDateTime)

> [WON'T FIX] DataNucleus doesn't support LocalDateTime
> -
>
> Key: ISIS-1015
> URL: https://issues.apache.org/jira/browse/ISIS-1015
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core: Objectstore: JDO
>Affects Versions: core-1.8.0
>Reporter: Martin Grigorov
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> While debugging ISIS-1012 I've found that Kitchensink app doesn't behave 
> correctly for Joda-Time's LocalDateTime: 
> org.apache.isis.viewer.wicket.ui.components.scalars.jodatime.JodaLocalDateTimePanel
>  doesn't show the scalar value.
> Partially the problem has been solved by moving 
> {code}
> @javax.jdo.annotations.Persistent(defaultFetchGroup="true")
> {code}
> next to
> {code}
> @Column(allowsNull = "true")
> {code}
> applied on the property getters.
> But it appeared that the actual problem is that DataNucleus 3.x and 4.x do 
> not support Joda-Time's LocalDateTime. There is support for Joda-Time's 
> LocalDate and JSR310/ThreeTen/JDK8 LocalDateTime though.
> This ticket is to document the bug. Since there is no urgent need for 
> supporting this type its priority is set to "Minor".
> Thanks to Dan for the directions!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2069) Remove support for guava event bus implementation, because ...

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2069:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> Remove support for guava event bus implementation, because ...
> --
>
> Key: ISIS-2069
> URL: https://issues.apache.org/jira/browse/ISIS-2069
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> ... because guava event bus doesn't allow cascading events, ie one event to 
> trigger another event.  Instead, there seems to be some sort of batching.
> In contrast, axon works the way one would hope, so this should be the default.
> Also, in v2, we will probably introduce implementations for CDI and for 
> Spring (on their respective platforms), so we don't really need so many 
> implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1015) [WON'T FIX] DataNucleus doesn't support LocalDateTime

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1015.
-
Resolution: Won't Fix

Some commits have been made on this, but I'm gonna mark it as "WON'T FIX" ... 
it can't be a major issue because this ticket is 3 years old...

> [WON'T FIX] DataNucleus doesn't support LocalDateTime
> -
>
> Key: ISIS-1015
> URL: https://issues.apache.org/jira/browse/ISIS-1015
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core: Objectstore: JDO
>Affects Versions: core-1.8.0
>Reporter: Martin Grigorov
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> While debugging ISIS-1012 I've found that Kitchensink app doesn't behave 
> correctly for Joda-Time's LocalDateTime: 
> org.apache.isis.viewer.wicket.ui.components.scalars.jodatime.JodaLocalDateTimePanel
>  doesn't show the scalar value.
> Partially the problem has been solved by moving 
> {code}
> @javax.jdo.annotations.Persistent(defaultFetchGroup="true")
> {code}
> next to
> {code}
> @Column(allowsNull = "true")
> {code}
> applied on the property getters.
> But it appeared that the actual problem is that DataNucleus 3.x and 4.x do 
> not support Joda-Time's LocalDateTime. There is support for Joda-Time's 
> LocalDate and JSR310/ThreeTen/JDK8 LocalDateTime though.
> This ticket is to document the bug. Since there is no urgent need for 
> supporting this type its priority is set to "Minor".
> Thanks to Dan for the directions!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734110#comment-16734110
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit b6daaac0b0c822aaa890ea8ea92f7db778258576 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b6daaac ]

ISIS-1811: updates docs - minor reformatting


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1911) TranslationServicePo: new config option to disable the service

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734115#comment-16734115
 ] 

ASF subversion and git services commented on ISIS-1911:
---

Commit 1a1810f928c6f410d90ce0cbbf9b71690be7a039 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a1810f ]

ISIS-1911: updates docs on disabling translation service po


> TranslationServicePo: new config option to disable the service
> --
>
> Key: ISIS-1911
> URL: https://issues.apache.org/jira/browse/ISIS-1911
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Always stumbling over integration test issues stating, that there is no 
> Application on the current thread, triggered by the PoReader when locating 
> translation resources.
> So adding an option for disabling this service should not harm.
> Usage: 
> {noformat}
> isis.services.translation.po.mode=disable|disabled{noformat}
> Default behavior is not affected by this new option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-2070) config properties for "where am I" should have "isis.viewer.wicket" as a prefix

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2070.
---
Resolution: Fixed

> config properties for "where am I" should have "isis.viewer.wicket" as a 
> prefix
> ---
>
> Key: ISIS-2070
> URL: https://issues.apache.org/jira/browse/ISIS-2070
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ISIS-2070) config properties for "where am I" should have "isis.viewer.wicket" as a prefix

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-2070:
-

Assignee: Dan Haywood

> config properties for "where am I" should have "isis.viewer.wicket" as a 
> prefix
> ---
>
> Key: ISIS-2070
> URL: https://issues.apache.org/jira/browse/ISIS-2070
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2069) Remove support for guava event bus implementation, because ...

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2069:
--
Description: 
... because guava event bus doesn't allow cascading events, ie one event to 
trigger another event.  Instead, there seems to be some sort of batching.

In contrast, axon works the way one would hope, so this should be the default.

Also, in v2, we will probably introduce implementations for CDI and for Spring 
(on their respective platforms), so we don't really need so many 
implementations.
Summary: Remove support for guava event bus implementation, because ... 
 (was: Remove support for guava event bus implementation.)

> Remove support for guava event bus implementation, because ...
> --
>
> Key: ISIS-2069
> URL: https://issues.apache.org/jira/browse/ISIS-2069
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> ... because guava event bus doesn't allow cascading events, ie one event to 
> trigger another event.  Instead, there seems to be some sort of batching.
> In contrast, axon works the way one would hope, so this should be the default.
> Also, in v2, we will probably introduce implementations for CDI and for 
> Spring (on their respective platforms), so we don't really need so many 
> implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2064) Allow explicit vs implicit metamodel discovery to be specified with @DomainObject

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2064:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> Allow explicit vs implicit metamodel discovery to be specified with 
> @DomainObject
> -
>
> Key: ISIS-2064
> URL: https://issues.apache.org/jira/browse/ISIS-2064
> Project: Isis
>  Issue Type: New Feature
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> as per dev mailing list
> [https://lists.apache.org/thread.html/9d766b4e43079f81d1a72c9a78be9f78f65433cb92288394b7f195df@%3Cusers.isis.apache.org%3E]
>  
> We currently have the configuration property 
> "isis.reflector.explicitAnnotations.action" which if specified requires 
> @Action to be added as an annotation for all public methods that don't 
> represent properties/collections or supporting methods.  If this is enabled 
> then there's generally no need to annotate public methods that aren't meant 
> to be in the metamodel with the @Programmatic annotation.
>   
>  Andi and I have just been discussing this (off-list) and wondering if we 
> should extend this in v2.  Our idea is maybe to allow this to be specified at 
> the class level, and to also have three levels rather than two:
>   
>  - explicit : all properties, collections and actions must be annotated
>  - actions : actions must be annotated, but properties and collections need 
> not.  This is the behavior if the above configuration property is specified.
>  - implicit : no annotations are required.  This is the current default
>   
>  So, we were thinking to add a value to @DomainObject, eg
>   
>  @DomainObject(metamodelDiscoveryStrategy = EXPLICIT | ACTIONS | IMPLICIT | 
> AS_CONFIGURED)
>   
>  where "AS_CONFIGURED" would read a new configuration property that would 
> take these three values (replacing the existing 
> "isis.reflector.explicitAnnotations.action".
>   
>  Two questions:
>   
>  1. is the idea of a new level to explicitly annotate everything (properties 
> and collections as well as actions) useful ?
>  2. is there a need to configure this on a class-by-class basis, or is a 
> global configuration property sufficient?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2016) Slow initial loading - webjars for bootswatch themes?

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2016:
--
Fix Version/s: (was: 2.0.0-M2)
   2.3.0

> Slow initial loading - webjars for bootswatch themes?
> -
>
> Key: ISIS-2016
> URL: https://issues.apache.org/jira/browse/ISIS-2016
> Project: Isis
>  Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.3.0
>
>
> I thinik we used to use webjars as a cache for bootswatch themes; have we 
> removed them accidentally?  
> https://www.webjars.org/documentation#wicket
> and commented out stuff in web.xml
> {code:xml}
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1978.
-
Resolution: Fixed

> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734120#comment-16734120
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit b431915df8088517e4ccff21281e7aeb5d121bcd in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b431915 ]

ISIS-1978: updates dependencies for junit and surefire to fix the issue.


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734112#comment-16734112
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 95bd70d92ea59708952c14fc13de5be5fc712d85 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=95bd70d ]

ISIS-1811: adds TODOs in .docs, relating to the changes of web.xml (now 
programmatic)


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1955) Allow for ErrorReportingService Tickets to render arbitrary HTML

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734116#comment-16734116
 ] 

ASF subversion and git services commented on ISIS-1955:
---

Commit bc216ba5f41abfcb1128009298ada678e26bc23d in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bc216ba ]

ISIS-1955: updates docs for Ticket, now an interface


> Allow for ErrorReportingService Tickets to render arbitrary HTML
> 
>
> Key: ISIS-1955
> URL: https://issues.apache.org/jira/browse/ISIS-1955
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> 1. Refactor `org.apache.isis.applib.services.error.Ticket` into an interface.
> 2. Add a method `getMarkup()` that provides the html to be rendered.
> 3. Implement as SimpleTicket providing legacy rendering behavior, but 
> allowing to override the actual html formatting.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734111#comment-16734111
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit ebdbfe7ecb3f35f314e242744279612e80da7367 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ebdbfe7 ]

ISIS-1811: updates docs for 2.0.0-M1  (or adds TODOs)


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734118#comment-16734118
 ] 

ASF subversion and git services commented on ISIS-1978:
---

Commit a85dcb927dc9893f4d648fcaa7798b61456fd6f5 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a85dcb9 ]

ISIS-1978: updates dependencies for junit and surefire to fix the issue.


> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734113#comment-16734113
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 8f956e65fe438455edf1919dbe85489c4029ca25 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8f956e6 ]

ISIS-1811: updates docs, minor reformatting of "where am i" documentation


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ISIS-1978) Integration tests are not executed in module `module-simple`

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-1978:
-

Assignee: Dan Haywood

> Integration tests are not executed in module `module-simple`
> 
>
> Key: ISIS-1978
> URL: https://issues.apache.org/jira/browse/ISIS-1978
> Project: Isis
>  Issue Type: Bug
>  Components: Archetype: SimpleApp
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> As reported by Gabriel Terwesten  [1]
> This is only true for projects generated from the 2.0.0-M1 archetype. The 
> integration tests in module `application` are executed.
> To reproduce generate a project:
> mvn archetype:generate  \
> -D archetypeGroupId=org.apache.isis.archetype \
> -D archetypeArtifactId=simpleapp-archetype \
> -D archetypeVersion=2.0.0-M1 \
> -D groupId=com.mycompany \
> -D artifactId=isis-2 \
> -D version=1.0-SNAPSHOT \
> -B
> Then execute:
> - mvn clean install
> - mvn -pl module-simple verify
> The test output for integration tests is empty.
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734117#comment-16734117
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 9a9fb6646fd9be6bb452c0033519102ad16e7fbc in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9a9fb66 ]

ISIS-1811: updates migration-notes.adoc with TODOs for 2.0.0-M1.


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> see [Migration 
> Notes|https://github.com/apache/isis/blob/v2/migration-notes.adoc]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1823) Config property for disabling footer entirly

2019-01-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734114#comment-16734114
 ] 

ASF subversion and git services commented on ISIS-1823:
---

Commit c657df80bb4d1ab074a97fa6caa511238c4cf632 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c657df8 ]

ISIS-1823: updates docs for hiding/disabling the footer.


> Config property for disabling footer entirly
> 
>
> Key: ISIS-1823
> URL: https://issues.apache.org/jira/browse/ISIS-1823
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.16.0
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> Provide a config property in isis.properties that allows disabling of the 
> footer. This is related to ISIS-1025 but not the same.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2015) Text (multiline?) can be changed on non-editable field, without using edit.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2015:
--
 Priority: Trivial  (was: Major)
Fix Version/s: (was: 1.17.0)
   2.4.0

> Text (multiline?) can be changed on non-editable field, without using edit.
> ---
>
> Key: ISIS-2015
> URL: https://issues.apache.org/jira/browse/ISIS-2015
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 2.4.0
>
>
> If you select with your mouse the text inside the note field (a disabled 
> multiline text field) from right to left to the first character, the text 
> will be selected and you can replace it with another text without entering 
> 'edit mode' on the note field. this new text will not be saved however but 
> still gives this impression to the uninformed user. This happens with Chrome.
> With Firefox trying to select the text results in pasting a copy of the 
> current url into the note field without edit mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ISIS-2015) Text (multiline?) can be changed on non-editable field, without using edit.

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-2015:
-

 Assignee: Dan Haywood
Fix Version/s: (was: 2.0.0-M2)
   1.17.0
   Issue Type: Bug  (was: Improvement)

> Text (multiline?) can be changed on non-editable field, without using edit.
> ---
>
> Key: ISIS-2015
> URL: https://issues.apache.org/jira/browse/ISIS-2015
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> If you select with your mouse the text inside the note field (a disabled 
> multiline text field) from right to left to the first character, the text 
> will be selected and you can replace it with another text without entering 
> 'edit mode' on the note field. this new text will not be saved however but 
> still gives this impression to the uninformed user. This happens with Chrome.
> With Firefox trying to select the text results in pasting a copy of the 
> current url into the note field without edit mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2011) Merge up AppManifest2 into AppManifest, untangle those builders

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2011:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> Merge up AppManifest2 into AppManifest, untangle those builders
> ---
>
> Key: ISIS-2011
> URL: https://issues.apache.org/jira/browse/ISIS-2011
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> perhaps there's a deeper composite pattern (we already have 
> ModuleOrSomethingAbstract ... I think that AppManifest might be the root of a 
> hierarchy with a common supertype).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1919) Collective UI Improvements

2019-01-04 Thread Dan Haywood (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734096#comment-16734096
 ] 

Dan Haywood commented on ISIS-1919:
---

Can I suggest that these are done in M3 ?

> Collective UI Improvements
> --
>
> Key: ISIS-1919
> URL: https://issues.apache.org/jira/browse/ISIS-1919
> Project: Isis
>  Issue Type: Task
>  Components: Core: Viewer: Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> Main task to track various sub-tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2067) Remove support for o.a.i.WebServer and also jetty-console in the archetypes

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2067.
-

> Remove support for o.a.i.WebServer and also jetty-console in the archetypes
> ---
>
> Key: ISIS-2067
> URL: https://issues.apache.org/jira/browse/ISIS-2067
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Because if we're moving to Spring etc then they will have their own way of 
> doing bootstrapping.
> In the meantime, can use mvn jetty:run



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1489) Rename @Property(notPersisted=...) to @Property(notAudited=...)

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1489:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> Rename @Property(notPersisted=...) to @Property(notAudited=...)
> ---
>
> Key: ISIS-1489
> URL: https://issues.apache.org/jira/browse/ISIS-1489
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> In which case, the attribute should be deprecated, and a new 
> @Property(notAudited=true) be introduced to replace it.
> It's used by:
> - ChangedObjectServiceInternal to determine if a property has changed; 
> marking it as notPersisted means this functionality is skipped.
> - Memento (which you almost certainly don't use, I think is only used in 
> anger by the Wicket viewer).
> It used to be used by the object persistor for persistence-by-reachability 
> (if notPersisted then don't follow the graph), but I *think* that 
> responsibility is now entirely that of JDO/DN.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1971) JAXB view model: setting view's properties via PostConstruct method not honored

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1971:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3
  Description: 
{code:java}
// CALLER

@DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
@DomainObjectLayout(named="Scalar Demo")
public class ScalarMenu {

@Inject private FactoryService factoryService;

@Action
@ActionLayout(cssClassFa="fa-font")
public TextDemo text(){
val demo = factoryService.instantiate(TextDemo.class);
return demo;
}
}

// VIEW MODEL

@XmlRootElement(name = "Demo")
@XmlType
@XmlAccessorType(XmlAccessType.FIELD)
@DomainObject(nature=Nature.VIEW_MODEL)
@Log
public class TextDemo {

@PostConstruct
public void initDefaults() {

log.info("TextDemo::initDefaults");

string = "a string (click me)";
}

@Property(editing=Editing.ENABLED) 
@XmlElement @Getter @Setter private String string; // string shows up on UI 
as empty, even though initDefaults was called
}
{code}


  was:

{code:java}
// CALLER

@DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
@DomainObjectLayout(named="Scalar Demo")
public class ScalarMenu {

@Inject private FactoryService factoryService;

@Action
@ActionLayout(cssClassFa="fa-font")
public TextDemo text(){
val demo = factoryService.instantiate(TextDemo.class);
return demo;
}
}

// VIEW MODEL

@XmlRootElement(name = "Demo")
@XmlType
@XmlAccessorType(XmlAccessType.FIELD)
@DomainObject(nature=Nature.VIEW_MODEL)
@Log
public class TextDemo {

@PostConstruct
public void initDefaults() {

log.info("TextDemo::initDefaults");

string = "a string (click me)";
}

@Property(editing=Editing.ENABLED) 
@XmlElement @Getter @Setter private String string; // string shows up on UI 
as empty, even though initDefaults was called
}
{code}



> JAXB view model: setting view's properties via PostConstruct method not 
> honored
> ---
>
> Key: ISIS-1971
> URL: https://issues.apache.org/jira/browse/ISIS-1971
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> {code:java}
> // CALLER
> @DomainService(nature=NatureOfService.VIEW_MENU_ONLY)
> @DomainObjectLayout(named="Scalar Demo")
> public class ScalarMenu {
> 
> @Inject private FactoryService factoryService;
> @Action
> @ActionLayout(cssClassFa="fa-font")
> public TextDemo text(){
> val demo = factoryService.instantiate(TextDemo.class);
> return demo;
> }
> }
> // VIEW MODEL
> @XmlRootElement(name = "Demo")
> @XmlType
> @XmlAccessorType(XmlAccessType.FIELD)
> @DomainObject(nature=Nature.VIEW_MODEL)
> @Log
> public class TextDemo {
> @PostConstruct
> public void initDefaults() {
> 
> log.info("TextDemo::initDefaults");
> 
> string = "a string (click me)";
> }
> 
> @Property(editing=Editing.ENABLED) 
> @XmlElement @Getter @Setter private String string; // string shows up on 
> UI as empty, even though initDefaults was called
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1968) @Title on a field can result in "Untitled Simple Object" - because DN hasn't always retrieved object

2019-01-04 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1968:
--
Fix Version/s: (was: 2.0.0-M2)
   2.0.0-M3

> @Title on a field can result in "Untitled Simple Object" - because DN hasn't 
> always retrieved object
> 
>
> Key: ISIS-1968
> URL: https://issues.apache.org/jira/browse/ISIS-1968
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 2.0.0-M1
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> To reproduce, use the simpleapp and remove SimpleObject#title and instead add:
>  
> {code:java}
> @Title(prepend="Object: ")
> private String name;
> {code}
> When edit the name, will see "Untitled Simple Object" on re-rendering



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >