[jira] [Updated] (ISIS-2427) Create a Docker Image showcasing the Vaadin Demo.
[
https://issues.apache.org/jira/browse/ISIS-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-2427:
-
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Create a Docker Image showcasing the Vaadin Demo.
> -
>
> Key: ISIS-2427
> URL: https://issues.apache.org/jira/browse/ISIS-2427
> Project: Isis
> Issue Type: Improvement
> Components: Isis Examples
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> also rename {color:#1d1c1d}demo-springboot -> demo-wicket{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2431) SecMan support for ObjectType (canonical object names)
[ https://issues.apache.org/jira/browse/ISIS-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2431: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > SecMan support for ObjectType (canonical object names) > -- > > Key: ISIS-2431 > URL: https://issues.apache.org/jira/browse/ISIS-2431 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > So called Application Features are currently referenced by fully qualified > class names, which breaks persistent authorization data as soon as > Application Features are refactored to new class names. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2377) Regression: download Layout.xml 'normalized' seems to behave like 'full'
[ https://issues.apache.org/jira/browse/ISIS-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2377: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Regression: download Layout.xml 'normalized' seems to behave like 'full' > > > Key: ISIS-2377 > URL: https://issues.apache.org/jira/browse/ISIS-2377 > Project: Isis > Issue Type: Bug > Components: Isis Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > And we produce invalid XML when outputting ... attribute=NOT_SPECIFIED > > Ultimately would be nice to have some tests and more docs on this topic as > well. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-2368) Add lightbox support (=enlarge image on click) for Antora template
[
https://issues.apache.org/jira/browse/ISIS-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber reassigned ISIS-2368:
Assignee: Andi Huber
> Add lightbox support (=enlarge image on click) for Antora template
> ---
>
> Key: ISIS-2368
> URL: https://issues.apache.org/jira/browse/ISIS-2368
> Project: Isis
> Issue Type: Improvement
> Components: Isis Docs & Website
>Reporter: Alexander Schwartz
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> The Antora based documentation allows a user to click on an image. The code
> for this looks like this:
>
> {{image::value-types/markup.png[width="400px",link="\{imagesdir}/value-types/markup.png"]}}
>
> An alternative would be to add "lightbox" support (=enlarge image on click)
> for the Antora template. This would reduce the markup to
>
> {{image::value-types/markup.png[width="400px"]}}
>
> An example can be found here:
> [https://intellij-asciidoc-plugin.ahus1.de/docs/users-guide/quick-start.html]
> I've also started a discussion to make it part of the standard Antora UI:
> [https://gitlab.com/antora/antora-ui-default/-/issues/140.|https://gitlab.com/antora/antora-ui-default/-/issues/140]
> Please let me know if you'd like to see a pull request for this for Isis
> including a clean-up of the AsciiDoc code (even before it is part of the
> standard Antora UI).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ISIS-2368) Add lightbox support (=enlarge image on click) for Antora template
[
https://issues.apache.org/jira/browse/ISIS-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber resolved ISIS-2368.
--
Resolution: Implemented
All credits to Alexander.
> Add lightbox support (=enlarge image on click) for Antora template
> ---
>
> Key: ISIS-2368
> URL: https://issues.apache.org/jira/browse/ISIS-2368
> Project: Isis
> Issue Type: Improvement
> Components: Isis Docs & Website
>Reporter: Alexander Schwartz
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> The Antora based documentation allows a user to click on an image. The code
> for this looks like this:
>
> {{image::value-types/markup.png[width="400px",link="\{imagesdir}/value-types/markup.png"]}}
>
> An alternative would be to add "lightbox" support (=enlarge image on click)
> for the Antora template. This would reduce the markup to
>
> {{image::value-types/markup.png[width="400px"]}}
>
> An example can be found here:
> [https://intellij-asciidoc-plugin.ahus1.de/docs/users-guide/quick-start.html]
> I've also started a discussion to make it part of the standard Antora UI:
> [https://gitlab.com/antora/antora-ui-default/-/issues/140.|https://gitlab.com/antora/antora-ui-default/-/issues/140]
> Please let me know if you'd like to see a pull request for this for Isis
> including a clean-up of the AsciiDoc code (even before it is part of the
> standard Antora UI).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2341) Ongoing: CI Maintenance
[ https://issues.apache.org/jira/browse/ISIS-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2341: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Ongoing: CI Maintenance > --- > > Key: ISIS-2341 > URL: https://issues.apache.org/jira/browse/ISIS-2341 > Project: Isis > Issue Type: Task > Components: Isis CI & Build Scripts >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2332) Add new JPA module to provide a JpaEntityFacet
[ https://issues.apache.org/jira/browse/ISIS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber resolved ISIS-2332. -- Resolution: Implemented Implemented, but Spring Data integration is still work in progress. > Add new JPA module to provide a JpaEntityFacet > -- > > Key: ISIS-2332 > URL: https://issues.apache.org/jira/browse/ISIS-2332 > Project: Isis > Issue Type: Improvement > Components: Isis Persistence JPA >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2340) New common UI Model Module
[ https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber resolved ISIS-2340. -- Resolution: Implemented Most notable, we implemented a new programmatic Interaction API similar to the WrapperFactory, but with more fine grained support for validation callbacks and parameter negotiation. We introduced bindable components, that any UI implementation can bind its UI elements to. This is still work in progress and requires some cleaning up of classes and concepts that are no longer used. Also Note: first idea was to also base the Wicket Viewer on this new common infrastructure, but it turned out, that there is too high risk of breaking things that already work great with Wicket. Nevertheless Parameter Negotiation for the Wicket Viewer received some fixes while we were working on this common UI infrastructure. There will be follow up tasks to this one, targeting the next milestone. > New common UI Model Module > -- > > Key: ISIS-2340 > URL: https://issues.apache.org/jira/browse/ISIS-2340 > Project: Isis > Issue Type: New Feature >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4 > > > Consolidate code that is common to all viewers into a new module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2294) Create JPA variant of the JDO Book/Product/Inventory (smoketest-domain)
[ https://issues.apache.org/jira/browse/ISIS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2294: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Create JPA variant of the JDO Book/Product/Inventory (smoketest-domain) > --- > > Key: ISIS-2294 > URL: https://issues.apache.org/jira/browse/ISIS-2294 > Project: Isis > Issue Type: New Feature > Components: Isis Persistence JPA >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Labels: persistence > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2297) Ongoing: Mitigate Sonar Code Quality Issues
[ https://issues.apache.org/jira/browse/ISIS-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2297: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Ongoing: Mitigate Sonar Code Quality Issues > --- > > Key: ISIS-2297 > URL: https://issues.apache.org/jira/browse/ISIS-2297 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0-M5 > > > Ongoing task: Mitigate Sonar Code Quality Issues -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2033) Spring Data Integration
[ https://issues.apache.org/jira/browse/ISIS-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2033: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Spring Data Integration > --- > > Key: ISIS-2033 > URL: https://issues.apache.org/jira/browse/ISIS-2033 > Project: Isis > Issue Type: Task > Components: Isis Persistence JPA >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > Re-platforming Apache Isis on Spring Boot + Spring Data -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-996) Define component factories as Spring @Components
[
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-996:
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Define component factories as Spring @Components
>
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
> - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
> ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at
> beginning of list) rather than "replace".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-1922) Session Timeout Indication
[ https://issues.apache.org/jira/browse/ISIS-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1922: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Session Timeout Indication > -- > > Key: ISIS-1922 > URL: https://issues.apache.org/jira/browse/ISIS-1922 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > Eg when a user clicks on a Menu Item, while the session has already timed > out, the session silently refreshes and no action is executed. > From a user's perspective, she/he experiences an application that sometimes > is ignoring clicks. > We should a least show a fade-in/out message to give a user friendly > notification, that her/his session was timed out and hence needed to be > refreshed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2168) Floating Point Value Types must support Scientific Notation
[ https://issues.apache.org/jira/browse/ISIS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2168: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Floating Point Value Types must support Scientific Notation > --- > > Key: ISIS-2168 > URL: https://issues.apache.org/jira/browse/ISIS-2168 > Project: Isis > Issue Type: Bug > Components: Isis Viewer Wicket >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > given a property of type Double, when you enter 1e-9 in the editable field, > this is not recognized; > even worse: entering 0.1 ends up being rendered as 0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2301) Docs for new IsisInteractionScope
[ https://issues.apache.org/jira/browse/ISIS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2301: - Attachment: image (2).png > Docs for new IsisInteractionScope > - > > Key: ISIS-2301 > URL: https://issues.apache.org/jira/browse/ISIS-2301 > Project: Isis > Issue Type: Improvement > Components: Isis Docs & Website >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: image (2).png, image (3).png > > > We allow IsisInteractions to be nested. The @IsisInteractionScope is always > bound to the top-level IsisInteraction of the current thread's session stack. > (first stack element, aka bottom of stack) > Isis (not Spring) is aware, when any IsisInteractionScope ends. So at the end > of each IsisInteractionScope, we call the destruction runnables on the > IsisInteractionScope-d beans that belong to the current thread, then clear > the IsisInteraction stack (of the current thread). (edited) > The IsisInteractionScope-d beans are managed by Spring, that is Spring > creates them and registers their destruction runnables. > Requires Provider idiom: we fail early if one tries to inject an > IsisInteractionScope-d bean directly. The thrown exception gives a hint, how > to fix it. (Use the Provider<> idiom instead) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2301) Docs for new IsisInteractionScope
[ https://issues.apache.org/jira/browse/ISIS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2301: - Attachment: image (3).png > Docs for new IsisInteractionScope > - > > Key: ISIS-2301 > URL: https://issues.apache.org/jira/browse/ISIS-2301 > Project: Isis > Issue Type: Improvement > Components: Isis Docs & Website >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: image (2).png, image (3).png > > > We allow IsisInteractions to be nested. The @IsisInteractionScope is always > bound to the top-level IsisInteraction of the current thread's session stack. > (first stack element, aka bottom of stack) > Isis (not Spring) is aware, when any IsisInteractionScope ends. So at the end > of each IsisInteractionScope, we call the destruction runnables on the > IsisInteractionScope-d beans that belong to the current thread, then clear > the IsisInteraction stack (of the current thread). (edited) > The IsisInteractionScope-d beans are managed by Spring, that is Spring > creates them and registers their destruction runnables. > Requires Provider idiom: we fail early if one tries to inject an > IsisInteractionScope-d bean directly. The thrown exception gives a hint, how > to fix it. (Use the Provider<> idiom instead) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ISIS-2441) Auditing/Publishing: dispatch calls happen before enlist calls
Andi Huber created ISIS-2441: Summary: Auditing/Publishing: dispatch calls happen before enlist calls Key: ISIS-2441 URL: https://issues.apache.org/jira/browse/ISIS-2441 Project: Isis Issue Type: Bug Reporter: Andi Huber Assignee: Andi Huber Fix For: 2.0.0-M5 At the end of each transaction (before commit), auditing and publishing queries any enlisted objects from the ChangedObjectsService for processing. However enlisting of changed objects happens too late. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2441) Auditing/Publishing: dispatch calls happen before enlist calls
[ https://issues.apache.org/jira/browse/ISIS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2441: - Component/s: Isis Core > Auditing/Publishing: dispatch calls happen before enlist calls > -- > > Key: ISIS-2441 > URL: https://issues.apache.org/jira/browse/ISIS-2441 > Project: Isis > Issue Type: Bug > Components: Isis Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > At the end of each transaction (before commit), auditing and publishing > queries any enlisted objects from the ChangedObjectsService for processing. > However enlisting of changed objects happens too late. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2425) Gradle Build (CI) does not fail when Metamodel Tests fail
[ https://issues.apache.org/jira/browse/ISIS-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2425: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Gradle Build (CI) does not fail when Metamodel Tests fail > - > > Key: ISIS-2425 > URL: https://issues.apache.org/jira/browse/ISIS-2425 > Project: Isis > Issue Type: Sub-task >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > There might be other modules too. We need to make sure, all the modules are > tested during run of the CI pipeline. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2301) Docs for new IsisInteractionScope
[ https://issues.apache.org/jira/browse/ISIS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2301: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Docs for new IsisInteractionScope > - > > Key: ISIS-2301 > URL: https://issues.apache.org/jira/browse/ISIS-2301 > Project: Isis > Issue Type: Improvement > Components: Isis Docs & Website >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > Attachments: image (2).png, image (3).png > > > We allow IsisInteractions to be nested. The @IsisInteractionScope is always > bound to the top-level IsisInteraction of the current thread's session stack. > (first stack element, aka bottom of stack) > Isis (not Spring) is aware, when any IsisInteractionScope ends. So at the end > of each IsisInteractionScope, we call the destruction runnables on the > IsisInteractionScope-d beans that belong to the current thread, then clear > the IsisInteraction stack (of the current thread). (edited) > The IsisInteractionScope-d beans are managed by Spring, that is Spring > creates them and registers their destruction runnables. > Requires Provider idiom: we fail early if one tries to inject an > IsisInteractionScope-d bean directly. The thrown exception gives a hint, how > to fix it. (Use the Provider<> idiom instead) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1451) SessionManagement#nextSession does not close off the current Interaction's execution graph.
[ https://issues.apache.org/jira/browse/ISIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-1451: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > SessionManagement#nextSession does not close off the current Interaction's > execution graph. > --- > > Key: ISIS-1451 > URL: https://issues.apache.org/jira/browse/ISIS-1451 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.12.2 >Reporter: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M5 > > > This is somewhat of a corner case, but if SessionManagementService's > nextSession() method is called -- within an action -- then this ought to > (somehow) gracefully close off the current interaction in order to set up a > new interaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-1451) SessionManagement#nextSession does not close off the current Interaction's execution graph.
[ https://issues.apache.org/jira/browse/ISIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber reassigned ISIS-1451: Assignee: Andi Huber > SessionManagement#nextSession does not close off the current Interaction's > execution graph. > --- > > Key: ISIS-1451 > URL: https://issues.apache.org/jira/browse/ISIS-1451 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.12.2 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0-M5 > > > This is somewhat of a corner case, but if SessionManagementService's > nextSession() method is called -- within an action -- then this ought to > (somehow) gracefully close off the current interaction in order to set up a > new interaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ISIS-1451) SessionManagement#nextSession does not close off the current Interaction's execution graph.
[ https://issues.apache.org/jira/browse/ISIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207282#comment-17207282 ] Andi Huber commented on ISIS-1451: -- Not sure whether still an issue. With ISIS-2441 we will have better tests. > SessionManagement#nextSession does not close off the current Interaction's > execution graph. > --- > > Key: ISIS-1451 > URL: https://issues.apache.org/jira/browse/ISIS-1451 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.12.2 >Reporter: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M5 > > > This is somewhat of a corner case, but if SessionManagementService's > nextSession() method is called -- within an action -- then this ought to > (somehow) gracefully close off the current interaction in order to set up a > new interaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2337) FacetFactories to be managed by Spring
[ https://issues.apache.org/jira/browse/ISIS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2337: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > FacetFactories to be managed by Spring > -- > > Key: ISIS-2337 > URL: https://issues.apache.org/jira/browse/ISIS-2337 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > And facet processing order needs to follow Spring's precedence of managed > beans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2337) [WON'T FIX] FacetFactories to be managed by Spring
[ https://issues.apache.org/jira/browse/ISIS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2337: - Summary: [WON'T FIX] FacetFactories to be managed by Spring (was: FacetFactories to be managed by Spring) > [WON'T FIX] FacetFactories to be managed by Spring > -- > > Key: ISIS-2337 > URL: https://issues.apache.org/jira/browse/ISIS-2337 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > > And facet processing order needs to follow Spring's precedence of managed > beans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2337) [WON'T FIX] FacetFactories to be managed by Spring
[ https://issues.apache.org/jira/browse/ISIS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-2337: - Fix Version/s: 2.0.0-M4 > [WON'T FIX] FacetFactories to be managed by Spring > -- > > Key: ISIS-2337 > URL: https://issues.apache.org/jira/browse/ISIS-2337 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4, 2.0.0-M5 > > > And facet processing order needs to follow Spring's precedence of managed > beans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ISIS-2337) [WON'T FIX] FacetFactories to be managed by Spring
[ https://issues.apache.org/jira/browse/ISIS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber closed ISIS-2337. Fix Version/s: (was: 2.0.0-M5) Resolution: Won't Fix unless there is requirement for that: won't fix > [WON'T FIX] FacetFactories to be managed by Spring > -- > > Key: ISIS-2337 > URL: https://issues.apache.org/jira/browse/ISIS-2337 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M4 > > > And facet processing order needs to follow Spring's precedence of managed > beans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-996) [WON'T FIX] Define component factories as Spring @Components
[
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-996:
Fix Version/s: (was: 2.0.0-M5)
2.0.0-M4
> [WON'T FIX] Define component factories as Spring @Components
>
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
> - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
> ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at
> beginning of list) rather than "replace".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-996) [WON'T FIX] Define component factories as Spring @Components
[
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-996:
Summary: [WON'T FIX] Define component factories as Spring @Components
(was: Define component factories as Spring @Components)
> [WON'T FIX] Define component factories as Spring @Components
>
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
> - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
> ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at
> beginning of list) rather than "replace".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (ISIS-996) [WON'T FIX] Define component factories as Spring @Components
[
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber closed ISIS-996.
---
Resolution: Won't Fix
Not fixed after 5 years.
> [WON'T FIX] Define component factories as Spring @Components
>
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
> - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
> ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at
> beginning of list) rather than "replace".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2329) Support nested non-static mixins, with domain event class declared within.
[
https://issues.apache.org/jira/browse/ISIS-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-2329:
-
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Support nested non-static mixins, with domain event class declared within.
> --
>
> Key: ISIS-2329
> URL: https://issues.apache.org/jira/browse/ISIS-2329
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> To support this, need to allow action domain events to have 1-arg
> constructor, being the mixee.
> eg, at the moment, in simpleapp, I can refactor updateName into a mixin:
> {code:java}
> public static class UpdateNameActionDomainEvent
> extends SimpleModule.ActionDomainEvent { }
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing =
> Publishing.DISABLED,
> associateWith = "name", domainEvent =
> UpdateNotesActionDomainEvent.class)
> public class updateName {
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
> {code}
> but the UpdateNameActionDomainEvent has to remain outside for now. Instead,
> I'd like to write:
> {code:java}
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing =
> Publishing.DISABLED,
> associateWith = "name", domainEvent =
> UpdateNotesActionDomainEvent.class)
> public class updateName {
>public class UpdateNameActionDomainEvent
> extends SimpleModule.ActionDomainEvent { }
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
> {code}
> The fix should be quite simple: improve the instantiation logic in
> DomainEventHelper to handle events with 1 arg as well as 0 args and 3 args.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2235) Mixins declared using @Property, @Collection or @Action should propagate facets correctly
[
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-2235:
-
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Mixins declared using @Property, @Collection or @Action should propagate
> facets correctly
> -
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
> {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by
> @Property(...) should be copied down correctly to the corresponding facets on
> the action, eg domain event (this might need specifying more precisely...)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2235) Mixins declared using @Property, @Collection or @Action should propagate facets correctly
[
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-2235:
-
Issue Type: Bug (was: Improvement)
> Mixins declared using @Property, @Collection or @Action should propagate
> facets correctly
> -
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
> Issue Type: Bug
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
> {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by
> @Property(...) should be copied down correctly to the corresponding facets on
> the action, eg domain event (this might need specifying more precisely...)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ISIS-2270) Rethink, who shall manage Lifecycles of DomainObjects, ViewModels and Mixins
[ https://issues.apache.org/jira/browse/ISIS-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber resolved ISIS-2270. -- Resolution: Resolved I'd say resolved: Lifecycles of DomainObject, ViewModel and Mixin are still managed by Isis not Spring. Simply because those are not inject-able Bean sorts. However, for all of these, service injection is supported. > Rethink, who shall manage Lifecycles of DomainObjects, ViewModels and Mixins > > > Key: ISIS-2270 > URL: https://issues.apache.org/jira/browse/ISIS-2270 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0-M4 > > > 1) Document and annotate @DomainObject, @ViewModel and @Mixin with > @Scope(SCOPE_PROTOTYPE) > 2) FactoryService#instantiate needs a semantic update > We want Spring to discover these types from the classpath (so that we can > build the metamodel eagerly), but we don't want it to manage them, or do we? > Using @Scope(PROTOTYPE) is the closest we can come to expressing that without > (attempting to) define a custom scope for each of these three types., > analogous to factoryService#instantiate for transient objects. > In practical terms, inventing a custom "entity" scope is probably impossible > due to DN's design (the enhancer creates a dnNewInstance method and this is > called upon as a factory). > Instead, then, we "veto" any of these domain types so that Spring is NOT > allowed to instantiate any of them. > The docs should be updated to explain what we're doing here. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ISIS-2322) Isis 2.0.0-M4 release activities
[ https://issues.apache.org/jira/browse/ISIS-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207309#comment-17207309 ] ASF subversion and git services commented on ISIS-2322: --- Commit 3cb2e61f60e5fc5c5163239b32132cb86ecb8af4 in isis's branch refs/heads/ISIS-2322 from danhaywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3cb2e61 ] ISIS-2322: fixes (some of the) missing licenses > Isis 2.0.0-M4 release activities > > > Key: ISIS-2322 > URL: https://issues.apache.org/jira/browse/ISIS-2322 > Project: Isis > Issue Type: Task >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2231) Bring in incode-platform stuff
[ https://issues.apache.org/jira/browse/ISIS-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2231. --- Resolution: Fixed > Bring in incode-platform stuff > -- > > Key: ISIS-2231 > URL: https://issues.apache.org/jira/browse/ISIS-2231 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions, Isis Mappings, Isis Subdomains, Isis > Testing >Affects Versions: 2.0.0-M2 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ISIS-2442) Bring in further incode-platform stuff.
Daniel Keir Haywood created ISIS-2442: - Summary: Bring in further incode-platform stuff. Key: ISIS-2442 URL: https://issues.apache.org/jira/browse/ISIS-2442 Project: Isis Issue Type: New Feature Reporter: Daniel Keir Haywood Assignee: Daniel Keir Haywood Fix For: 2.0.0-M5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ISIS-2443) Flesh out demo app with further examples
Daniel Keir Haywood created ISIS-2443: - Summary: Flesh out demo app with further examples Key: ISIS-2443 URL: https://issues.apache.org/jira/browse/ISIS-2443 Project: Isis Issue Type: New Feature Reporter: Daniel Keir Haywood Assignee: Daniel Keir Haywood Fix For: 2.0.0-M5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2010) Define a formal API for programmatic interactions between modules
[ https://issues.apache.org/jira/browse/ISIS-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2010: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Define a formal API for programmatic interactions between modules > - > > Key: ISIS-2010 > URL: https://issues.apache.org/jira/browse/ISIS-2010 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > One idea: > - NatureOfService.DOMAIN_API vs NatureOfService.DOMAIN (latter interpreted as > IMPL) > For the API, can wrap (and perhaps are auto-wrapped) > For the IMPL, are not wrapped, and don't introspect the methods to create > actions. > It's not clear to me which of the Isis services should be DOMAIN_API vs > DOMAIN. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2222) Flesh out demo app with extra examples.
[ https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-. --- Resolution: Fixed > Flesh out demo app with extra examples. > --- > > Key: ISIS- > URL: https://issues.apache.org/jira/browse/ISIS- > Project: Isis > Issue Type: Improvement > Components: Isis Examples >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > > ISIS-2243 will continue this work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2222) Flesh out demo app with extra examples.
[ https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-: -- Description: ISIS-2243 will continue this work. > Flesh out demo app with extra examples. > --- > > Key: ISIS- > URL: https://issues.apache.org/jira/browse/ISIS- > Project: Isis > Issue Type: Improvement > Components: Isis Examples >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > > ISIS-2243 will continue this work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2336) Ongoing improvements for Antora website
[ https://issues.apache.org/jira/browse/ISIS-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2336: -- Description: Continued by ISIS-2444 > Ongoing improvements for Antora website > --- > > Key: ISIS-2336 > URL: https://issues.apache.org/jira/browse/ISIS-2336 > Project: Isis > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > > Continued by ISIS-2444 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2336) Ongoing improvements for Antora website
[ https://issues.apache.org/jira/browse/ISIS-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2336. --- Resolution: Fixed > Ongoing improvements for Antora website > --- > > Key: ISIS-2336 > URL: https://issues.apache.org/jira/browse/ISIS-2336 > Project: Isis > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > > Continued by ISIS-2444 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ISIS-2444) Ongoing improvements to the Apache Isis website
Daniel Keir Haywood created ISIS-2444: - Summary: Ongoing improvements to the Apache Isis website Key: ISIS-2444 URL: https://issues.apache.org/jira/browse/ISIS-2444 Project: Isis Issue Type: Improvement Reporter: Daniel Keir Haywood Assignee: Daniel Keir Haywood Fix For: 2.0.0-M5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2231) Bring in incode-platform stuff
[ https://issues.apache.org/jira/browse/ISIS-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2231: -- Description: Continued by ISIS-2442 > Bring in incode-platform stuff > -- > > Key: ISIS-2231 > URL: https://issues.apache.org/jira/browse/ISIS-2231 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions, Isis Mappings, Isis Subdomains, Isis > Testing >Affects Versions: 2.0.0-M2 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > > Continued by ISIS-2442 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2416) Allow action domain event handlers to change argument in the executing phase.
[ https://issues.apache.org/jira/browse/ISIS-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2416. --- Resolution: Fixed > Allow action domain event handlers to change argument in the executing phase. > - > > Key: ISIS-2416 > URL: https://issues.apache.org/jira/browse/ISIS-2416 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2422) Treat schema DTOs (InteractionDto, ChangesDto, CommandDto) as value types.
[ https://issues.apache.org/jira/browse/ISIS-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2422. --- Resolution: Fixed > Treat schema DTOs (InteractionDto, ChangesDto, CommandDto) as value types. > -- > > Key: ISIS-2422 > URL: https://issues.apache.org/jira/browse/ISIS-2422 > Project: Isis > Issue Type: Improvement > Components: Isis Core, Isis Viewer Wicket >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > > And as a nice-to-have, extend the Asciidoc component to be able to render > these as nicely formatted XML. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2423) Persisted callback and PublisherService#changedObjects are not called, instead appear as updates.
[ https://issues.apache.org/jira/browse/ISIS-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2423. --- Resolution: Fixed > Persisted callback and PublisherService#changedObjects are not called, > instead appear as updates. > - > > Key: ISIS-2423 > URL: https://issues.apache.org/jira/browse/ISIS-2423 > Project: Isis > Issue Type: Bug > Components: Isis Core >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > > Due to use of EntityUtil.isAttached(...) in the > PersistenceSession5#enlistCreated... method, rather than checking our own > Oid. In this particular case they were not equivalent. > Fix: > - was able to simplify and remove some redundant code, using instead > persistable.dnGetStateManager().isNew(persistable) > as the mechanism to determine in preStore/postStore whether we are dealing > within an insert or an update. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2396) Make Markup final, remove ListeningMarkup (can just use Markup)
[ https://issues.apache.org/jira/browse/ISIS-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2396: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Make Markup final, remove ListeningMarkup (can just use Markup) > --- > > Key: ISIS-2396 > URL: https://issues.apache.org/jira/browse/ISIS-2396 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-826) Remove WrappedObject interface, use instead WrappingObject as its replacement.
[ https://issues.apache.org/jira/browse/ISIS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-826: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Remove WrappedObject interface, use instead WrappingObject as its replacement. > -- > > Key: ISIS-826 > URL: https://issues.apache.org/jira/browse/ISIS-826 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: core-1.5.0 >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > For example, WrappedObject defines save() and wrapped(). If the underlying > domain object also defined these methods as actions, then it would be > impossible to use the wrapper to check business rules etc. > Therefore should remove this interface (in Isis 2.x), to replace with one > that uses methods which are unlikely to cause a clash. > (The workaround in the meantime is to rename the action methods and use > @Named() if required for the UI). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-439) Remove concept of mutable collections from programming model.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-439: - Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Remove concept of mutable collections from programming model. > - > > Key: ISIS-439 > URL: https://issues.apache.org/jira/browse/ISIS-439 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Affects Versions: viewer-wicket-1.2.0 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > was: Wicket viewer should support mutable collections - ie with an implicit > 'add' and 'remove' action. > but see comments underneath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1023) Allow user to invoke action on entity in table collection
[ https://issues.apache.org/jira/browse/ISIS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1023: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Allow user to invoke action on entity in table collection > - > > Key: ISIS-1023 > URL: https://issues.apache.org/jira/browse/ISIS-1023 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Affects Versions: viewer-wicket-1.7.0, core-1.7.0 >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > Enhance the Wicket viewer (with corresponding metadata annotations) to render > an entity's actions as drop-down menu when that entity is rendered as a row > of a table. > There's probably no need to introduce additional annotations; the > @ActionLayout(hidden=...) indicates whether an action is hidden in various > contexts, one of these being it being hidden (or not) within tables. > My idea therefore is that, unless every action of an entity is indicated as > hidden for a table, that there is an additional column that includes a > drop-down and that allows the actions to be invoked (bringing up the dialog). > Once the action is invoked (like bulk actions) the table should be reloaded > (rather than, say, navigate to the object returned by the action). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1995) Render collection of objects as panels
[ https://issues.apache.org/jira/browse/ISIS-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1995: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Render collection of objects as panels > -- > > Key: ISIS-1995 > URL: https://issues.apache.org/jira/browse/ISIS-1995 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1994) Render collection of objects as tabs
[ https://issues.apache.org/jira/browse/ISIS-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1994: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Render collection of objects as tabs > > > Key: ISIS-1994 > URL: https://issues.apache.org/jira/browse/ISIS-1994 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2059) Allow Wicket viewer caching strategy (timestamp or digest) to be selected via config property.
[ https://issues.apache.org/jira/browse/ISIS-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2059: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Allow Wicket viewer caching strategy (timestamp or digest) to be selected via > config property. > -- > > Key: ISIS-2059 > URL: https://issues.apache.org/jira/browse/ISIS-2059 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M5 > > > There is already some commented-out code in IsisWicketApplication. > // getResourceSettings().setCachingStrategy( > // new FilenameWithVersionResourceCachingStrategy( > // new CachingResourceVersion( > // new MessageDigestResourceVersion(; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-1536) BackgroundService should fail-fast if there is no BackgroundCommandService implementation available to persist the command.
[ https://issues.apache.org/jira/browse/ISIS-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-1536: - Assignee: Daniel Keir Haywood > BackgroundService should fail-fast if there is no BackgroundCommandService > implementation available to persist the command. > --- > > Key: ISIS-1536 > URL: https://issues.apache.org/jira/browse/ISIS-1536 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.13.1 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-1536) BackgroundService should fail-fast if there is no BackgroundCommandService implementation available to persist the command.
[ https://issues.apache.org/jira/browse/ISIS-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-1536. --- Resolution: Won't Do This has been superceded,, as the command service has been overhauled cmpletely in this release. > BackgroundService should fail-fast if there is no BackgroundCommandService > implementation available to persist the command. > --- > > Key: ISIS-1536 > URL: https://issues.apache.org/jira/browse/ISIS-1536 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.13.1 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1678) Remove org.apache.isis.applib.clock.Clock, replace with org.apache.isis.applib.services.clock.ClockService
[ https://issues.apache.org/jira/browse/ISIS-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1678: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Remove org.apache.isis.applib.clock.Clock, replace with > org.apache.isis.applib.services.clock.ClockService > -- > > Key: ISIS-1678 > URL: https://issues.apache.org/jira/browse/ISIS-1678 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2122) adviseXxx(), a softer version of validateXxx().
[ https://issues.apache.org/jira/browse/ISIS-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2122: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > adviseXxx(), a softer version of validateXxx(). > --- > > Key: ISIS-2122 > URL: https://issues.apache.org/jira/browse/ISIS-2122 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > more discussion at > [https://lists.apache.org/thread.html/bd8a407ceb0e07cc42c1b7eb85e266817b802a11fccf05819c9c4812@%3Cusers.isis.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1898) Use Joda Interval for LocalDate collection parameter
[
https://issues.apache.org/jira/browse/ISIS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1898:
--
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Use Joda Interval for LocalDate collection parameter
>
>
> Key: ISIS-1898
> URL: https://issues.apache.org/jira/browse/ISIS-1898
> Project: Isis
> Issue Type: Improvement
> Components: Isis Applib (programming model)
>Affects Versions: 1.16.1
>Reporter: Sander Ginn
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> {code:java}
> // code placeholder
> {code}
> To accommodate to the requirement of a {{choicesXxx}}/{{autoCompleteXxx}}
> method for a collection parameter on an action, it would be useful to be able
> to return a Joda Interval instead of a collection of LocalDates.
> Furthermore, it is desirable that the available options are offered through
> the date picker that is currently used for single LocalDate parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-1692) Resilient if TableColumnOrderingService returns non-existent property name.
[
https://issues.apache.org/jira/browse/ISIS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1692:
--
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Resilient if TableColumnOrderingService returns non-existent property name.
> ---
>
> Key: ISIS-1692
> URL: https://issues.apache.org/jira/browse/ISIS-1692
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> at least in 1.15.0-SNAPSHOT, this gave me an NPE
> eg in Estatio, because of non-existent property in TableColumnOrderingService
> {code}
> @DomainService(nature = NatureOfService.DOMAIN)
> public static class TableColumnOrderServiceForCreditTransfer implements
> TableColumnOrderService {
> @Override
> public List orderParented(
> final Object parent,
> final String collectionId,
> final Class collectionType,
> final List propertyIds) {
> if(parent instanceof PaymentBatch &&
> CreditTransfer.class.isAssignableFrom(collectionType)) {
> return Lists.newArrayList(
> "endToEndId",
> "seller",
> "sellerBankAccount",
> "amount",
> "remittanceInformation"
> );
> }
> return null;
> }
> @Override
> public List orderStandalone(final Class collectionType,
> final List propertyIds) {
> return null;
> }
> }
> {code}
> resulted in stack trace:
> {code}
> java.lang.NullPointerException
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#createObjectAdapterPropertyColumn(CollectionContentsAsAjaxTablePanel.java:256)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:208)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1081)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
> org.apache.wicket.MarkupContainer#addOrReplace(MarkupContainer.java:265)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel#addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel#onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1081)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
> org.apache.wicket.MarkupContainer#addOrReplace(MarkupContainer.java:265)
> org.apache.isis.viewer.wicket.viewer.registries.components.ComponentFactoryRegistryDefault#addOrReplaceComponent(ComponentFactoryRegistryDefault.java:107)
> org.apache.isis.viewer.wicket.ui.components.collection.CollectionPanel#buildGui(CollectionPanel.java:87)
> org.apache.isis.viewer.wicket.ui.components.collection.CollectionPanel#onInitialize(CollectionPanel.java:83)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer$3#component(MarkupContainer.java:1087)
> org.apache.wicket.MarkupContainer$3#component(MarkupContainer.java:1083)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:144)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:123)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:192)
> org.apache.wicket.MarkupContainer#visitChildren(MarkupContainer.java:983)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1082)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
> org.apache.isis.viewer.wicket.ui.components.entity.collection.EntityCollectionPanel#onInitialize(EntityCollectionPanel.java:94)
> org.a
[jira] [Updated] (ISIS-1704) BigDecimal properties are not right aligned in Wicket viewer when shown in read-only mode.
[ https://issues.apache.org/jira/browse/ISIS-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1704: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > BigDecimal properties are not right aligned in Wicket viewer when shown in > read-only mode. > -- > > Key: ISIS-1704 > URL: https://issues.apache.org/jira/browse/ISIS-1704 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Affects Versions: 1.15.0 >Reporter: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1709) Inconsistent handling of commands vs auditing for objects implementing HasTransactionId
[ https://issues.apache.org/jira/browse/ISIS-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1709: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 There's a reasonable chance this was fixed in 2.0.0-M4 with the reworking of command, but haven't checked so keeping it on the board. > Inconsistent handling of commands vs auditing for objects implementing > HasTransactionId > --- > > Key: ISIS-1709 > URL: https://issues.apache.org/jira/browse/ISIS-1709 > Project: Isis > Issue Type: Bug > Components: Isis Core >Affects Versions: 1.15.0 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M5 > > > Noticed that if > ApplicationUser#updateEmailAddress(...) > with > isis.services.audit.objects=none > isis.services.command.actions=none > then do get a Command persisted, but don't get any audit records persisted. > The auditing behaviour is correct, but the command behaviour is wrong. > What seems to happen is that no CommandFacet is installed > (ActionAnnotationFacetFactory#processCommand), and then in the > ObjectMemberAbstract because there is no command facet it defaults to > "// if no facet, assume do want to execute right now, but only persist > (eventually) if hinted." > My guess is that the hinting does occur > (PersistenceSession#completeCommandFromInteractionAndClearDomainEvents as > objects are dirtied. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1732) Document "hidden" as a supported method for services.
[
https://issues.apache.org/jira/browse/ISIS-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1732:
--
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Document "hidden" as a supported method for services.
> -
>
> Key: ISIS-1732
> URL: https://issues.apache.org/jira/browse/ISIS-1732
> Project: Isis
> Issue Type: Improvement
> Components: Isis Docs & Website
>Affects Versions: 1.15.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> eg, in kitchensink, we have:
> {code}
> public abstract class RepositoryAbstract {
> private final Class cls;
> public RepositoryAbstract(Class cls, Visibility visibility) {
> this.cls = cls;
> this.visibility = visibility;
> }
> //region > visibility
> private final Visibility visibility;
> protected enum Visibility {
> VISIBLE,
> NOT_VISIBLE
> }
> public boolean hidden() {
> return this.visibility == Visibility.NOT_VISIBLE;
> }
> //endregion
>
> {code}
> and then:
> {code}
> @DomainService(
> repositoryFor = ChildObject.class
> )
> public class ChildObjects extends RepositoryAbstract {
> public ChildObjects() {
> super(ChildObject.class, Visibility.NOT_VISIBLE);
> }
> public ChildObject create(
> final String name,
> final ParentObject parentObject) {
> return repositoryService.persist(ChildObject.create(name,
> parentObject));
> }
> public List listAll() {
> return repositoryService.allInstances(ChildObject.class);
> }
> }
> {code}
> if use super(...VISIBLE) then this service appears in the menu. so,
> "hidden()" is a way of globally hiding an object (or a domain service, at
> least).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-1873) Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then assume veto and log a WARNing.
[
https://issues.apache.org/jira/browse/ISIS-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1873:
--
Fix Version/s: (was: 2.0.0-M4)
2.0.0-M5
> Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then
> assume veto and log a WARNing.
>
>
> Key: ISIS-1873
> URL: https://issues.apache.org/jira/browse/ISIS-1873
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Affects Versions: 1.16.1
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> Currently the framework doesn't degrade gracefully.
> For example, had a coding error in a hideXxx() method.
> This resulted in the error page, rather than simply hide the relevant member.
> {code:java}
> org.eclipse.jetty.util.thread.QueuedThreadPool#runJob(QueuedThreadPool.java:672)
> org.eclipse.jetty.util.thread.QueuedThreadPool$2#run(QueuedThreadPool.java:590)
> java.lang.Thread#run(Thread.java:745)
> Caused by:
> java.lang.NullPointerException
> org.isisaddons.module.command.dom.CommandJdo#hideReplayStateFailureReason(CommandJdo.java:386)
> sun.reflect.NativeMethodAccessorImpl#invoke0(NativeMethodAccessorImpl.java:-2)
> sun.reflect.NativeMethodAccessorImpl#invoke(NativeMethodAccessorImpl.java:62)
> sun.reflect.DelegatingMethodAccessorImpl#invoke(DelegatingMethodAccessorImpl.java:43)
> java.lang.reflect.Method#invoke(Method.java:498)
> org.apache.isis.core.commons.lang.MethodExtensions#invoke(MethodExtensions.java:53)
> org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils#invoke(ObjectAdapter.java:38{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-1815) Log URL for when we get Tomcat ClientConnection closed error (which we think is mostly due to slow response and users getting tired of waiting).
[ https://issues.apache.org/jira/browse/ISIS-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1815: -- Fix Version/s: (was: 2.0.0-M4) 2.0.0-M5 > Log URL for when we get Tomcat ClientConnection closed error (which we think > is mostly due to slow response and users getting tired of waiting). > > > Key: ISIS-1815 > URL: https://issues.apache.org/jira/browse/ISIS-1815 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Affects Versions: 1.16.0 >Reporter: Daniel Keir Haywood >Priority: Critical > Fix For: 2.0.0-M5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2382) Concurrent Spec Loading is broken (possible race condition)
[ https://issues.apache.org/jira/browse/ISIS-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2382: -- Fix Version/s: (was: 2.0.5) 2.0.0 > Concurrent Spec Loading is broken (possible race condition) > --- > > Key: ISIS-2382 > URL: https://issues.apache.org/jira/browse/ISIS-2382 > Project: Isis > Issue Type: Bug > Components: Isis Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > > Seen this both in production and prototyping mode. Prototyping mode allows to > refresh the meta model, which fixes any missing action buttons. With > production mode, one needs to restart the App. Though seen very rarely, this > is mission critical. > My assumption is, that we have a race condition when introspecting the domain > classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ISIS-1536) BackgroundService should fail-fast if there is no BackgroundCommandService implementation available to persist the command.
[ https://issues.apache.org/jira/browse/ISIS-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood closed ISIS-1536. - > BackgroundService should fail-fast if there is no BackgroundCommandService > implementation available to persist the command. > --- > > Key: ISIS-1536 > URL: https://issues.apache.org/jira/browse/ISIS-1536 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.13.1 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ISIS-2222) Flesh out demo app with extra examples.
[ https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood closed ISIS-. - > Flesh out demo app with extra examples. > --- > > Key: ISIS- > URL: https://issues.apache.org/jira/browse/ISIS- > Project: Isis > Issue Type: Improvement > Components: Isis Examples >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-M4 > > > ISIS-2243 will continue this work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2389) Metamodel exception should be thrown if default supporting method type does not match.
[
https://issues.apache.org/jira/browse/ISIS-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-2389:
--
Fix Version/s: (was: 2.0.0)
> Metamodel exception should be thrown if default supporting method type does
> not match.
> --
>
> Key: ISIS-2389
> URL: https://issues.apache.org/jira/browse/ISIS-2389
> Project: Isis
> Issue Type: Bug
> Components: Isis Core
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> eg in the demo app, I had this error:
>
> @Action(semantics = SemanticsOf.SAFE)
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> public WrapperBooleanVm openViewModel(Boolean initialValue) {
> return new WrapperBooleanVm(initialValue);
> }
> public char default0OpenViewModel() {
> return 'a';
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2390) Not possible to navigate to date/time drop-down using keyboard.
[ https://issues.apache.org/jira/browse/ISIS-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2390: -- Component/s: Isis Viewer Wicket Fix Version/s: (was: 2.0.0) > Not possible to navigate to date/time drop-down using keyboard. > --- > > Key: ISIS-2390 > URL: https://issues.apache.org/jira/browse/ISIS-2390 > Project: Isis > Issue Type: Bug > Components: Isis Viewer Wicket >Affects Versions: 2.0.0-M3 >Reporter: Daniel Keir Haywood >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-439) Remove concept of mutable collections from programming model.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-439: - Fix Version/s: (was: 2.0.0-M5) > Remove concept of mutable collections from programming model. > - > > Key: ISIS-439 > URL: https://issues.apache.org/jira/browse/ISIS-439 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Affects Versions: viewer-wicket-1.2.0 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > > was: Wicket viewer should support mutable collections - ie with an implicit > 'add' and 'remove' action. > but see comments underneath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1023) Allow user to invoke action on entity in table collection
[ https://issues.apache.org/jira/browse/ISIS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1023: -- Fix Version/s: (was: 2.0.0-M5) > Allow user to invoke action on entity in table collection > - > > Key: ISIS-1023 > URL: https://issues.apache.org/jira/browse/ISIS-1023 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Affects Versions: viewer-wicket-1.7.0, core-1.7.0 >Reporter: Daniel Keir Haywood >Priority: Major > > Enhance the Wicket viewer (with corresponding metadata annotations) to render > an entity's actions as drop-down menu when that entity is rendered as a row > of a table. > There's probably no need to introduce additional annotations; the > @ActionLayout(hidden=...) indicates whether an action is hidden in various > contexts, one of these being it being hidden (or not) within tables. > My idea therefore is that, unless every action of an entity is indicated as > hidden for a table, that there is an additional column that includes a > drop-down and that allows the actions to be invoked (bringing up the dialog). > Once the action is invoked (like bulk actions) the table should be reloaded > (rather than, say, navigate to the object returned by the action). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-826) Remove WrappedObject interface, use instead WrappingObject as its replacement.
[ https://issues.apache.org/jira/browse/ISIS-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-826: - Component/s: (was: Isis Core) Isis Applib (programming model) Fix Version/s: (was: 2.0.0-M5) > Remove WrappedObject interface, use instead WrappingObject as its replacement. > -- > > Key: ISIS-826 > URL: https://issues.apache.org/jira/browse/ISIS-826 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Affects Versions: core-1.5.0 >Reporter: Daniel Keir Haywood >Priority: Major > > For example, WrappedObject defines save() and wrapped(). If the underlying > domain object also defined these methods as actions, then it would be > impossible to use the wrapper to check business rules etc. > Therefore should remove this interface (in Isis 2.x), to replace with one > that uses methods which are unlikely to cause a clash. > (The workaround in the meantime is to rename the action methods and use > @Named() if required for the UI). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1994) Render collection of objects as tabs
[ https://issues.apache.org/jira/browse/ISIS-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1994: -- Fix Version/s: (was: 2.0.0-M5) > Render collection of objects as tabs > > > Key: ISIS-1994 > URL: https://issues.apache.org/jira/browse/ISIS-1994 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Reporter: Daniel Keir Haywood >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-439) Remove concept of mutable collections from programming model.
[ https://issues.apache.org/jira/browse/ISIS-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-439: Assignee: (was: Daniel Keir Haywood) > Remove concept of mutable collections from programming model. > - > > Key: ISIS-439 > URL: https://issues.apache.org/jira/browse/ISIS-439 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Affects Versions: viewer-wicket-1.2.0 >Reporter: Daniel Keir Haywood >Priority: Major > > was: Wicket viewer should support mutable collections - ie with an implicit > 'add' and 'remove' action. > but see comments underneath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1732) Document "hidden" as a supported method for services.
[
https://issues.apache.org/jira/browse/ISIS-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1732:
--
Fix Version/s: (was: 2.0.0-M5)
> Document "hidden" as a supported method for services.
> -
>
> Key: ISIS-1732
> URL: https://issues.apache.org/jira/browse/ISIS-1732
> Project: Isis
> Issue Type: Improvement
> Components: Isis Docs & Website
>Affects Versions: 1.15.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> eg, in kitchensink, we have:
> {code}
> public abstract class RepositoryAbstract {
> private final Class cls;
> public RepositoryAbstract(Class cls, Visibility visibility) {
> this.cls = cls;
> this.visibility = visibility;
> }
> //region > visibility
> private final Visibility visibility;
> protected enum Visibility {
> VISIBLE,
> NOT_VISIBLE
> }
> public boolean hidden() {
> return this.visibility == Visibility.NOT_VISIBLE;
> }
> //endregion
>
> {code}
> and then:
> {code}
> @DomainService(
> repositoryFor = ChildObject.class
> )
> public class ChildObjects extends RepositoryAbstract {
> public ChildObjects() {
> super(ChildObject.class, Visibility.NOT_VISIBLE);
> }
> public ChildObject create(
> final String name,
> final ParentObject parentObject) {
> return repositoryService.persist(ChildObject.create(name,
> parentObject));
> }
> public List listAll() {
> return repositoryService.allInstances(ChildObject.class);
> }
> }
> {code}
> if use super(...VISIBLE) then this service appears in the menu. so,
> "hidden()" is a way of globally hiding an object (or a domain service, at
> least).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-1815) Log URL for when we get Tomcat ClientConnection closed error (which we think is mostly due to slow response and users getting tired of waiting).
[ https://issues.apache.org/jira/browse/ISIS-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1815: -- Fix Version/s: (was: 2.0.0-M5) > Log URL for when we get Tomcat ClientConnection closed error (which we think > is mostly due to slow response and users getting tired of waiting). > > > Key: ISIS-1815 > URL: https://issues.apache.org/jira/browse/ISIS-1815 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Affects Versions: 1.16.0 >Reporter: Daniel Keir Haywood >Priority: Critical > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1898) Use Joda Interval for LocalDate collection parameter
[
https://issues.apache.org/jira/browse/ISIS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1898:
--
Fix Version/s: (was: 2.0.0-M5)
> Use Joda Interval for LocalDate collection parameter
>
>
> Key: ISIS-1898
> URL: https://issues.apache.org/jira/browse/ISIS-1898
> Project: Isis
> Issue Type: Improvement
> Components: Isis Applib (programming model)
>Affects Versions: 1.16.1
>Reporter: Sander Ginn
>Priority: Major
>
> {code:java}
> // code placeholder
> {code}
> To accommodate to the requirement of a {{choicesXxx}}/{{autoCompleteXxx}}
> method for a collection parameter on an action, it would be useful to be able
> to return a Joda Interval instead of a collection of LocalDates.
> Furthermore, it is desirable that the available options are offered through
> the date picker that is currently used for single LocalDate parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2059) Allow Wicket viewer caching strategy (timestamp or digest) to be selected via config property.
[ https://issues.apache.org/jira/browse/ISIS-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2059: -- Fix Version/s: (was: 2.0.0-M5) > Allow Wicket viewer caching strategy (timestamp or digest) to be selected via > config property. > -- > > Key: ISIS-2059 > URL: https://issues.apache.org/jira/browse/ISIS-2059 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Priority: Minor > > There is already some commented-out code in IsisWicketApplication. > // getResourceSettings().setCachingStrategy( > // new FilenameWithVersionResourceCachingStrategy( > // new CachingResourceVersion( > // new MessageDigestResourceVersion(; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1995) Render collection of objects as panels
[ https://issues.apache.org/jira/browse/ISIS-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1995: -- Fix Version/s: (was: 2.0.0-M5) > Render collection of objects as panels > -- > > Key: ISIS-1995 > URL: https://issues.apache.org/jira/browse/ISIS-1995 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1922) Session Timeout Indication
[ https://issues.apache.org/jira/browse/ISIS-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1922: -- Fix Version/s: (was: 2.0.0-M5) > Session Timeout Indication > -- > > Key: ISIS-1922 > URL: https://issues.apache.org/jira/browse/ISIS-1922 > Project: Isis > Issue Type: Improvement > Components: Isis Viewer Wicket >Reporter: Andi Huber >Priority: Major > > Eg when a user clicks on a Menu Item, while the session has already timed > out, the session silently refreshes and no action is executed. > From a user's perspective, she/he experiences an application that sometimes > is ignoring clicks. > We should a least show a fade-in/out message to give a user friendly > notification, that her/his session was timed out and hence needed to be > refreshed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1953) @NotPersistable is deprecated but javadoc is missing instructions
[ https://issues.apache.org/jira/browse/ISIS-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-1953: -- Fix Version/s: (was: 2.0.0-M5) > @NotPersistable is deprecated but javadoc is missing instructions > - > > Key: ISIS-1953 > URL: https://issues.apache.org/jira/browse/ISIS-1953 > Project: Isis > Issue Type: Improvement > Components: Isis Docs & Website >Affects Versions: 1.16.0 >Reporter: Jörg Rade >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-1873) Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then assume veto and log a WARNing.
[
https://issues.apache.org/jira/browse/ISIS-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-1873:
--
Fix Version/s: (was: 2.0.0-M5)
> Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then
> assume veto and log a WARNing.
>
>
> Key: ISIS-1873
> URL: https://issues.apache.org/jira/browse/ISIS-1873
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Affects Versions: 1.16.1
>Reporter: Daniel Keir Haywood
>Priority: Major
>
> Currently the framework doesn't degrade gracefully.
> For example, had a coding error in a hideXxx() method.
> This resulted in the error page, rather than simply hide the relevant member.
> {code:java}
> org.eclipse.jetty.util.thread.QueuedThreadPool#runJob(QueuedThreadPool.java:672)
> org.eclipse.jetty.util.thread.QueuedThreadPool$2#run(QueuedThreadPool.java:590)
> java.lang.Thread#run(Thread.java:745)
> Caused by:
> java.lang.NullPointerException
> org.isisaddons.module.command.dom.CommandJdo#hideReplayStateFailureReason(CommandJdo.java:386)
> sun.reflect.NativeMethodAccessorImpl#invoke0(NativeMethodAccessorImpl.java:-2)
> sun.reflect.NativeMethodAccessorImpl#invoke(NativeMethodAccessorImpl.java:62)
> sun.reflect.DelegatingMethodAccessorImpl#invoke(DelegatingMethodAccessorImpl.java:43)
> java.lang.reflect.Method#invoke(Method.java:498)
> org.apache.isis.core.commons.lang.MethodExtensions#invoke(MethodExtensions.java:53)
> org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils#invoke(ObjectAdapter.java:38{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (ISIS-1926) Why do we create an ActionInvocationDto for a mixin property anyway ?
[ https://issues.apache.org/jira/browse/ISIS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-1926: - Fix Version/s: (was: 2.0.0-M5) Assignee: (was: Daniel Keir Haywood) > Why do we create an ActionInvocationDto for a mixin property anyway ? > - > > Key: ISIS-1926 > URL: https://issues.apache.org/jira/browse/ISIS-1926 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Affects Versions: 1.16.2 >Reporter: Daniel Keir Haywood >Priority: Minor > > see ISIS-1925 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2164) OpenTracing integration
[ https://issues.apache.org/jira/browse/ISIS-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2164: -- Fix Version/s: (was: 2.0.0-M5) 2.0.0 > OpenTracing integration > --- > > Key: ISIS-2164 > URL: https://issues.apache.org/jira/browse/ISIS-2164 > Project: Isis > Issue Type: New Feature > Components: Isis Viewer Wicket >Affects Versions: 1.17.0 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2168) Floating Point Value Types must support Scientific Notation
[ https://issues.apache.org/jira/browse/ISIS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2168: -- Fix Version/s: (was: 2.0.0-M5) > Floating Point Value Types must support Scientific Notation > --- > > Key: ISIS-2168 > URL: https://issues.apache.org/jira/browse/ISIS-2168 > Project: Isis > Issue Type: Bug > Components: Isis Viewer Wicket >Reporter: Andi Huber >Priority: Major > > given a property of type Double, when you enter 1e-9 in the editable field, > this is not recognized; > even worse: entering 0.1 ends up being rendered as 0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-2096) Extend ReasonBuffer in the applib.
[ https://issues.apache.org/jira/browse/ISIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-2096: - Fix Version/s: (was: 2.0.0-M5) Assignee: (was: Daniel Keir Haywood) > Extend ReasonBuffer in the applib. > -- > > Key: ISIS-2096 > URL: https://issues.apache.org/jira/browse/ISIS-2096 > Project: Isis > Issue Type: New Feature >Affects Versions: 2.0.0-M2 >Reporter: Daniel Keir Haywood >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-2122) adviseXxx(), a softer version of validateXxx().
[ https://issues.apache.org/jira/browse/ISIS-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-2122: - Assignee: (was: Daniel Keir Haywood) > adviseXxx(), a softer version of validateXxx(). > --- > > Key: ISIS-2122 > URL: https://issues.apache.org/jira/browse/ISIS-2122 > Project: Isis > Issue Type: Improvement > Components: Isis Applib (programming model) >Reporter: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > more discussion at > [https://lists.apache.org/thread.html/bd8a407ceb0e07cc42c1b7eb85e266817b802a11fccf05819c9c4812@%3Cusers.isis.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2232) Remove support for domain services contributing properties, collections or actions. (Use mixins instead).
[
https://issues.apache.org/jira/browse/ISIS-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood resolved ISIS-2232.
---
Resolution: Fixed
> Remove support for domain services contributing properties, collections or
> actions. (Use mixins instead).
> --
>
> Key: ISIS-2232
> URL: https://issues.apache.org/jira/browse/ISIS-2232
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Hit an issue where there's an error in contributed properties (from service)
> throwing NPE, due to mismatch of push/pop with interactoin execution graph.
> Mixins work fine.
> Rather than fix the inconsistency, think it's better to now remove that
> functionality (as we've planned a long while now).
>
> Details of the problem encountered:
> in the current HEAD (2.0.0-M3-SNAPSHOT), I am getting an NPE as the result of
> the presence of this contributed action (nb: contributed from a service):
>
> {code:java}
> public class SimpleObjects {
> @Action(semantics = SemanticsOf.SAFE)
> public SimpleObject search(final SimpleObject simpleObject) {
> return simpleObject;
> }
> public List autoComplete0Search(final String search) {
> return findByName(search);
> }
> ...
> }{code}
>
> The NPE occurs in the stuff around Interaction's execution:
> h3. Stack trace:
> * java.lang.NullPointerException
> *
> *
> org.apache.isis.applib.util.schema.MemberExecutionDtoUtils#metricsFor(MemberExecutionDtoUtils.java:77)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#metricsFor(Interaction.java:640)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#access$200(Interaction.java:582)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When$2#syncMetrics(Interaction.java:613)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#syncMetrics(Interaction.java:660)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#setCompletedAt(Interaction.java:503)
> * org.apache.isis.applib.services.iactn.Interaction#pop(Interaction.java:246)
> *
> org.apache.isis.applib.services.iactn.Interaction#executeInternal(Interaction.java:193)
> *
> org.apache.isis.applib.services.iactn.Interaction#execute(Interaction.java:142)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#doInvoke(ActionInvocationFacetForDomainEventAbstract.java:208)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#lambda$invoke$0(ActionInvocationFacetForDomainEventAbstract.java:129)
> *
> org.apache.isis.runtime.services.xactn.TransactionServiceSpring#executeWithinTransaction(TransactionServiceSpring.java:149)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#invoke(ActionInvocationFacetForDomainEventAbstract.java:128)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#executeInternal(ObjectActionDefault.java:423)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#execute(ObjectActionDefault.java:409)
> *
> org.apache.isis.metamodel.specloader.specimpl.OneToOneAssociationContributee#get(OneToOneAssociationContributee.java:117)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#setObjectFromPropertyIfVisible(ScalarModel.java:761)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#access$200(ScalarModel.java:83)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#reset(ScalarModel.java:315)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#init(ScalarModel.java:305)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#init(ScalarModel.java:729)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#(ScalarModel.java:724)
> *
> org.apache.isis.viewer.wicket.model.models.EntityModel#getPropertyModel(EntityModel.java:367)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#addPropertyToForm(PropertyGroup.java:215)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#buildGui(PropertyGroup.java:117)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#(PropertyGroup.java:81)
>
> we can see that 'pop' is called but there's no execution to work upon; the
> stack trace tells us that we're in the render phase and evaluating this
> contributed property (as an action) to reset the model of the rendered entity.
>
> FWIW, with this mixin:
> {code:java}
> @Mixin(m
[jira] [Assigned] (ISIS-2232) Remove support for domain services contributing properties, collections or actions. (Use mixins instead).
[
https://issues.apache.org/jira/browse/ISIS-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood reassigned ISIS-2232:
-
Assignee: Andi Huber (was: Andi Huber)
> Remove support for domain services contributing properties, collections or
> actions. (Use mixins instead).
> --
>
> Key: ISIS-2232
> URL: https://issues.apache.org/jira/browse/ISIS-2232
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Hit an issue where there's an error in contributed properties (from service)
> throwing NPE, due to mismatch of push/pop with interactoin execution graph.
> Mixins work fine.
> Rather than fix the inconsistency, think it's better to now remove that
> functionality (as we've planned a long while now).
>
> Details of the problem encountered:
> in the current HEAD (2.0.0-M3-SNAPSHOT), I am getting an NPE as the result of
> the presence of this contributed action (nb: contributed from a service):
>
> {code:java}
> public class SimpleObjects {
> @Action(semantics = SemanticsOf.SAFE)
> public SimpleObject search(final SimpleObject simpleObject) {
> return simpleObject;
> }
> public List autoComplete0Search(final String search) {
> return findByName(search);
> }
> ...
> }{code}
>
> The NPE occurs in the stuff around Interaction's execution:
> h3. Stack trace:
> * java.lang.NullPointerException
> *
> *
> org.apache.isis.applib.util.schema.MemberExecutionDtoUtils#metricsFor(MemberExecutionDtoUtils.java:77)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#metricsFor(Interaction.java:640)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#access$200(Interaction.java:582)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When$2#syncMetrics(Interaction.java:613)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#syncMetrics(Interaction.java:660)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#setCompletedAt(Interaction.java:503)
> * org.apache.isis.applib.services.iactn.Interaction#pop(Interaction.java:246)
> *
> org.apache.isis.applib.services.iactn.Interaction#executeInternal(Interaction.java:193)
> *
> org.apache.isis.applib.services.iactn.Interaction#execute(Interaction.java:142)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#doInvoke(ActionInvocationFacetForDomainEventAbstract.java:208)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#lambda$invoke$0(ActionInvocationFacetForDomainEventAbstract.java:129)
> *
> org.apache.isis.runtime.services.xactn.TransactionServiceSpring#executeWithinTransaction(TransactionServiceSpring.java:149)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#invoke(ActionInvocationFacetForDomainEventAbstract.java:128)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#executeInternal(ObjectActionDefault.java:423)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#execute(ObjectActionDefault.java:409)
> *
> org.apache.isis.metamodel.specloader.specimpl.OneToOneAssociationContributee#get(OneToOneAssociationContributee.java:117)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#setObjectFromPropertyIfVisible(ScalarModel.java:761)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#access$200(ScalarModel.java:83)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#reset(ScalarModel.java:315)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#init(ScalarModel.java:305)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#init(ScalarModel.java:729)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#(ScalarModel.java:724)
> *
> org.apache.isis.viewer.wicket.model.models.EntityModel#getPropertyModel(EntityModel.java:367)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#addPropertyToForm(PropertyGroup.java:215)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#buildGui(PropertyGroup.java:117)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#(PropertyGroup.java:81)
>
> we can see that 'pop' is called but there's no execution to work upon; the
> stack trace tells us that we're in the render phase and evaluating this
> contributed property (as an action) to reset the model of the rendered entity.
>
> FWIW, with this mixi
[jira] [Assigned] (ISIS-2232) Remove support for domain services contributing properties, collections or actions. (Use mixins instead).
[
https://issues.apache.org/jira/browse/ISIS-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood reassigned ISIS-2232:
-
Assignee: Andi Huber (was: Daniel Keir Haywood)
> Remove support for domain services contributing properties, collections or
> actions. (Use mixins instead).
> --
>
> Key: ISIS-2232
> URL: https://issues.apache.org/jira/browse/ISIS-2232
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Hit an issue where there's an error in contributed properties (from service)
> throwing NPE, due to mismatch of push/pop with interactoin execution graph.
> Mixins work fine.
> Rather than fix the inconsistency, think it's better to now remove that
> functionality (as we've planned a long while now).
>
> Details of the problem encountered:
> in the current HEAD (2.0.0-M3-SNAPSHOT), I am getting an NPE as the result of
> the presence of this contributed action (nb: contributed from a service):
>
> {code:java}
> public class SimpleObjects {
> @Action(semantics = SemanticsOf.SAFE)
> public SimpleObject search(final SimpleObject simpleObject) {
> return simpleObject;
> }
> public List autoComplete0Search(final String search) {
> return findByName(search);
> }
> ...
> }{code}
>
> The NPE occurs in the stuff around Interaction's execution:
> h3. Stack trace:
> * java.lang.NullPointerException
> *
> *
> org.apache.isis.applib.util.schema.MemberExecutionDtoUtils#metricsFor(MemberExecutionDtoUtils.java:77)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#metricsFor(Interaction.java:640)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#access$200(Interaction.java:582)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When$2#syncMetrics(Interaction.java:613)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#syncMetrics(Interaction.java:660)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#setCompletedAt(Interaction.java:503)
> * org.apache.isis.applib.services.iactn.Interaction#pop(Interaction.java:246)
> *
> org.apache.isis.applib.services.iactn.Interaction#executeInternal(Interaction.java:193)
> *
> org.apache.isis.applib.services.iactn.Interaction#execute(Interaction.java:142)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#doInvoke(ActionInvocationFacetForDomainEventAbstract.java:208)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#lambda$invoke$0(ActionInvocationFacetForDomainEventAbstract.java:129)
> *
> org.apache.isis.runtime.services.xactn.TransactionServiceSpring#executeWithinTransaction(TransactionServiceSpring.java:149)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#invoke(ActionInvocationFacetForDomainEventAbstract.java:128)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#executeInternal(ObjectActionDefault.java:423)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#execute(ObjectActionDefault.java:409)
> *
> org.apache.isis.metamodel.specloader.specimpl.OneToOneAssociationContributee#get(OneToOneAssociationContributee.java:117)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#setObjectFromPropertyIfVisible(ScalarModel.java:761)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#access$200(ScalarModel.java:83)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#reset(ScalarModel.java:315)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#init(ScalarModel.java:305)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#init(ScalarModel.java:729)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#(ScalarModel.java:724)
> *
> org.apache.isis.viewer.wicket.model.models.EntityModel#getPropertyModel(EntityModel.java:367)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#addPropertyToForm(PropertyGroup.java:215)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#buildGui(PropertyGroup.java:117)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#(PropertyGroup.java:81)
>
> we can see that 'pop' is called but there's no execution to work upon; the
> stack trace tells us that we're in the render phase and evaluating this
> contributed property (as an action) to reset the model of the rendered entity.
>
> FWIW, with
[jira] [Updated] (ISIS-2232) Remove support for domain services contributing properties, collections or actions. (Use mixins instead).
[
https://issues.apache.org/jira/browse/ISIS-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-2232:
--
Fix Version/s: (was: 2.0.0-M5)
2.0.0-M4
> Remove support for domain services contributing properties, collections or
> actions. (Use mixins instead).
> --
>
> Key: ISIS-2232
> URL: https://issues.apache.org/jira/browse/ISIS-2232
> Project: Isis
> Issue Type: Improvement
> Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Hit an issue where there's an error in contributed properties (from service)
> throwing NPE, due to mismatch of push/pop with interactoin execution graph.
> Mixins work fine.
> Rather than fix the inconsistency, think it's better to now remove that
> functionality (as we've planned a long while now).
>
> Details of the problem encountered:
> in the current HEAD (2.0.0-M3-SNAPSHOT), I am getting an NPE as the result of
> the presence of this contributed action (nb: contributed from a service):
>
> {code:java}
> public class SimpleObjects {
> @Action(semantics = SemanticsOf.SAFE)
> public SimpleObject search(final SimpleObject simpleObject) {
> return simpleObject;
> }
> public List autoComplete0Search(final String search) {
> return findByName(search);
> }
> ...
> }{code}
>
> The NPE occurs in the stuff around Interaction's execution:
> h3. Stack trace:
> * java.lang.NullPointerException
> *
> *
> org.apache.isis.applib.util.schema.MemberExecutionDtoUtils#metricsFor(MemberExecutionDtoUtils.java:77)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#metricsFor(Interaction.java:640)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When#access$200(Interaction.java:582)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution$When$2#syncMetrics(Interaction.java:613)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#syncMetrics(Interaction.java:660)
> *
> org.apache.isis.applib.services.iactn.Interaction$Execution#setCompletedAt(Interaction.java:503)
> * org.apache.isis.applib.services.iactn.Interaction#pop(Interaction.java:246)
> *
> org.apache.isis.applib.services.iactn.Interaction#executeInternal(Interaction.java:193)
> *
> org.apache.isis.applib.services.iactn.Interaction#execute(Interaction.java:142)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#doInvoke(ActionInvocationFacetForDomainEventAbstract.java:208)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#lambda$invoke$0(ActionInvocationFacetForDomainEventAbstract.java:129)
> *
> org.apache.isis.runtime.services.xactn.TransactionServiceSpring#executeWithinTransaction(TransactionServiceSpring.java:149)
> *
> org.apache.isis.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract#invoke(ActionInvocationFacetForDomainEventAbstract.java:128)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#executeInternal(ObjectActionDefault.java:423)
> *
> org.apache.isis.metamodel.specloader.specimpl.ObjectActionDefault#execute(ObjectActionDefault.java:409)
> *
> org.apache.isis.metamodel.specloader.specimpl.OneToOneAssociationContributee#get(OneToOneAssociationContributee.java:117)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#setObjectFromPropertyIfVisible(ScalarModel.java:761)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#access$200(ScalarModel.java:83)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#reset(ScalarModel.java:315)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel$Kind$1#init(ScalarModel.java:305)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#init(ScalarModel.java:729)
> *
> org.apache.isis.viewer.wicket.model.models.ScalarModel#(ScalarModel.java:724)
> *
> org.apache.isis.viewer.wicket.model.models.EntityModel#getPropertyModel(EntityModel.java:367)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#addPropertyToForm(PropertyGroup.java:215)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#buildGui(PropertyGroup.java:117)
> *
> org.apache.isis.viewer.wicket.ui.components.entity.fieldset.PropertyGroup#(PropertyGroup.java:81)
>
> we can see that 'pop' is called but there's no execution to work upon; the
> stack trace tells us that we're in the render phase and evaluating this
> contributed property (as an action) to reset the model of the rendered entity.
>
[jira] [Resolved] (ISIS-2276) BackgroundCommandExecution - should use a different persistent session for each command
[ https://issues.apache.org/jira/browse/ISIS-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2276. --- Resolution: Fixed This functionality has been superceded by reworking of CommandService and async actions. > BackgroundCommandExecution - should use a different persistent session for > each command > --- > > Key: ISIS-2276 > URL: https://issues.apache.org/jira/browse/ISIS-2276 > Project: Isis > Issue Type: Improvement > Components: Isis Core >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M5 > > > To avoid memory starvation if submit lots of work to be performed in the > background. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ISIS-2278) Reinstate background commands for entities, incorporate fix ISIS-2277 from v1
[ https://issues.apache.org/jira/browse/ISIS-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood resolved ISIS-2278. --- Resolution: Fixed This has been incorporated into the reworking of Command along with WrapperFactory async actions. > Reinstate background commands for entities, incorporate fix ISIS-2277 from v1 > - > > Key: ISIS-2278 > URL: https://issues.apache.org/jira/browse/ISIS-2278 > Project: Isis > Issue Type: Improvement > Components: Isis Core, Isis Extensions >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2278) Reinstate background commands for entities, incorporate fix ISIS-2277 from v1
[ https://issues.apache.org/jira/browse/ISIS-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood updated ISIS-2278: -- Fix Version/s: (was: 2.0.0-M5) 2.0.0-M4 > Reinstate background commands for entities, incorporate fix ISIS-2277 from v1 > - > > Key: ISIS-2278 > URL: https://issues.apache.org/jira/browse/ISIS-2278 > Project: Isis > Issue Type: Improvement > Components: Isis Core, Isis Extensions >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Major > Fix For: 2.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ISIS-2329) Support nested non-static mixins, with domain event class declared within.
[
https://issues.apache.org/jira/browse/ISIS-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood reassigned ISIS-2329:
-
Assignee: (was: Andi Huber)
> Support nested non-static mixins, with domain event class declared within.
> --
>
> Key: ISIS-2329
> URL: https://issues.apache.org/jira/browse/ISIS-2329
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M5
>
>
> To support this, need to allow action domain events to have 1-arg
> constructor, being the mixee.
> eg, at the moment, in simpleapp, I can refactor updateName into a mixin:
> {code:java}
> public static class UpdateNameActionDomainEvent
> extends SimpleModule.ActionDomainEvent { }
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing =
> Publishing.DISABLED,
> associateWith = "name", domainEvent =
> UpdateNotesActionDomainEvent.class)
> public class updateName {
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
> {code}
> but the UpdateNameActionDomainEvent has to remain outside for now. Instead,
> I'd like to write:
> {code:java}
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing =
> Publishing.DISABLED,
> associateWith = "name", domainEvent =
> UpdateNotesActionDomainEvent.class)
> public class updateName {
>public class UpdateNameActionDomainEvent
> extends SimpleModule.ActionDomainEvent { }
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
> {code}
> The fix should be quite simple: improve the instantiation logic in
> DomainEventHelper to handle events with 1 arg as well as 0 args and 3 args.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (ISIS-2301) Docs for new IsisInteractionScope
[ https://issues.apache.org/jira/browse/ISIS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Keir Haywood reassigned ISIS-2301: - Assignee: (was: Andi Huber) > Docs for new IsisInteractionScope > - > > Key: ISIS-2301 > URL: https://issues.apache.org/jira/browse/ISIS-2301 > Project: Isis > Issue Type: Improvement > Components: Isis Docs & Website >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M5 > > Attachments: image (2).png, image (3).png > > > We allow IsisInteractions to be nested. The @IsisInteractionScope is always > bound to the top-level IsisInteraction of the current thread's session stack. > (first stack element, aka bottom of stack) > Isis (not Spring) is aware, when any IsisInteractionScope ends. So at the end > of each IsisInteractionScope, we call the destruction runnables on the > IsisInteractionScope-d beans that belong to the current thread, then clear > the IsisInteraction stack (of the current thread). (edited) > The IsisInteractionScope-d beans are managed by Spring, that is Spring > creates them and registers their destruction runnables. > Requires Provider idiom: we fail early if one tries to inject an > IsisInteractionScope-d bean directly. The thrown exception gives a hint, how > to fix it. (Use the Provider<> idiom instead) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ISIS-2360) document how to specify the timezone
[
https://issues.apache.org/jira/browse/ISIS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-2360:
--
Summary: document how to specify the timezone (was: how to specify the
timezone)
> document how to specify the timezone
>
>
> Key: ISIS-2360
> URL: https://issues.apache.org/jira/browse/ISIS-2360
> Project: Isis
> Issue Type: Documentation
>Affects Versions: 1.17.0, 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> Defaults.setTimeZone(DateTimeZone.forTimeZone(TimeZone.getTimeZone("Europe/Amsterdam")));
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ISIS-2360) document how to specify the timezone
[
https://issues.apache.org/jira/browse/ISIS-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Keir Haywood updated ISIS-2360:
--
Component/s: Isis Docs & Website
> document how to specify the timezone
>
>
> Key: ISIS-2360
> URL: https://issues.apache.org/jira/browse/ISIS-2360
> Project: Isis
> Issue Type: Documentation
> Components: Isis Docs & Website
>Affects Versions: 1.17.0, 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> Defaults.setTimeZone(DateTimeZone.forTimeZone(TimeZone.getTimeZone("Europe/Amsterdam")));
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
