[GitHub] [isis] andi-huber merged pull request #1174: Bump vaadin.version from 23.2.7 to 23.2.8
andi-huber merged PR #1174: URL: https://github.com/apache/isis/pull/1174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [isis] dependabot[bot] opened a new pull request, #1174: Bump vaadin.version from 23.2.7 to 23.2.8
dependabot[bot] opened a new pull request, #1174: URL: https://github.com/apache/isis/pull/1174 Bumps `vaadin.version` from 23.2.7 to 23.2.8. Updates `vaadin-bom` from 23.2.7 to 23.2.8 Updates `vaadin-maven-plugin` from 23.2.7 to 23.2.8 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ISIS-3268) [Wicket Viewer] Action parameter layout LabelPosition might get ignored (based on chance)
[
https://issues.apache.org/jira/browse/ISIS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630847#comment-17630847
]
ASF subversion and git services commented on ISIS-3268:
---
Commit 71552b21a70754f19c66d3e05838aa78d747f766 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=71552b21a7 ]
ISIS-3268: MM regr test approval
> [Wicket Viewer] Action parameter layout LabelPosition might get ignored
> (based on chance)
> -
>
> Key: ISIS-3268
> URL: https://issues.apache.org/jira/browse/ISIS-3268
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M9
>Reporter: Zermelo
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> Action parameter labels are not rendered on top in production mode (even if
> the PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode
> only.
> To reproduce on SimpleApp:
> * Add LabelPosition.TOP to SimpleObject.updateName action name parameter.
> public SimpleObject updateName(
> {color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
> {color}final String name) {
> * Disable Prototyping mode in SimpleApp.main
> ** {color:#4c9aff}//{color}IsisPresets.prototyping();
> * Make seeds run while not in prototyping. In SeedSecurityService:
> ** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
> isisSystemEnvironment.isPrototyping()) {
> {color:#4c9aff}if (event.isPostMetamodel()) {{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ISIS-3268) [Wicket Viewer] Action parameter layout LabelPosition might get ignored (based on chance)
[
https://issues.apache.org/jira/browse/ISIS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber resolved ISIS-3268.
--
Resolution: Fixed
> [Wicket Viewer] Action parameter layout LabelPosition might get ignored
> (based on chance)
> -
>
> Key: ISIS-3268
> URL: https://issues.apache.org/jira/browse/ISIS-3268
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M9
>Reporter: Zermelo
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> Action parameter labels are not rendered on top in production mode (even if
> the PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode
> only.
> To reproduce on SimpleApp:
> * Add LabelPosition.TOP to SimpleObject.updateName action name parameter.
> public SimpleObject updateName(
> {color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
> {color}final String name) {
> * Disable Prototyping mode in SimpleApp.main
> ** {color:#4c9aff}//{color}IsisPresets.prototyping();
> * Make seeds run while not in prototyping. In SeedSecurityService:
> ** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
> isisSystemEnvironment.isPrototyping()) {
> {color:#4c9aff}if (event.isPostMetamodel()) {{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3268) [Wicket Viewer] Action parameter layout LabelPosition might get ignored (based on chance)
[
https://issues.apache.org/jira/browse/ISIS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630833#comment-17630833
]
ASF subversion and git services commented on ISIS-3268:
---
Commit abdca3e3791c85817821ffa9e0a92ce18c16f1b7 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=abdca3e379 ]
ISIS-3268: fixes facet precedence too high for
LabelAtFacetFromLayoutConfiguration
- must be lower than precedence of facets from annotations
> [Wicket Viewer] Action parameter layout LabelPosition might get ignored
> (based on chance)
> -
>
> Key: ISIS-3268
> URL: https://issues.apache.org/jira/browse/ISIS-3268
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M9
>Reporter: Zermelo
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> Action parameter labels are not rendered on top in production mode (even if
> the PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode
> only.
> To reproduce on SimpleApp:
> * Add LabelPosition.TOP to SimpleObject.updateName action name parameter.
> public SimpleObject updateName(
> {color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
> {color}final String name) {
> * Disable Prototyping mode in SimpleApp.main
> ** {color:#4c9aff}//{color}IsisPresets.prototyping();
> * Make seeds run while not in prototyping. In SeedSecurityService:
> ** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
> isisSystemEnvironment.isPrototyping()) {
> {color:#4c9aff}if (event.isPostMetamodel()) {{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
