[jira] [Created] (ISIS-3269) Selecting the empty item from the choices of an optional parameter throws exception
Zermelo created ISIS-3269:
-
Summary: Selecting the empty item from the choices of an optional
parameter throws exception
Key: ISIS-3269
URL: https://issues.apache.org/jira/browse/ISIS-3269
Project: Isis
Issue Type: Bug
Components: Isis Viewer Wicket
Affects Versions: 2.0.0-M9
Reporter: Zermelo
Attachments: SelectingNoneThrowsAnException.mov
In wicket viewer, selecting the empty (none) item from the select box (choices)
of an optional action parameter throws an exception. I experience it both with
Enum parameters and String parameters.
To test it, you can add this snippet to SimpleObjects.java in SimpleApp.
{code:java}
public enum SomeOption {A, B, C}
@Action
public void a1(@Parameter(optionality = Optionality.OPTIONAL) SomeOption
someOption) {
}
@Action
public void a2(@Parameter(optionality = Optionality.OPTIONAL) String
someOption) {
}
@MemberSupport
public List choices0A2() {
return Arrays.asList("A", "B", "C");
} {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ISIS-3268) Action parameter LabelPosition.TOP does not work in production (vs. prototyping) mode
[
https://issues.apache.org/jira/browse/ISIS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3268:
--
Description:
Action parameter labels are not rendered on top in production mode (even if the
PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode only.
To reproduce on SimpleApp:
* Add LabelPosition.TOP to SimpleObject.updateName action name parameter.
public SimpleObject updateName(
{color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
{color}final String name) {
* Disable Prototyping mode in SimpleApp.main
** {color:#4c9aff}//{color}IsisPresets.prototyping();
* Make seeds run while not in prototyping. In SeedSecurityService:
** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
isisSystemEnvironment.isPrototyping()) {
{color:#4c9aff}if (event.isPostMetamodel()) {{color}
was:
Action parameter labels are not rendered on top in production mode (even if the
PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode only.
To reproduce on SimpleApp:
* Add LabelPosition.TOP to SimpleObject.updateName action name
parameter.public SimpleObject updateName(
{color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
{color}final String name) {
* Disable Prototyping mode in SimpleApp.main
** {color:#4c9aff}//{color}IsisPresets.prototyping();
* Make seeds run while not in prototyping. In SeedSecurityService:
** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
isisSystemEnvironment.isPrototyping()) {
{color:#4c9aff}if (event.isPostMetamodel()) {{color}
> Action parameter LabelPosition.TOP does not work in production (vs.
> prototyping) mode
> -
>
> Key: ISIS-3268
> URL: https://issues.apache.org/jira/browse/ISIS-3268
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Zermelo
>Priority: Minor
>
> Action parameter labels are not rendered on top in production mode (even if
> the PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode
> only.
> To reproduce on SimpleApp:
> * Add LabelPosition.TOP to SimpleObject.updateName action name parameter.
> public SimpleObject updateName(
> {color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
> {color}final String name) {
> * Disable Prototyping mode in SimpleApp.main
> ** {color:#4c9aff}//{color}IsisPresets.prototyping();
> * Make seeds run while not in prototyping. In SeedSecurityService:
> ** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
> isisSystemEnvironment.isPrototyping()) {
> {color:#4c9aff}if (event.isPostMetamodel()) {{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ISIS-3268) Action parameter LabelPosition.TOP does not work in production (vs. prototyping) mode
Zermelo created ISIS-3268:
-
Summary: Action parameter LabelPosition.TOP does not work in
production (vs. prototyping) mode
Key: ISIS-3268
URL: https://issues.apache.org/jira/browse/ISIS-3268
Project: Isis
Issue Type: Bug
Components: Isis Viewer Wicket
Reporter: Zermelo
Action parameter labels are not rendered on top in production mode (even if the
PromptStyle is DIALOG_MODAL). It renders on top while in prototyping mode only.
To reproduce on SimpleApp:
* Add LabelPosition.TOP to SimpleObject.updateName action name
parameter.public SimpleObject updateName(
{color:#4c9aff}@ParameterLayout(labelPosition = LabelPosition.TOP)
{color}final String name) {
* Disable Prototyping mode in SimpleApp.main
** {color:#4c9aff}//{color}IsisPresets.prototyping();
* Make seeds run while not in prototyping. In SeedSecurityService:
** {color:#4c9aff}//{color}if (event.isPostMetamodel() &&
isisSystemEnvironment.isPrototyping()) {
{color:#4c9aff}if (event.isPostMetamodel()) {{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ISIS-3201) Default methods not triggered after changing a date parameter with date picker
[
https://issues.apache.org/jira/browse/ISIS-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3201:
--
Description:
{code:java}
import lombok.RequiredArgsConstructor;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.MinLength;
import org.apache.isis.applib.annotation.PromptStyle;
import org.apache.isis.applib.services.repository.RepositoryService;
import javax.inject.Inject;
import java.time.LocalDate;
import java.util.List;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor(onConstructor_ = {@Inject})
public class Isis3201Demo {
public final Object target;
public Object act(
LocalDate aDate, String dependent) {
return target;
}
public String default1Act(LocalDate aDate) {
return "Current value of date parameter:" + aDate;
}
}
{code}
was:
{code:java}
import lombok.RequiredArgsConstructor;
import mono.isis.issues.isis3198.Isis3198DemoClass;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.MinLength;
import org.apache.isis.applib.annotation.PromptStyle;
import org.apache.isis.applib.services.repository.RepositoryService;
import javax.inject.Inject;
import java.time.LocalDate;
import java.util.List;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor(onConstructor_ = {@Inject})
public class Isis3201Demo {
@Inject
RepositoryService repositoryService;
public final Object target;
public Object act(
LocalDate aDate, String dependent) {
return target;
}
public String default1Act(LocalDate aDate) {
return "Current value of date parameter:" + aDate;
}
}
{code}
> Default methods not triggered after changing a date parameter with date picker
> --
>
> Key: ISIS-3201
> URL: https://issues.apache.org/jira/browse/ISIS-3201
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M7
>Reporter: Zermelo
>Priority: Blocker
> Attachments: ActionDateParameter.mov
>
>
> {code:java}
> import lombok.RequiredArgsConstructor;
> import org.apache.isis.applib.annotation.Action;
> import org.apache.isis.applib.annotation.ActionLayout;
> import org.apache.isis.applib.annotation.MinLength;
> import org.apache.isis.applib.annotation.PromptStyle;
> import org.apache.isis.applib.services.repository.RepositoryService;
> import javax.inject.Inject;
> import java.time.LocalDate;
> import java.util.List;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor(onConstructor_ = {@Inject})
> public class Isis3201Demo {
> public final Object target;
> public Object act(
> LocalDate aDate, String dependent) {
> return target;
> }
> public String default1Act(LocalDate aDate) {
> return "Current value of date parameter:" + aDate;
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ISIS-3201) Default methods not triggered after changing a date parameter with date picker
[
https://issues.apache.org/jira/browse/ISIS-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3201:
--
Attachment: ActionDateParameter.mov
> Default methods not triggered after changing a date parameter with date picker
> --
>
> Key: ISIS-3201
> URL: https://issues.apache.org/jira/browse/ISIS-3201
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M7
>Reporter: Zermelo
>Priority: Blocker
> Attachments: ActionDateParameter.mov
>
>
> {code:java}
> import lombok.RequiredArgsConstructor;
> import mono.isis.issues.isis3198.Isis3198DemoClass;
> import org.apache.isis.applib.annotation.Action;
> import org.apache.isis.applib.annotation.ActionLayout;
> import org.apache.isis.applib.annotation.MinLength;
> import org.apache.isis.applib.annotation.PromptStyle;
> import org.apache.isis.applib.services.repository.RepositoryService;
> import javax.inject.Inject;
> import java.time.LocalDate;
> import java.util.List;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor(onConstructor_ = {@Inject})
> public class Isis3201Demo {
> @Inject
> RepositoryService repositoryService;
> public final Object target;
> public Object act(
> LocalDate aDate, String dependent) {
> return target;
> }
> public String default1Act(LocalDate aDate) {
> return "Current value of date parameter:" + aDate;
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ISIS-3201) Default methods not triggered after changing a date parameter with date picker
[
https://issues.apache.org/jira/browse/ISIS-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3201:
--
Description:
{code:java}
import lombok.RequiredArgsConstructor;
import mono.isis.issues.isis3198.Isis3198DemoClass;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.MinLength;
import org.apache.isis.applib.annotation.PromptStyle;
import org.apache.isis.applib.services.repository.RepositoryService;
import javax.inject.Inject;
import java.time.LocalDate;
import java.util.List;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor(onConstructor_ = {@Inject})
public class Isis3201Demo {
@Inject
RepositoryService repositoryService;
public final Object target;
public Object act(
LocalDate aDate, String dependent) {
return target;
}
public String default1Act(LocalDate aDate) {
return "Current value of date parameter:" + aDate;
}
}
{code}
> Default methods not triggered after changing a date parameter with date picker
> --
>
> Key: ISIS-3201
> URL: https://issues.apache.org/jira/browse/ISIS-3201
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M7
>Reporter: Zermelo
>Priority: Blocker
>
> {code:java}
> import lombok.RequiredArgsConstructor;
> import mono.isis.issues.isis3198.Isis3198DemoClass;
> import org.apache.isis.applib.annotation.Action;
> import org.apache.isis.applib.annotation.ActionLayout;
> import org.apache.isis.applib.annotation.MinLength;
> import org.apache.isis.applib.annotation.PromptStyle;
> import org.apache.isis.applib.services.repository.RepositoryService;
> import javax.inject.Inject;
> import java.time.LocalDate;
> import java.util.List;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor(onConstructor_ = {@Inject})
> public class Isis3201Demo {
> @Inject
> RepositoryService repositoryService;
> public final Object target;
> public Object act(
> LocalDate aDate, String dependent) {
> return target;
> }
> public String default1Act(LocalDate aDate) {
> return "Current value of date parameter:" + aDate;
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ISIS-3201) Default methods not triggered after changing a date parameter with date picker
Zermelo created ISIS-3201: - Summary: Default methods not triggered after changing a date parameter with date picker Key: ISIS-3201 URL: https://issues.apache.org/jira/browse/ISIS-3201 Project: Isis Issue Type: Bug Components: Isis Viewer Wicket Affects Versions: 2.0.0-M7 Reporter: Zermelo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ISIS-3198) action parameter hiding problem & default method argument null
[
https://issues.apache.org/jira/browse/ISIS-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3198:
--
Description:
[https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189]
action parameter hiding problem
{code:java}
import lombok.RequiredArgsConstructor;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.PromptStyle;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor
public class Isis3198Demo {
public final Object target;
public Object act(String a, boolean showB, String b) {
return target;
}
public boolean hide2Act(String a, boolean showB) {
return !showB;
}
}
{code}
default method argument null
{code:java}
import lombok.RequiredArgsConstructor;
import org.apache.isis.applib.annotation.*;
import org.apache.isis.applib.services.repository.RepositoryService;
import javax.inject.Inject;
import java.util.Collection;
import java.util.List;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor(onConstructor_ = {@Inject})
public class Isis3198Demo2 {
@Inject
RepositoryService repositoryService;
public final Object target;
public Object act(
Isis3198DemoClass a, String dependentToA) {
return target;
}
public List autoComplete0Act(@MinLength(1) String input)
{
var c1 = new Isis3198DemoClass();
c1.setName(input + " item 1");
c1 = repositoryService.detachedEntity(c1);
repositoryService.persistAndFlush(c1);
var c2 = new Isis3198DemoClass();
c2.setName(input + " item 2");
c2 = repositoryService.detachedEntity(c2);
repositoryService.persistAndFlush(c2);
return List.of(c1, c2);
}
public String default1Act(Isis3198DemoClass a) {
return "Current value of A:" + a;
}
} {code}
{code:java}
import lombok.*;
import org.apache.isis.applib.annotation.DomainObject;
import org.apache.isis.applib.annotation.Nature;
import org.apache.isis.applib.annotation.Title;
import javax.persistence.Entity;
import javax.persistence.Id;
@DomainObject(logicalTypeName = "demo.Isis3198DemoClass")
@Entity
@Getter @Setter
public class Isis3198DemoClass {
@Id
@Title
private String name;
@Override
public String toString() {
return name;
}
}
{code}
was:
[https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189]
{code:java}
import lombok.RequiredArgsConstructor;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.PromptStyle;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor
public class Isis3198Demo {
public final Object target;
public Object act(String a, boolean showB, String b) {
return target;
}
public boolean hide2Act(String a, boolean showB) {
return !showB;
}
}{code}
> action parameter hiding problem & default method argument null
> --
>
> Key: ISIS-3198
> URL: https://issues.apache.org/jira/browse/ISIS-3198
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Zermelo
>Priority: Blocker
> Fix For: 2.0.0-M8
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189]
> action parameter hiding problem
> {code:java}
> import lombok.RequiredArgsConstructor;
> import org.apache.isis.applib.annotation.Action;
> import org.apache.isis.applib.annotation.ActionLayout;
> import org.apache.isis.applib.annotation.PromptStyle;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor
> public class Isis3198Demo {
> public final Object target;
> public Object act(String a, boolean showB, String b) {
> return target;
> }
> public boolean hide2Act(String a, boolean showB) {
> return !showB;
> }
> }
> {code}
>
> default method argument null
>
> {code:java}
> import lombok.RequiredArgsConstructor;
> import org.apache.isis.applib.annotation.*;
> import org.apache.isis.applib.services.repository.RepositoryService;
> import javax.inject.Inject;
> import java.util.Collection;
> import java.util.List;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor(onConstructor_ = {@Inject})
> public class Isis3198Demo2 {
> @Inject
> RepositoryService repositoryService;
> public final Object target;
> public Object act(
> Isis3198DemoClass a, String dependentToA) {
> return target;
> }
> public List autoComplete0Act(@MinLength(1) String
> input) {
> var c1 = new
[jira] [Updated] (ISIS-3198) action parameter hiding problem & default method argument null
[
https://issues.apache.org/jira/browse/ISIS-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zermelo updated ISIS-3198:
--
Description:
[https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189]
{code:java}
import lombok.RequiredArgsConstructor;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.ActionLayout;
import org.apache.isis.applib.annotation.PromptStyle;
@Action
@ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
@RequiredArgsConstructor
public class Isis3198Demo {
public final Object target;
public Object act(String a, boolean showB, String b) {
return target;
}
public boolean hide2Act(String a, boolean showB) {
return !showB;
}
}{code}
was:https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189
> action parameter hiding problem & default method argument null
> --
>
> Key: ISIS-3198
> URL: https://issues.apache.org/jira/browse/ISIS-3198
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Zermelo
>Priority: Blocker
> Fix For: 2.0.0-M8
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189]
>
> {code:java}
> import lombok.RequiredArgsConstructor;
> import org.apache.isis.applib.annotation.Action;
> import org.apache.isis.applib.annotation.ActionLayout;
> import org.apache.isis.applib.annotation.PromptStyle;
> @Action
> @ActionLayout(promptStyle = PromptStyle.DIALOG_MODAL)
> @RequiredArgsConstructor
> public class Isis3198Demo {
> public final Object target;
> public Object act(String a, boolean showB, String b) {
> return target;
> }
> public boolean hide2Act(String a, boolean showB) {
> return !showB;
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ISIS-3198) action parameter hiding problem & default method argument null
Zermelo created ISIS-3198: - Summary: action parameter hiding problem & default method argument null Key: ISIS-3198 URL: https://issues.apache.org/jira/browse/ISIS-3198 Project: Isis Issue Type: Bug Components: Isis Viewer Wicket Reporter: Zermelo https://the-asf.slack.com/archives/CFC42LWBV/p1662043383425189 -- This message was sent by Atlassian Jira (v8.20.10#820010)
