[jira] [Commented] (ISIS-2085) [Validation] Every entity should be annotated with @XmlJavaTypeAdapter(PersistentEntityAdapter.class)

2022-07-31 Thread Daniel Keir Haywood (Jira) 


[ 
https://issues.apache.org/jira/browse/ISIS-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573427#comment-17573427
 ] 

Daniel Keir Haywood commented on ISIS-2085:
---

I think there's an arch test that does this; but we can have both.

> [Validation] Every entity should be annotated with 
> @XmlJavaTypeAdapter(PersistentEntityAdapter.class)
> -
>
> Key: ISIS-2085
> URL: https://issues.apache.org/jira/browse/ISIS-2085
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.17.0
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M8
>
>
> So can be referenced in a view model.
> Perhaps only enable this metamodel validation if a config property is enabled.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ISIS-2085) [Validation] Every entity should be annotated with @XmlJavaTypeAdapter(PersistentEntityAdapter.class)

2022-04-29 Thread Andi Huber (Jira) 


[ 
https://issues.apache.org/jira/browse/ISIS-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530025#comment-17530025
 ] 

Andi Huber commented on ISIS-2085:
--

A probably even better solution is to inspect all JAXB viewmodels and collect 
all the types they reference. Then validate that either the referencing member 
or the referenced entity have the appropriate annotation. No configuration 
required.

> [Validation] Every entity should be annotated with 
> @XmlJavaTypeAdapter(PersistentEntityAdapter.class)
> -
>
> Key: ISIS-2085
> URL: https://issues.apache.org/jira/browse/ISIS-2085
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.17.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> So can be referenced in a view model.
> Perhaps only enable this metamodel validation if a config property is enabled.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)