[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360905#comment-17360905
]
ASF subversion and git services commented on ISIS-2727:
---
Commit fe9d58ed13592b52377d80d92d91eed1102c40bd in isis's branch
refs/heads/ISIS-2442 from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fe9d58e ]
ISIS-2727: remove AnonymousInteractionFactory
(merge up into InteractionService)
remove InteractionFactory, as is now identical to InteractionService
rename InteractionFactoryDefault->
InteractionServiceDefault
also cleanup InteractionContextFactory
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360906#comment-17360906
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 7a606bf42a93dabaa49373fdd9f363dd6e9de887 in isis's branch
refs/heads/ISIS-2442 from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7a606bf ]
ISIS-2727: java-doc fixes
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360907#comment-17360907
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 42d29aad778964e300a8e4316f8edbad180d843e in isis's branch
refs/heads/ISIS-2442 from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=42d29aa ]
ISIS-2727: remove AuthenticationProvider
(replaced with InteractionProvider)
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360904#comment-17360904
]
ASF subversion and git services commented on ISIS-2727:
---
Commit e93e59ddbffbc6337f62e90f1bdc17389cc4d24c in isis's branch
refs/heads/ISIS-2442 from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e93e59d ]
ISIS-2727: remove Authentication from 'security'
instead have UserMemento hold the authentication state
also adds some todos
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360884#comment-17360884
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 42d29aad778964e300a8e4316f8edbad180d843e in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=42d29aa ]
ISIS-2727: remove AuthenticationProvider
(replaced with InteractionProvider)
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360834#comment-17360834
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 7a606bf42a93dabaa49373fdd9f363dd6e9de887 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7a606bf ]
ISIS-2727: java-doc fixes
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360830#comment-17360830
]
ASF subversion and git services commented on ISIS-2727:
---
Commit fe9d58ed13592b52377d80d92d91eed1102c40bd in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fe9d58e ]
ISIS-2727: remove AnonymousInteractionFactory
(merge up into InteractionService)
remove InteractionFactory, as is now identical to InteractionService
rename InteractionFactoryDefault->
InteractionServiceDefault
also cleanup InteractionContextFactory
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360735#comment-17360735
]
ASF subversion and git services commented on ISIS-2727:
---
Commit e93e59ddbffbc6337f62e90f1bdc17389cc4d24c in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e93e59d ]
ISIS-2727: remove Authentication from 'security'
instead have UserMemento hold the authentication state
also adds some todos
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360550#comment-17360550
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 39d48d4ca944fb1ec39b2a8be010d39dc134f462 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39d48d4 ]
ISIS-2727: minor: housekeeping
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360539#comment-17360539
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 4d1bf7007d83b65a0e848326dc882b4cf7975a05 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4d1bf70 ]
ISIS-2727: renames InteractionHandler to InteractionService
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360538#comment-17360538
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 2fac54a041c11c26473c63d79d6d0b9f9d967546 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2fac54a ]
ISIS-2727: factors out InteractionHandler as superinterface of
InteractionFactory
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360540#comment-17360540
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 06e6ccf1b4db29ccb92dbcd5f0867aec0c799f76 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=06e6ccf ]
ISIS-2727: moves InteractionLayer and InteractionServie from runtime to applib
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360542#comment-17360542
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ebdbb0b8eec5c158df07cf34ffdf1a6af5ee4c57 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ebdbb0b ]
ISIS-2727: fixes further compile issues
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360536#comment-17360536
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 5315fb12cd5b4eca84023a43d87318c520137778 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5315fb1 ]
ISIS-2727: decouples common from ThrowingRunnable
... preparing to move ThrowingRunnable into applib
... moves Result.ofVoid(ThrowingRunnable) to
ThrowingRunnable.resultOf(ThrowingRunnable)
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360537#comment-17360537
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 48dff404d863171abf433053048174f0e39937e9 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=48dff40 ]
ISIS-2727: moves ThrowingRunnable from commons to applib
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360544#comment-17360544
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 8ea8e5f94b53ac66ebe6219426e337f5f8756184 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ea8e5f ]
ISIS-2727: fixes unit test
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360545#comment-17360545
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 62820feca3045e678fcee07e7f531f4f56c6f26a in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=62820fe ]
Merge pull request #590 from apache/ISIS-2727
Isis 2727 : factors out InteractionService as a low-level service available in
the applib.
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360541#comment-17360541
]
ASF subversion and git services commented on ISIS-2727:
---
Commit bdd4eeef410db6ea3934182f261e7952ea5f24df in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bdd4eee ]
ISIS-2727: fixes compile issues
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360543#comment-17360543
]
ASF subversion and git services commented on ISIS-2727:
---
Commit cab80666a74ba3de414e7fde21d8af04852a26ea in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cab8066 ]
ISIS-2727: fixes unit test
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}. [DONE]
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead. [DONE]
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned..
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360154#comment-17360154
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 8ea8e5f94b53ac66ebe6219426e337f5f8756184 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ea8e5f ]
ISIS-2727: fixes unit test
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360145#comment-17360145
]
ASF subversion and git services commented on ISIS-2727:
---
Commit cab80666a74ba3de414e7fde21d8af04852a26ea in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cab8066 ]
ISIS-2727: fixes unit test
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360128#comment-17360128
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ebdbb0b8eec5c158df07cf34ffdf1a6af5ee4c57 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ebdbb0b ]
ISIS-2727: fixes further compile issues
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360126#comment-17360126
]
ASF subversion and git services commented on ISIS-2727:
---
Commit bdd4eeef410db6ea3934182f261e7952ea5f24df in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bdd4eee ]
ISIS-2727: fixes compile issues
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360104#comment-17360104
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 4d1bf7007d83b65a0e848326dc882b4cf7975a05 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4d1bf70 ]
ISIS-2727: renames InteractionHandler to InteractionService
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360105#comment-17360105
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 06e6ccf1b4db29ccb92dbcd5f0867aec0c799f76 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=06e6ccf ]
ISIS-2727: moves InteractionLayer and InteractionServie from runtime to applib
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360086#comment-17360086
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 2fac54a041c11c26473c63d79d6d0b9f9d967546 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2fac54a ]
ISIS-2727: factors out InteractionHandler as superinterface of
InteractionFactory
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360082#comment-17360082
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 48dff404d863171abf433053048174f0e39937e9 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=48dff40 ]
ISIS-2727: moves ThrowingRunnable from commons to applib
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360078#comment-17360078
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 7ccabd8a626e83c669c84f7580f473d632fb08c9 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7ccabd8 ]
ISIS-2727: adds InteractionFactory#call and #run
that use only an InteractionContext, not an Authenticated
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360079#comment-17360079
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 5315fb12cd5b4eca84023a43d87318c520137778 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5315fb1 ]
ISIS-2727: decouples common from ThrowingRunnable
... preparing to move ThrowingRunnable into applib
... moves Result.ofVoid(ThrowingRunnable) to
ThrowingRunnable.resultOf(ThrowingRunnable)
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360076#comment-17360076
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 11fd859af4bd250da0bdb8cb0b2b3c19e15abd97 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=11fd859 ]
ISIS-2727: changes InteractionLayer#getInteraction() to return Interaction
(in the applib) rather than IsisInteraction (internal).
This should let us now move it up into the applib. There were only 2 downcasts
required for this
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360077#comment-17360077
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 5afc51ccbdde47de459c6d08f15e76628fb130b9 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5afc51c ]
ISIS-2727: javadoc only
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360048#comment-17360048
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 2cf9ef623dd18d81ae64ca81b012e76993b47b30 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2cf9ef6 ]
ISIS-2727: fixes jdk11 dependency, javadoc is all
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360036#comment-17360036
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 710d49b091aec9d9521ae420d12a8c7a42be8bbe in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=710d49b ]
ISIS-2727: fixes error in InteractionFactoryDefault#openInteraction, in
determining the whether to reuse the current layer
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360037#comment-17360037
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 2cd342c6d68b61de09bf55067384e46c434b408d in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2cd342c ]
ISIS-2727: removes Authentication from InteractionLayer
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360030#comment-17360030
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ba5633df8252c05c66f462467e6375ad330b9a67 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ba5633d ]
ISIS-2727: adds a general purpose attributes to InteractionContext
my thinking being that we can attach an Authentication to InteractionContext,
rather than vice versa
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360033#comment-17360033
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ad179f7afb1ad8e95263bebbb2a4e3aac71e03bf in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ad179f7 ]
ISIS-2727: stores InteractionContext directly within InteractionLayer
... on the way to removing authToUse from InteractionLayer
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360035#comment-17360035
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 4c14c462fd9ef1fbfa9aa12155736d6b7aae45f5 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4c14c46 ]
ISIS-2727: removes Authentication param from InteractionFactory#openInteraction
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360034#comment-17360034
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 1a245c631b5ce0789fac53bacc083664bc624a7c in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a245c6 ]
ISIS-2727: refactors InteractionLayer
... now derive Authentication from the provided InteractionContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360032#comment-17360032
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 9d32f843e5a200298aac0f116495ab45f247d484 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9d32f84 ]
ISIS-2727: adds static method to lookup an Authentication from an
InteractionContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360031#comment-17360031
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 7408f7e9bc8480c2d187b4dbea705d1870d94021 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7408f7e ]
ISIS-2727: AuthenticationAbstract now saves a reference to itself in
InteractionContext#attributes map
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360029#comment-17360029
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 277fc2d6c8e1209a023a87e61792bc182754e388 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=277fc2d ]
ISIS-2727: just renames a var in SudoService
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359923#comment-17359923
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 795b41043a7df11096c07e8186808f7637e0fd68 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=795b410 ]
ISIS-2727: adds InteractionContext as parameter to
InteractionFactory#openInteraction(Authentication)
... on the way to replacing Authentication with a more abstract concept
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359794#comment-17359794
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ffdcdf642989cd9a373a71e5161f55fa0b166f2d in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ffdcdf6 ]
ISIS-2727: renames Authentication#getExecutionContext to #getInteractionContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359795#comment-17359795
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 0b8e1b25148688334289ba11a630226dd4b80090 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0b8e1b2 ]
ISIS-2727: renames Authentication#getInteractionContext to
#withInteractionContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359792#comment-17359792
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 3acf1075d245ae8cefddcea183f96f68076d4ccc in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3acf107 ]
ISIS-2727: fixes compile issue with MetaModelContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359791#comment-17359791
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 88e39afb00baf35801ddb2dfbcab6648aa329398 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=88e39af ]
ISIS-2727: fixes javadoc is all
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359790#comment-17359790
]
ASF subversion and git services commented on ISIS-2727:
---
Commit e37c452718c396898269bb0bcca3871d2696400c in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e37c452 ]
ISIS-2727: renames iactnlayer.ExecutionContext -> iactnlayer.InteractionContext
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359789#comment-17359789
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 05989944d4c697d2187e70bf63a2116f8fc237f9 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0598994 ]
ISIS-2727: moves ExecutionContext from services.iactn to services.iactnlayer
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead *[DONE]*
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that was recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern *[DONE]*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359782#comment-17359782
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 8ddca9c602f7c7859ffba5d58464cf2ec56c8eef in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ddca9c ]
ISIS-2727: renames variables of type 'AuthenticationContext'
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359780#comment-17359780
]
ASF subversion and git services commented on ISIS-2727:
---
Commit ce7cb1bd93c050991634bbf1ffebafb5d032de7e in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ce7cb1b ]
ISIS-2727: just renames variables and fields to 'interactionProviderProvider'
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359784#comment-17359784
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 79cb215f5f2437d6e3340ddf0d27ae53ba191b37 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=79cb215 ]
ISIS-2727: just renames some variables
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359783#comment-17359783
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 4793e5f679bab31f28b3e8ee02d1d51b5116d86c in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4793e5f ]
ISIS-2727: moves 'getInteractionLayerCount' from AuthenticationProvider to
InteractionProvider
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359781#comment-17359781
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 69d659d6795a0c8ae6899129aefd382fa75da2a2 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=69d659d ]
ISIS-2727: renames AuthenticationContext to AuthenticationProvider
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
> Also:
> * Rename {{AuthenticationContext}} to {{AuthenticationProvider}} , as this
> follows a similar pattern.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359769#comment-17359769
]
ASF subversion and git services commented on ISIS-2727:
---
Commit be8fd689fcff437673113f1dc502c698dc702c71 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=be8fd68 ]
ISIS-2727: fixes javadoc is all
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359770#comment-17359770
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 83fbb7ca8b31d5c8bdc992be4f812d567ebdc205 in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=83fbb7c ]
ISIS-2727: renames InteractionContext -> InteractionProvider
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this:
> * {{ExecutionContext}} is already in the applib, though its name is
> confusing as it suggests it is related to the {{Interaction.Execution}} class
> (it isn't, really) and also the fixtures applib provide
> {{FixtureScript.ExecutionContext}}. Really it acts more like a context for
> creating an {{InteractionLayer}}, so I think it should be called
> {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2727) Expose minimal InteractionFactory in the applib, to create new InteractionLayers. Perhaps this is an extension of SudoService ?
[
https://issues.apache.org/jira/browse/ISIS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17359764#comment-17359764
]
ASF subversion and git services commented on ISIS-2727:
---
Commit 75de2d548301ff04cdf28e37714886c62c0150cd in isis's branch
refs/heads/ISIS-2727 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=75de2d5 ]
ISIS-2727: just renaming some classes for better consistency
> Expose minimal InteractionFactory in the applib, to create new
> InteractionLayers. Perhaps this is an extension of SudoService ?
>
>
> Key: ISIS-2727
> URL: https://issues.apache.org/jira/browse/ISIS-2727
> Project: Isis
> Issue Type: New Feature
> Components: Isis Core
>Affects Versions: 2.0.0-M5
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M6
>
>
> [https://the-asf.slack.com/archives/CFC42LWBV/p1623056272236700]
> A fixture script that mocks the clock "just" needs to push an
> {{AuthenticationLayer}} with the desired {{VirtualClock}}.
> We also need to be able (within the test) to "sudo". This is where we need
> the ability to create an AuthenticationLayer (we'll rename it to
> InteractionLayer) on the fly.
> Discussion:
> some thoughts on how to do this: * {{ExecutionContext}} is already in the
> applib, though its name is confusing as it suggests it is related to the
> {{Interaction.Execution}} class (it isn't, really) and also the fixtures
> applib provide {{FixtureScript.ExecutionContext}}. Really it acts more like
> a context for creating an {{InteractionLayer}}, so I think it should be
> called {{InteractionContext}}.
> * That then means that the _current_ {{InteractionContext}} - which exposes
> the Isis applib {{Interaction}} to domain apps - then needs to be renamed. I
> suggest this is called {{InteractionProvider}} instead
> * We promote some small super-interface of {{InteractionFactory}} up into
> the applib. This might allow us to remove the
> {{AnonymousInteractionFactory}} interface that you recently introduced into
> security.
> * Rather than {{InteractionFactory#openInteraction(...)}} taking an
> {{Authentication}}, I think it could instead take the (now renamed)
> {{InteractionContext}} which is wrapped by an {{Authentication}}. My
> reasoning is that {{Authentication}} is not much more than a wrapper around
> {{InteractionContext}}, so I doubt there is any code that has a hard
> dependency on {{Authentication}} that couldn't be refactored to work with
> {{InteractionContext}} instead
> * The responsibilities of {{Authentication}} are then to do with ensuring
> that it is valid (the validation code) and the type (delegated or not etc).
> Those responsibilities hopefully won't need to leak outside of security, ie
> {{Authentication}} is not used elsewhere, ie other modules just use
> {{InteractionContext}} as mentioned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
