[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647758#comment-17647758 ] ASF subversion and git services commented on ISIS-3303: --- Commit f8dd79967c6ebf49488036b2f9484e6e473265e1 in isis's branch refs/heads/ISIS-3255 from Daniel Keir Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f8dd79967c ] Merge pull request #1252 from apache/ISIS-3303 ISIS-3303: reworks UserMemento#isSystem to instead be a check ... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647756#comment-17647756 ] ASF subversion and git services commented on ISIS-3303: --- Commit 60cb4e55d783d98116edb4f3969b20761af6e4fb in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=60cb4e55d7 ] ISIS-3303: makes stable regression tests artifacts consistent > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647753#comment-17647753 ] ASF subversion and git services commented on ISIS-3303: --- Commit 6883fee9b764504f8ecbaeb387375e630cb322b0 in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6883fee9b7 ] ISIS-3303: adds trivial improvements to build.sh > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647755#comment-17647755 ] ASF subversion and git services commented on ISIS-3303: --- Commit 13d3dacec81e3cca7ff7bee66302d4395d062002 in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=13d3dacec8 ] ISIS-3303: adds back in automaticModuleName etc for all regression tests as still failing in my local build... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647752#comment-17647752
]
ASF subversion and git services commented on ISIS-3303:
---
Commit fb8d558496088726299a84b03836d5d0b3b0cb54 in isis's branch
refs/heads/ISIS-3255 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb8d558496 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo}
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647757#comment-17647757 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3f9e51b0383124b598cf8f556a973177dfc50b02 in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3f9e51b038 ] ISIS-3303: fixes unit test by locking down the value semantics of UserMemento and RoleMemento more clearly > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647754#comment-17647754
]
ASF subversion and git services commented on ISIS-3303:
---
Commit ca9f44fae90d66f6d8dfac6574815e2730f4405c in isis's branch
refs/heads/ISIS-3255 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca9f44fae9 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo} (2)
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647751#comment-17647751 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3dc857a473347f88d2a7077a4ab65bc4caf33aa7 in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3dc857a473 ] ISIS-3303: fixes regression test, adds a new one > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647750#comment-17647750 ] ASF subversion and git services commented on ISIS-3303: --- Commit 9cce8147b08c20321018d13c497446ae752344ca in isis's branch refs/heads/ISIS-3255 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cce8147b0 ] ISIS-3303: reworks UserMemento#isSystem to instead be a check for SudoService#ACCESS_ALL_ROLE > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646432#comment-17646432 ] ASF subversion and git services commented on ISIS-3303: --- Commit 60cb4e55d783d98116edb4f3969b20761af6e4fb in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=60cb4e55d7 ] ISIS-3303: makes stable regression tests artifacts consistent > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646431#comment-17646431 ] ASF subversion and git services commented on ISIS-3303: --- Commit 13d3dacec81e3cca7ff7bee66302d4395d062002 in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=13d3dacec8 ] ISIS-3303: adds back in automaticModuleName etc for all regression tests as still failing in my local build... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646430#comment-17646430
]
ASF subversion and git services commented on ISIS-3303:
---
Commit ca9f44fae90d66f6d8dfac6574815e2730f4405c in isis's branch
refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca9f44fae9 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo} (2)
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646429#comment-17646429 ] ASF subversion and git services commented on ISIS-3303: --- Commit 6883fee9b764504f8ecbaeb387375e630cb322b0 in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6883fee9b7 ] ISIS-3303: adds trivial improvements to build.sh > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646428#comment-17646428
]
ASF subversion and git services commented on ISIS-3303:
---
Commit fb8d558496088726299a84b03836d5d0b3b0cb54 in isis's branch
refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb8d558496 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo}
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646426#comment-17646426 ] ASF subversion and git services commented on ISIS-3303: --- Commit 9cce8147b08c20321018d13c497446ae752344ca in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cce8147b0 ] ISIS-3303: reworks UserMemento#isSystem to instead be a check for SudoService#ACCESS_ALL_ROLE > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646434#comment-17646434 ] ASF subversion and git services commented on ISIS-3303: --- Commit f8dd79967c6ebf49488036b2f9484e6e473265e1 in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Daniel Keir Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f8dd79967c ] Merge pull request #1252 from apache/ISIS-3303 ISIS-3303: reworks UserMemento#isSystem to instead be a check ... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646433#comment-17646433 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3f9e51b0383124b598cf8f556a973177dfc50b02 in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3f9e51b038 ] ISIS-3303: fixes unit test by locking down the value semantics of UserMemento and RoleMemento more clearly > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646427#comment-17646427 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3dc857a473347f88d2a7077a4ab65bc4caf33aa7 in isis's branch refs/heads/dependabot/maven/master/spring-boot.version-3.0.0 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3dc857a473 ] ISIS-3303: fixes regression test, adds a new one > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645883#comment-17645883 ] ASF subversion and git services commented on ISIS-3303: --- Commit 13d3dacec81e3cca7ff7bee66302d4395d062002 in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=13d3dacec8 ] ISIS-3303: adds back in automaticModuleName etc for all regression tests as still failing in my local build... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645887#comment-17645887 ] ASF subversion and git services commented on ISIS-3303: --- Commit af0efb733a16a5e606215ce7119c75489a2e6e6d in isis's branch refs/heads/spring6 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=af0efb733a ] ISIS-3303: Merge remote-tracking branch 'origin/master' into spring6 > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645879#comment-17645879 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3dc857a473347f88d2a7077a4ab65bc4caf33aa7 in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3dc857a473 ] ISIS-3303: fixes regression test, adds a new one > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645881#comment-17645881 ] ASF subversion and git services commented on ISIS-3303: --- Commit 6883fee9b764504f8ecbaeb387375e630cb322b0 in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6883fee9b7 ] ISIS-3303: adds trivial improvements to build.sh > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645884#comment-17645884 ] ASF subversion and git services commented on ISIS-3303: --- Commit 60cb4e55d783d98116edb4f3969b20761af6e4fb in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=60cb4e55d7 ] ISIS-3303: makes stable regression tests artifacts consistent > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645885#comment-17645885 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3f9e51b0383124b598cf8f556a973177dfc50b02 in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3f9e51b038 ] ISIS-3303: fixes unit test by locking down the value semantics of UserMemento and RoleMemento more clearly > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645882#comment-17645882
]
ASF subversion and git services commented on ISIS-3303:
---
Commit ca9f44fae90d66f6d8dfac6574815e2730f4405c in isis's branch
refs/heads/spring6 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca9f44fae9 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo} (2)
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645878#comment-17645878 ] ASF subversion and git services commented on ISIS-3303: --- Commit 9cce8147b08c20321018d13c497446ae752344ca in isis's branch refs/heads/spring6 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cce8147b0 ] ISIS-3303: reworks UserMemento#isSystem to instead be a check for SudoService#ACCESS_ALL_ROLE > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645880#comment-17645880
]
ASF subversion and git services commented on ISIS-3303:
---
Commit fb8d558496088726299a84b03836d5d0b3b0cb54 in isis's branch
refs/heads/spring6 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb8d558496 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo}
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645886#comment-17645886 ] ASF subversion and git services commented on ISIS-3303: --- Commit f8dd79967c6ebf49488036b2f9484e6e473265e1 in isis's branch refs/heads/spring6 from Daniel Keir Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f8dd79967c ] Merge pull request #1252 from apache/ISIS-3303 ISIS-3303: reworks UserMemento#isSystem to instead be a check ... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645638#comment-17645638 ] ASF subversion and git services commented on ISIS-3303: --- Commit 60cb4e55d783d98116edb4f3969b20761af6e4fb in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=60cb4e55d7 ] ISIS-3303: makes stable regression tests artifacts consistent > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645640#comment-17645640 ] ASF subversion and git services commented on ISIS-3303: --- Commit f8dd79967c6ebf49488036b2f9484e6e473265e1 in isis's branch refs/heads/master from Daniel Keir Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f8dd79967c ] Merge pull request #1252 from apache/ISIS-3303 ISIS-3303: reworks UserMemento#isSystem to instead be a check ... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645639#comment-17645639 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3f9e51b0383124b598cf8f556a973177dfc50b02 in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3f9e51b038 ] ISIS-3303: fixes unit test by locking down the value semantics of UserMemento and RoleMemento more clearly > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645635#comment-17645635 ] ASF subversion and git services commented on ISIS-3303: --- Commit 6883fee9b764504f8ecbaeb387375e630cb322b0 in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6883fee9b7 ] ISIS-3303: adds trivial improvements to build.sh > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645634#comment-17645634
]
ASF subversion and git services commented on ISIS-3303:
---
Commit fb8d558496088726299a84b03836d5d0b3b0cb54 in isis's branch
refs/heads/master from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb8d558496 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo}
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645636#comment-17645636
]
ASF subversion and git services commented on ISIS-3303:
---
Commit ca9f44fae90d66f6d8dfac6574815e2730f4405c in isis's branch
refs/heads/master from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca9f44fae9 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo} (2)
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645633#comment-17645633 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3dc857a473347f88d2a7077a4ab65bc4caf33aa7 in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3dc857a473 ] ISIS-3303: fixes regression test, adds a new one > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645632#comment-17645632 ] ASF subversion and git services commented on ISIS-3303: --- Commit 9cce8147b08c20321018d13c497446ae752344ca in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cce8147b0 ] ISIS-3303: reworks UserMemento#isSystem to instead be a check for SudoService#ACCESS_ALL_ROLE > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645637#comment-17645637 ] ASF subversion and git services commented on ISIS-3303: --- Commit 13d3dacec81e3cca7ff7bee66302d4395d062002 in isis's branch refs/heads/master from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=13d3dacec8 ] ISIS-3303: adds back in automaticModuleName etc for all regression tests as still failing in my local build... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645628#comment-17645628 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3f9e51b0383124b598cf8f556a973177dfc50b02 in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3f9e51b038 ] ISIS-3303: fixes unit test by locking down the value semantics of UserMemento and RoleMemento more clearly > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645614#comment-17645614 ] ASF subversion and git services commented on ISIS-3303: --- Commit 60cb4e55d783d98116edb4f3969b20761af6e4fb in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=60cb4e55d7 ] ISIS-3303: makes stable regression tests artifacts consistent > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645611#comment-17645611 ] ASF subversion and git services commented on ISIS-3303: --- Commit 13d3dacec81e3cca7ff7bee66302d4395d062002 in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=13d3dacec8 ] ISIS-3303: adds back in automaticModuleName etc for all regression tests as still failing in my local build... > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645607#comment-17645607
]
ASF subversion and git services commented on ISIS-3303:
---
Commit ca9f44fae90d66f6d8dfac6574815e2730f4405c in isis's branch
refs/heads/ISIS-3303 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca9f44fae9 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo} (2)
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[
https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645600#comment-17645600
]
ASF subversion and git services commented on ISIS-3303:
---
Commit fb8d558496088726299a84b03836d5d0b3b0cb54 in isis's branch
refs/heads/ISIS-3303 from Dan Haywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb8d558496 ]
ISIS-3303: fixes (?) 'Invalid automatic module name' error for
regressiontests-cmdexecauditsess-persistence-{jpa|jdo}
> Redefine UserMemento#isSystemUser to instead take into account
> SudoService#accessAll role
> -
>
> Key: ISIS-3303
> URL: https://issues.apache.org/jira/browse/ISIS-3303
> Project: Isis
> Issue Type: Improvement
> Components: Isis Extensions SecMan
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-RC1
>
>
> We currently have two very similar notions that are meant to disable
> permission checking (typically for integration tests),
> `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role,
> as set up by the `NoPermissionsCheck` junit 5 extension.
> However, the `TenantedAuthorizationFacetDefault` is only aware of the former
> of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because
> the UserMemento#isSystem is an equality check, the two mechanisms are
> incompatible.
> Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.
> Therefore, the purpose of this improvement is to combine these two notions,
> and refactor names from (real) "system user" (aka root) to (effective) user
> (aka sudo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645601#comment-17645601 ] ASF subversion and git services commented on ISIS-3303: --- Commit 6883fee9b764504f8ecbaeb387375e630cb322b0 in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6883fee9b7 ] ISIS-3303: adds trivial improvements to build.sh > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644760#comment-17644760 ] ASF subversion and git services commented on ISIS-3303: --- Commit 3dc857a473347f88d2a7077a4ab65bc4caf33aa7 in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3dc857a473 ] ISIS-3303: fixes regression test, adds a new one > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3303) Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role
[ https://issues.apache.org/jira/browse/ISIS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644741#comment-17644741 ] ASF subversion and git services commented on ISIS-3303: --- Commit 9cce8147b08c20321018d13c497446ae752344ca in isis's branch refs/heads/ISIS-3303 from Dan Haywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cce8147b0 ] ISIS-3303: reworks UserMemento#isSystem to instead be a check for SudoService#ACCESS_ALL_ROLE > Redefine UserMemento#isSystemUser to instead take into account > SudoService#accessAll role > - > > Key: ISIS-3303 > URL: https://issues.apache.org/jira/browse/ISIS-3303 > Project: Isis > Issue Type: Improvement > Components: Isis Extensions SecMan >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Daniel Keir Haywood >Priority: Minor > Fix For: 2.0.0-RC1 > > > We currently have two very similar notions that are meant to disable > permission checking (typically for integration tests), > `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, > as set up by the `NoPermissionsCheck` junit 5 extension. > However, the `TenantedAuthorizationFacetDefault` is only aware of the former > of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because > the UserMemento#isSystem is an equality check, the two mechanisms are > incompatible. > Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API. > Therefore, the purpose of this improvement is to combine these two notions, > and refactor names from (real) "system user" (aka root) to (effective) user > (aka sudo). -- This message was sent by Atlassian Jira (v8.20.10#820010)
