[jira] Commented: (JCR-1212) JCR2SPI Node.hasProperty(String) optional property incompatibility with Jeceira
[
https://issues.apache.org/jira/browse/JCR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543016
]
angela commented on JCR-1212:
-
I think that JCR2SPI and SPI2JCR should be as tolerant as possible with
different JCR compliant implementations
no objections here.
however: before i spent hours to find out what david rauschenbach is refering
to, i want him
to create a simple test case that illustrates his problem with the default
setup and shows the effect of the proposed modification.
as stated above:
from what i remember, the itemstatefactory implementation deals with
the PathNotFoundException (and throws ItemNotFoundException).
that's why i requested additional information.
david rauschenbach, can you please provide that or resolve this issue?
thanks
angela
JCR2SPI Node.hasProperty(String) optional property incompatibility with
Jeceira
-
Key: JCR-1212
URL: https://issues.apache.org/jira/browse/JCR-1212
Project: Jackrabbit
Issue Type: Improvement
Components: SPI
Affects Versions: 1.4
Environment: 1.4-SNAPSHOT
Reporter: David Rauschenbach
Priority: Minor
Jeceira throws a PathNotFoundException when an SPI2JCR-wrapped Jeceira
repository gets invoked with the SPI getPropertyInfo, specifying an optional
property that does not exist for a given node instance.
JCR2SPI only expects an ItemNotFoundException to be thrown in such a case,
which prevents Node.hasProperty(String) from returning true/false, and
instead results in a RepositoryException being thrown, which in effect is an
interoperability issue.
JCR2SPI compatibility with Jeceira-based repositories would be significantly
improved if the code in NodeEntryImpl.java:loadPropertyEntry(PropertyId)
caught not only ItemNotFoundException, but also PathNotFoundException, before
returning null in both cases.
Proposed change to NodeEntryImpl.java:
private PropertyEntry loadPropertyEntry(PropertyId childId) throws
RepositoryException {
try {
PropertyState state =
factory.getItemStateFactory().createDeepPropertyState(childId, this);
return (PropertyEntry) state.getHierarchyEntry();
} catch (ItemNotFoundException e) {
return null;
} catch (PathNotFoundException e) { -- new
return null; -- new
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1067) Referenced beans in an object graph should be persisted by the ocm automatically
[ https://issues.apache.org/jira/browse/JCR-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542962 ] Christophe Lombart commented on JCR-1067: - After reflexion, I see 2 solutions : - create new converters - or apply your patch and set the mapping param : auto-insert, auto-update, auto-delete to false in my case. I'm going to investigate the second one and review your patch. Thanks Referenced beans in an object graph should be persisted by the ocm automatically Key: JCR-1067 URL: https://issues.apache.org/jira/browse/JCR-1067 Project: Jackrabbit Issue Type: Improvement Components: jcr-mapping Affects Versions: 1.3.1 Reporter: Padraic Hannon Attachments: BeanReferenceCollectionConverterImpl.diff, ReferenceBeanConverterImpl.diff Currently the BeanReferenceCollectionConverter and ReferenceBeanConverter classes only persist the UUID of the referenced object. There should either be new converter classes that cascade down the object graph to ensure all referenced items are created or updated, or the existing ones should be updated to cascade. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (JCR-1217) Aggregate include ignored if no primaryType set
Aggregate include ignored if no primaryType set --- Key: JCR-1217 URL: https://issues.apache.org/jira/browse/JCR-1217 Project: Jackrabbit Issue Type: Bug Components: indexing Reporter: Marcel Reutegger Priority: Minor If the include element of an aggregate definition does not have a primaryType attribute then the include is never matched. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1043) Package names for spring project do not match update ocm packages
[ https://issues.apache.org/jira/browse/JCR-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon updated JCR-1043: Attachment: spring-mvn2.patch Updated to move things to maven2 Package names for spring project do not match update ocm packages - Key: JCR-1043 URL: https://issues.apache.org/jira/browse/JCR-1043 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3 Environment: All environments Reporter: Padraic Hannon Assignee: Christophe Lombart Priority: Blocker Attachments: spring-mvn2.patch, spring.patch The spring package and tests reference the old graffitto package naming scheme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1043) Package names for spring project do not match update ocm packages
[ https://issues.apache.org/jira/browse/JCR-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon updated JCR-1043: Attachment: spring-mvn2.patch Package names for spring project do not match update ocm packages - Key: JCR-1043 URL: https://issues.apache.org/jira/browse/JCR-1043 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3 Environment: All environments Reporter: Padraic Hannon Assignee: Christophe Lombart Priority: Blocker Attachments: spring-mvn2.patch, spring.patch The spring package and tests reference the old graffitto package naming scheme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1043) Package names for spring project do not match update ocm packages
[ https://issues.apache.org/jira/browse/JCR-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon updated JCR-1043: Attachment: (was: spring-mvn2.patch) Package names for spring project do not match update ocm packages - Key: JCR-1043 URL: https://issues.apache.org/jira/browse/JCR-1043 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3 Environment: All environments Reporter: Padraic Hannon Assignee: Christophe Lombart Priority: Blocker Attachments: spring-mvn2.patch, spring.patch The spring package and tests reference the old graffitto package naming scheme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (JCR-1218) RepositoryUtil moved outside of main source tree
RepositoryUtil moved outside of main source tree Key: JCR-1218 URL: https://issues.apache.org/jira/browse/JCR-1218 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (JCR-1219) RepositoryUtil moved outside of main source tree
RepositoryUtil moved outside of main source tree Key: JCR-1219 URL: https://issues.apache.org/jira/browse/JCR-1219 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1219) RepositoryUtil moved outside of main source tree
[ https://issues.apache.org/jira/browse/JCR-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon resolved JCR-1219. - Resolution: Duplicate Duplicates JCR-1218 RepositoryUtil moved outside of main source tree Key: JCR-1219 URL: https://issues.apache.org/jira/browse/JCR-1219 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1218) RepositoryUtil moved outside of main source tree
[ https://issues.apache.org/jira/browse/JCR-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon updated JCR-1218: Priority: Blocker (was: Major) RepositoryUtil moved outside of main source tree Key: JCR-1218 URL: https://issues.apache.org/jira/browse/JCR-1218 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon Priority: Blocker Attachments: move-repositoryutil.patch It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1218) RepositoryUtil moved outside of main source tree
[ https://issues.apache.org/jira/browse/JCR-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padraic Hannon updated JCR-1218: Attachment: move-repositoryutil.patch RepositoryUtil moved outside of main source tree Key: JCR-1218 URL: https://issues.apache.org/jira/browse/JCR-1218 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon Priority: Blocker Attachments: move-repositoryutil.patch It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1218) RepositoryUtil moved outside of main source tree
[ https://issues.apache.org/jira/browse/JCR-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543244 ] Padraic Hannon commented on JCR-1218: - basically need to move jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/repository/RepositoryUtil.java to jcr-mapping/src/main/java/org/apache/jackrabbit/ocm/repository/RepositoryUtil.java RepositoryUtil moved outside of main source tree Key: JCR-1218 URL: https://issues.apache.org/jira/browse/JCR-1218 Project: Jackrabbit Issue Type: Bug Components: jcr-mapping Affects Versions: 1.3.3 Reporter: Padraic Hannon Priority: Blocker Attachments: move-repositoryutil.patch It appears that the RepositoryUtil class was moved from src/main to src/test. This class is used by the ocm-spring project. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
