[GitHub] [jackrabbit-oak] ankitaagar commented on a diff in pull request #904: OAK-8646 - Tests for detecting changes from orphaned branch commits
ankitaagar commented on code in PR #904: URL: https://github.com/apache/jackrabbit-oak/pull/904#discussion_r1173325563 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/BranchCommitGCTest.java: ## @@ -0,0 +1,101 @@ +package org.apache.jackrabbit.oak.plugins.document; + +import org.apache.jackrabbit.oak.spi.commit.CommitInfo; +import org.apache.jackrabbit.oak.spi.commit.EmptyHook; +import org.apache.jackrabbit.oak.spi.state.NodeBuilder; +import org.apache.jackrabbit.oak.stats.Clock; +import org.junit.*; Review Comment: sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke merged pull request #903: OAK-10196: switch oak-store-document to shaded guava
reschke merged PR #903: URL: https://github.com/apache/jackrabbit-oak/pull/903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #904: OAK-8646 - Tests for detecting changes from orphaned branch commits
reschke commented on code in PR #904: URL: https://github.com/apache/jackrabbit-oak/pull/904#discussion_r1172946759 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/BranchCommitGCTest.java: ## @@ -0,0 +1,101 @@ +package org.apache.jackrabbit.oak.plugins.document; + +import org.apache.jackrabbit.oak.spi.commit.CommitInfo; +import org.apache.jackrabbit.oak.spi.commit.EmptyHook; +import org.apache.jackrabbit.oak.spi.state.NodeBuilder; +import org.apache.jackrabbit.oak.stats.Clock; +import org.junit.*; Review Comment: please do not use wildcard imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #904: OAK-8646 - Tests for detecting changes from orphaned branch commits
stefan-egli commented on PR #904: URL: https://github.com/apache/jackrabbit-oak/pull/904#issuecomment-1516618135 @ankitaagar, +1, lgtm, I think it should just have the license header and we can then merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke closed pull request #856: Bump commons-fileupload from 1.3.3 to 1.5 in /oak-solr-core
reschke closed pull request #856: Bump commons-fileupload from 1.3.3 to 1.5 in /oak-solr-core URL: https://github.com/apache/jackrabbit-oak/pull/856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #856: Bump commons-fileupload from 1.3.3 to 1.5 in /oak-solr-core
dependabot[bot] commented on PR #856: URL: https://github.com/apache/jackrabbit-oak/pull/856#issuecomment-1516561156 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #857: Bump commons-fileupload from 1.4 to 1.5 in /oak-it-osgi
dependabot[bot] commented on PR #857: URL: https://github.com/apache/jackrabbit-oak/pull/857#issuecomment-1516559412 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke closed pull request #857: Bump commons-fileupload from 1.4 to 1.5 in /oak-it-osgi
reschke closed pull request #857: Bump commons-fileupload from 1.4 to 1.5 in /oak-it-osgi URL: https://github.com/apache/jackrabbit-oak/pull/857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jackrabbit-oak] reschke merged pull request #906: OAK-10201: oak-blub-plugins: exported packages need to be marked @internal
reschke merged PR #906: URL: https://github.com/apache/jackrabbit-oak/pull/906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JCR-4927) EOL Jackrabbit 2.16
[ https://issues.apache.org/jira/browse/JCR-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4927: Description: Users of 2.16 should switch to the latest stable release of 2.20 (which requires Java 8). What it'll mean in actual actions: - no supported Jackrabbit release for Java 7 anymore - links will be removed from the download page - news will be posted on the homepage - [announce] will be sent to jr-user, jr-dev, oak-dev - branch and tags WILL stay there - issues labels "candidate_jcr_2_14" will be removed See also http://jackrabbit.apache.org/jcr/downloads.html and http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. was: Users of 2.14 should switch to the latest stable release of 2.20 (which requires Java 8). What it'll mean in actual actions: - no supported Jackrabbit release for Java 7 anymore - links will be removed from the download page - news will be posted on the homepage - [announce] will be sent to jr-user, jr-dev, oak-dev - branch and tags WILL stay there - issues labels "candidate_jcr_2_14" will be removed See also http://jackrabbit.apache.org/jcr/downloads.html and http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. > EOL Jackrabbit 2.16 > --- > > Key: JCR-4927 > URL: https://issues.apache.org/jira/browse/JCR-4927 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > Users of 2.16 should switch to the latest stable release of 2.20 (which > requires Java 8). > What it'll mean in actual actions: > - no supported Jackrabbit release for Java 7 anymore > - links will be removed from the download page > - news will be posted on the homepage > - [announce] will be sent to jr-user, jr-dev, oak-dev > - branch and tags WILL stay there > - issues labels "candidate_jcr_2_14" will be removed > See also http://jackrabbit.apache.org/jcr/downloads.html and > http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JCR-4927) EOL Jackrabbit 2.16
Julian Reschke created JCR-4927: --- Summary: EOL Jackrabbit 2.16 Key: JCR-4927 URL: https://issues.apache.org/jira/browse/JCR-4927 Project: Jackrabbit Content Repository Issue Type: Task Reporter: Julian Reschke Assignee: Julian Reschke Users of 2.14 should switch to the latest stable release of 2.20 (which requires Java 8). What it'll mean in actual actions: - no supported Jackrabbit release for Java 7 anymore - links will be removed from the download page - news will be posted on the homepage - [announce] will be sent to jr-user, jr-dev, oak-dev - branch and tags WILL stay there - issues labels "candidate_jcr_2_14" will be removed See also http://jackrabbit.apache.org/jcr/downloads.html and http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4927) EOL Jackrabbit 2.16
[ https://issues.apache.org/jira/browse/JCR-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4927: Description: Users of 2.16 should switch to the latest stable release of 2.20 (which requires Java 8). What it'll mean in actual actions: - no supported Jackrabbit release for Java 7 anymore - links will be removed from the download page - news will be posted on the homepage - [announce] will be sent to jr-user, jr-dev, oak-dev - branch and tags WILL stay there - issues labels "candidate_jcr_2_16" will be removed See also http://jackrabbit.apache.org/jcr/downloads.html and http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. was: Users of 2.16 should switch to the latest stable release of 2.20 (which requires Java 8). What it'll mean in actual actions: - no supported Jackrabbit release for Java 7 anymore - links will be removed from the download page - news will be posted on the homepage - [announce] will be sent to jr-user, jr-dev, oak-dev - branch and tags WILL stay there - issues labels "candidate_jcr_2_14" will be removed See also http://jackrabbit.apache.org/jcr/downloads.html and http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. > EOL Jackrabbit 2.16 > --- > > Key: JCR-4927 > URL: https://issues.apache.org/jira/browse/JCR-4927 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > Users of 2.16 should switch to the latest stable release of 2.20 (which > requires Java 8). > What it'll mean in actual actions: > - no supported Jackrabbit release for Java 7 anymore > - links will be removed from the download page > - news will be posted on the homepage > - [announce] will be sent to jr-user, jr-dev, oak-dev > - branch and tags WILL stay there > - issues labels "candidate_jcr_2_16" will be removed > See also http://jackrabbit.apache.org/jcr/downloads.html and > http://jackrabbit.apache.org/jcr/jackrabbit-roadmap.html. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #903: OAK-10196: switch oak-store-document to shaded guava
reschke commented on code in PR #903: URL: https://github.com/apache/jackrabbit-oak/pull/903#discussion_r1172305520 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/CacheInvalidationIT.java: ## @@ -39,7 +39,7 @@ import org.junit.Before; import org.junit.Test; -import static com.google.common.collect.Iterables.*; +import static org.apache.jackrabbit.guava.common.collect.Iterables.*; Review Comment: No. I'm not going to make any edits that will make the change bigger than necessary. I agree that wildcard imports are bad, but if we want to change them, that should be done as part of a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (JCR-4926) Support CUBRID database in Jackrabbit 2
[ https://issues.apache.org/jira/browse/JCR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714475#comment-17714475 ] Woonsan Ko edited comment on JCR-4926 at 4/20/23 8:06 AM: -- PR is ready for review: https://github.com/apache/jackrabbit/pull/131 I've tested it working fine in a simple CMS application configured like the following: ``` http://jackrabbit.apache.org/dtd/repository-2.0.dtd";> ``` And JDBC setting example: - driver: cubrid.jdbc.driver.CUBRIDDriver - url: 'jdbc:CUBRID:localhost:33000:repodb:public::?charSet=utf-8' - username: '' - password: '' was (Author: woonsan): PR is ready for review: https://github.com/apache/jackrabbit/pull/131 I've tested it working fine in a simple CMS application configured like the following: ``` http://jackrabbit.apache.org/dtd/repository-2.0.dtd";> ``` > Support CUBRID database in Jackrabbit 2 > --- > > Key: JCR-4926 > URL: https://issues.apache.org/jira/browse/JCR-4926 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: clustering, jackrabbit-core, jackrabbit-data >Reporter: Woonsan Ko >Assignee: Julian Reschke >Priority: Major > Fix For: 2.22, 2.21.17 > > > In the region where I work, I see CUBRID database [1][2] being adopted, > especially in the public sector. It seems like CUBRID is regarded as one of > the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. > So I'd like to support the database in Jackrabbit 2 first and then maintain > and port it to OAK later. (OSGi is not quite popular yet here.) > Even if Cubrid is not as popular as other OSS projects, it might be helpful > to support here. > [1] https://en.wikipedia.org/wiki/CUBRID > [2] https://www.cubrid.org/downloads -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4926) Support CUBRID database in Jackrabbit 2
[ https://issues.apache.org/jira/browse/JCR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4926: Fix Version/s: 2.22 > Support CUBRID database in Jackrabbit 2 > --- > > Key: JCR-4926 > URL: https://issues.apache.org/jira/browse/JCR-4926 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: clustering, jackrabbit-core, jackrabbit-data >Reporter: Woonsan Ko >Assignee: Julian Reschke >Priority: Major > Fix For: 2.22, 2.21.17 > > > In the region where I work, I see CUBRID database [1][2] being adopted, > especially in the public sector. It seems like CUBRID is regarded as one of > the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. > So I'd like to support the database in Jackrabbit 2 first and then maintain > and port it to OAK later. (OSGi is not quite popular yet here.) > Even if Cubrid is not as popular as other OSS projects, it might be helpful > to support here. > [1] https://en.wikipedia.org/wiki/CUBRID > [2] https://www.cubrid.org/downloads -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4926) Support CUBRID database in Jackrabbit 2
[ https://issues.apache.org/jira/browse/JCR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated JCR-4926: Description: In the region where I work, I see CUBRID database [1][2] being adopted, especially in the public sector. It seems like CUBRID is regarded as one of the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. So I'd like to support the database in Jackrabbit 2 first and then maintain and port it to OAK later. (OSGi is not quite popular yet here.) Even if Cubrid is not as popular as other OSS projects, it might be helpful to support here. [1] https://en.wikipedia.org/wiki/CUBRID [2] https://www.cubrid.org/downloads was: In the region where I work, I see CUBRID database [1] being adopted, especially in the public sector. It seems like CUBRID is regarded as one of the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. So I'd like to support the database in Jackrabbit 2 first and then maintain and port it to OAK later. (OSGi is not quite popular yet here.) Even if Cubrid is not as popular as other OSS projects, it might be helpful to support here. [1] https://en.wikipedia.org/wiki/CUBRID > Support CUBRID database in Jackrabbit 2 > --- > > Key: JCR-4926 > URL: https://issues.apache.org/jira/browse/JCR-4926 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: clustering, jackrabbit-core, jackrabbit-data >Reporter: Woonsan Ko >Assignee: Julian Reschke >Priority: Major > Fix For: 2.21.17 > > > In the region where I work, I see CUBRID database [1][2] being adopted, > especially in the public sector. It seems like CUBRID is regarded as one of > the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. > So I'd like to support the database in Jackrabbit 2 first and then maintain > and port it to OAK later. (OSGi is not quite popular yet here.) > Even if Cubrid is not as popular as other OSS projects, it might be helpful > to support here. > [1] https://en.wikipedia.org/wiki/CUBRID > [2] https://www.cubrid.org/downloads -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (JCR-4926) Support CUBRID database in Jackrabbit 2
[ https://issues.apache.org/jira/browse/JCR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko reassigned JCR-4926: --- Assignee: Julian Reschke (was: Woonsan Ko) Hi [~reschke], Would you mind reviewing my PR when you have some time? (Not so urgent..) Thanks in advance, Woonsan > Support CUBRID database in Jackrabbit 2 > --- > > Key: JCR-4926 > URL: https://issues.apache.org/jira/browse/JCR-4926 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: clustering, jackrabbit-core, jackrabbit-data >Reporter: Woonsan Ko >Assignee: Julian Reschke >Priority: Major > Fix For: 2.21.17 > > > In the region where I work, I see CUBRID database [1] being adopted, > especially in the public sector. It seems like CUBRID is regarded as one of > the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. > So I'd like to support the database in Jackrabbit 2 first and then maintain > and port it to OAK later. (OSGi is not quite popular yet here.) > Even if Cubrid is not as popular as other OSS projects, it might be helpful > to support here. > [1] https://en.wikipedia.org/wiki/CUBRID -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCR-4926) Support CUBRID database in Jackrabbit 2
[ https://issues.apache.org/jira/browse/JCR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714475#comment-17714475 ] Woonsan Ko commented on JCR-4926: - PR is ready for review: https://github.com/apache/jackrabbit/pull/131 I've tested it working fine in a simple CMS application configured like the following: ``` http://jackrabbit.apache.org/dtd/repository-2.0.dtd";> ``` > Support CUBRID database in Jackrabbit 2 > --- > > Key: JCR-4926 > URL: https://issues.apache.org/jira/browse/JCR-4926 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: clustering, jackrabbit-core, jackrabbit-data >Reporter: Woonsan Ko >Assignee: Woonsan Ko >Priority: Major > Fix For: 2.21.17 > > > In the region where I work, I see CUBRID database [1] being adopted, > especially in the public sector. It seems like CUBRID is regarded as one of > the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. > So I'd like to support the database in Jackrabbit 2 first and then maintain > and port it to OAK later. (OSGi is not quite popular yet here.) > Even if Cubrid is not as popular as other OSS projects, it might be helpful > to support here. > [1] https://en.wikipedia.org/wiki/CUBRID -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JCR-4926) Support CUBRID database in Jackrabbit 2
Woonsan Ko created JCR-4926: --- Summary: Support CUBRID database in Jackrabbit 2 Key: JCR-4926 URL: https://issues.apache.org/jira/browse/JCR-4926 Project: Jackrabbit Content Repository Issue Type: Improvement Components: clustering, jackrabbit-core, jackrabbit-data Reporter: Woonsan Ko Assignee: Woonsan Ko Fix For: 2.21.17 In the region where I work, I see CUBRID database [1] being adopted, especially in the public sector. It seems like CUBRID is regarded as one of the OSS DBMS alternatives (with PostgreSQL and MariaDB) here. So I'd like to support the database in Jackrabbit 2 first and then maintain and port it to OAK later. (OSGi is not quite popular yet here.) Even if Cubrid is not as popular as other OSS projects, it might be helpful to support here. [1] https://en.wikipedia.org/wiki/CUBRID -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #903: OAK-10196: switch oak-store-document to shaded guava
rishabhdaim commented on code in PR #903: URL: https://github.com/apache/jackrabbit-oak/pull/903#discussion_r1172173984 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/CacheInvalidationIT.java: ## @@ -39,7 +39,7 @@ import org.junit.Before; import org.junit.Test; -import static com.google.common.collect.Iterables.*; +import static org.apache.jackrabbit.guava.common.collect.Iterables.*; Review Comment: could you please import them individually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
