[jira] [Commented] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
[
https://issues.apache.org/jira/browse/JCR-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746785#comment-17746785
]
Woonsan Ko commented on JCR-4957:
-
Hi [~reschke],
I recall somethings on why/how commons-vfs2 relies on the standalone-components
(not standalone itself).
As described in JCR-4401 (and discussed [1]), Jackrabbit has split the old
standalone module into two: standalone (a demo) and standalone-components (a
library). To help commons-vfs2 be able to verify its VFS2 over WebDAV, we moved
some public classes originally in the demo project to the library project, at
least for commons-vfs2 as of JCR-4401.
I'm not sure if it is feasible to bring it back easily, but it would be great
to see commons-VFS2 being verified with JR webdav server.
Woonsan
[1] https://lists.apache.org/thread/87rdszdzx4nqc7x0o9x4y10p338doc1p
> Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
> --
>
> Key: JCR-4957
> URL: https://issues.apache.org/jira/browse/JCR-4957
> Project: Jackrabbit Content Repository
> Issue Type: Bug
>Affects Versions: 2.21.18
>Reporter: Gary D. Gregory
>Priority: Major
>
> We see this break in Apache Commons VFS when trying to update from 2.21.17 to
> 2.21.18:
> {quote}[INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
> incompatible types: java.lang.String[] cannot be converted to
> org.apache.commons.cli.CommandLine
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
> cannot find symbol
> symbol: constructor (java.lang.String[])
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
> method run in class org.apache.jackrabbit.standalone.Main cannot be applied
> to given types;
> required: java.io.File,java.io.File,java.io.File
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {quote}
> Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
[
https://issues.apache.org/jira/browse/JCR-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746770#comment-17746770
]
Julian Reschke commented on JCR-4957:
-
1) 2.21 are unstable releases. They can change anytime. It's good to use them
for testing (and looking for regressions), but do not ever use them in releases.
2) I don't consider standalone to be part of the public API, and I really
wasn't aware of this kind of usage. It's a demo project, nothing more.
> Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
> --
>
> Key: JCR-4957
> URL: https://issues.apache.org/jira/browse/JCR-4957
> Project: Jackrabbit Content Repository
> Issue Type: Bug
>Affects Versions: 2.21.18
>Reporter: Gary D. Gregory
>Priority: Major
>
> We see this break in Apache Commons VFS when trying to update from 2.21.17 to
> 2.21.18:
> {quote}[INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
> incompatible types: java.lang.String[] cannot be converted to
> org.apache.commons.cli.CommandLine
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
> cannot find symbol
> symbol: constructor (java.lang.String[])
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
> method run in class org.apache.jackrabbit.standalone.Main cannot be applied
> to given types;
> required: java.io.File,java.io.File,java.io.File
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {quote}
> Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
[
https://issues.apache.org/jira/browse/JCR-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated JCR-4957:
-
Description:
We see this break in Apache Commons VFS when trying to update from 2.21.17 to
2.21.18:
{quote}[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
incompatible types: java.lang.String[] cannot be converted to
org.apache.commons.cli.CommandLine
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
cannot find symbol
symbol: constructor (java.lang.String[])
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
method run in class org.apache.jackrabbit.standalone.Main cannot be applied to
given types;
required: java.io.File,java.io.File,java.io.File
found: no arguments
reason: actual and formal argument lists differ in length
[INFO] 3 errors
{quote}
Breaking BC in a non-major release should not be allowed IMO.
was:
We see this break in Apache Commons VFS when trying to update from 2.21.16 to
2.21.17:
{quote}[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
incompatible types: java.lang.String[] cannot be converted to
org.apache.commons.cli.CommandLine
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
cannot find symbol
symbol: constructor (java.lang.String[])
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
method run in class org.apache.jackrabbit.standalone.Main cannot be applied to
given types;
required: java.io.File,java.io.File,java.io.File
found: no arguments
reason: actual and formal argument lists differ in length
[INFO] 3 errors
{quote}
Breaking BC in a non-major release should not be allowed IMO.
> Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
> --
>
> Key: JCR-4957
> URL: https://issues.apache.org/jira/browse/JCR-4957
> Project: Jackrabbit Content Repository
> Issue Type: Bug
>Affects Versions: 2.21.18
>Reporter: Gary D. Gregory
>Priority: Major
>
> We see this break in Apache Commons VFS when trying to update from 2.21.17 to
> 2.21.18:
> {quote}[INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
> incompatible types: java.lang.String[] cannot be converted to
> org.apache.commons.cli.CommandLine
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
> cannot find symbol
> symbol: constructor (java.lang.String[])
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
> method run in class org.apache.jackrabbit.standalone.Main cannot be applied
> to given types;
> required: java.io.File,java.io.File,java.io.File
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {quote}
> Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
[
https://issues.apache.org/jira/browse/JCR-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated JCR-4957:
-
Summary: Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17 (was:
Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.16)
> Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
> --
>
> Key: JCR-4957
> URL: https://issues.apache.org/jira/browse/JCR-4957
> Project: Jackrabbit Content Repository
> Issue Type: Bug
>Affects Versions: 2.21.18
>Reporter: Gary D. Gregory
>Priority: Major
>
> We see this break in Apache Commons VFS when trying to update from 2.21.16 to
> 2.21.18:
> {quote}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
> incompatible types: java.lang.String[] cannot be converted to
> org.apache.commons.cli.CommandLine
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
> cannot find symbol
> symbol: constructor (java.lang.String[])
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
> method run in class org.apache.jackrabbit.standalone.Main cannot be applied
> to given types;
> required: java.io.File,java.io.File,java.io.File
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {quote}
> Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
[
https://issues.apache.org/jira/browse/JCR-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated JCR-4957:
-
Description:
We see this break in Apache Commons VFS when trying to update from 2.21.16 to
2.21.17:
{quote}[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
incompatible types: java.lang.String[] cannot be converted to
org.apache.commons.cli.CommandLine
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
cannot find symbol
symbol: constructor (java.lang.String[])
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
method run in class org.apache.jackrabbit.standalone.Main cannot be applied to
given types;
required: java.io.File,java.io.File,java.io.File
found: no arguments
reason: actual and formal argument lists differ in length
[INFO] 3 errors
{quote}
Breaking BC in a non-major release should not be allowed IMO.
was:
We see this break in Apache Commons VFS when trying to update from 2.21.16 to
2.21.18:
{quote}
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
incompatible types: java.lang.String[] cannot be converted to
org.apache.commons.cli.CommandLine
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
cannot find symbol
symbol: constructor (java.lang.String[])
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
method run in class org.apache.jackrabbit.standalone.Main cannot be applied to
given types;
required: java.io.File,java.io.File,java.io.File
found: no arguments
reason: actual and formal argument lists differ in length
[INFO] 3 errors
{quote}
Breaking BC in a non-major release should not be allowed IMO.
> Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.17
> --
>
> Key: JCR-4957
> URL: https://issues.apache.org/jira/browse/JCR-4957
> Project: Jackrabbit Content Repository
> Issue Type: Bug
>Affects Versions: 2.21.18
>Reporter: Gary D. Gregory
>Priority: Major
>
> We see this break in Apache Commons VFS when trying to update from 2.21.16 to
> 2.21.17:
> {quote}[INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
> incompatible types: java.lang.String[] cannot be converted to
> org.apache.commons.cli.CommandLine
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
> cannot find symbol
> symbol: constructor (java.lang.String[])
> [ERROR]
> /C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
> method run in class org.apache.jackrabbit.standalone.Main cannot be applied
> to given types;
> required: java.io.File,java.io.File,java.io.File
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {quote}
> Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (JCR-4957) Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.16
Gary D. Gregory created JCR-4957:
Summary: Jackrabbit 2.21.18 breaks binary compatiblity with 2.21.16
Key: JCR-4957
URL: https://issues.apache.org/jira/browse/JCR-4957
Project: Jackrabbit Content Repository
Issue Type: Bug
Affects Versions: 2.21.18
Reporter: Gary D. Gregory
We see this break in Apache Commons VFS when trying to update from 2.21.16 to
2.21.18:
{quote}
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,27]
incompatible types: java.lang.String[] cannot be converted to
org.apache.commons.cli.CommandLine
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[231,18]
cannot find symbol
symbol: constructor (java.lang.String[])
[ERROR]
/C:/Users/ggregory/git/a/commons-vfs/commons-vfs2-jackrabbit2/src/test/java/org/apache/commons/vfs2/provider/webdav4/test/Webdav4ProviderTestCase.java:[235,15]
method run in class org.apache.jackrabbit.standalone.Main cannot be applied to
given types;
required: java.io.File,java.io.File,java.io.File
found: no arguments
reason: actual and formal argument lists differ in length
[INFO] 3 errors
{quote}
Breaking BC in a non-major release should not be allowed IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[ANNOUNCE] Apache Jackrabbit Oak 1.54.0 released
The Apache Jackrabbit community is pleased to announce the release of Apache Jackrabbit Oak 1.54.0. The release is available for download at: http://jackrabbit.apache.org/downloads.html See the full release notes below for details about this release: Release Notes -- Apache Jackrabbit Oak -- Version 1.54.0 Introduction Jackrabbit Oak is a scalable, high-performance hierarchical content repository designed for use as the foundation of modern world-class web sites and other demanding content applications. Apache Jackrabbit Oak 1.54.0 is an incremental feature release based on and compatible with earlier stable Jackrabbit Oak 1.x releases. This release is considered stable and targeted for production use. While Oak 1.54.0 compiles and tests successfully on Java 17, Javadocs generation fails on Java 17 (but works as expected on Java 11). The Oak effort is a part of the Apache Jackrabbit project. Apache Jackrabbit is a project of the Apache Software Foundation. Changes in Oak 1.54.0 - Technical task [OAK-10197] - switch oak-blob-plugins to shaded guava [OAK-10204] - switch oak-blob to shaded guava [OAK-10236] - Update oak-segment-remote modules with shaded guava [OAK-10237] - Update oak-blob* modules with shaded guava [OAK-10238] - switch oak-search to shaded guava [OAK-10239] - Update oak-lucene with shaded guava [OAK-10240] - switch oak-solr to shaded guava [OAK-10242] - switch oak-search-elastic to shaded guava [OAK-10244] - oak-solr-osgi: remove Guava import decl [OAK-10245] - Document OAK-10173 [OAK-10246] - Minor cleanup of unused imports, indention and whitespace [OAK-10247] - oak-commons: remove Guava from public API [OAK-10270] - Document limitation [OAK-10276] - switch oak-upgrade to shaded guava [OAK-10278] - switch oak-run-elastic to shaded guava [OAK-10282] - switch oak-it to shaded guava [OAK-10283] - switch oak-examples to shaded guava [OAK-10284] - switch oak-benchmarks to shaded guava [OAK-10287] - switch oak-benchmarks-lucene to shaded guava [OAK-10290] - switch oak-benchmarks-elastic to shaded guava [OAK-10292] - switch oak-benchmarks-solr to shaded guava [OAK-10307] - oak-shaded-guava leaks original guava as transitive dependency [OAK-10330] - oak-it-osgi: temporarily introduce Guava dependency again Bug [OAK-9660] - NullPointerException When Moving Transient node [OAK-10226] - Elasticsearch custom analyzers fail when the files contain comments [OAK-10241] - NPE while trying to get the BinaryDownload URI [OAK-10243] - Flaky test in oak-blob-cloud-azure and oak-run [OAK-10257] - NodeCounterMetricTest does not release resources [OAK-10259] - oak-core tests running out of memory [OAK-10263] - Inconsistent state in TarWriter when close() fails to write to Azure [OAK-10268] - oak-search-elastic: propertyIndex=false fields cannot be used for sorting [OAK-10280] - Occasional failure to start docker container [OAK-10305] - oak-core should changes scope of annotation dependencies to provided [OAK-10306] - Incorrect dependency scope for commons-math3 [OAK-10308] - Tests using MongoUtils may skip even if Docker is available [OAK-10324] - oak-search-elastic: IN queries on boolean fields should not fail when one of the value cannot be parsed [OAK-10338] - PipelinedMergeSortTaskTest is failing on Windows due to line end issues [OAK-10340] - Child order not updated on source after move New Feature [OAK-10093] - Oak Blob Store support for SSE-C for AWS Story [OAK-10173] - Allow configured principals to impersonate any user Improvement [OAK-10211] - Rectify documentation for hybrid indexes [OAK-10213] - Add new api in DocumentStore to handle bulk findAndUpdate operations [OAK-10250] - Configurable suspend timeout [OAK-10252] - Distinguish in oak-jackrabbit-api between provider and consumer type interfaces [OAK-10253] - Option to only collect references when calling checkConsistency [OAK-10256] - Principal documentation does not mention GroupPrincipal [OAK-10261] - Query with OR clause with COALESCE function incorrectly interpreted [OAK-10262] - Document ASCIIFolder and OakAnalyzer [OAK-10267] - oak-search-elastic: index should be more lenient when a field cannot be converted to the mapped type [OAK-10273] - Index-definition json created during oak-run reindex should not serialise index data [OAK-10285] - MembershipProvider change log level to ERROR for cyclic membership [OAK-10286] - AutoMembershipPrincipals.isInheritedMember add check for cyclic membership [OAK-10294] - Indexing job: add new Pipelined Strategy for dumping Mongo contents in preparation for reindexing [OAK-10303] - oak-search-elastic: remove propertyIndex/nodeScopeIndex from dynamicBoost tests [OAK-10310] - Bump testcontainers dependency to
[jira] [Closed] (JCRVLT-669) Log throwable of ValidationMessage
[
https://issues.apache.org/jira/browse/JCRVLT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed JCRVLT-669.
--
> Log throwable of ValidationMessage
> --
>
> Key: JCRVLT-669
> URL: https://issues.apache.org/jira/browse/JCRVLT-669
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.3.4
>
>
> Currently the {{ValidationMessagePrinter}} does not emit the optional
> {{getThrowable()}}. As this may contain further crucial information it should
> be emitted as well in case it is set.
> Additionally its stack trace should be emitted on DEBUG level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (JCRVLT-686) Goal format-xml: Improve help how to format docview XML
[
https://issues.apache.org/jira/browse/JCRVLT-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed JCRVLT-686.
--
> Goal format-xml: Improve help how to format docview XML
> ---
>
> Key: JCRVLT-686
> URL: https://issues.apache.org/jira/browse/JCRVLT-686
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.3.4
>
>
> Currently the error message in case of incorrect format reads
> {quote}Malformed according to DocView format. Use either your IDE with
> JCR-VLT integration to sync files with the repository or use vlt-cli to apply
> the docview format ([http://jackrabbit.apache.org/filevault/usage.html]).
> {quote}
> Actually both ways rely on external tools. Instead the recommended way should
> be to call the Maven goal with option {{validateOnly}}
> ([https://jackrabbit.apache.org/filevault-package-maven-plugin/format-xml-mojo.html#validateOnly])
> set to false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (JCRVLT-681) validate-files: Files which don't end up in the package are validated
[
https://issues.apache.org/jira/browse/JCRVLT-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed JCRVLT-681.
--
> validate-files: Files which don't end up in the package are validated
> -
>
> Key: JCRVLT-681
> URL: https://issues.apache.org/jira/browse/JCRVLT-681
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
>Affects Versions: package-maven-plugin-1.3.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.3.4
>
>
> Files like {{.gitignore}} are not part of the content package but still
> validated via goal {{validate-files}}.
> This may lead to errors like
> {code}
> [INFO] --- filevault-package-maven-plugin:1.3.2:validate-files
> (default-validate-files) @ ... ---
> [INFO] Validate files in generatedMetaInfRootDirectory
> 'target/vault-work/META-INF' and metaInfRootDir 'target/vault-work/META-INF'
> [INFO] Using 14 validators for package of type CONTAINER:
> jackrabbit-accesscontrol
> (org.apache.jackrabbit.vault.validation.spi.impl.AccessControlValidator),
> jackrabbit-filter
> (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator),
> jackrabbit-properties
> (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator),
> jackrabbit-docviewparser
> (org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator),
> netcentric-aem-classification
> (biz.netcentric.filevault.validator.aem.classification.AemClassificationValidator),
> netcentric-aem-cloud
> (biz.netcentric.filevault.validator.aem.cloud.AemCloudValidator),
> sling-repoinit
> (org.apache.sling.repoinit.filevault.validator.RepoInitValidator),
> jackrabbit-dependencies
> (org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator),
> jackrabbit-duplicateuuid
> (org.apache.jackrabbit.vault.validation.spi.impl.DuplicateUuidValidator),
> jackrabbit-emptyelements
> (org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator),
> jackrabbit-mergelimitations
> (org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator),
> jackrabbit-oakindex
> (org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator),
> jackrabbit-packagetype
> (org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator),
> jackrabbit-nodetypes
> (org.apache.jackrabbit.vault.validation.spi.impl.nodetype.NodeTypeValidator)
> [INFO] Scanning baseDir 'target/vault-work/META-INF'...
> [INFO] Scanning path 'target/vault-work/META-INF'...
> [INFO] Scanning path 'target/vault-work/META-INF/MANIFEST.MF'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault/config.xml'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault/definition'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault/filter.xml'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault/properties.xml'...
> [INFO] Scanning path 'target/vault-work/META-INF/vault/settings.xml'...
> [INFO] Scanning path
> 'target/vault-work/META-INF/vault/definition/.content.xml'...
> [INFO] Scanning baseDir 'src/main/jcr_root'...
> [INFO] Scanning path 'src/main/jcr_root'...
> [INFO] Scanning path 'src/main/jcr_root/.gitignore'...
> [ERROR] ValidationViolation: Node '/.gitignore' is not contained in any of
> the filter rules @ src/main/jcr_root/.gitignore, validator: jackrabbit-filter
> [WARNING] ValidationViolation: Property 'jcr:data' [Binary] is not allowed in
> node with potential default types [nt:folder]: No applicable property
> definition found for name and type! @ src/main/jcr_root/.gitignore,
> validator: jackrabbit-nodetypes, JCR node path: /.gitignore
> [WARNING] ValidationViolation: Property 'jcr:mimeType' [String] is not
> allowed in node with potential default types [nt:folder]: No applicable
> property definition found for name and type! @ src/main/jcr_root/.gitignore,
> validator: jackrabbit-nodetypes, JCR node path: /.gitignore
> [WARNING] ValidationViolation: Property 'jcr:lastModified' [Date] is not
> allowed in node with potential default types [nt:folder]: No applicable
> property definition found for name and type! @ src/main/jcr_root/.gitignore,
> validator: jackrabbit-nodetypes, JCR node path: /.gitignore
> [ERROR] ValidationViolation: Using mutable nodes in this repository location
> is only allowed in author-specific packages as it is not writable by the
> underlying service user on a publish instance. Consider to use repoinit
> scripts instead or move that content to another location. Further details at
> https://experienceleague.adobe.com/docs/experience-manager-learn/cloud-service/debugging/debugging-aem-as-a-cloud-service/
[jira] [Closed] (JCRVLT-712) Use FileVault 3.7.0
[ https://issues.apache.org/jira/browse/JCRVLT-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed JCRVLT-712. -- > Use FileVault 3.7.0 > --- > > Key: JCRVLT-712 > URL: https://issues.apache.org/jira/browse/JCRVLT-712 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: package maven plugin >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: package-maven-plugin-1.3.4 > > > Currently the version FileVault 3.6.6 is used in the Maven plugin. This > should be updated to the most recent 3.7.0. > The changelogs since 3.6.6 are here: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20JCRVLT%20AND%20fixVersion%20in%20(3.6.8%2C%203.7.0)%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JCRVLT-694) Document OSGi support
[ https://issues.apache.org/jira/browse/JCRVLT-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed JCRVLT-694. -- > Document OSGi support > - > > Key: JCRVLT-694 > URL: https://issues.apache.org/jira/browse/JCRVLT-694 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: Misc >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: package-maven-plugin-1.3.4 > > > Add some documentation on embedded OSGi bundles/configuration inside packages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Jackrabbit FileVault Package Maven Plugin 1.3.4
Hi there, The vote passes as follows: +1 (binding): Robert, Julian, Manfred +1 (non-binding): Stefan Seifert Thanks for voting. I'll push the release out. Best regards, Konrad > On 20. Jul 2023, at 12:09, Konrad Windszus wrote: > > Hello, > > A candidate for the Jackrabbit FileVault Package Maven Plugin 1.3.4 release > is available at: > https://dist.apache.org/repos/dist/dev/jackrabbit/filevault-package-maven-plugin/1.3.4/ > > The release candidate is a zip archive of the sources in: > https://github.com/apache/jackrabbit-filevault-package-maven-plugin/tree/filevault-package-maven-plugin-1.3.4/ > > The release notes can be found in JIRA at > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314920&version=12352672 > > The command for running automated checks against this release candidate is: > (Again minor tweaks necessary due to > https://issues.apache.org/jira/browse/MASFRES-67, so please update the check > script before running it) > > $ sh check-release.sh filevault-plugin 1.3.4 > 349aac4aba42f9a8b73611748fefc9920891ca88 > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachejackrabbit-1658 > > Please vote on releasing this package as Apache Jackrabbit FileVault Package > Maven Plugin 1.3.4. > The vote is open for a minimum of 72 hours during business days and passes > if a majority of at least three +1 Jackrabbit PMC votes are cast. > The vote fails if not enough votes are cast after 1 week (5 business days). > > [ ] +1 Release this package as Apache Jackrabbit FileVault Package Maven > Plugin 1.3.4 > [ ] -1 Do not release this package because... > > Thanks in advance for voting, > Konrad
[GitHub] [jackrabbit-oak] reschke merged pull request #1036: OAK-10366: Update Oak trunk and Oak 1.22 to Jackrabbit 2.20.11
reschke merged PR #1036: URL: https://github.com/apache/jackrabbit-oak/pull/1036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746445#comment-17746445 ] Manfred Baedke edited comment on JCR-4956 at 7/24/23 1:01 PM: -- We can actually just remove them, because the default forkCount=1 are just what we want. Find a patch attached. was (Author: baedke): We can actually just remove them, because the default forkCount=1 are just what we want. > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[ANNOUNCE] Apache Jackrabbit 2.20.11 released
The Apache Jackrabbit community is pleased to announce the release of Apache Jackrabbit 2.20.11. The release is available for download at: http://jackrabbit.apache.org/downloads.html See the full release notes below for details about this release: Release Notes -- Apache Jackrabbit -- Version 2.20.11 Introduction This is Apache Jackrabbit(TM) 2.20.11, a fully compliant implementation of the Content Repository for Java(TM) Technology API, version 2.0 (JCR 2.0) as specified in the Java Specification Request 283 (JSR 283). Apache Jackrabbit 2.20.11 is an incremental feature release based on and compatible with earlier stable Jackrabbit 2.x releases. Jackrabbit 2.20.x releases are considered stable and targeted for production use. The minimum Java version for this release is Java 8. See http://jackrabbit.apache.org/jcr/downloads.html for maintenance versions that support earlier Java versions. Changes in Jackrabbit 2.20.11 - Sub-task [JCR-4948] - core: beanutils leaks dependency to commons-collections in oak-core tests Bug [JCR-4949] - get rid of beanutils dependency Task [JCR-4925] - Update oak-jackrabbit-api.version.used in trunk and 2.20 to Oak 1.22.15 [JCR-4932] - Update commons-io dependency to 2.12.0 [JCR-4933] - Update tomcat dependency to 8.5.88 [JCR-4936] - Update tomcat dependency to 8.5.89 [JCR-4937] - jcr-tests: get rid of duplicate XMLChar class [JCR-4939] - Update commons-io dependency to 2.13.0 [JCR-4941] - Update tomcat dependency to 8.5.90 [JCR-4942] - spi-commons: bump minor version number of o.a.j.spi.commons.conversion For more detailed information about all the changes in this and other Jackrabbit releases, please see the Jackrabbit issue tracker at https://issues.apache.org/jira/browse/JCR Release Contents This release consists of a single source archive packaged as a zip file. The archive can be unpacked with the jar tool from your JDK installation. See the README.txt file for instructions on how to build this release. The source archive is accompanied by an SHA512 checksum and a PGP signature that you can use to verify the authenticity of your download. The public key used for the PGP signature can be found at https://www.apache.org/dist/jackrabbit/KEYS. About Apache Jackrabbit --- Apache Jackrabbit is a fully conforming implementation of the Content Repository for Java Technology API (JCR). A content repository is a hierarchical content store with support for structured and unstructured content, full text search, versioning, transactions, observation, and more. For more information, visit http://jackrabbit.apache.org/ About The Apache Software Foundation Established in 1999, The Apache Software Foundation provides organizational, legal, and financial support for more than 140 freely-available, collaboratively-developed Open Source projects. The pragmatic Apache License enables individual and commercial users to easily deploy Apache software; the Foundation's intellectual property framework limits the legal exposure of its 3,800+ contributors. For more information, visit http://www.apache.org/ Trademarks -- Apache Jackrabbit, Jackrabbit, Apache, the Apache feather logo, and the Apache Jackrabbit project logo are trademarks of The Apache Software Foundation.
[jira] [Updated] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4956: Attachment: jcr-4956.patch Status: Patch Available (was: In Progress) > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JCR-4931) set baseline comparisonVersion to latest stable (2.20.10)
[ https://issues.apache.org/jira/browse/JCR-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke closed JCR-4931. --- > set baseline comparisonVersion to latest stable (2.20.10) > - > > Key: JCR-4931 > URL: https://issues.apache.org/jira/browse/JCR-4931 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22, 2.21.18 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCR-4955) set baseline comparisonVersion to latest stable (2.20.11)
[ https://issues.apache.org/jira/browse/JCR-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746447#comment-17746447 ] Julian Reschke commented on JCR-4955: - trunk: [r1911236|http://svn.apache.org/r1911236] > set baseline comparisonVersion to latest stable (2.20.11) > - > > Key: JCR-4955 > URL: https://issues.apache.org/jira/browse/JCR-4955 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22, 2.21.19 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4931) set baseline comparisonVersion to latest stable (2.20.10)
[ https://issues.apache.org/jira/browse/JCR-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4931: Fix Version/s: 2.21.18 (was: 2.16.11) > set baseline comparisonVersion to latest stable (2.20.10) > - > > Key: JCR-4931 > URL: https://issues.apache.org/jira/browse/JCR-4931 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22, 2.21.18 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JCR-4931) set baseline comparisonVersion to latest stable (2.20.10)
[ https://issues.apache.org/jira/browse/JCR-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4931. - Resolution: Fixed > set baseline comparisonVersion to latest stable (2.20.10) > - > > Key: JCR-4931 > URL: https://issues.apache.org/jira/browse/JCR-4931 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22, 2.21.18 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JCR-4955) set baseline comparisonVersion to latest stable (2.20.11)
[ https://issues.apache.org/jira/browse/JCR-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4955. - Fix Version/s: 2.21.19 Resolution: Fixed > set baseline comparisonVersion to latest stable (2.20.11) > - > > Key: JCR-4955 > URL: https://issues.apache.org/jira/browse/JCR-4955 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22, 2.21.19 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [jackrabbit-oak] reschke opened a new pull request, #1036: OAK-10366: Update Oak trunk and Oak 1.22 to Jackrabbit 2.20.11
reschke opened a new pull request, #1036: URL: https://github.com/apache/jackrabbit-oak/pull/1036 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (JCR-4956) Replace deprecated Surefire fork options
Manfred Baedke created JCR-4956: --- Summary: Replace deprecated Surefire fork options Key: JCR-4956 URL: https://issues.apache.org/jira/browse/JCR-4956 Project: Jackrabbit Content Repository Issue Type: Task Reporter: Manfred Baedke Assignee: Manfred Baedke Some subprojects use the the deprecated Surefire option"forkMode" (or even the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (JCR-4952) Release Jackrabbit 2.20.11
[ https://issues.apache.org/jira/browse/JCR-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4952. - Resolution: Fixed > Release Jackrabbit 2.20.11 > -- > > Key: JCR-4952 > URL: https://issues.apache.org/jira/browse/JCR-4952 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (JCR-4952) Release Jackrabbit 2.20.11
[ https://issues.apache.org/jira/browse/JCR-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke closed JCR-4952. --- > Release Jackrabbit 2.20.11 > -- > > Key: JCR-4952 > URL: https://issues.apache.org/jira/browse/JCR-4952 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JCR-4955) set baseline comparisonVersion to latest stable (2.20.11)
Julian Reschke created JCR-4955: --- Summary: set baseline comparisonVersion to latest stable (2.20.11) Key: JCR-4955 URL: https://issues.apache.org/jira/browse/JCR-4955 Project: Jackrabbit Content Repository Issue Type: Task Components: parent Reporter: Julian Reschke Assignee: Julian Reschke Fix For: 2.22, 2.16.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4955) set baseline comparisonVersion to latest stable (2.20.11)
[ https://issues.apache.org/jira/browse/JCR-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4955: Fix Version/s: (was: 2.16.11) > set baseline comparisonVersion to latest stable (2.20.11) > - > > Key: JCR-4955 > URL: https://issues.apache.org/jira/browse/JCR-4955 > Project: Jackrabbit Content Repository > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 2.22 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Jackrabbit 2.20.11
On 19.07.2023 12:43, Julian Reschke wrote: ... Hi there, The vote passes as follows: +1 Angela Schreiber via dev +1 Jörg Hoh +1 Julian Reschke +1 Konrad Windszus +1 Manfred Baedke +1 Woonsan Ko Thanks for voting. I'll push the release out. Best regards, Julian
[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #1034: OAK-10318 : Improve AutoMembershipPrincipals#isInheritedMember
anchela commented on code in PR #1034:
URL: https://github.com/apache/jackrabbit-oak/pull/1034#discussion_r1272049353
##
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/AutoMembershipPrincipals.java:
##
@@ -127,23 +128,55 @@ boolean isMember(@NotNull String idpName, @NotNull String
groupId, @NotNull Auth
}
boolean isInheritedMember(@NotNull String idpName, @NotNull Group group,
@NotNull Authorizable authorizable) throws RepositoryException {
-return isInheritedMember(idpName, group, authorizable, new
HashSet<>());
-}
-
-boolean isInheritedMember(@NotNull String idpName, @NotNull Group group,
@NotNull Authorizable authorizable, @NotNull Set processedIds) throws
RepositoryException {
String groupId = group.getID();
-if (!processedIds.add(groupId)) {
-log.error("Cyclic group membership detected for group id {}",
groupId);
-return false;
-}
if (isMember(idpName, groupId, authorizable)) {
+// groupId is listed in auto-membership configuration
return true;
}
-Iterator declaredGroupMembers =
Iterators.filter(group.getDeclaredMembers(), Authorizable::isGroup);
-while (declaredGroupMembers.hasNext()) {
-Group grMember = (Group) declaredGroupMembers.next();
-if (isInheritedMember(idpName, grMember, authorizable,
processedIds)) {
+// to test for inherited membership collect automembership-ids and
loop auto-membership groups
+Set automembershipIds = new
HashSet<>(Arrays.asList(autoMembershipMapping.get(idpName)));
+AutoMembershipConfig config = autoMembershipConfigMap.get(idpName);
+if (config != null) {
+automembershipIds.addAll(config.getAutoMembership(authorizable));
+}
+
+// keep track of processed ids over all 'automembership' ids to avoid
repeated evaluation
+Set processed = new HashSet<>();
+for (String automembershipId : automembershipIds) {
+Authorizable gr = userManager.getAuthorizable(automembershipId);
+if (gr == null || !gr.isGroup()) {
+log.warn("Configured automembership id '{}' is not a valid
group", automembershipId);
+} else if (hasInheritedMembership(gr.declaredMemberOf(), groupId,
automembershipId, processed)) {
+return true;
+}
+}
+return false;
+}
+
+private static boolean hasInheritedMembership(@NotNull Iterator
declared, @NotNull String groupId,
+ @NotNull String memberId,
@NotNull Set processed) throws RepositoryException {
+List groups = new ArrayList<>();
+while (declared.hasNext()) {
+Group gr = declared.next();
+String grId = gr.getID();
+if (memberId.equals(grId)) {
+log.error("Cyclic group membership detected for group id {}",
memberId);
Review Comment:
@joerghoh , done. if you can take another look that would be great. i also
added more tests and rearranged the code a bit to make easier to read)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[ANNOUNCE] Apache Jackrabbit 2.21.18 released
The Apache Jackrabbit community is pleased to announce the release of Apache Jackrabbit 2.21.18. The release is available for download at: http://jackrabbit.apache.org/downloads.html See the full release notes below for details about this release: Release Notes -- Apache Jackrabbit -- Version 2.21.18 Introduction This is Apache Jackrabbit(TM) 2.21.18, a fully compliant implementation of the Content Repository for Java(TM) Technology API, version 2.0 (JCR 2.0) as specified in the Java Specification Request 283 (JSR 283). Apache Jackrabbit 2.21.18 is an unstable release cut directly from Jackrabbit trunk, with a focus on new features and other improvements. For production use we recommend the latest stable 2.20.x release. NOTE: 2.21.17 was released from an incorrect SVN tag and actually contains version 2.21.16. This release contains what was supposed to go into 2.21.17. Changes in Jackrabbit 2.21.18 - Sub-task [JCR-4948] - core: beanutils leaks dependency to commons-collections in oak-core tests Bug [JCR-4606] - standalone: logback log files created in wrong place [JCR-4949] - get rid of beanutils dependency Task [JCR-4308] - update Jetty to 9.4.* [JCR-4352] - Update lucene-core dependency to 3.6.2 [JCR-4925] - Update oak-jackrabbit-api.version.used in trunk and 2.20 to Oak 1.22.15 [JCR-4932] - Update commons-io dependency to 2.12.0 [JCR-4933] - Update tomcat dependency to 8.5.88 [JCR-4936] - Update tomcat dependency to 8.5.89 [JCR-4937] - jcr-tests: get rid of duplicate XMLChar class [JCR-4938] - update remaining copies of XMLChar.java with latest version from Xerces [JCR-4939] - Update commons-io dependency to 2.13.0 [JCR-4941] - Update tomcat dependency to 8.5.90 [JCR-4942] - spi-commons: bump minor version number of o.a.j.spi.commons.conversion [JCR-4944] - upgrade to Tomcat 9.x For more detailed information about all the changes in this and other Jackrabbit releases, please see the Jackrabbit issue tracker at https://issues.apache.org/jira/browse/JCR Release Contents This release consists of a single source archive packaged as a zip file. The archive can be unpacked with the jar tool from your JDK installation. See the README.txt file for instructions on how to build this release. The source archive is accompanied by an SHA512 checksum and a PGP signature that you can use to verify the authenticity of your download. The public key used for the PGP signature can be found at https://www.apache.org/dist/jackrabbit/KEYS. About Apache Jackrabbit --- Apache Jackrabbit is a fully conforming implementation of the Content Repository for Java Technology API (JCR). A content repository is a hierarchical content store with support for structured and unstructured content, full text search, versioning, transactions, observation, and more. For more information, visit http://jackrabbit.apache.org/ About The Apache Software Foundation Established in 1999, The Apache Software Foundation provides organizational, legal, and financial support for more than 140 freely-available, collaboratively-developed Open Source projects. The pragmatic Apache License enables individual and commercial users to easily deploy Apache software; the Foundation's intellectual property framework limits the legal exposure of its 3,800+ contributors. For more information, visit http://www.apache.org/ Trademarks -- Apache Jackrabbit, Jackrabbit, Apache, the Apache feather logo, and the Apache Jackrabbit project logo are trademarks of The Apache Software Foundation.
[GitHub] [jackrabbit-oak] reschke commented on pull request #993: Oak 10199 : Added Skeleton & Deteled garbage Properties
reschke commented on PR #993: URL: https://github.com/apache/jackrabbit-oak/pull/993#issuecomment-1647506857 By all means, when this is done: please use "squash & merge" :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT] [VOTE] Release Apache Jackrabbit 2.21.18
On 19.07.2023 10:08, Julian Reschke wrote: ... Hi there, The vote passes as follows: +1 Angela Schreiber via dev +1 Jörg Hoh +1 Julian Reschke +1 Manfred Baedke +1 Rishabh Daim +1 Woonsan Ko Thanks for voting. I'll push the release out. Best regards, Julian
