Re: [PR] OAK-10486 : Resolution of inherited groups may terminate pre-maturely for external users [jackrabbit-oak]
reschke commented on PR #1147: URL: https://github.com/apache/jackrabbit-oak/pull/1147#issuecomment-1761642839 bq. @reschke , to answer your questions: yes and yes. do you agree that the approach chosen in the PR is equivalent? i find it easier to understand as the decision on what iterator to read from, when to move on to the next and when all iterators have been processed is kept in a single place. Yes, they look equivalent. I just wanted to double-check that I had understood the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10311 - Optimize SegmentBlob#equals for segment blobs that origin… [jackrabbit-oak]
sonarcloud[bot] commented on PR #1150: URL: https://github.com/apache/jackrabbit-oak/pull/1150#issuecomment-1761609756 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&metric=new_coverage&view=list) [27.3% Coverage](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1150&metric=new_duplicated_lines_density&view=list)  The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] OAK-10473 do not throw an IAE on invalid names [jackrabbit-oak]
joerghoh opened a new pull request, #1152: URL: https://github.com/apache/jackrabbit-oak/pull/1152 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] OAK-10491 - Indexing: pass a MongoDatabase instance instead of MongoConnection to indexing logic [jackrabbit-oak]
nfsantos opened a new pull request, #1151: URL: https://github.com/apache/jackrabbit-oak/pull/1151 Refactor Indexing logic to take only a MongoDatabase instance instead of a MongoConnection, which is a more complex object with more fields other than the MongoDatabase. The pipeline indexing strategy needs to have access to a MongoDatabase object to register a custom codec to deserialize the responses from Mongo. Previously we were passing a MongoConnection object which contained a reference to MongoDatabase. But the indexing job does not need any other fields from MongoConnection other than MongoDatabase. But requiring MongoConnection makes it harder for users of Oak to call this API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10490 Suggest queries return duplicate entries if prefetch is enabled [jackrabbit-oak]
sonarcloud[bot] commented on PR #1148: URL: https://github.com/apache/jackrabbit-oak/pull/1148#issuecomment-1761474236 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_coverage&view=list) [54.5% Coverage](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_duplicated_lines_density&view=list)  The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please
Re: [PR] OAK-10490 Suggest queries return duplicate entries if prefetch is enabled [jackrabbit-oak]
thomasmueller merged PR #1148: URL: https://github.com/apache/jackrabbit-oak/pull/1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10486 : Resolution of inherited groups may terminate pre-maturely for external users [jackrabbit-oak]
mbaedke commented on PR #1147: URL: https://github.com/apache/jackrabbit-oak/pull/1147#issuecomment-1761359006 It is definitely equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10490 Suggest queries return duplicate entries if prefetch is enabled [jackrabbit-oak]
sonarcloud[bot] commented on PR #1148: URL: https://github.com/apache/jackrabbit-oak/pull/1148#issuecomment-1761289708 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_coverage&view=list) [52.4% Coverage](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1148&metric=new_duplicated_lines_density&view=list)  The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please
Re: [PR] OAK-10486 : Resolution of inherited groups may terminate pre-maturely for external users [jackrabbit-oak]
anchela commented on PR #1147: URL: https://github.com/apache/jackrabbit-oak/pull/1147#issuecomment-1761282824 @reschke , to answer your questions: yes and yes. do you agree that the approach chosen in the PR is equivalent? i find it easier to understand as the decision on what iterator to read from, when to move on to the next and when all iterators have been processed is kept in a single place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10490 Suggest queries return duplicate entries if prefetch is enabled [jackrabbit-oak]
nfsantos commented on code in PR #1148:
URL: https://github.com/apache/jackrabbit-oak/pull/1148#discussion_r1358022250
##
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndex.java:
##
@@ -465,67 +470,13 @@ public void remove() {
@Override
public IndexRow next() {
final IndexRow pathRow = pathCursor.next();
-return new IndexRow() {
-
-@Override
-public boolean isVirtualRow() {
-return currentRow.isVirutal;
-}
-
-@Override
-public String getPath() {
-String sub = pathRow.getPath();
-if (isVirtualRow()) {
-return sub;
-} else if (!"".equals(pathPrefix) &&
PathUtils.denotesRoot(sub)) {
-return pathPrefix;
-} else if (PathUtils.isAbsolute(sub)) {
-return pathPrefix + sub;
-} else {
-return PathUtils.concat(pathPrefix, sub);
-}
-}
-@Override
-public PropertyValue getValue(String columnName) {
-// overlay the score
-if (QueryConstants.JCR_SCORE.equals(columnName)) {
-return PropertyValues.newDouble(currentRow.score);
-}
-if (QueryConstants.REP_SPELLCHECK.equals(columnName) ||
QueryConstants.REP_SUGGEST.equals(columnName)) {
-return PropertyValues.newString(currentRow.suggestion);
-}
-if
(QueryConstants.OAK_SCORE_EXPLANATION.equals(columnName)) {
-return
PropertyValues.newString(currentRow.explanation);
-}
-if (columnName.startsWith(QueryConstants.REP_EXCERPT)) {
-String excerpt = currentRow.excerpts.get(columnName);
-if (excerpt != null) {
-return PropertyValues.newString(excerpt);
-}
-}
-if (columnName.startsWith(QueryConstants.REP_FACET)) {
-try {
-List facets =
currentRow.getFacets(numberOfFacets, columnName);
-if (facets != null) {
-JsopWriter writer = new JsopBuilder();
-writer.object();
-for (Facet f : facets) {
-
writer.key(f.getLabel()).value(f.getCount());
-}
-writer.endObject();
-return
PropertyValues.newString(writer.toString());
-}
-} catch (IOException | RuntimeException e) {
-LOG.warn(e.getMessage());
-LOG.debug(e.getMessage(), e);
-throw new RuntimeException(e);
-}
-}
-return pathRow.getValue(columnName);
-}
+// we need to copy the reference to the current row here,
+// otherwise all the returned IndexRows might reference the same
row
+// (and then we use _this_ row in the IndexRow class below)
Review Comment:
This comment may not be needed anymore. Or else rephrase it because the copy
of the reference is now implicit, it's just the standard call-by-value Java
behaviour so maybe there is no need for comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774825#comment-17774825 ] Manfred Baedke edited comment on JCR-4956 at 10/13/23 8:38 AM: --- trunk (2.21.21): [r1912931|http://svn.apache.org/r1912931] was (Author: baedke): trunk: r1912931 > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 2.21.21 > > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4956: Fix Version/s: 2.21.21 > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 2.21.21 > > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774825#comment-17774825 ] Manfred Baedke commented on JCR-4956: - trunk: r1912931 > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4956: Resolution: Fixed Status: Resolved (was: Patch Available) > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] OAK-10490 Suggest queries return duplicate entries if prefetch is enabled [jackrabbit-oak]
thomasmueller commented on code in PR #1148:
URL: https://github.com/apache/jackrabbit-oak/pull/1148#discussion_r1357913024
##
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndex.java:
##
@@ -465,6 +465,9 @@ public void remove() {
@Override
public IndexRow next() {
final IndexRow pathRow = pathCursor.next();
+// we need to copy the reference to the current row here,
+// otherwise all the returned IndexRows might reference the same
row
+final FulltextResultRow currentRow = currentRowInPathIterator;
return new IndexRow() {
@Override
Review Comment:
Yes, that would probably be cleaner... My plan was to create the most simple
fix, but this seems better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746445#comment-17746445 ] Manfred Baedke edited comment on JCR-4956 at 10/13/23 7:32 AM: --- We can actually just remove them, because the default forkCount=1 is just what we want. Find a patch attached. was (Author: baedke): We can actually just remove them, because the default forkCount=1 are just what we want. Find a patch attached. > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
