[PR] OAK-10833 - Consistency check reports success for repository with SNF… [jackrabbit-oak]

2024-05-24 Thread via GitHub


dulceanu opened a new pull request, #1487:
URL: https://github.com/apache/jackrabbit-oak/pull/1487

   …E in checkpoints


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Issue/oak 10621 [jackrabbit-oak]

2024-05-24 Thread via GitHub


reschke commented on PR #1286:
URL: https://github.com/apache/jackrabbit-oak/pull/1286#issuecomment-2129369108

   @mbaedke - could you please rebase the patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Issues/oak 10781 [jackrabbit-oak]

2024-05-24 Thread via GitHub


rootpea commented on PR #1485:
URL: https://github.com/apache/jackrabbit-oak/pull/1485#issuecomment-2129047177

   @t-rana the jenkins test failed, could you please re-run


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Issue/oak 8848 [jackrabbit-oak]

2024-05-24 Thread via GitHub


reschke commented on code in PR #1474:
URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1613082105


##
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/MoveVersionableNodeWithMemoryRepositoryTest.java:
##
@@ -0,0 +1,26 @@
+package org.apache.jackrabbit.oak.jcr;

Review Comment:
   So, IIUC, you have created mutliple test classes so that the different 
mixtures are covered automatically. That was certainly helpful for testing, but 
it wouldn't scale if we did this everywhere.
   
   So I would propose to simplify that again; and we also should wortk on the 
orthogonal issue of documenting and potentially fixing the CI pipelines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OAK-10826 - Misleading warning about missing checkpoint [jackrabbit-oak]

2024-05-24 Thread via GitHub


rishabhdaim merged PR #1479:
URL: https://github.com/apache/jackrabbit-oak/pull/1479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OAK-10830: Upgrade jackson-databind dependency to 2.17.1 [jackrabbit-oak]

2024-05-24 Thread via GitHub


reschke merged PR #1486:
URL: https://github.com/apache/jackrabbit-oak/pull/1486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] OAK-10830: Upgrade jackson-databind dependency to 2.17.1 [jackrabbit-oak]

2024-05-24 Thread via GitHub


reschke opened a new pull request, #1486:
URL: https://github.com/apache/jackrabbit-oak/pull/1486

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-24 Thread via GitHub


smiroslav merged PR #1441:
URL: https://github.com/apache/jackrabbit-oak/pull/1441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (JCR-5062) Attempt to return connection twice

2024-05-24 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/JCR-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849201#comment-17849201
 ] 

Julian Reschke commented on JCR-5062:
-

We could add debug information to find out why the connection is closed twice. 
But it's a bit of work. (We have similar code in Oak's RDB code).

> Attempt to return connection twice
> --
>
> Key: JCR-5062
> URL: https://issues.apache.org/jira/browse/JCR-5062
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.20.16
>Reporter: Henrik Hald Nørgaard
>Priority: Minor
> Attachments: stacktrace.txt
>
>
> We are using a JackRabbit content repository and are going to update some 
> nodes with a new mixin. While iterating through the nodes that should be 
> updated, the following warning sometimes appears in the log:
> {{WARN  [org.jboss.jca.core.connectionmanager.pool.strategy.OnePool] 
> (ServerService Thread Pool -- 88) IJ000609: Attempt to return connection 
> twice: 
> org.jboss.jca.core.connectionmanager.listener.NoTxConnectionListener@f6ff104[state=NORMAL
>  managed 
> connection=org.jboss.jca.adapters.jdbc.local.LocalManagedConnection@7f3ceaf7 
> connection handles=0 lastReturned=1715156332529 lastValidated=1715156332529 
> lastCheckedOut=1715156332528 trackByTx=false 
> pool=org.jboss.jca.core.connectionmanager.pool.strategy.OnePool@16cc91e8 
> mcp=SemaphoreConcurrentLinkedQueueManagedConnectionPool@53f6d09[pool=DezideAuthorJackrabbit]]:
>  java.lang.Throwable: STACKTRACE}}
> I have attached a stacktrace.
> It seems that the database connection handled by the 
> BundleDbPersistenceManager can in some situations be closed twice?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (JCR-5062) Attempt to return connection twice

2024-05-24 Thread Jira


[ 
https://issues.apache.org/jira/browse/JCR-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849200#comment-17849200
 ] 

Henrik Hald Nørgaard commented on JCR-5062:
---

Thank you for your reply.

It will be difficult to write a test case that consistently reproduces this 
warning. It seems to appear when we are doing "a lot" of work in the repository 
and it does not appear consistently.

I think that we will close our eyes and ignore this warning for now.

> Attempt to return connection twice
> --
>
> Key: JCR-5062
> URL: https://issues.apache.org/jira/browse/JCR-5062
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.20.16
>Reporter: Henrik Hald Nørgaard
>Priority: Minor
> Attachments: stacktrace.txt
>
>
> We are using a JackRabbit content repository and are going to update some 
> nodes with a new mixin. While iterating through the nodes that should be 
> updated, the following warning sometimes appears in the log:
> {{WARN  [org.jboss.jca.core.connectionmanager.pool.strategy.OnePool] 
> (ServerService Thread Pool -- 88) IJ000609: Attempt to return connection 
> twice: 
> org.jboss.jca.core.connectionmanager.listener.NoTxConnectionListener@f6ff104[state=NORMAL
>  managed 
> connection=org.jboss.jca.adapters.jdbc.local.LocalManagedConnection@7f3ceaf7 
> connection handles=0 lastReturned=1715156332529 lastValidated=1715156332529 
> lastCheckedOut=1715156332528 trackByTx=false 
> pool=org.jboss.jca.core.connectionmanager.pool.strategy.OnePool@16cc91e8 
> mcp=SemaphoreConcurrentLinkedQueueManagedConnectionPool@53f6d09[pool=DezideAuthorJackrabbit]]:
>  java.lang.Throwable: STACKTRACE}}
> I have attached a stacktrace.
> It seems that the database connection handled by the 
> BundleDbPersistenceManager can in some situations be closed twice?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)