[jira] [Updated] (JCRVLT-754) check-release does not work for filevault anymore
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-754: --- Status: Patch Available (was: In Progress) > check-release does not work for filevault anymore > - > > Key: JCRVLT-754 > URL: https://issues.apache.org/jira/browse/JCRVLT-754 > Project: Jackrabbit FileVault > Issue Type: Task >Reporter: Julian Reschke >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.7.4 > > Attachments: JCRVLT-754-1.patch > > > Since https://issues.apache.org/jira/browse/JCRVLT-742, no sha1 is generated > anymore; however, this is what is put into the generated vote template. > The proper fix likely would be to put the SHA512 checksum into the vote > template. > Furthermore, the basename of the source artefact changed from"src" to > "source-release". This needs to be adjusted in the check script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCRVLT-754) check-release does not work for filevault anymore
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855248#comment-17855248 ] Konrad Windszus commented on JCRVLT-754: I attached my proposed fix in [^JCRVLT-754-1.patch]. Please have a look [~reschke]. > check-release does not work for filevault anymore > - > > Key: JCRVLT-754 > URL: https://issues.apache.org/jira/browse/JCRVLT-754 > Project: Jackrabbit FileVault > Issue Type: Task >Reporter: Julian Reschke >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.7.4 > > Attachments: JCRVLT-754-1.patch > > > Since https://issues.apache.org/jira/browse/JCRVLT-742, no sha1 is generated > anymore; however, this is what is put into the generated vote template. > The proper fix likely would be to put the SHA512 checksum into the vote > template. > Furthermore, the basename of the source artefact changed from"src" to > "source-release". This needs to be adjusted in the check script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCRVLT-754) check-release does not work for filevault anymore
[ https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-754: --- Attachment: JCRVLT-754-1.patch > check-release does not work for filevault anymore > - > > Key: JCRVLT-754 > URL: https://issues.apache.org/jira/browse/JCRVLT-754 > Project: Jackrabbit FileVault > Issue Type: Task >Reporter: Julian Reschke >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.7.4 > > Attachments: JCRVLT-754-1.patch > > > Since https://issues.apache.org/jira/browse/JCRVLT-742, no sha1 is generated > anymore; however, this is what is put into the generated vote template. > The proper fix likely would be to put the SHA512 checksum into the vote > template. > Furthermore, the basename of the source artefact changed from"src" to > "source-release". This needs to be adjusted in the check script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCRVLT-754) check-release does not work for filevault anymore
[
https://issues.apache.org/jira/browse/JCRVLT-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855246#comment-17855246
]
Konrad Windszus commented on JCRVLT-754:
bq. For the basenames, can we switch it for filevault maintenance releases as
well,
Yes, although it is unlikely to happen. Therefore supporting both ZIP filename
formats is IMHO too much effort
I am not sure about the intent of of the additional check of the SHA1 given as
parameter. There is already a check if the checksums are correctly calculated
for the to-be release source ZIP. What exactly do we want to verify here? Check
if someone replaced the source ZIP and the checksums in the SVN repo as well
as modified the Git tag after the vote has been sent out? Not sure this is
worth checking at all. I would rather tend to make this additional SHA CLI
argument for {{check-release.sh}} optional and leave it out for FileVault. WDYT
[~reschke]?
> check-release does not work for filevault anymore
> -
>
> Key: JCRVLT-754
> URL: https://issues.apache.org/jira/browse/JCRVLT-754
> Project: Jackrabbit FileVault
> Issue Type: Task
>Reporter: Julian Reschke
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.4
>
>
> Since https://issues.apache.org/jira/browse/JCRVLT-742, no sha1 is generated
> anymore; however, this is what is put into the generated vote template.
> The proper fix likely would be to put the SHA512 checksum into the vote
> template.
> Furthermore, the basename of the source artefact changed from"src" to
> "source-release". This needs to be adjusted in the check script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (JCRVLT-759) Update to ASF Parent POM 32
[ https://issues.apache.org/jira/browse/JCRVLT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved JCRVLT-759. Resolution: Fixed > Update to ASF Parent POM 32 > --- > > Key: JCRVLT-759 > URL: https://issues.apache.org/jira/browse/JCRVLT-759 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: Misc >Affects Versions: 3.7.2 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.7.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] JCRVLT-759 Update to ASF Parent 32 [jackrabbit-filevault]
kwin merged PR #338: URL: https://github.com/apache/jackrabbit-filevault/pull/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
