[jira] [Commented] (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210264#comment-13210264 ] Marek Slama commented on JCR-134: - Done. I filed JCR-3238. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Content Repository Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Jukka Zitting Priority: Minor Fix For: 1.6 Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208482#comment-13208482 ] Marek Slama commented on JCR-134: - There is one use case where it fails: When I have versionable node but never create version using VersionManager so there is only rootVersion. I assume VersionHistory removal is triggered by removing last non root Version so it is understandable. To fix this it would be good to have some way how to explicitly remove also rootVersion after versionable node remove so this removal of rootVersion could trigger removal of version history. It would be good to allow rootVersion removal when its versioned node is already removed. Does it make sense to create issue for this use case? (Yes it is our mistake as we set versionable node which was not actually used as versioned node. We could workaround it by creating one additional regular version and then removing node, this new version to do full version history cleanup.) Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Content Repository Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Jukka Zitting Priority: Minor Fix For: 1.6 Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208497#comment-13208497 ] Jukka Zitting commented on JCR-134: --- It would be good to allow rootVersion removal when its versioned node is already removed. Sounds like a reasonable idea. Does it make sense to create issue for this use case? Yes, please do. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Content Repository Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Jukka Zitting Priority: Minor Fix For: 1.6 Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12712992#action_12712992 ] Jukka Zitting commented on JCR-134: --- Merged to the 1.x branch in revision 778680. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Content Repository Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Jukka Zitting Priority: Minor Fix For: 1.6.0 Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661088#action_12661088 ] Cédric Damioli commented on JCR-134: may the attached patch be reviewed and eventually committed, so this issue can be part of the upcoming 1.5.1 release ? IMHO, many users have the same concern (see recent thread on users@) Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Tobias Bocanegra Priority: Minor Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621448#action_12621448 ] Oleg Alexeyev commented on JCR-134: --- IMO, this covers at least the most important use case. Actually, node.remove() after all versions (except the root version) have been deleted is not possible as the node refers to one of the versions. So, we tried to clean up VH, we used node.remove() and then VH.removeVersion() for each Version returned by getAllVersions() enumeration except the root one. This approach works, but leaves VH and root version nodes. Thanks for approaching this issue! :) Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Tobias Bocanegra Priority: Minor Attachments: jackrabbit-1.4.x-JCR-134-first-try-2008-08-11.patch since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554679 ] Jukka Zitting commented on JCR-134: --- Is there any chance of having this fixed in 1.4? No, at least not in the scope you envision, see Tobias' summary comment above. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ https://issues.apache.org/jira/browse/JCR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554267 ] Oleg Alexeyev commented on JCR-134: --- Is there any chance of having this fixed in 1.4? Our use case is as follows: data format (node structure) for an application may change from one app's version to another (currently it happens pretty often, as it's not stable yet) and nodes are versionable. Conversion is done by creating another nodes' tree and copying properties there, original nodes are deleted. And they, of course, should be deleted completely, along with all the versions and VH... Thanks, --oleg Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: https://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assignee: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457629 ] Tobias Bocanegra commented on JCR-134: -- yes, of course: empty VH, no references - remove non-empty VH, no references - keep (or at least configurable). Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
Paul J DeCoursey a écrit : Cédric Damioli (JIRA) wrote: [ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457455 ] Cédric Damioli commented on JCR-134: The VH need only to be kept when there are remaining Version attached to it. In many apps, it would be great to get rid of empty VH (ie no more Version, and no more Node referencing it). This doesn't seem right to me. Kind of defeats the purpose of Versioning if we start removing deleted items, deleted is just another state in the history that should be tracked and preserved. Deleting Versions means actually deleting these history states. Its no more than an administrative task, which in some cases may be very useful, eg. to maintain the repository as small as possible, or to keep only important versions (up to the app, of course). The point of this JCR-134 issue is only that when there is no more Version in the VH (they have all been deleted) and no more Node in any workspace referencing this VH, there should be a way to also delete the VH, which can't be useful anymore. Regards, Cédric
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457736 ] Cédric Damioli commented on JCR-134: Concerning the eventual ref count kept on VHs, is it allowed to store it in the repository, as a new property of the VH ? If yes there would be a compatibility problem whith existing repositories. Otherwise, how would you see the storage of this ref count ? Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457305 ] Cédric Damioli commented on JCR-134: On node.removeMixin(mix:versionable), should the VersionHistory also be deleted ? May a Node be versionable in a workspace and not in another one ? The above proposal (remove the VH when no node and no version references it) would be great, but I think there is no easy and cheap way ATM to check all corresponding nodes on a node or version deletion. Or am I missing something ? Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457333 ] Tobias Bocanegra commented on JCR-134: -- but I think there is no easy and cheap way ATM to check all corresponding nodes on a node or version deletion. you're right. one would have to check all workspaces if no corresponding node exist anymore. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457427 ] Cédric Damioli commented on JCR-134: And about the two other points : - should the VH be deleted on node.removeMixin(mix:versionable) ? would it be safe ? - may a Node be versionable in a workspace and not in another one ? I think the spec allows it (it doesn't actually forbid it). But I need confirmation. So the only way to do this is IMHO the following algorithm : - when removing a Version, if this is the last version (only the jcr:rootVersion is left), and there is no references to the jcr:rootVersion, one can remove the VH - when removing a Node, if it is versionable, and references the jcr:rootVersion (ie have never been checked in) and there is no other references to the VH (in others workspaces), then delete the VH - when removing the mix:versionable, either delete directly the VH (see my first question in this post), either check if there is only the jcr:rootVersion left, and then delete the VH. WDYT ? Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457445 ] Julian Reschke commented on JCR-134: Isn't it a common use case that version histories need to be preserved even after the last reference is gone? It seems to me that this may be a valuable feature, so maybe this needs to be configurable. Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-134) Unreferenced VersionHistory should be deleted automatically.
[ http://issues.apache.org/jira/browse/JCR-134?page=comments#action_12457455 ] Cédric Damioli commented on JCR-134: The VH need only to be kept when there are remaining Version attached to it. In many apps, it would be great to get rid of empty VH (ie no more Version, and no more Node referencing it). Unreferenced VersionHistory should be deleted automatically. Key: JCR-134 URL: http://issues.apache.org/jira/browse/JCR-134 Project: Jackrabbit Issue Type: New Feature Components: versioning Reporter: Tobias Bocanegra Assigned To: Tobias Bocanegra Priority: Minor since the creation of a VersionHistory is triggered by the creation of a mix:versionable node, the removal should happen automatically, as soon as no references to that version histroy exist anymore. this is the case, when all mix:versionable nodes (in all workspaces) belonging to that VH are deleted, and all the versions in the VH are removed i.e. only the jcr:rootVersion is left. At this point, the VH should be deleted aswell. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
