[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Tobias Bocanegra (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926334#comment-16926334
 ] 

Tobias Bocanegra commented on JCRVLT-367:
-

ok then! go ahead.

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: JCRVLT-367-remove-version-parsing-v01.patch
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926327#comment-16926327
 ] 

Konrad Windszus commented on JCRVLT-367:


IMHO this would be nice to integrate into 3.4.0 and definitely belongs to the 
Java 8 cleanup tasks. I quickly cross-checked the fix on Mac OS and it works 
for me. I also cross-checked the generated vlt.bat and this looks good to me as 
well.

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.2
>
> Attachments: JCRVLT-367-remove-version-parsing-v01.patch
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Tobias Bocanegra (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926196#comment-16926196
 ] 

Tobias Bocanegra commented on JCRVLT-367:
-

I don't think we should block the release... moving it to 3.4.2

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.2
>
> Attachments: JCRVLT-367-remove-version-parsing-v01.patch
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926028#comment-16926028
 ] 

Konrad Windszus commented on JCRVLT-367:


Since the version check was introduced for JCRVLT-149 and FileVault 3.4.0 is 
only supporting Java 8 or newer I think the whole version parsing can be 
completely removed.
[~tripod] WDYT?

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.0
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Robert Munteanu (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925992#comment-16925992
 ] 

Robert Munteanu commented on JCRVLT-367:


[~kwin] - the script from the article you mentioned correctly outputs '11' for 
the {{java -version}} I added in the description.

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.0
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCRVLT-367) CLONE - vlt shell script prints out error when using openjdk

2019-09-09 Thread Konrad Windszus (Jira) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925970#comment-16925970
 ] 

Konrad Windszus commented on JCRVLT-367:


Not sure whether Windows is affected as well, but maybe for Unix/MacOS one 
could rely on http://eed3si9n.com/detecting-java-version-bash.

> CLONE - vlt shell script prints out error when using openjdk
> 
>
> Key: JCRVLT-367
> URL: https://issues.apache.org/jira/browse/JCRVLT-367
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.2.8
>Reporter: Robert Munteanu
>Priority: Minor
> Fix For: 3.4.0
>
>
> {noformat}$ vlt --version
> /usr/bin/vlt: line 146: [: 110 2019-07-16: integer expression expected
> Jackrabbit FileVault [version 3.2.8] Copyright 2018 by Apache Software 
> Foundation. See LICENSE.txt for more information.{noformat}
> {noformat}$ java -version
> openjdk version "11.0.4" 2019-07-16
> OpenJDK Runtime Environment (build 11.0.4+11-suse-1.1-x8664)
> OpenJDK 64-Bit Server VM (build 11.0.4+11-suse-1.1-x8664, mixed 
> mode){noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)