[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406886#comment-17406886
]
Dominik Süß commented on JCRVLT-391:
[~kwin] this is based on our baseline chels we perform to prevent adopting
breaking changes without validation of the impact. So the breaking change
happened in a differ Commit- thx for the pointer. This helps me to verify /
proof that noone is depending on the removed api. ( i know it’s very unlikely
but we‘ve seen the weirdest abuse of internal utils already )
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406812#comment-17406812
]
Konrad Windszus commented on JCRVLT-391:
{{org.apache.jackrabbit.vault.util.xml.serialize}} has been increased to 3.0.0
because formerly public classes have been removed
(https://github.com/apache/jackrabbit-filevault/commit/ffe8e36fbdb3023a4436b820463197762aa9c281#diff-98491387af99e0595ce4f42692221e831a038d9f94bf6b3316383336eae20378L1).
{{org.apache.jackrabbit.vault.util.xml}} does not contain any classes,
therefore the package version should not matter (there should never be a
import-package towards it). But maybe in the past it contained some classes. We
can remove the package-version there.
What concrete issue do you have? Which bundle has conflicting imports to those
packages?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406792#comment-17406792
]
Dominik Süß commented on JCRVLT-391:
[~kwin] - as I'm currently in the process of tracking down any kind of
potentially breaking dependencies for the version increase I stumbled over the
version increases of
https://github.com/apache/jackrabbit-filevault/commit/0b5716a2ffd3390731d7a3949e00dccf2e37b29a
specifically
{code}org.apache.jackrabbit.vault.util.xml
org.apache.jackrabbit.vault.util.xml.serialize
{code}
both receiving a major version increase although it looks like nothing has
changed for both packages.
Can you please shed some light on why a version increase was required or if
this was an accidential increase because of the refactoring efforts? If yes
could we please export the old version as well to not have dependencies
unnecessarily be detected as unsatisfied.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012043#comment-17012043
]
Konrad Windszus commented on JCRVLT-391:
Restored backwards compatibility (to a large extend) with
http://svn.apache.org/viewvc?view=revision&revision=1872562.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993552#comment-16993552
]
Tobias Bocanegra commented on JCRVLT-391:
-
yes. please go ahead. thanks for all the work!
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991218#comment-16991218
]
Konrad Windszus commented on JCRVLT-391:
Can I go ahead here or should I wait before applying this?
I guess from license perspective this should be safer than the previous "This
class and dependencies were copied from the sun jdk1.5 source base"
(https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L65).
AFAIK the JDK source was never released with an ASF compliant license
(https://www.oracle.com/technetwork/java/javase/source-license-137365.html):
SCSL is explicitly listed in
https://www.apache.org/legal/resolved.html#category-x.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986822#comment-16986822
]
Julian Reschke commented on JCRVLT-391:
---
My 2 cents: if the license is compatible with the Apache license, it should be
ok. Or am I missing something here?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986728#comment-16986728
]
Tobias Bocanegra commented on JCRVLT-391:
-
I confused the EPL with EDL; In fact, *Eclipse Distribution License 1.0* it is
a category a. (the EPL is category-b).
So this should be ok.
> What Adobe thinks about this, is not that important IMHO,
well, yes and no. if we add a dependency with a problematic license, and Adobe
doesn't allow it in the product, then we effectively can't use this project
anymore. So any customers relying on new features and bug fixes would be
impacted as well.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986695#comment-16986695
]
Konrad Windszus commented on JCRVLT-391:
>From an ASF point of view EDL is not a problematic license
>(https://www.apache.org/legal/resolved.html#category-b).
What Adobe thinks about this, is not that important IMHO, as this is open
source following the ASF guidelines.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986464#comment-16986464
]
Tobias Bocanegra commented on JCRVLT-391:
-
the Eclipse Distribution License is better, but we would need to check with
Adobe Legal, before we can include it in the product.
I would prefer a solution w/o a _problematic_ license.
> WDYT about the max line length?
I don't think this is a problem.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985892#comment-16985892
]
Konrad Windszus commented on JCRVLT-391:
[~tripod] This is no longer true, as JAXB-Impl has been donated to Eclipse and
therefore is having now an Eclipse license
(https://github.com/eclipse-ee4j/jaxb-ri#licensing-and-governance). I guess not
all places have been updated yet with regards to the license but version 2.3.2
was definitely release after it has been donated to Eclipse.
WDYT about the max line length?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985726#comment-16985726
]
Tobias Bocanegra commented on JCRVLT-391:
-
{noformat}
org.glassfish.jaxb
txw2
2.3.2
{noformat}
AFAICS, this has a *CDDL+GPL License*
https://mvnrepository.com/artifact/org.glassfish.jaxb/txw2/2.3.1
which is problematic to use. we cannot embed it and we (adobe) cannot put it
into our products. can you find another library?
(com.fasterxml.woodstox is Apache-2.0 licensed, so no problem.)
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985642#comment-16985642
]
Konrad Windszus commented on JCRVLT-391:
I came up with a different approach based on StAX in
https://github.com/apache/jackrabbit-filevault/pull/69/files. The only thing
missing is the maximum line length. It would be possible to implement that as
well, but I don't really see the need here, as DocView files are anyhow put
each attribute in a new line and all other files shouldn't have too many
attributes per element. Overall with that PR I could get rid of around 9200 LoC!
[~reschke][[~tripod] WDYT?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The following alternatives are available:
> # Use the {{javax.xml.transform}} API (JAXP Transformation API, TrAX). There
> is no official way though to control the order of attribute, therefore I
> would recommend to already emit the attributes in the correct order instead
> of reordering them with the output. Controlling the indentation of
> attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
> # Use StAX with the Woodstox implementation. Seems faster, but still no
> sophisticated output formatting options available (like indentation options
> and line length)
> # Implement a simple serializer based on SAX events from scratch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985072#comment-16985072
]
Konrad Windszus commented on JCRVLT-391:
I made an attempt in https://github.com/apache/jackrabbit-filevault/pull/68.
Some test are failing.
On question around linebreaks between attributes. Why do you expect
{code}
http://www.jcp.org/jcr/1.0";
xmlns:nt="http://www.jcp.org/jcr/nt/1.0";
jcr:primaryType="nt:unstructured">
{code}
instead of
{code}
http://www.jcp.org/jcr/1.0";
xmlns:nt="http://www.jcp.org/jcr/nt/1.0";
jcr:primaryType="nt:unstructured">
{code}
[~tripod] Under which circumstances should there be a linebreak in front of an
attribute?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977217#comment-16977217
]
Julian Reschke commented on JCRVLT-391:
---
That sounds like a good plan.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977205#comment-16977205
]
Konrad Windszus commented on JCRVLT-391:
One concrete issue is JCRVLT-393. The other is the concern about maintaining
third party code. Regarding reproducible ouutput:
* AttributeImpl is not using a HashSet but rather a list with a predictable
order, so any serialization based on SAX keeps that order
* Indentation of attributes is not necessary for reproducability but makes the
diffs nicer, unfortunately there is not OOTB support for that in TraX
(https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes)
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976999#comment-16976999
]
Tobias Bocanegra commented on JCRVLT-391:
-
it's not only the ordering of the attributes, it's also having a well defined,
fixed, reproducible outputformat for the serialized nodes.
this is especially important since the exports are usually stored in a SCM. if
each _sync_ would cause a different formatting, due to user preferences or
hashmap ordering, there would be a lot of false positive in respect to modified
files.
except for the not-so-nice code duplication, I don't see any problem why we
shouldn't keep the current copy of xecres. is there a concrete reason you want
to update xecres?
the other drawback using a transformer could be the impact on performance.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976435#comment-16976435
]
Konrad Windszus commented on JCRVLT-391:
I think it is to make diffs nicer to evaluate. You can see at first glance
which attribute has been added/removed.
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976434#comment-16976434
]
Julian Reschke commented on JCRVLT-391:
---
Yes, I saw that. But *why* do we care about that?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976429#comment-16976429
]
Konrad Windszus commented on JCRVLT-391:
I guess the reason is in
https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
[~tripod] Was there any other reason?
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-391) Remove copied classes of Xerces
[
https://issues.apache.org/jira/browse/JCRVLT-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976426#comment-16976426
]
Julian Reschke commented on JCRVLT-391:
---
Does anybody recall why we need this???
> Remove copied classes of Xerces
> ---
>
> Key: JCRVLT-391
> URL: https://issues.apache.org/jira/browse/JCRVLT-391
> Project: Jackrabbit FileVault
> Issue Type: Task
> Components: vlt
>Affects Versions: 3.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.2
>
>
> Currently the classes below {{o.a.j.v.util.xml}} seem to be a copy of Xerces
> classes. Instead of just relying on an old copy one should use a proper Maven
> dependency together with https://maven.apache.org/plugins/maven-shade-plugin/
> or https://bnd.bndtools.org/instructions/conditionalpackage.html to make sure
> update to the latest version is possible.
> Also it needs to be clarified if the embedded Xerces should be listed
> explicitly in
> https://github.com/apache/jackrabbit-filevault/blob/trunk/LICENSE.txt.
> The original intent is stated in
> https://github.com/apache/jackrabbit-filevault/blob/9fa6c72bf4bdf36331b50b9370f3ed826a4622e8/vault-core/src/main/java/org/apache/jackrabbit/vault/util/xml/serialize/XMLSerializer.java#L64.
> The only modifications to the original Xerces were linebreaks after
> attributes and an alphabetic attribute sort order.
> The alternative is to use the {{javax.xml.transform}} API (JAXP
> Transformation API). There is no official way though to control the order of
> attribute, therefore I would recommend to already emit the attributes in the
> correct order instead of reordering them with the output. Controlling the
> indentation of attributes is hard to achieve:
> https://stackoverflow.com/questions/8393370/use-xslt-to-add-newlines-after-attributes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
