[jira] Commented: (JCR-1209) NodeImpl.checkot() calls save() two times
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541305 ] Marcel Reutegger commented on JCR-1209: --- I did a quick performance test using derby and the default configuration (but removed the durability setting we have for testing). The test involved 200 checkin/checkout cycles: current average checkout time: 140 ms. checkout time using node.save: 90 ms. that's a decrease of 35% > NodeImpl.checkot() calls save() two times > - > > Key: JCR-1209 > URL: https://issues.apache.org/jira/browse/JCR-1209 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-core, versioning >Reporter: Przemo Pakulski >Priority: Minor > Fix For: 1.4 > > > Similar to JCR-975, The version related properties on a versionable node that > is checked out are saved individually. There is no need to save them > individually because checkd in node must not have pending changes and save() > can be called safely on the node itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1209) NodeImpl.checkot() calls save() two times
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541293 ] Przemo Pakulski commented on JCR-1209: -- The idea was to speed up versioning operations like checkin/checkout I'll revert the changes for now. > NodeImpl.checkot() calls save() two times > - > > Key: JCR-1209 > URL: https://issues.apache.org/jira/browse/JCR-1209 > Project: Jackrabbit > Issue Type: Improvement > Components: versioning >Affects Versions: 1.3.3, 1.4 >Reporter: Przemo Pakulski >Priority: Minor > Fix For: 1.4 > > > Similar to JCR-975, The version related properties on a versionable node that > is checked out are saved individually. There is no need to save them > individually because checkd in node must not have pending changes and save() > can be called safely on the node itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1209) NodeImpl.checkot() calls save() two times
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541286 ] Stefan Guggisberg commented on JCR-1209: > We could check if node has pending changes, if not call save once on node > otherwise call save twice on properties level, but i'm not sure if it makes > sense. i don't think that's worth it. i'd leave it as it was before. > NodeImpl.checkot() calls save() two times > - > > Key: JCR-1209 > URL: https://issues.apache.org/jira/browse/JCR-1209 > Project: Jackrabbit > Issue Type: Improvement > Components: versioning >Affects Versions: 1.3.3, 1.4 >Reporter: Przemo Pakulski >Priority: Minor > Fix For: 1.4 > > > Similar to JCR-975, The version related properties on a versionable node that > is checked out are saved individually. There is no need to save them > individually because checkd in node must not have pending changes and save() > can be called safely on the node itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1209) NodeImpl.checkot() calls save() two times
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541273 ] Przemo Pakulski commented on JCR-1209: -- hm, I forgot that Node.save() method saves changes on the whole subtree. We could check if node has pending changes, if not call save once on node otherwise call save twice on properties level, but i'm not sure if it makes sense. > NodeImpl.checkot() calls save() two times > - > > Key: JCR-1209 > URL: https://issues.apache.org/jira/browse/JCR-1209 > Project: Jackrabbit > Issue Type: Improvement > Components: versioning >Affects Versions: 1.3.3, 1.4 >Reporter: Przemo Pakulski >Priority: Minor > Fix For: 1.4 > > > Similar to JCR-975, The version related properties on a versionable node that > is checked out are saved individually. There is no need to save them > individually because checkd in node must not have pending changes and save() > can be called safely on the node itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
