[jira] Updated: (JCR-680) Improve the Value implementation
[ https://issues.apache.org/jira/browse/JCR-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-680: -- Attachment: GenericValue.tar.gz Improve the Value implementation Key: JCR-680 URL: https://issues.apache.org/jira/browse/JCR-680 Project: Jackrabbit Issue Type: Improvement Components: core Reporter: Jukka Zitting Assigned To: Jukka Zitting Priority: Minor Attachments: class.jpg, GenericValue.patch, GenericValue.tar.gz, JCR-680.patch The current Value implementation found in jackrabbit-jcr-commons has some deficiencies like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and Path values not following namespace remappings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-680) Improve the Value implementation
[ http://issues.apache.org/jira/browse/JCR-680?page=all ] Jukka Zitting updated JCR-680: -- Attachment: GenericValue.patch Attached GenericValue.patch, that implements only the State pattern part of the proposed change. The patch is against Jackrabbit trunk, since the change affects both jackrabbit-core and jackrabbit-jcr-commons. This patch fixes JCR-320 and notably simplifies the Value classes. The changes in jackrabbit-core replace direct dependencies to the Value classes with use of Session.getValueFactory().createValue(). Improve the Value implementation Key: JCR-680 URL: http://issues.apache.org/jira/browse/JCR-680 Project: Jackrabbit Issue Type: Improvement Components: core Reporter: Jukka Zitting Assigned To: Jukka Zitting Priority: Minor Attachments: class.jpg, GenericValue.patch, JCR-680.patch The current Value implementation found in jackrabbit-jcr-commons has some deficiencies like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and Path values not following namespace remappings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-680) Improve the Value implementation
[ http://issues.apache.org/jira/browse/JCR-680?page=all ] Jukka Zitting updated JCR-680: -- Attachment: JCR-680.patch Attached a patch that contains a full Value implementation I've been playing with lately in an attempt to resolve JCR-301. The proposed Value implementation has the following extra features compared to the current implementation: * Correct (AFAIK) implementation of Value.equals() and Value.hashCode() * Support for namespace remappings in NAME and PATH values * Support for serialization The implementation is based on the State pattern used originally in JCR-RMI. This makes for a nice separation of the committed and uncommitted value states and notably simplifies the logic within the Value methods. Improve the Value implementation Key: JCR-680 URL: http://issues.apache.org/jira/browse/JCR-680 Project: Jackrabbit Issue Type: Improvement Components: core Reporter: Jukka Zitting Assigned To: Jukka Zitting Priority: Minor Attachments: JCR-680.patch The current Value implementation found in jackrabbit-jcr-commons has some deficiencies like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and Path values not following namespace remappings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-680) Improve the Value implementation
[ http://issues.apache.org/jira/browse/JCR-680?page=all ] Jukka Zitting updated JCR-680: -- Attachment: class.jpg Attached a class diagram of the patch contents. Improve the Value implementation Key: JCR-680 URL: http://issues.apache.org/jira/browse/JCR-680 Project: Jackrabbit Issue Type: Improvement Components: core Reporter: Jukka Zitting Assigned To: Jukka Zitting Priority: Minor Attachments: class.jpg, JCR-680.patch The current Value implementation found in jackrabbit-jcr-commons has some deficiencies like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and Path values not following namespace remappings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
