Re: [PR] OAK-10784: o.a.j.o.plugins.migration.version.VersionableEditor should… [jackrabbit-oak]
mbaedke merged PR #1438: URL: https://github.com/apache/jackrabbit-oak/pull/1438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10784: o.a.j.o.plugins.migration.version.VersionableEditor should… [jackrabbit-oak]
mbaedke commented on code in PR #1438:
URL: https://github.com/apache/jackrabbit-oak/pull/1438#discussion_r1593709973
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/version/VersionableEditor.java:
##
@@ -79,7 +80,7 @@ public class VersionableEditor extends DefaultEditor {
private VersionableEditor(Provider provider, NodeBuilder rootBuilder) {
this.rootBuilder = rootBuilder;
-this.versionStorage = getVersionStorage(rootBuilder);
+this.versionStorage = createVersionStorage(rootBuilder);
Review Comment:
Yes, but the migration works completely on the nodestore API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10784: o.a.j.o.plugins.migration.version.VersionableEditor should… [jackrabbit-oak]
mbaedke commented on code in PR #1438:
URL: https://github.com/apache/jackrabbit-oak/pull/1438#discussion_r1593709973
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/version/VersionableEditor.java:
##
@@ -79,7 +80,7 @@ public class VersionableEditor extends DefaultEditor {
private VersionableEditor(Provider provider, NodeBuilder rootBuilder) {
this.rootBuilder = rootBuilder;
-this.versionStorage = getVersionStorage(rootBuilder);
+this.versionStorage = createVersionStorage(rootBuilder);
Review Comment:
Depends on the RepositoryInitializers used.
org.apache.jackrabbit.oak.InitialContent does create it,
com.adobe.granite.repository.impl.GraniteContent does not. After all these
years using it, I'd guess that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10784: o.a.j.o.plugins.migration.version.VersionableEditor should… [jackrabbit-oak]
reschke commented on code in PR #1438:
URL: https://github.com/apache/jackrabbit-oak/pull/1438#discussion_r1593484456
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/migration/version/VersionableEditor.java:
##
@@ -79,7 +80,7 @@ public class VersionableEditor extends DefaultEditor {
private VersionableEditor(Provider provider, NodeBuilder rootBuilder) {
this.rootBuilder = rootBuilder;
-this.versionStorage = getVersionStorage(rootBuilder);
+this.versionStorage = createVersionStorage(rootBuilder);
Review Comment:
Hm, on secomd thought... I'd like to understand under what circumstances
there can be an Oak repository without version storage. Isn't it always created
by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
