Re: svn commit: r1178129 | Latency/readBuffer
Hello,
I will work on a patch which introduce a property to change the
readBuffer size (default 8192B).
That me seems important because this buffer size is the calculation base
for the latency time.
I would like for some bandwidth tests, change the buffer size to ~1400
or 1500B (i.e. ip packet size).
Sebb, have you a special opinion (or history) on this buffer size?
Thanks
Milamber
Le 02/10/2011 07:49, milam...@apache.org a ecrit :
Author: milamber
Date: Sun Oct 2 05:49:57 2011
New Revision: 1178129
URL: http://svn.apache.org/viewvc?rev=1178129view=rev
Log:
Bug 51918 - GZIP compressed traffic produces errors, when multiple
connections allowed
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
jakarta/jmeter/trunk/xdocs/changes.xml
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java?rev=1178129r1=1178128r2=1178129view=diff
==
---
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
(original)
+++
jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
Sun Oct 2 05:49:57 2011
@@ -47,8 +47,6 @@ public class JMeterContext {
private int threadNum;
-private byte[] readBuffer = null;
-
private boolean isReinitSubControllers = false;
JMeterContext() {
@@ -66,7 +64,6 @@ public class JMeterContext {
previousSampler = null;
samplingStarted = false;
threadNum = 0;
-readBuffer = null;
thread = null;
isReinitSubControllers = false;
}
@@ -80,18 +77,6 @@ public class JMeterContext {
return variables;
}
-/**
- * A temporary buffer that can be shared between samplers in a thread.
- *
- * @return the shared read buffer
- */
-public byte[] getReadBuffer() {
-if (readBuffer == null) {
-readBuffer = new byte[8192];
-}
-return readBuffer;
-}
-
public void setVariables(JMeterVariables vars) {
this.variables = vars;
}
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1178129r1=1178128r2=1178129view=diff
==
---
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Sun Oct 2 05:49:57 2011
@@ -1548,7 +1548,7 @@ public abstract class HTTPSamplerBase ex
*/
public byte[] readResponse(SampleResult sampleResult, InputStream in,
int length) throws IOException {
-byte[] readBuffer = getThreadContext().getReadBuffer();
+byte[] readBuffer = new byte[8192]; // 8kB is the (max) size to have
the latency ('the first packet')
int bufferSize=32;// Enough for MD5
MessageDigest md=null;
Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=1178129r1=1178128r2=1178129view=diff
==
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Sun Oct 2 05:49:57 2011
@@ -33,6 +33,7 @@ Earlier changes are detailed in the a h
ptemporary section to collect changes while release vote is in progress/p
ul
liBug 51932 - CacheManager does not handle cache-control header with any
attributes after max-age/li
+liBug 51918 - GZIP compressed traffic produces errors, when multiple
connections allowed/li
/ul
-
To unsubscribe, e-mail: notifications-unsubscr...@jakarta.apache.org
For additional commands, e-mail: notifications-h...@jakarta.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download
On 1 October 2011 14:33, Philippe Mouawad philippe.moua...@gmail.com wrote: A little additional note, There is an implementation of Concurrent map by doug lea in concurrent.jar called ConcurrentReaderHashMap that has same performance as HashMap in read and a little less on write. But performances are much better than ConcurrentHashMap. So maybe a better alternative but requires concurrent-1.3.4.jar from: - http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html That looks interesting, however the licensing is not at all clear to me, and AFAICT we would only want the one class, not the entire jar. So it's quite a lot of extra complication for what is just a local optimisation. - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download
On 2 October 2011 15:20, Rainer Jung rainer.j...@kippdata.de wrote: On 02.10.2011 15:49, sebb wrote: On 1 October 2011 14:33, Philippe Mouawad philippe.moua...@gmail.com wrote: A little additional note, There is an implementation of Concurrent map by doug lea in concurrent.jar called ConcurrentReaderHashMap that has same performance as HashMap in read and a little less on write. But performances are much better than ConcurrentHashMap. So maybe a better alternative but requires concurrent-1.3.4.jar from: - http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html That looks interesting, however the licensing is not at all clear to me, and AFAICT we would only want the one class, not the entire jar. So it's quite a lot of extra complication for what is just a local optimisation. Concerning license the page says: All classes are released to the public domain and may be used for any purpose whatsoever without permission or acknowledgment. Portions of the CopyOnWriteArrayList and ConcurrentReaderHashMap classes are adapted from Sun JDK source code. These are copyright of Sun Microsystems, Inc, and are used with their kind permission, as described in this license. and this license is another link to a PDF. Legal has already resolved that one: http://www.apache.org/legal/resolved.html#concurrent Thanks! Very useful. That would allow us to use the class as part of the concurrent library. However, we cannot use that particular source file, because it is one of the Sun-licensed ones. Not sure if there is any other way to include just the class that we need. - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download
Hello Sebb, XMLBeans which is an Apache project under Apache Licence has included it : - http://massapi.com/source/xmlbeans-2.5.0/src/common/org/apache/xmlbeans/impl/common/ConcurrentReaderHashMap.java.html Couldn't we do the same ? Regards Philippe On Sun, Oct 2, 2011 at 4:29 PM, sebb seb...@gmail.com wrote: On 2 October 2011 15:20, Rainer Jung rainer.j...@kippdata.de wrote: On 02.10.2011 15:49, sebb wrote: On 1 October 2011 14:33, Philippe Mouawad philippe.moua...@gmail.com wrote: A little additional note, There is an implementation of Concurrent map by doug lea in concurrent.jar called ConcurrentReaderHashMap that has same performance as HashMap in read and a little less on write. But performances are much better than ConcurrentHashMap. So maybe a better alternative but requires concurrent-1.3.4.jar from: - http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html That looks interesting, however the licensing is not at all clear to me, and AFAICT we would only want the one class, not the entire jar. So it's quite a lot of extra complication for what is just a local optimisation. Concerning license the page says: All classes are released to the public domain and may be used for any purpose whatsoever without permission or acknowledgment. Portions of the CopyOnWriteArrayList and ConcurrentReaderHashMap classes are adapted from Sun JDK source code. These are copyright of Sun Microsystems, Inc, and are used with their kind permission, as described in this license. and this license is another link to a PDF. Legal has already resolved that one: http://www.apache.org/legal/resolved.html#concurrent Thanks! Very useful. That would allow us to use the class as part of the concurrent library. However, we cannot use that particular source file, because it is one of the Sun-licensed ones. Not sure if there is any other way to include just the class that we need. - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org -- Cordialement. Philippe Mouawad.
Re: [Bug 51919] Random ConcurrentModificationException or NoSuchElementException in CookieManager#removeMatchingCookies when using Concurrent Download
On 2 October 2011 19:39, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello Sebb, XMLBeans which is an Apache project under Apache Licence has included it : - http://massapi.com/source/xmlbeans-2.5.0/src/common/org/apache/xmlbeans/impl/common/ConcurrentReaderHashMap.java.html Couldn't we do the same ? Possibly; but we would need to be sure that their reading of the rules was correct; we don't want to propagate a mistake if it is one. I'm pretty sure that they should not have added the AL header to the file, so I wonder if they should have included the file at all. - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: JMeter TLP - draft resolution and first chair
On 1 October 2011 15:36, Rahul Akolkar rahul.akol...@gmail.com wrote: On Wed, Sep 21, 2011 at 8:31 PM, sebb seb...@gmail.com wrote: On 22 September 2011 01:15, Rahul Akolkar rahul.akol...@gmail.com wrote: On Wed, Sep 21, 2011 at 7:33 PM, Henri Yandell bay...@generationjava.com wrote: On Thu, Sep 22, 2011 at 1:30 AM, Rahul Akolkar rahul.akol...@gmail.com wrote: On Tue, Sep 20, 2011 at 3:15 AM, Henri Yandell bay...@generationjava.com wrote: Happy to be on the PMC :) I'm not sure I'll be that active, but hopefully can help with any setup items. +1 for Sebb as Chair. I've updated the resolution to reflect the nomination. If there are no further changes to the proposal in a couple of days, I'll start the TLP vote. We shouldn't vote until Sebb, or someone else, is signed up to be the chair. snip/ Thats reasonable too :-) Sebb? I would have preferred to see JMeter as part of HC, but perhaps it would be better as a TLP. snip/ IMO, yes. However I think we need some more PMC members first. snap/ I see you added olegk, which is goodness. We can always add others I also added Rainer Jung who has kindly agreed to help. later. I think we're good for a vote on the resolution as is on the wiki. WDYT? Yes. -Rahul I can think of some Jakarta PMC members who have been involved with JMeter recently, and I think some of the Tomcat PMC use JMeter. Is it OK just to add them, or should they be asked first? - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
