Re: Patch 52001

[sebb]

On 13 October 2011 18:47, Philippe Mouawad  wrote:
> I agree with you.

By the way, please don't top-post; it's harder to follow the thread
when it appears in reverse order.

> Do we close the issue or we wait for other opinions ?

We can wait a while, and then close it.

> Thanks
> Regards
> Philippe
>
> On Thu, Oct 13, 2011 at 7:45 PM, sebb  wrote:
>
>> On 13 October 2011 18:28, Philippe Mouawad  wrote:
>> > Hello Sebb,
>> > Do you think we should  implement issue
>> > 52001
>> > :
>> >
>> >   - Add scroll automatically to Summary Report
>> >
>> > The only use case I see is when you label sampler with a variable name,
>> > otherwise you may scroll but it won't last after some time number of
>> lines
>> > will stay the same.
>>
>> Yes, it's only needed in limited circumstances, which is why I don't
>> really see the need for it.
>>
>> > If you give me the go, I will patch it.
>>
>> It's not my personal decision; we make decisions by consensus.
>> Any committer can veto a change on a technical basis (e.g. it would
>> break something else) but that is probably not the case here.
>>
>> If it were me, I would not apply the patch as I cannot see the point;
>> more code to test and maintain with little benefit.
>>
>> So I don't support the patch, but if you feel it would be useful I
>> won't veto it.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
>> For additional commands, e-mail: dev-h...@jakarta.apache.org
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: Patch 52001

[Philippe Mouawad]

I agree with you.
Do we close the issue or we wait for other opinions ?

Thanks
Regards
Philippe

On Thu, Oct 13, 2011 at 7:45 PM, sebb  wrote:

> On 13 October 2011 18:28, Philippe Mouawad  wrote:
> > Hello Sebb,
> > Do you think we should  implement issue
> > 52001
> > :
> >
> >   - Add scroll automatically to Summary Report
> >
> > The only use case I see is when you label sampler with a variable name,
> > otherwise you may scroll but it won't last after some time number of
> lines
> > will stay the same.
>
> Yes, it's only needed in limited circumstances, which is why I don't
> really see the need for it.
>
> > If you give me the go, I will patch it.
>
> It's not my personal decision; we make decisions by consensus.
> Any committer can veto a change on a technical basis (e.g. it would
> break something else) but that is probably not the case here.
>
> If it were me, I would not apply the patch as I cannot see the point;
> more code to test and maintain with little benefit.
>
> So I don't support the patch, but if you feel it would be useful I
> won't veto it.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Patch 52001

[sebb]

On 13 October 2011 18:28, Philippe Mouawad  wrote:
> Hello Sebb,
> Do you think we should  implement issue
> 52001
> :
>
>   - Add scroll automatically to Summary Report
>
> The only use case I see is when you label sampler with a variable name,
> otherwise you may scroll but it won't last after some time number of lines
> will stay the same.

Yes, it's only needed in limited circumstances, which is why I don't
really see the need for it.

> If you give me the go, I will patch it.

It's not my personal decision; we make decisions by consensus.
Any committer can veto a change on a technical basis (e.g. it would
break something else) but that is probably not the case here.

If it were me, I would not apply the patch as I cannot see the point;
more code to test and maintain with little benefit.

So I don't support the patch, but if you feel it would be useful I
won't veto it.

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Patch 52001

[Philippe Mouawad]

Hello Sebb,
Do you think we should  implement issue
52001
:

   - Add scroll automatically to Summary Report

The only use case I see is when you label sampler with a variable name,
otherwise you may scroll but it won't last after some time number of lines
will stay the same.

If you give me the go, I will patch it.

Regards
Philippe