[jbehave-dev] Broken sources and builds in JBehave

2009-12-07 Thread Elizabeth Keogh
Hi all,

Just to let you know, I've come across a bit of an issue in JBehave
2.3.2 and am investigating. The sources appear to have a lot of .svn
files in them. I'm also getting test failures on trunk in the Maven
build and compile failures in the Ant build (running on a Mac with
1.5.0).

Mauro, I'm not going to try to maintain the Maven build, so if these
are something you can help with, would you mind taking a look? I'll
check the Ant build.

Thanks,
Liz.

--
Elizabeth Keogh
l...@lunivore.com
http://lizkeogh.com
http://lunivore.com

-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




Re: [jbehave-dev] Broken sources and builds in JBehave

2009-12-07 Thread Paul Hammant
Liz,

It builds from root for me :-

  mvn -Pexamples clean install

  
  [INFO] BUILD SUCCESSFUL
  [INFO] 

  [INFO] Total time: 47 seconds
  [INFO] Finished at: Mon Dec 07 08:45:04 PST 2009
  [INFO] Final Memory: 61M/81M

My maven is ( mvn --version ) :-

  Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
  Java version: 1.6.0_17

Regards,

- Paul

On Dec 7, 2009, at 8:38 AM, Elizabeth Keogh wrote:

 Hi all,
 
 Just to let you know, I've come across a bit of an issue in JBehave
 2.3.2 and am investigating. The sources appear to have a lot of .svn
 files in them. I'm also getting test failures on trunk in the Maven
 build and compile failures in the Ant build (running on a Mac with
 1.5.0).
 
 Mauro, I'm not going to try to maintain the Maven build, so if these
 are something you can help with, would you mind taking a look? I'll
 check the Ant build.
 
 Thanks,
 Liz.
 
 --
 Elizabeth Keogh
 l...@lunivore.com
 http://lizkeogh.com
 http://lunivore.com
 
 -
 To unsubscribe from this list, please visit:
 
http://xircles.codehaus.org/manage_email
 
 


-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Created: (JBEHAVE-213) Scenario runner form submission should support both GET And POST methods

2009-12-07 Thread Mauro Talevi (JIRA)
Scenario runner form submission should support both GET And POST methods  
--

 Key: JBEHAVE-213
 URL: http://jira.codehaus.org/browse/JBEHAVE-213
 Project: JBehave
  Issue Type: Improvement
Reporter: Mauro Talevi
Assignee: Mauro Talevi
 Fix For: web-2.2


Post is required for very long scenarios.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Updated: (JBEHAVE-213) Scenario runner form submission should support both GET and POST methods

2009-12-07 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-213:
-

Description: 
POST is required for very long scenarios - and it now the default. 

To change invoke scenario/scenario.action?scenarioContext.method=[POST|GET]



  was:Post is required for very long scenarios.

Summary: Scenario runner form submission should support both GET and 
POST methods(was: Scenario runner form submission should support both GET 
And POST methods  )

 Scenario runner form submission should support both GET and POST methods  
 --

 Key: JBEHAVE-213
 URL: http://jira.codehaus.org/browse/JBEHAVE-213
 Project: JBehave
  Issue Type: Improvement
Reporter: Mauro Talevi
Assignee: Mauro Talevi
 Fix For: web-2.1.6, web-2.2


 POST is required for very long scenarios - and it now the default. 
 To change invoke scenario/scenario.action?scenarioContext.method=[POST|GET]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Updated: (JBEHAVE-213) Scenario runner form submission should support both GET And POST methods

2009-12-07 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-213:
-

Fix Version/s: web-2.1.6

 Scenario runner form submission should support both GET And POST methods  
 --

 Key: JBEHAVE-213
 URL: http://jira.codehaus.org/browse/JBEHAVE-213
 Project: JBehave
  Issue Type: Improvement
Reporter: Mauro Talevi
Assignee: Mauro Talevi
 Fix For: web-2.1.6, web-2.2


 Post is required for very long scenarios.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-scm] [1398] trunk/web/web-runner/src/main/webapp/ftl/scenario: JBEHAVE-213: Support different form action methods in scenario submission.

2009-12-07 Thread mauro
Title:  [1398] trunk/web/web-runner/src/main/webapp/ftl/scenario: JBEHAVE-213:  Support different form action methods in scenario submission.







Revision 1398
Author mauro
Date 2009-12-07 11:06:29 -0600 (Mon, 07 Dec 2009)


Log Message
JBEHAVE-213:  Support different form action methods in scenario submission.

Modified Paths

trunk/web/web-runner/src/main/java/org/jbehave/web/runner/waffle/controllers/ScenarioContext.java
trunk/web/web-runner/src/main/webapp/ftl/scenario/scenario.ftl




Diff

Modified: trunk/web/web-runner/src/main/java/org/jbehave/web/runner/waffle/controllers/ScenarioContext.java (1397 => 1398)

--- trunk/web/web-runner/src/main/java/org/jbehave/web/runner/waffle/controllers/ScenarioContext.java	2009-12-03 21:47:24 UTC (rev 1397)
+++ trunk/web/web-runner/src/main/java/org/jbehave/web/runner/waffle/controllers/ScenarioContext.java	2009-12-07 17:06:29 UTC (rev 1398)
@@ -11,26 +11,38 @@
 
 public class ScenarioContext {
 
-	private static final String EMPTY = ;
+	private static final String POST = post;
+private static final String EMPTY = ;
 	private static final ListString EMPTY_LIST = asList();
 
+private String method;
 	private String input;
 	private String output;
 	private ListString messages;
 	private Throwable cause;
 
 	public ScenarioContext() {
-		this(EMPTY, EMPTY, EMPTY_LIST);
+		this(POST, EMPTY, EMPTY, EMPTY_LIST);
 	}
 
-	public ScenarioContext(String input, String output, ListString messages) {
-		this.input = input;
+	public ScenarioContext(String method, String input, String output, ListString messages) {
+		this.method = method;
+this.input = input;
 		this.output = output;
 		this.messages = new ArrayListString();
 		this.messages.addAll(messages);
 	}
 
-	public String getInput() {
+	
+	public String getMethod() {
+return method;
+}
+
+public void setMethod(String method) {
+this.method = method;
+}
+
+public String getInput() {
 		return input;
 	}
 


Modified: trunk/web/web-runner/src/main/webapp/ftl/scenario/scenario.ftl (1397 => 1398)

--- trunk/web/web-runner/src/main/webapp/ftl/scenario/scenario.ftl	2009-12-03 21:47:24 UTC (rev 1397)
+++ trunk/web/web-runner/src/main/webapp/ftl/scenario/scenario.ftl	2009-12-07 17:06:29 UTC (rev 1398)
@@ -7,7 +7,7 @@
 /head
 #include /ftl/navigation.ftl parse=true
 div id=content
-form action=""
+form action="" method=${scenarioContext.method}
 
 #include /ftl/errors.ftl parse=true
 div id=scenarioInput










To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email



[jbehave-dev] Re: Broken sources and builds in JBehave

2009-12-07 Thread Mauro Talevi

Elizabeth Keogh wrote:

Hi all,

Just to let you know, I've come across a bit of an issue in JBehave
2.3.2 and am investigating. The sources appear to have a lot of .svn
files in them. I'm also getting test failures on trunk in the Maven
build and compile failures in the Ant build (running on a Mac with
1.5.0).

Mauro, I'm not going to try to maintain the Maven build, so if these
are something you can help with, would you mind taking a look? I'll
check the Ant build.



Liz,

there is an open issue to fix the build with JDK 1.5.0 - it works with 
JDK 1.6


http://jira.codehaus.org/browse/JBEHAVE-203

I'll look into the .svn issues - it may have to do with some 
experimentation we did in git-to-svn bridging.


Chers


-
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Created: (JBEHAVE-214) Allow for multiple aliases for a given step

2009-12-07 Thread Elizabeth Keogh (JIRA)
Allow for multiple aliases for a given step
---

 Key: JBEHAVE-214
 URL: http://jira.codehaus.org/browse/JBEHAVE-214
 Project: JBehave
  Issue Type: New Feature
Reporter: Elizabeth Keogh
 Fix For: 2.4


I've got a machine which outputs messages. I've found three different ways of 
expressing that in steps:

Then the machine should tell me that $message
Then the machine should tell me to $message
Then the machine should say $message

I'd like to be able to put more than one alias on a step.

(@Aliases ?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-214) Allow for multiple aliases for a given step

2009-12-07 Thread JIRA

[ 
http://jira.codehaus.org/browse/JBEHAVE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=201598#action_201598
 ] 

Cristiano Gavião commented on JBEHAVE-214:
--

Hi,
Maybe I don't understand right this request, but I'm thinking that @Aliases is 
already working...

@Given(the dropdown $label has been selected with $value)
@Aliases(values = { dropdown $label was changed to $value,
the value $value was choosed in dropdown $label })
public void ensureDropDownWasSelectedWithValue(
@Named(label) String pIdOrLabel, @Named(value) 
String pValue) {}

regards.

Cristiano


 Allow for multiple aliases for a given step
 ---

 Key: JBEHAVE-214
 URL: http://jira.codehaus.org/browse/JBEHAVE-214
 Project: JBehave
  Issue Type: New Feature
Reporter: Elizabeth Keogh
 Fix For: 2.4


 I've got a machine which outputs messages. I've found three different ways of 
 expressing that in steps:
 Then the machine should tell me that $message
 Then the machine should tell me to $message
 Then the machine should say $message
 I'd like to be able to put more than one alias on a step.
 (@Aliases ?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-215) Allow a step to be reused between scenarios with and without example tables

2009-12-07 Thread JIRA

[ 
http://jira.codehaus.org/browse/JBEHAVE-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=201600#action_201600
 ] 

Cristiano Gavião commented on JBEHAVE-215:
--

Maybe a solution could be to indicate on textual sentence both tableColumn and 
@named parameter to use.

For example:
{code}
Given that user is editing Suppliers
When user inputs $rankNumber_value for $rankNumber_field
And inputs $maxValue_value for $maxValue_field
Then system sends a email for the manager with '$messageTitle_value'. 
Example:
|rankNumber|maxValue|messageTitle|
|11|2122,00|decreased rank|
|1|5,00|gold supplier|
{code}

 Allow a step to be reused between scenarios with and without example tables
 ---

 Key: JBEHAVE-215
 URL: http://jira.codehaus.org/browse/JBEHAVE-215
 Project: JBehave
  Issue Type: Improvement
  Components: Core
Affects Versions: 2.4
Reporter: Cristiano Gavião
 Fix For: 2.4


 I would like to reuse Step classes and its methods in both scenarios that 
 don't use example tables and also in scenarios that I want to use it.
 For example:
 {code}
 This scenario we don't use example table, and its very flexible and reusable:
 Given that user is editing Suppliers
 When user input 12 for rankNumber
 And input 3300,00 for maxValue
 Then system sends a email to the managers with title 'Supplier rank was 
 changed'.  
 {code}
 For this work today I just need to create a step method like this:
 {code}
 @When(user inputs $value for $field)
 @Alias(inputs $value for $field)
 public void whenUserInputsValue(@Named(field) String pField,
 @Named(value) String pValue)
 {
 }
 {code}
 That step method is very reusable indeed a lot of scenarios could use it.
 But if I want to use the benefit of an Example table in this scenario (maybe 
 I found out others businesse rules that could be treat here too), I don't 
 have this flexibility anymore, because Example table needs the steps sentence 
 be fixed and table column matching @Named parameters. 
 So I will need to construct other method for the same purpose.
 Today example tables need that the column tables match the parameter names

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Created: (JBEHAVE-216) Allow to indicate which is the weight of each StepsCandidate class used by a Scenario class to resolve duplicated methods.

2009-12-07 Thread JIRA
Allow to indicate which is the weight of each StepsCandidate class used by a 
Scenario class to resolve duplicated methods.
--

 Key: JBEHAVE-216
 URL: http://jira.codehaus.org/browse/JBEHAVE-216
 Project: JBehave
  Issue Type: New Feature
  Components: Core
Affects Versions: 2.4
Reporter: Cristiano Gavião
 Fix For: 2.4


With the addition of the GivenScenarios feature, almost often will be necessary 
to inform more than one StepsCandidate class for one Scenario class.

The problem is that those StepsCandidates could have same methods, or could be 
extending the same parent class and sharing same method. 

Jbehave will get the first occurrence of method that match textual sentence, 
which not necessarily will be the desired one.

So I would like that jbehave had some way to stablish a weight, or an order, or 
maybe indicate a default steps class (or anything like that) where I could 
indicate which is the best path it should be taken.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Resolved: (JBEHAVE-214) Allow for multiple aliases for a given step

2009-12-07 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi resolved JBEHAVE-214.
--

Resolution: Duplicate

Implemented in JBEHAVE-131.


 Allow for multiple aliases for a given step
 ---

 Key: JBEHAVE-214
 URL: http://jira.codehaus.org/browse/JBEHAVE-214
 Project: JBehave
  Issue Type: New Feature
Reporter: Elizabeth Keogh
 Fix For: 2.4


 I've got a machine which outputs messages. I've found three different ways of 
 expressing that in steps:
 Then the machine should tell me that $message
 Then the machine should tell me to $message
 Then the machine should say $message
 I'd like to be able to put more than one alias on a step.
 (@Aliases ?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email