[jbehave-dev] [jira] Created: (JBEHAVE-406) jbehave-site-resources 3.1.2 needs uploading to Maven Central repo

2010-12-16 Thread Alistair Dutton (JIRA)
jbehave-site-resources 3.1.2 needs uploading to Maven Central repo
--

 Key: JBEHAVE-406
 URL: http://jira.codehaus.org/browse/JBEHAVE-406
 Project: JBehave
  Issue Type: Task
Affects Versions: 3.1.2
Reporter: Alistair Dutton
Priority: Minor


All the JBehave 3.1.2 artifacts look to be present and correct in the Maven 
Central repository with the exception of jbehave-site-resources which is 
missing (see 
http://repo2.maven.org/maven2/org/jbehave/site/jbehave-site-resources/).

I tend to have a single "jbehave.version" property in my POMs - I've now 
updated it 3.1.2 but my build now breaks because of a reference to the 
jbehave-site-resources artifact in my maven-dependency-plugin definition. It's 
a minor annoyance which can easily be worked around of course but uploading it 
would be neater.

I'd happily have a go myself but I believe I would need to have my public PGP 
key assigned the appropriate trusts before I could do so (which seems fair 
enough!).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Created: (JBEHAVE-405) Signal that next step is of different type

2010-12-16 Thread Paul Hammant (JIRA)
Signal that next step is of different type
--

 Key: JBEHAVE-405
 URL: http://jira.codehaus.org/browse/JBEHAVE-405
 Project: JBehave
  Issue Type: New Feature
  Components: Core
Reporter: Paul Hammant


Consider:

{code}
  Given something
  And something else
  Then it happened

  or..

  Given something
  Then it happened

  and..

  @When("something")
  public void something() {
  }
  @When("something else")
  public void somethingElse() {
  }
  @Then("it happened")
  public void itHappened() {
  }
{code}   

I'd like to be able to know in something() whether the next step is of a 
different type or not.

{code}
  @When("something")
  public void something(@Named("lastOfStepType") boolean lastOfStepType) {
  }
{code}

This is particularly useful for UI interactions (WebDriver etc).

Given I am have a hat in the cart
When I purchase with credit card
And I specify an alternate delivery address
Then I should see a warning about different addresses

I might want... 

When I purchase with credit card

... as a standalone, or with refining AND clauses.  In the last of the when 
lines that's pertinent I may execute the whole set.  When in this context feels 
like a continuation of sorts.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-398) Provide conversion of table value

2010-12-16 Thread Mauro Talevi (JIRA)

[ 
http://jira.codehaus.org/browse/JBEHAVE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248756#action_248756
 ] 

Mauro Talevi commented on JBEHAVE-398:
--

Yes, an example story in trader would be most welcome!

I'm starting to get the use case, but a concrete example would be useful.

> Provide conversion of table value
> -
>
> Key: JBEHAVE-398
> URL: http://jira.codehaus.org/browse/JBEHAVE-398
> Project: JBehave
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.1.2
>Reporter: Daniel Godfrey
>Assignee: Mauro Talevi
> Fix For: 3.2
>
>
> Currently to convert into a List it's necessary to register a 
> custom ParameterConverter. By default it already provides the ability to 
> convert into List and List, but this should be 
> extended to support all instances of List as it will reduce the duplicate 
> code necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-400) Error in WebDriverProvider intialize method ignored because of consequential NPE for StoryRunner.reporter

2010-12-16 Thread Paul Hammant (JIRA)

[ 
http://jira.codehaus.org/browse/JBEHAVE-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248754#action_248754
 ] 

Paul Hammant commented on JBEHAVE-400:
--

See the Etsy tutorial.  If you change the WebDriver sys-prop to 'DoesNotExist' 
and run the tests, you'll get the NPE described in this bug report.

It is because new FirefoxDriver() fails during the initialize() of 
WebDriverProvider as described, but that is totally hidden by a reference to 
StoryRunner.runner being null and causing a NPE.



- Paul

> Error in WebDriverProvider intialize method ignored because of consequential 
> NPE for StoryRunner.reporter
> -
>
> Key: JBEHAVE-400
> URL: http://jira.codehaus.org/browse/JBEHAVE-400
> Project: JBehave
>  Issue Type: Bug
>  Components: Web Selenium
>Affects Versions: 3.2
>Reporter: Paul Hammant
> Attachments: BadlyInitializingWebDriverStepsTest.java
>
>
> {noformat} 
> new WebDriverProvider() {
>public void initialize() { 
>  throw new RuntimeException(); //  or Error or something
>} 
> } 
> {noformat} 
> ... does not get reported. It's consumed because of a later NPE 
> The NPE is in StoryRunner, concerning member variable 'reporter' which is not 
> set before use, in this situation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-398) Provide conversion of table value

2010-12-16 Thread Daniel Godfrey (JIRA)

[ 
http://jira.codehaus.org/browse/JBEHAVE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248727#action_248727
 ] 

Daniel Godfrey commented on JBEHAVE-398:


I'm mainly using the tables to set up a database and then to import data. The 
defaults allows me to specify values in java, so the stories then don't need to 
contain the data if it's not relevant to the test, but lets me reuse the same 
steps.

So (rubbish example) given a database table that needs a name and age, I can 
have the following line in my @Given step:
{noformat}dao.addUser(record.value("Name"), record.valueAs("Age", 
Integer.class, "19"){noformat}

Then in 1 scenario/story where age is irrelevant I can simply add

{noformat}
When new user added:
  |Name|
  |Dan |
{noformat} 

Then in a different scenario where the age is relevant to the test, I can put
{noformat}
When new user added:
  |Name|Age|
  |Dan |32 |
  |Mark|21 |
{noformat}

The reason for the ExamplesTable#withDefaults(Record) method is it make this 
easy to do in a scenario:
{noformat}
Given user defaults:
  |Age|
  |22 |

When new user addded:
  |Name|
  |Dan |
{noformat} 

This isn't my actual domain, It's trade settlement/confirmation, so there's 
lots of data that's required for each record, most of which is pretty 
irrelevant for the current test, so this allows the tests to focus on what's 
important.

I can add some examples to the Trader example in JBehave if you want?

I'm not convinced myself about the Row -> Record rename either, just convinced 
that Row is the wrong name as they're more useful than simply as Rows. I've 
just written a ParamaterConverter that will covert "key:value\nkey2:value2" 
into a Record and I've been considering using them to read the columns of a 
table, so you can have row/column headers. One idea that crossed my mind was to 
make ConvertingRecord extend Map, and change 
ExamplesTable#getRow to return ConvertingRecord (renamed to something sensible 
like ConvertingMap) rather than Map. Haven't really thought 
about it in detail, IE backwards compatibility implications, etc.

> Provide conversion of table value
> -
>
> Key: JBEHAVE-398
> URL: http://jira.codehaus.org/browse/JBEHAVE-398
> Project: JBehave
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.1.2
>Reporter: Daniel Godfrey
>Assignee: Mauro Talevi
> Fix For: 3.2
>
>
> Currently to convert into a List it's necessary to register a 
> custom ParameterConverter. By default it already provides the ability to 
> convert into List and List, but this should be 
> extended to support all instances of List as it will reduce the duplicate 
> code necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-scm] jbehave-web branch, master, updated. jbehave-web-3.1.1-6-gfc512d9

2010-12-16 Thread git version control
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "jbehave-web".

The branch, master has been updated
   via  fc512d90acbd6c6972900d28926617e3d4a87ebc (commit)
  from  70f7a22ee583a6dfec162f5507458c4fd92fb6ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit fc512d90acbd6c6972900d28926617e3d4a87ebc
Author: Paul Hammant 
Date:   Thu Dec 16 05:46:52 2010 -0600

fix exception wrap-rethrow

---

Summary of changes:
 .../web/selenium/TypeWebDriverProvider.java|4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
jbehave-web



To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email