[jbehave-dev] [jira] Updated: (JBEHAVE-490) Screenshots for failing scenarios are taken but not correlated with the story HTML output hyperlink

2011-04-22 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-490:
-

  Description: 
This could well be an issue in core around exceptions being thrown (wrapped by 
UUIDExceptionWrapper).

1) Apply the attached patch to Etsy (it makes everything fail).  
2) Run regular build (no saucelabs):  mvn clean install
3) Open Navigator or reports page and click through to the HTML page for the 
failing story.
4) Click the screenshot icon (see that it 404s)
5) Otherwise check the screenshots directory, and observer that it has only one 
screenshot, instead of one for each failed story.



  was:
This could well be an issue in core around exceptions being thrown (wrapped by 
UUIDExceptionWrapper).

1) Apply the attached patch to Etsy (it makes everything fail).  
2) Run regular build (no saucelabs).
3) Open Navigator (or the older results page) and click through to the HTML 
page for the failing story.
4) Click the screen-shot icon (see that it 404s)
5) Otherwise check the screen-shots directory, and observer that it has three 
screenshots.


Fix Version/s: web-3.4
 Assignee: Mauro Talevi
  Summary: Screenshots for failing scenarios are taken but not 
correlated with the story HTML output hyperlink  (was: Screen-shots for failing 
scenarios are being taken, but are not correlated with the story-results HTML 
output's hyperlink.)

> Screenshots for failing scenarios are taken but not correlated with the story 
> HTML output hyperlink
> ---
>
> Key: JBEHAVE-490
> URL: http://jira.codehaus.org/browse/JBEHAVE-490
> Project: JBehave
>  Issue Type: Bug
>  Components: Web Selenium
>Reporter: Paul Hammant
>Assignee: Mauro Talevi
> Fix For: web-3.4
>
> Attachments: screenshots404.patch
>
>
> This could well be an issue in core around exceptions being thrown (wrapped 
> by UUIDExceptionWrapper).
> 1) Apply the attached patch to Etsy (it makes everything fail).  
> 2) Run regular build (no saucelabs):  mvn clean install
> 3) Open Navigator or reports page and click through to the HTML page for the 
> failing story.
> 4) Click the screenshot icon (see that it 404s)
> 5) Otherwise check the screenshots directory, and observer that it has only 
> one screenshot, instead of one for each failed story.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-dev] [jira] Commented: (JBEHAVE-490) Screenshots for failing scenarios are taken but not correlated with the story HTML output hyperlink

2011-04-22 Thread Mauro Talevi (JIRA)

[ 
http://jira.codehaus.org/browse/JBEHAVE-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=264418#action_264418
 ] 

Mauro Talevi commented on JBEHAVE-490:
--

This is caused by JBEHAVE-472, fixed from core 3.4-beta-2.

> Screenshots for failing scenarios are taken but not correlated with the story 
> HTML output hyperlink
> ---
>
> Key: JBEHAVE-490
> URL: http://jira.codehaus.org/browse/JBEHAVE-490
> Project: JBehave
>  Issue Type: Bug
>  Components: Web Selenium
>Reporter: Paul Hammant
>Assignee: Mauro Talevi
> Fix For: web-3.4
>
> Attachments: screenshots404.patch
>
>
> This could well be an issue in core around exceptions being thrown (wrapped 
> by UUIDExceptionWrapper).
> 1) Apply the attached patch to Etsy (it makes everything fail).  
> 2) Run regular build (no saucelabs):  mvn clean install
> 3) Open Navigator or reports page and click through to the HTML page for the 
> failing story.
> 4) Click the screenshot icon (see that it 404s)
> 5) Otherwise check the screenshots directory, and observer that it has only 
> one screenshot, instead of one for each failed story.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-scm] jbehave-web branch, master, updated. jbehave-web-3.3.1-4-g3657d8b

2011-04-22 Thread git version control
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "jbehave-web".

The branch, master has been updated
   via  3657d8b623fb2768f6bf6b0f1b26aff6165c7e8f (commit)
  from  3b24b85f264d7ebbea8134fcd007ab87e5e6dbec (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3657d8b623fb2768f6bf6b0f1b26aff6165c7e8f
Author: Paul Hammant 
Date:   Thu Apr 21 11:30:00 2011 -0500

upgrade jbehave to snapshot version

---

Summary of changes:
 pom.xml |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
jbehave-web



To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email



[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-1-9-g1018cf0

2011-04-22 Thread git version control
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "jbehave-core".

The branch, master has been updated
   via  1018cf0df632a67101597fe01729b5ea1b59d310 (commit)
  from  b8c8d964665e70af1ef6c9ad227531022f8c2c88 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 1018cf0df632a67101597fe01729b5ea1b59d310
Author: Mauro Talevi 
Date:   Fri Apr 22 13:32:30 2011 +0200

JBEHAVE-472: Refactored Step.doNotPerform() method to be aware of any 
failure, in order to allow for correct story failure correlation.

---

Summary of changes:
 .../examples/trader/FailureCorrelationStories.java |   23 +++--
 .../org/jbehave/core/embedder/StoryControls.java   |5 ++
 .../org/jbehave/core/embedder/StoryRunner.java |9 +++-
 .../src/main/java/org/jbehave/core/steps/Step.java |2 +-
 .../java/org/jbehave/core/steps/StepCreator.java   |   16 +++---
 .../core/embedder/StoryRunnerBehaviour.java|   58 ++--
 .../jbehave/core/steps/StepCandidateBehaviour.java |2 +-
 .../jbehave/core/steps/StepCreatorBehaviour.java   |4 +-
 .../org/jbehave/core/steps/StepsBehaviour.java |   11 ++--
 9 files changed, 78 insertions(+), 52 deletions(-)


hooks/post-receive
-- 
jbehave-core



To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Reopened: (JBEHAVE-472) Improve state management of StoryRunner

2011-04-22 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi reopened JBEHAVE-472:
--


The refactor has broken the failure UUID correlation between stories 
(JBEHAVE-490).

Added FailureCorrelationStories in trader example to reproduce behaviour. 



> Improve state management of StoryRunner
> ---
>
> Key: JBEHAVE-472
> URL: http://jira.codehaus.org/browse/JBEHAVE-472
> Project: JBehave
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.3
>Reporter: Mauro Talevi
>Assignee: Mauro Talevi
> Fix For: 3.4
>
>
> We need to improve the state management of the StoryRunner.  
> Currently after every set of steps run the state is reset and the scenario 
> @Before/@After steps are run separately from the normal steps, causing wierd 
> behaviours when there are failure in the @Before steps but not in the normal 
> steps.  Examples of such a behaviour are the trader 
> failing_before_after.story and failing_before_stories.story.
> A better and more intuitive state management should be in place, keeping 
> state in the run context.  The state should be reset by default before each 
> scenario (to ensure backward compat) but will be shared between the 
> @Before/@After steps and the normal steps.  
> We should also have the option to not reset it before each scenario to allow 
> for failures in the @BeforeStory/Stories steps to propagate to the scenario 
> steps in the same run context.
> Once a failing state in a given run context, the steps that follow will not 
> be performed, as customary with normal steps.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email




[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-1-8-gb8c8d96

2011-04-22 Thread git version control
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "jbehave-core".

The branch, master has been updated
   via  b8c8d964665e70af1ef6c9ad227531022f8c2c88 (commit)
  from  3640594fbc909039879886e73c1541141ac98459 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b8c8d964665e70af1ef6c9ad227531022f8c2c88
Author: Mauro Talevi 
Date:   Fri Apr 22 12:04:27 2011 +0200

JBEHAVE-472:  Added FailureCorrelationStories to verify behaviour of 
failure correlation.  It seems we may need to allow the configurable reset of 
the story state before each story.

---

Summary of changes:
 .../examples/trader/FailureCorrelationStories.java |   52 
 .../trader/stories/failure_correlation_one.story   |3 +
 .../trader/stories/failure_correlation_two.story   |3 +
 3 files changed, 58 insertions(+), 0 deletions(-)
 create mode 100644 
examples/trader/src/main/java/org/jbehave/examples/trader/FailureCorrelationStories.java
 create mode 100644 
examples/trader/src/main/java/org/jbehave/examples/trader/stories/failure_correlation_one.story
 create mode 100644 
examples/trader/src/main/java/org/jbehave/examples/trader/stories/failure_correlation_two.story


hooks/post-receive
-- 
jbehave-core



To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email