[jbehave-scm] jbehave-tutorial branch, master, updated. 7ca48376f05eaabbbbb5bf12d5cfd8c95caf5097
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-tutorial". The branch, master has been updated via 7ca48376f05eaab5bf12d5cfd8c95caf5097 (commit) via dde5422bb6f72c473710bc6bfe693caf995bbcf5 (commit) from 70748d2b891392439322974e0a726eb938c81dc7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7ca48376f05eaab5bf12d5cfd8c95caf5097 Merge: dde5422bb6f72c473710bc6bfe693caf995bbcf5 70748d2b891392439322974e0a726eb938c81dc7 Author: Mauro Talevi Date: Sat Apr 30 17:30:46 2011 +0200 Merged. commit dde5422bb6f72c473710bc6bfe693caf995bbcf5 Author: Mauro Talevi Date: Sat Apr 30 16:58:23 2011 +0200 Instantiate all steps via container using ThreadCaching to have different instances in each thread. --- Summary of changes: .../jbehave/tutorials/etsy/EtsyDotComStories.java | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) hooks/post-receive -- jbehave-tutorial To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-2-12-gd58864c
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-core". The branch, master has been updated via d58864c6f514ef7ca2672ad0861d7962b7305cd5 (commit) from 942d12b1b22ad12a7c7fa2ced67a2fb430bca128 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit d58864c6f514ef7ca2672ad0861d7962b7305cd5 Author: Mauro Talevi Date: Sat Apr 30 15:04:51 2011 +0200 JBEHAVE-492: Ensured before and after stories steps use the same steps instances. --- Summary of changes: .../java/org/jbehave/core/embedder/Embedder.java |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- jbehave-core To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-tutorial branch, master, updated. 70748d2b891392439322974e0a726eb938c81dc7
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-tutorial". The branch, master has been updated via 70748d2b891392439322974e0a726eb938c81dc7 (commit) via df31e4ab7d91ea266863c4ea2190fa4a65f4b252 (commit) from 5fa93054318eebdea89b2150d72888f690fc58d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 70748d2b891392439322974e0a726eb938c81dc7 Merge: df31e4ab7d91ea266863c4ea2190fa4a65f4b252 5fa93054318eebdea89b2150d72888f690fc58d2 Author: Paul Hammant Date: Sat Apr 30 06:21:58 2011 -0500 Merge branch 'master' of ssh://git.codehaus.org/jbehave-tutorial commit df31e4ab7d91ea266863c4ea2190fa4a65f4b252 Author: Paul Hammant Date: Sat Apr 30 06:21:29 2011 -0500 more of multi-threaded work --- Summary of changes: .../jbehave/tutorials/etsy/EtsyDotComStories.java |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- jbehave-tutorial To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Updated: (JBEHAVE-492) CandidateSteps instances should be created by StoryRunner context allowing for multi-threaded stateful steps logic
[
http://jira.codehaus.org/browse/JBEHAVE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mauro Talevi updated JBEHAVE-492:
-
Description:
In multi-threaded mode, the steps instances need to be instantiated per thread.
A way to do this is to pass the InjectableStepsFactory to the StoryRunner run
context and let the context instantiate the candidate steps per thread.
was:
public void addSteps(List steps) {
}
... would be better.
Why? There's an instance that's made during the setup of a suite (refer
EtsyStories). If you are running in multi-threaded mode, that **initial**
instance is **never** used during the running of scenarios.
In multi-threaded mode, there's a constructor for BasePage that takes a
WebDriverProvider. When it is passed in during the primordial instantiation
phase, no WebDriver has been initialized. We don't want to do that of course
because (a) we know this **initial** instance is going to be garbage collected
and never used, and (b) on SauceLabs at least it would result in browser
opening in the cloud then closing (or maybe not closing, but never used; I'm
not sure).
JBehave does not actually need the **initial** instance. I believe this is
provable. Instead it could perfectly well use the class definition without the
instance ref somehow.
Proposal: Long overdue, I think, but could for 4.x we shift to using
class-defs. Either rework CandidateSteps to hold a Class rather than an
instance. Or further do a away (move the logic elsewhere) with CandidateSteps,
and use the POJO Step's class-def directly.
> CandidateSteps instances should be created by StoryRunner context allowing
> for multi-threaded stateful steps logic
> --
>
> Key: JBEHAVE-492
> URL: http://jira.codehaus.org/browse/JBEHAVE-492
> Project: JBehave
> Issue Type: New Feature
> Components: Core
>Affects Versions: 3.x
>Reporter: Paul Hammant
>Assignee: Mauro Talevi
> Fix For: 3.4
>
>
> In multi-threaded mode, the steps instances need to be instantiated per
> thread.
> A way to do this is to pass the InjectableStepsFactory to the StoryRunner run
> context and let the context instantiate the candidate steps per thread.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Updated: (JBEHAVE-492) CandidateSteps instances should be created by StoryRunner context allowing for multi-threaded stateful steps logic
[
http://jira.codehaus.org/browse/JBEHAVE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mauro Talevi updated JBEHAVE-492:
-
Fix Version/s: (was: 3.x)
3.4
Assignee: Mauro Talevi
> CandidateSteps instances should be created by StoryRunner context allowing
> for multi-threaded stateful steps logic
> --
>
> Key: JBEHAVE-492
> URL: http://jira.codehaus.org/browse/JBEHAVE-492
> Project: JBehave
> Issue Type: New Feature
> Components: Core
>Affects Versions: 3.x
>Reporter: Paul Hammant
>Assignee: Mauro Talevi
> Fix For: 3.4
>
>
> public void addSteps(List steps) {
> }
> ... would be better.
> Why? There's an instance that's made during the setup of a suite (refer
> EtsyStories). If you are running in multi-threaded mode, that **initial**
> instance is **never** used during the running of scenarios.
> In multi-threaded mode, there's a constructor for BasePage that takes a
> WebDriverProvider. When it is passed in during the primordial instantiation
> phase, no WebDriver has been initialized. We don't want to do that of course
> because (a) we know this **initial** instance is going to be garbage
> collected and never used, and (b) on SauceLabs at least it would result in
> browser opening in the cloud then closing (or maybe not closing, but never
> used; I'm not sure).
> JBehave does not actually need the **initial** instance. I believe this is
> provable. Instead it could perfectly well use the class definition without
> the instance ref somehow.
> Proposal: Long overdue, I think, but could for 4.x we shift to using
> class-defs. Either rework CandidateSteps to hold a Class rather than an
> instance. Or further do a away (move the logic elsewhere) with
> CandidateSteps, and use the POJO Step's class-def directly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-tutorial branch, master, updated. 5fa93054318eebdea89b2150d72888f690fc58d2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-tutorial". The branch, master has been updated via 5fa93054318eebdea89b2150d72888f690fc58d2 (commit) from 53960b91dd55d581c2f1ad2b652b84271af7a554 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5fa93054318eebdea89b2150d72888f690fc58d2 Author: Mauro Talevi Date: Sat Apr 30 12:21:29 2011 +0200 Use CompositeStepsFactory to separate the before and after steps from the Pico-instantiated steps. --- Summary of changes: .../jbehave/tutorials/etsy/EtsyDotComStories.java | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) hooks/post-receive -- jbehave-tutorial To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-2-11-g942d12b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-core". The branch, master has been updated via 942d12b1b22ad12a7c7fa2ced67a2fb430bca128 (commit) from 6d2d120204b9cbbecdf2a36ad012799811924e68 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 942d12b1b22ad12a7c7fa2ced67a2fb430bca128 Author: Mauro Talevi Date: Sat Apr 30 12:14:51 2011 +0200 JBEHAVE-492: Updated annotation builders to use steps factory by default. Behaviour controlled by @UsingEmbedder(stepsFactory=[true|false]) flag. Added CompositeStepsFactory to allow composition of steps factories, as typically used by DI containers. --- Summary of changes: .../jbehave/core/annotations/UsingEmbedder.java|7 ++- .../core/configuration/AnnotationBuilder.java | 26 ++-- .../jbehave/core/steps/CompositeStepsFactory.java | 34 +++ .../configuration/AnnotationBuilderBehaviour.java | 43 .../groovy/GroovyAnnotationBuilder.java| 15 +++ .../guice/GuiceAnnotationBuilder.java | 13 +++--- .../configuration/pico/PicoAnnotationBuilder.java | 15 +++ .../spring/SpringAnnotationBuilder.java| 13 +++--- .../configuration/weld/WeldAnnotationBuilder.java | 14 +++ 9 files changed, 133 insertions(+), 47 deletions(-) create mode 100644 jbehave-core/src/main/java/org/jbehave/core/steps/CompositeStepsFactory.java hooks/post-receive -- jbehave-core To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Resolved: (JBEHAVE-496) Null meta filters should be ignored in Maven plugin
[ http://jira.codehaus.org/browse/JBEHAVE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mauro Talevi resolved JBEHAVE-496. -- Resolution: Fixed > Null meta filters should be ignored in Maven plugin > --- > > Key: JBEHAVE-496 > URL: http://jira.codehaus.org/browse/JBEHAVE-496 > Project: JBehave > Issue Type: Improvement > Components: Maven Plugin >Reporter: Mauro Talevi >Assignee: Mauro Talevi >Priority: Minor > Fix For: 3.4 > > > When specifying the meta filters via the Maven plugin, null entries are > sometimes passed in, which should be ignored. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Created: (JBEHAVE-496) Null meta filters should be ignored in Maven plugin
Null meta filters should be ignored in Maven plugin --- Key: JBEHAVE-496 URL: http://jira.codehaus.org/browse/JBEHAVE-496 Project: JBehave Issue Type: Improvement Components: Maven Plugin Reporter: Mauro Talevi Assignee: Mauro Talevi Priority: Minor Fix For: 3.4 When specifying the meta filters via the Maven plugin, null entries are sometimes passed in, which should be ignored. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-2-10-g6d2d120
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-core". The branch, master has been updated via 6d2d120204b9cbbecdf2a36ad012799811924e68 (commit) from dc176a423acd1b82bdb048e7b90613cc3102be19 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 6d2d120204b9cbbecdf2a36ad012799811924e68 Author: Mauro Talevi Date: Sat Apr 30 10:06:49 2011 +0200 JBEHAVE-496: Ignore null meta filter entries. --- Summary of changes: .../org/jbehave/mojo/AbstractEmbedderMojo.java | 10 +- .../org/jbehave/mojo/EmbedderMojoBehaviour.java| 28 2 files changed, 36 insertions(+), 2 deletions(-) hooks/post-receive -- jbehave-core To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Resolved: (JBEHAVE-487) Allow parameters to be specified as meta properties
[
http://jira.codehaus.org/browse/JBEHAVE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mauro Talevi resolved JBEHAVE-487.
--
Resolution: Fixed
> Allow parameters to be specified as meta properties
> ---
>
> Key: JBEHAVE-487
> URL: http://jira.codehaus.org/browse/JBEHAVE-487
> Project: JBehave
> Issue Type: New Feature
> Components: Core
>Reporter: Mauro Talevi
>Assignee: Mauro Talevi
> Fix For: 3.4
>
>
> As suggested by Paul, parameters may be specified as Meta properties:
> {noformat}
> Meta:
> @theme parameters
> Scenario:
> Meta:
> @variant named
> Given I have specified the
> And a
> Then the theme is parameters with variant named
> {noformat}
> The named meta parameters would be matched by usual @Named mechanism, also
> used in story or scenario parametrisation.
> {code}
> @Given("I have specified the ")
> public void givenIHaveSpecifiedTheTheme(@Named("theme") String theme){
> this.theme = theme;
> }
> {code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-2-9-gdc176a4
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-core". The branch, master has been updated via dc176a423acd1b82bdb048e7b90613cc3102be19 (commit) from 5398fe9e9f9453603c1d1a29b8d321b98d205078 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit dc176a423acd1b82bdb048e7b90613cc3102be19 Author: Mauro Talevi Date: Sat Apr 30 09:31:15 2011 +0200 JBEHAVE-476: Updated doc page. --- Summary of changes: distribution/src/site/content/archetypes.html | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) hooks/post-receive -- jbehave-core To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Updated: (JBEHAVE-479) Cross Reference XM/JSON should include meta-filter choice (if present) for display in Story Navigator output
[ http://jira.codehaus.org/browse/JBEHAVE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mauro Talevi updated JBEHAVE-479: - Affects Version/s: (was: 3.3.2) Fix Version/s: (was: 3.4) 3.3 > Cross Reference XM/JSON should include meta-filter choice (if present) for > display in Story Navigator output > > > Key: JBEHAVE-479 > URL: http://jira.codehaus.org/browse/JBEHAVE-479 > Project: JBehave > Issue Type: Improvement > Components: Core >Reporter: Paul Hammant >Assignee: Paul Hammant >Priority: Minor > Fix For: 3.3 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Updated: (JBEHAVE-495) Upgrade Groovy dependency to 1.8.0
[ http://jira.codehaus.org/browse/JBEHAVE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mauro Talevi updated JBEHAVE-495: - Priority: Minor (was: Major) Issue Type: Task (was: Improvement) > Upgrade Groovy dependency to 1.8.0 > -- > > Key: JBEHAVE-495 > URL: http://jira.codehaus.org/browse/JBEHAVE-495 > Project: JBehave > Issue Type: Task > Components: Groovy Support >Reporter: Paul Hammant >Assignee: Paul Hammant >Priority: Minor > Fix For: 3.4 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] Resolved: (JBEHAVE-495) Upgrade Groovy dependency to 1.8.0
[ http://jira.codehaus.org/browse/JBEHAVE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mauro Talevi resolved JBEHAVE-495. -- Resolution: Fixed > Upgrade Groovy dependency to 1.8.0 > -- > > Key: JBEHAVE-495 > URL: http://jira.codehaus.org/browse/JBEHAVE-495 > Project: JBehave > Issue Type: Task > Components: Groovy Support >Reporter: Paul Hammant >Assignee: Paul Hammant >Priority: Minor > Fix For: 3.4 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-scm] jbehave-core branch, master, updated. jbehave-3.4-beta-2-8-g5398fe9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "jbehave-core". The branch, master has been updated via 5398fe9e9f9453603c1d1a29b8d321b98d205078 (commit) via b9bc04abb6281b2f112a2a9372f21b6ff52ee605 (commit) from fa33de898712f93f89dc991c6f21ba11e686647b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5398fe9e9f9453603c1d1a29b8d321b98d205078 Merge: b9bc04abb6281b2f112a2a9372f21b6ff52ee605 fa33de898712f93f89dc991c6f21ba11e686647b Author: Mauro Talevi Date: Sat Apr 30 09:10:01 2011 +0200 Merge branch 'master' of ssh://git.codehaus.org/jbehave-core commit b9bc04abb6281b2f112a2a9372f21b6ff52ee605 Author: Paul Hammant Date: Fri Apr 29 19:46:59 2011 -0500 JBEHAVE-495: Upgraded groovy to 1.8 --- Summary of changes: hooks/post-receive -- jbehave-core To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email
