[jbehave-dev] [jira] (JBEHAVE-1024) Use of constant or expression in step priority results in missing step candidates
Title: Message Title Chris Rimes created an issue JBehave / JBEHAVE-1024 Use of constant or _expression_ in step priority results in missing step candidates Issue Type: Bug Assignee: Unassigned Components: Eclipse Support Created: 05/Jun/14 1:58 PM Priority: Minor Reporter: Chris Rimes The code for parsing the priority attribute of the JBehave annotations assumes that the value is an integer literal. When it encounters a value that is a constant or _expression_, it stops parsing the file and any steps that appear after the problematic one are missed. I don't think there's an easy way to evaluate the priority in these cases without involving the java compiler, but an improvement would be to use the default priority (or none at all) and at least parse the rest of the steps in the file. Add Comment
[jbehave-dev] [jira] (JBEHAVE-1022) Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial
Title: Message Title Praveen G commented on an issue Re: Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial I have seen t his but how it is injecting through beans. If observe in java-spring project the provider injected from etsy-steps.xml with bean id. but in groovy-pico there is no concept of spring. So it will more helpful for us to implement the same in java-spring. Add Comment JBehave / JBEHAVE-1022 Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial Hi, Currently I'm able to see the saucelabs implementation only in etsy-selenium/groovy-pico project in github. But could you please implement the same in etsy-selenium/java-spring project also. https://github.com/jbehave/jbehave-tutorial/tree/master/etsy-selenium/java-spring Please let us know how this is going to be work in SauceLabs for ja... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-889) Asynchronous cache reload
Title: Message Title Mauro Talevi resolved an issue as Fixed JBehave / JBEHAVE-889 Asynchronous cache reload Change By: Mauro Talevi Resolution: Fixed Status: In Progress Resolved Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1022) Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial
Title: Message Title Mauro Talevi commented on an issue Re: Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial The configuration for the SauceWebDriverProvider is in Java: https://github.com/jbehave/jbehave-tutorial/blob/master/etsy-selenium/groovy-pico/src/main/java/org/jbehave/tutorials/etsy/EtsyDotComStories.java It is the same regardless of the language used for the steps and the container used to wire them up. Add Comment JBehave / JBEHAVE-1022 Saucelab implementation for etsy-selenium/ java-spring project in Jbehave tutorial Hi, Currently I'm able to see the saucelabs implementation only in etsy-selenium/groovy-pico project in github. But could you please implement the same in etsy-selenium/java-spring project also. https://github.com/jbehave/jbehave-tutorial/tree/master/etsy-selenium/java-spring Please let us know how this is going to be work in SauceLabs for ja... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list,
[jbehave-dev] [jira] (JBEHAVE-1023) Improve responsiveness of editor for large projects by not recreating the same StepMatcher for every candidate step on every keystroke
Title: Message Title Mauro Talevi resolved an issue as Fixed Pulled request with thanks and deployed new version. JBehave / JBEHAVE-1023 Improve responsiveness of editor for large projects by not recreating the same StepMatcher for every candidate step on every keystroke Change By: Mauro Talevi Resolution: Fixed Status: Open Resolved Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1023) Improve responsiveness of editor for large projects by not recreating the same StepMatcher for every candidate step on every keystroke
Title: Message Title Mauro Talevi updated an issue JBehave / JBEHAVE-1023 Improve responsiveness of editor for large projects by not recreating the same StepMatcher for every candidate step on every keystroke Change By: Mauro Talevi Affects Version/s: eclipse-1.0 Fix Version/s: eclipse-1.0 Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-scm] [scm-eclipse][1/1] JBEHAVE-1023: Lazily create the StepMatcher in the StepCandidate, as recreating and recompiling the regex pattern every time is insanely expensive.
commit e8439f0069fef96870f440f21e6beccb3c944c78
Author: Chris Rimes
AuthorDate: Thu, 24 Apr 2014 21:28:06 +0100
Commit: Mauro Talevi
CommitDate: Thu, 5 Jun 2014 08:16:28 +0100
JBEHAVE-1023: Lazily create the StepMatcher in the StepCandidate, as
recreating and recompiling the regex pattern every time is insanely expensive.
diff --git
a/org.jbehave.eclipse/src/org/jbehave/eclipse/editor/step/StepCandidate.java
b/org.jbehave.eclipse/src/org/jbehave/eclipse/editor/step/StepCandidate.java
index c9dfea6..2d48ff2 100644
--- a/org.jbehave.eclipse/src/org/jbehave/eclipse/editor/step/StepCandidate.java
+++ b/org.jbehave.eclipse/src/org/jbehave/eclipse/editor/step/StepCandidate.java
@@ -22,6 +22,7 @@ public class StepCandidate {
public final Integer priority;
private ParametrizedStep parametrizedStep;
private StepPatternParser stepParser;
+ private StepMatcher matcher;
public StepCandidate(LocalizedStepSupport localizedSupport,
String parameterPrefix, IMethod method,
@@ -73,7 +74,7 @@ public class StepCandidate {
}
public boolean matches(String stepWithoutKeyword) {
- return matcher(stepType,
stepPattern).matches(stepWithoutKeyword);
+ return matcher().matches(stepWithoutKeyword);
}
public String toString() {
@@ -97,8 +98,11 @@ public class StepCandidate {
return builder.toString();
}
- private StepMatcher matcher(StepType stepType, String stepPattern) {
- return stepParser.parseStep(stepType, stepPattern);
+ private StepMatcher matcher() {
+ if (matcher == null) {
+ matcher = stepParser.parseStep(stepType, stepPattern);
+ }
+ return matcher;
}
}
\ No newline at end of file
