Re: [jbehave-dev] Generics doesn't work for StringListConverter, List is not recognized as a ParameterType
Nice ! You fixed it that fast !
Thanks for that.
Do you know when i can expect a release ?
2014-10-01 10:15 GMT+02:00 Matthieu Mestrez mestrez.matth...@gmail.com:
Thanks for the follow-up
I've created a Jira issue here :
https://jira.codehaus.org/browse/JBEHAVE-1049
2014-10-01 1:02 GMT+02:00 Mauro Talevi mauro.tal...@aquilonia.org:
Yes, there is a problem but not in the converter. Rather, the
StepCreator tries to use the parameter types instead of the generic
parameter types.
Could you please raise a Jira issue for this?
Cheers
On 30/09/2014 15:19, Matthieu Mestrez wrote:
Since i'm behind a proxy at work i can only give you a zip file to work
with by this way :
http://www.filedropper.com/meta-string-list
2014-09-30 15:52 GMT+02:00 Matthieu Mestrez mestrez.matth...@gmail.com:
Since i'm behind a proxy at work i can only give you a zip file to work
with by this way :
http://www.filedropper.com/meta-string-list
Or attached here, not sure it will work through a mailing list though :
2014-09-30 15:00 GMT+02:00 Mauro Talevi mauro.tal...@aquilonia.org:
Could you provide a sample project that reproduces the desired
behaviour?
On 30 Sep 2014, at 13:01, Matthieu Mestrez
mestrez.matth...@gmail.com wrote:
Hello,
I've been trying to make use of a list of strings in a Meta in this
context :
Scenario: 1. First Case
Meta :
@Dataset firstDataset.xml, secondDataset.xml
Given ...
When ..
Then ...
And in the
@BeforeScenario
public void initializeDataset(@Named(Dataset) ListString
dbUnitFiles) {
...
}
The scenario fails because
org.jbehave.core.steps.ParameterConverters$ParameterConvertionFailed: No
parameter converter for interface java.util.List'
If i debug, he passes through the StringListConverter, but in the
accept method the type is not an instance of ParameterizedType, because in
the StepCreator class you use method.getParameterTypes() that doesn't
retrieve de generics but the Class type (so java.util.List)
I think that you should use for that Parameter class the Type and not
the Class
Or maybe i've made a mistake somewhere
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
Re: [jbehave-dev] Generics doesn't work for StringListConverter, List is not recognized as a ParameterType
Thank you for reporting the issue and providing the suggested fix.
We'll push out a release on the weekend.
On 02/10/2014 07:16, Matthieu Mestrez wrote:
Nice ! You fixed it that fast !
Thanks for that.
Do you know when i can expect a release ?
2014-10-01 10:15 GMT+02:00 Matthieu Mestrez
mestrez.matth...@gmail.com mailto:mestrez.matth...@gmail.com:
Thanks for the follow-up
I've created a Jira issue here :
https://jira.codehaus.org/browse/JBEHAVE-1049
2014-10-01 1:02 GMT+02:00 Mauro Talevi mauro.tal...@aquilonia.org
mailto:mauro.tal...@aquilonia.org:
Yes, there is a problem but not in the converter. Rather,
the StepCreator tries to use the parameter types instead of
the generic parameter types.
Could you please raise a Jira issue for this?
Cheers
On 30/09/2014 15:19, Matthieu Mestrez wrote:
Since i'm behind a proxy at work i can only give you a zip
file to work with by this way :
http://www.filedropper.com/meta-string-list
2014-09-30 15:52 GMT+02:00 Matthieu Mestrez
mestrez.matth...@gmail.com mailto:mestrez.matth...@gmail.com:
Since i'm behind a proxy at work i can only give you a
zip file to work with by this way :
http://www.filedropper.com/meta-string-list
Or attached here, not sure it will work through a mailing
list though :
2014-09-30 15:00 GMT+02:00 Mauro Talevi
mauro.tal...@aquilonia.org
mailto:mauro.tal...@aquilonia.org:
Could you provide a sample project that reproduces
the desired behaviour?
On 30 Sep 2014, at 13:01, Matthieu Mestrez
mestrez.matth...@gmail.com
mailto:mestrez.matth...@gmail.com wrote:
Hello,
I've been trying to make use of a list of strings
in a Meta in this context :
Scenario: 1. First Case
Meta :
@Dataset firstDataset.xml, secondDataset.xml
Given ...
When ..
Then ...
And in the
@BeforeScenario
public void initializeDataset(@Named(Dataset)
ListString dbUnitFiles) {
...
}
The scenario fails because
org.jbehave.core.steps.ParameterConverters$ParameterConvertionFailed:
No parameter converter for interface java.util.List'
If i debug, he passes through the
StringListConverter, but in the accept method the
type is not an instance of ParameterizedType, because
in the StepCreator class you use
method.getParameterTypes() that doesn't retrieve de
generics but the Class type (so java.util.List)
I think that you should use for that Parameter
class the Type and not the Class
Or maybe i've made a mistake somewhere
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
mailto:mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
mailto:mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com
mailto:mestrez.matth...@gmail.com
--
Mestrez Matthieu
avenue Jolé 11
1160 Auderghem
GSM : 0494/77.26.87
e-mail : mestrez.matth...@gmail.com mailto:mestrez.matth...@gmail.com
[jbehave-dev] [jira] (JBEHAVE-1050) Last of two subsequent internationalized AND-clauses is not performed
Title: Message Title Nikolay Artamonov created an issue JBehave / JBEHAVE-1050 Last of two subsequent internationalized AND-clauses is not performed Issue Type: Bug Affects Versions: 3.9.4 Assignee: Unassigned Components: Core Created: 02/Oct/14 4:47 AM Environment: Windows 7 x64 Priority: Major Reporter: Nikolay Artamonov I translated jbehave scenario keywords to russian, so that: Given - When - Then - And - When I try to execute simple scenario with three THEN-clauses concatenated with AND: something happened check first condition check second condition check third condition Then last clause is not matched with corresponding step and marked as pending. Although corresponding step is present in code. If I use english keywords all work fine. I created sample project for
[jbehave-dev] [jira] (JBEHAVE-1050) Last of two subsequent internationalized AND-clauses is not performed
Title: Message Title
Nikolay Artamonov updated an issue
JBehave / JBEHAVE-1050
Last of two subsequent internationalized AND-clauses is not performed
Change By:
Nikolay Artamonov
Itranslatedjbehavescenariokeywordstorussian,sothat:{noformat:nopanel=true}Given-When- Then- And- {noformat}WhenItrytoexecutesimplescenariowiththreeTHEN-clausesconcatenatedwithAND:{noformat:nopanel=true} somethinghappened checkfirstcondition checksecondcondition checkthirdcondition{noformat}Thenlastclauseisnotmatchedwithcorrespondingstepandmarkedaspending.Althoughcorrespondingstepispresentincode.*IfIuseenglishkeywordsallworkfine*.Icreatedsampleprojectforreproducingbug:https://github.com/nartamonov/jbehave-i18n-bug
Add Comment
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1050) Last of two subsequent internationalized AND-clauses is not performed
Title: Message Title
Nikolay Artamonov updated an issue
JBehave / JBEHAVE-1050
Last of two subsequent internationalized AND-clauses is not performed
Change By:
Nikolay Artamonov
Itranslatedjbehavescenariokeywordstorussian,sothat: {noformat:nopanel=true}Given- When-
Then- And- {noformat}WhenItrytoexecutesimplescenariowiththreeTHEN-clausesconcatenatedwithAND:{noformat:nopanel=true}
somethinghappened checkfirstcondition checksecondcondition checkthirdcondition{noformat}Thenlastclauseisnotmatchedwithcorrespondingstepandmarkedaspending.Althoughcorrespondingstepispresentincode.*IfIuseenglishkeywordsallworkfine*.Icreatedsampleprojectforreproducingbug:https://github.com/nartamonov/jbehave-i18n-bug
Add Comment
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1050) Last of two subsequent AND-clauses with translated keywords is not performed
Title: Message Title
Nikolay Artamonov updated an issue
JBehave / JBEHAVE-1050
Last of two subsequent AND-clauses with translated keywords is not performed
Change By:
Nikolay Artamonov
Summary:
Lastoftwosubsequent internationalized AND-clauses withtranslatedkeywords isnotperformed
Itranslated jbehavescenariokeywords 'And'keyword to 'Ande'(actuallyIuse russian word , sothat: butinordertosimplifyIwilluseplainlatinletters).Allotherkeywordsremainthesame. {noformat:nopanel=true}Given- When -Then-And-{noformat}When ItrytoexecutesimplescenariowiththreeTHEN-clausesconcatenated with by AND:{noformat:nopanel=true} When somethinghappened Then checkfirstcondition Ande checksecondcondition Ande checkthirdcondition{noformat}Thenlastclauseisnotmatchedwithcorrespondingstepandmarkedaspending.Althoughcorrespondingstepispresentincode.*IfIuseenglish keywords keyword'And' allworkfine*.Icreatedsampleprojectforreproducingbug:https://github.com/nartamonov/jbehave-i18n-bug
Add Comment
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
-
To unsubscribe
[jbehave-dev] [jira] (JBEHAVE-1051) The method StoryManager.waitUntilAllDoneOrFailed(BatchFailures) can cancel un-started stories
Title: Message Title Jewgenij Moldawski created an issue JBehave / JBEHAVE-1051 The method StoryManager.waitUntilAllDoneOrFailed(BatchFailures) can cancel un-started stories Issue Type: Bug Affects Versions: 3.x Assignee: Unassigned Components: Core Created: 02/Oct/14 9:37 AM Environment: IBM J9 VM (build 2.6, JRE 1.7.0 Windows 7 amd64-64 Compressed References 2013061 7_152572 (JIT enabled, AOT enabled) J9VM - R26_Java726_SR5_20130617_1436_B152572 JIT - r11.b04_20130528_38954ifx1 GC - R26_Java726_SR5_20130617_1436_B152572_CMPRSS J9CL - 20130617_152572) JCL - 20130616_01 based on Oracle 7u25-b12 Priority: Major Reporter: Jewgenij Moldawski I run several stories in parallel using the default multi-threaded Embedder.executorService and configure it with EmbedderControls.threads 1 Sometimes the JBEHAVE ends and no scenario (but before- and after- scenario) of my stories was even started. It is not repeatable, sometims it goes good. I founded out, that the method StoryManager.waitUntilAllDoneOrFailed fails, if there are ONLY stories, which are already SUBMITTED, but not yet really STARTED. The method
[jbehave-dev] [jira] (JBEHAVE-1051) The method StoryManager.waitUntilAllDoneOrFailed(BatchFailures) can cancel un-started stories
Title: Message Title
Jewgenij Moldawski commented on an issue
Re: The method StoryManager.waitUntilAllDoneOrFailed(BatchFailures) can cancel un-started stories
With this patch I could solve this problem. I didn't refactor the if (true) in order to show the real change.
diff --git a/jbehave-core/src/main/java/org/jbehave/core/embedder/StoryManager.java b/jbehave-core/src/main/java/org/jbehave/core/embedder/StoryManager.java index 2414cf7..ad70587 100644 ? a/jbehave-core/src/main/java/org/jbehave/core/embedder/StoryManager.java +++ b/jbehave-core/src/main/java/org/jbehave/core/embedder/StoryManager.java @@ -143,7 +143,7 @@ while (!allDone) { allDone = true; for (RunningStory runningStory : runningStories.values()) {
if ( runningStory.isStarted() ){ + if ( true ){ Story story = runningStory.getStory(); FutureThrowableStory future = runningStory.getFuture(); if (!future.isDone()) {
Add Comment
JBehave / JBEHAVE-1051
The method StoryManager.waitUntilAllDoneOrFailed(BatchFailures) can cancel un-started stories
I run several stories in parallel using the default multi-threaded Embedder.executorService and configure it with EmbedderControls.threads 1 Sometimes the JBEHAVE ends and no scenario (but before- and after- scenario) of my stories was even started. It is not repeatable, sometims it goes good. I founded out, that the method StoryManager.waitUntilAllDo...
