[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted Yep I can take a stab at it. The more I think about this, the more I'm wondering if it would be better to simply have a configuration that takes a number to define how many times to restart the story if any failure occurs. This would replace trying to keep track and see if the RestartingStoryFailure exception was thrown. Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Mauro Talevi commented on an issue Re: Allow entire story to be restarted Hi Brett, apologies for the delay in pulling this request. I meant to do the corresponding changes to the 4.x branch but did not get time for it. Could you perhaps have a first stab at it? Essentially changing the PerformableTree in a similar way you've modified the StoryRunner? Cheers Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted Is there anything else I can do to help get this merged? Let me know if you want me to re-work any code Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Mauro Talevi commented on an issue Re: Allow entire story to be restarted Hi Brett, the changes are a bit tricky to track because they're spread over multiple commits. Could you please provide in a single commit the proposed changes since the pull of Nov 10? Thanks Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted The above problems have been resolved: https://github.com/jbehave/jbehave-core/pull/71 Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted The above pull request doesn't work when running a story with an examples table. I'm working on resolving this Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted I updated the restarting.story to reflect these changes, and are in pull request https://github.com/jbehave/jbehave-core/pull/71 Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted Great, thank you very much! I tried the code, and if an exception is thrown from a before/after annotated method, it does not restart the story. Exceptions that happen in that area only gets logged, and does not get saved off anywhere. The scenario would be like this: If a story fails, call the annotated method: @AfterScenario(uponType = ScenarioType.NORMAL, uponOutcome = Outcome.FAILURE) public void afterNormalScenario(UUIDExceptionWrapper uuidWrappedFailure) Inside of that method, would be logic to restart the story if it fails the first time. Other then that don't restart. I'll see if I can add that logic to the restarting.story, but I may have to edit a lifecycle method somewhere to do this. Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to...
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Mauro Talevi commented on an issue Re: Allow entire story to be restarted Did some cleanup on the StoryRunner implementation. Can you please verify it works on your side? Please add any different behaviour to restarting.story. Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Mauro Talevi updated an issue JBehave / JBEHAVE-1053 Allow entire story to be restarted Change By: Mauro Talevi Fix Version/s: 3.9.6 Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Mauro Talevi commented on an issue Re: Allow entire story to be restarted Thanks for the contribution! I'll have a look at it soon. As for the multi-threading reporting, it should get reported by the invokeDelayed() method in the ConcurrentReporter. Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker commented on an issue Re: Allow entire story to be restarted I've created a branch for this issue with some the basics implemented: https://github.com/bbarke/jbehave-core How it works is similar to the RestartingScenarioFailure, just throw RestartingStoryFailure somewhere within the jbehave framework and it will restart the story Some questions/problems I have are: reporter.get().restartedStory(story, e); does not get reported if running in multi-threaded mode (Story runner, line 254) Also, I am not sure how to get reporting to report if a story was restarted or not. Please advise how I can get the reporting to work correctly Thanks in advance! Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker edited a comment on an issue Re: Allow entire story to be restarted I'vecreatedabranchforthisissuewithsomethebasicsimplemented:https://github.com/bbarke/jbehave-core https://github.com/bbarke/jbehave-core/commit/c6c7020f04ee247619d530e76f742c9e9d229aae HowitworksissimilartotheRestartingScenarioFailure,justthrowRestartingStoryFailuresomewherewithinthejbehaveframeworkanditwillrestartthestorySomequestions/problemsIhaveare:reporter.get().restartedStory(story,e);doesnotgetreportedifrunninginmulti-threadedmode(Storyrunner,line254)Also,Iamnotsurehowtogetreportingtoreportifastorywasrestartedornot.PleaseadvisehowIcangetthereportingtoworkcorrectlyThanksinadvance! Add Comment JBehave / JBEHAVE-1053 Allow entire story to be restarted For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to... This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-1053) Allow entire story to be restarted
Title: Message Title Brent Barker created an issue JBehave / JBEHAVE-1053 Allow entire story to be restarted Issue Type: New Feature Affects Versions: 3.9.5 Assignee: Unassigned Components: Core Created: 30/Oct/14 11:26 AM Priority: Major Reporter: Brent Barker For selenium tests that keep the same browser / context throughout the story, there are countless things that can go wrong such as network latency, slow application, etc. Since a false positive can cause people to quickly lose trust in the tests, others advised that the story should restart x amount of times before failing the test. There is a way to restart a single scenario, but it is possible it could cause additional errors such as expecting to be on a specific page when the scenario starts, context variables have been changed, being in an unknown state with data.
