Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-15 Thread Ying Jiang
Hi,

The doc is actually construct-quad.mdtext. In another easy way, You
can just compose it offline, and send it to us for review. I can help
you commit the mdtext file into svn finally.

Best regards,
Ying Jiang

On Sat, Aug 15, 2015 at 5:21 PM, Qihong Lin confidence@gmail.com wrote:
 Hi,

 Please check my updates of the 3 tasks blow:

 1) jena/arq: in master branch (to be merged first)
 In PR 89, I added some more tests in TestAPI and TS_Script. The bug of
 construct quad projection on exeConstructTriples() has been fixed,
 with the tests of 4 cases (commit 03a321f).

 2) jena/fuseki: in JENA-491 branch
 In PR 91, see commit 0eb28d8. You can try out
 org.apache.jena.fuseki.TestQuery.query_construct_01()/query_construct_quad_01()

 3) doc: in jena web page (wiki)
 I can see the staging page [1]. But when I try the Improve this Page
 with [1], it redirects me to [2]. I can not find construct_quad.mdtext
 under [2]. I also try to open [3], with Not Found error. Could you
 help me please?

 regards,
 Qihong

 [1] http://jena.staging.apache.org/documentation/query/construct-quad.html
 [2] https://cms.apache.org/jena/wc/edit/anonymous-LWMAVL/trunk/
 [3] http://jena.apache.org/documentation/query/construct-quad.html

 On Tue, Aug 11, 2015 at 10:35 AM, Ying Jiang jpz6311...@gmail.com wrote:
 Hi Qihong,

 You may have received the reminder email from Google that the final
 evaluation of the GSoC project is approaching. The soft deadline is
 17 August, with the hard one on 21 August. It means there're only 2
 weeks left for your remaining work. The tests of arq need improving,
 as Andy points out. You can also deliver the Fuseki part in the other
 branch for review in the mean time. Meanwhile, the documentation can
 be composed in jena web page (wiki). In order to save time, I suggest
 the 3 parts of the work go on simultaneously:
 1) jena/arq: in master branch (to be merged first)
 2) jena/fuseki: in JENA-491 branch
 3) doc: in jena web page (wiki)

 Best regards,
 Ying Jiang


 On Mon, Aug 10, 2015 at 9:58 PM, Andy Seaborne a...@apache.org wrote:
 I've managed to integrate the latest updates.

 The scripted ones look, at first glance OK, but the data isn't very rich.

 Also, please can we have some API tests in TestAPI.  These are JUnit tests
 in java.  These should be have comprehensive coverage.

 I also tried out execConstructTriples(), I noticed that the result is from
 all graphs.  When just triples are asked for, only those in the default
 graph should be returned.  Template.getTriples calls Quad.asTriple.  But it
 needs to deal with just the default graph, and c can't rely on
 Quad.asTriple.

 Andy


 On 10/08/15 12:44, Qihong Lin wrote:

 Hi,

 I've enriched the syntax tests with short form and default graph
 cases.

 For execution tests, I add the test support in QueryTest for construct
 quad with the scripts files and data files in TRIG (see
 jena-arq/testing/ARQ/Construct/*.trig). I think construct quad should
 be part of the construct of ARQ. So I add the execution tests in
 jena-arq/testing/ARQ/Construct/manifest.ttl.

 The fuseki part of construct quad has been implemented (not committed
 yet). I'll submit the code as soon as the PR 89 [1] being merged.
 Anything to be improved for PR 89 from your reviews?

 regards,
 Qihong

 [1] https://github.com/apache/jena/pull/89


 On Thu, Aug 6, 2015 at 8:55 PM, Andy Seaborne a...@apache.org wrote:

 Hi - looking better - I see the syntax tests I provided.

 Does that set of tests cover all cases of the new syntax?

 Next, we need execution tests for ARQ.

 There will need to be execute tests in jena-arq as well. These can be
 Junit tests in java and do not need to be external script files.
 This is separate from testing in Fuseki.



 Do you have any other constraints on your time over the next 2 weeks?

  Andy


 On 06/08/15 04:18, Qihong Lin wrote:


 Hi,

 I've fixed the bugs related to syntax checks. Please see my latest
 commits. Here're the output of the syntax files through qparse (you
 can also run ExampleConstructQuads.java to get the results). Are
 these with the expected behaviors, especially for
 syntax-quad-construct-07.arq?

 run-construct-quad-test:  File: syntax-quad-construct-01.arq
 PREFIX : http://example/

 CONSTRUCT { GRAPH :g { :s :p :o } } WHERE {}  Output of qparse
 --file syntax-quad-construct-01.arq PREFIX  : http://example/

 CONSTRUCT { GRAPH :g { :s :p :o .} } WHERE {  }  File:
 syntax-quad-construct-02.arq PREFIX : http://example/

 CONSTRUCT { GRAPH ?g { ?s ?p ?o } } WHERE { ?s ?p ?o }  Output of
 qparse --file syntax-quad-construct-02.arq PREFIX  :
 http://example/

 CONSTRUCT { GRAPH ?g { ?s ?p ?o .} } WHERE { ?s  ?p  ?o } 
 File: syntax-quad-construct-03.arq PREFIX : http://example/

 CONSTRUCT { :s :p :o } WHERE {}  Output of qparse --file
 syntax-quad-construct-03.arq PREFIX  : http://example/

 CONSTRUCT { :s :p :o . } WHERE {  }  File:
 

[jira] [Commented] (JENA-491) Extend CONSTRUCT to build quads

2015-08-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698191#comment-14698191
 ] 

ASF GitHub Bot commented on JENA-491:
-

GitHub user confidencesun opened a pull request:

https://github.com/apache/jena/pull/91

Jena 491 - Fuseki support of construct quad

confidencesun/jena/JENA-491 contains the code commits of Fuseki support of 
construct quad

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/confidencesun/jena JENA-491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 5237c71aef40b7e1be24a62f407ab3f0ae550b41
Author: confidencesun confidence@gmail.com
Date:   2015-03-21T16:34:54Z

a demo for JENA-491

commit 15c9b132964e331132225661da4cc8348d02418c
Author: confidencesun confidence@gmail.com
Date:   2015-05-24T08:39:47Z

Merge pull request #1 from apache/master

pull master to  begin

commit ee075b7b201f80c6ed421210971952f139a8ccaf
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T13:24:15Z

Merge pull request #3 from apache/master

sych master 20150526

commit 3f163bff6b1d4020c0f2a77321bbb47baf743ebb
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T23:38:58Z

delete JENA-491 example code

commit ca1dc7bbcce401dea0908f22b3a4209d562716a0
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T23:47:00Z

Merge pull request #4 from confidencesun/master

delete JENA-491 example code

commit 2d09a7dfe84539ecdafc9f99247019d0ddeefd5e
Author: confidencesun confidence@gmail.com
Date:   2015-06-11T14:56:15Z

create new Template for SPARQL_11

commit 07c8b98dbafbf2ea12ee3f6df6816e8edda93650
Author: confidencesun confidence@gmail.com
Date:   2015-06-12T03:03:13Z

rollback FmtTemplate, in order to build success for TS_Scripted

commit 2cb175d2305c02582eb24629d18d06bdc53ae4ba
Author: confidencesun confidence@gmail.com
Date:   2015-06-15T10:12:10Z

reimplement Template, that does not affect the SPARQL 1.0 parser

commit a8b0d53e83a39357f6d35763494ecfa447826b51
Author: confidencesun confidence@gmail.com
Date:   2015-06-18T03:21:34Z

The SPARQL 1.1 parser (like the SPARQL 1.0 parser) are now unchanged.

commit c475249148792da2148cd9ec9976312516ed1d11
Author: confidencesun confidence@gmail.com
Date:   2015-06-18T08:44:33Z

refactor ConstructTemplate() to make ARQ for constructing quards similar
to that for triples.

commit 5076b1ed0844d0a1e7c57b539b64af3d831ee039
Author: confidencesun confidence@gmail.com
Date:   2015-06-19T08:22:38Z

new QueryExecution operations: execConstrucQuads(),
execConstructDataset()

commit d0ce13b2587905859c9ed854f5114b8c86c2125c
Author: confidencesun confidence@gmail.com
Date:   2015-06-19T08:53:07Z

add licence info for ExampleConstructQuads; retain QuadAcc unchanged

commit d58625693e9439ee0c9164b56993b44f34c2a383
Author: confidencesun confidence@gmail.com
Date:   2015-06-21T13:16:18Z

fix bugs for default graphs; add some examples in
ExampleConstructQuads.java

commit 5e56c1f2b0e2b0b2f6a1e7fda9fe17b6254176da
Author: confidencesun confidence@gmail.com
Date:   2015-06-21T13:28:15Z

commit ExampleConstructQuads.java

commit 1348bf5498543f747f1b4707f011a46bfcca90e1
Author: confidencesun confidence@gmail.com
Date:   2015-07-22T06:16:15Z

Merge pull request #8 from apache/master

pull master up to date

commit e58b62cb2e288cc71754776e00179cd011ecdf5f
Author: confidencesun confidence@gmail.com
Date:   2015-07-22T07:07:10Z

Merge remote-tracking branch 'origin/JENA-491'

commit 6e4379e5d4ab94d5689813edeef1edfa496f9d33
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T09:41:55Z

Merge pull request #9 from apache/master

pull master 2015-07-24

commit 5b73280fc9ecbfe8526230031080a4bb6c8cbec3
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T10:39:48Z

1) remove all @author; 2) remove unnecesary blank lines

commit 7d0986fbde189afa79c8cf52a81a56802f37aff5
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T21:40:12Z

better way to print datasets

commit 44d8010659bbc813dddee9ffca8ef529f716ad11
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T23:39:32Z

No need to write the package name - add an import

commit e398c4e73e6ebb907c1b9acd584f965050cbc4ca
Author: confidencesun confidence@gmail.com
Date:   2015-07-27T00:54:40Z

fix graph uri in the example of construct quads

commit 1ce04970fdf72c1b5bf2d209349ad4fec4390b65
Author: confidencesun confidence@gmail.com
Date:   2015-07-28T19:40:08Z

   

[GitHub] jena pull request: Jena 491 - Fuseki support of construct quad

2015-08-15 Thread confidencesun
GitHub user confidencesun opened a pull request:

https://github.com/apache/jena/pull/91

Jena 491 - Fuseki support of construct quad

confidencesun/jena/JENA-491 contains the code commits of Fuseki support of 
construct quad

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/confidencesun/jena JENA-491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 5237c71aef40b7e1be24a62f407ab3f0ae550b41
Author: confidencesun confidence@gmail.com
Date:   2015-03-21T16:34:54Z

a demo for JENA-491

commit 15c9b132964e331132225661da4cc8348d02418c
Author: confidencesun confidence@gmail.com
Date:   2015-05-24T08:39:47Z

Merge pull request #1 from apache/master

pull master to  begin

commit ee075b7b201f80c6ed421210971952f139a8ccaf
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T13:24:15Z

Merge pull request #3 from apache/master

sych master 20150526

commit 3f163bff6b1d4020c0f2a77321bbb47baf743ebb
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T23:38:58Z

delete JENA-491 example code

commit ca1dc7bbcce401dea0908f22b3a4209d562716a0
Author: confidencesun confidence@gmail.com
Date:   2015-05-26T23:47:00Z

Merge pull request #4 from confidencesun/master

delete JENA-491 example code

commit 2d09a7dfe84539ecdafc9f99247019d0ddeefd5e
Author: confidencesun confidence@gmail.com
Date:   2015-06-11T14:56:15Z

create new Template for SPARQL_11

commit 07c8b98dbafbf2ea12ee3f6df6816e8edda93650
Author: confidencesun confidence@gmail.com
Date:   2015-06-12T03:03:13Z

rollback FmtTemplate, in order to build success for TS_Scripted

commit 2cb175d2305c02582eb24629d18d06bdc53ae4ba
Author: confidencesun confidence@gmail.com
Date:   2015-06-15T10:12:10Z

reimplement Template, that does not affect the SPARQL 1.0 parser

commit a8b0d53e83a39357f6d35763494ecfa447826b51
Author: confidencesun confidence@gmail.com
Date:   2015-06-18T03:21:34Z

The SPARQL 1.1 parser (like the SPARQL 1.0 parser) are now unchanged.

commit c475249148792da2148cd9ec9976312516ed1d11
Author: confidencesun confidence@gmail.com
Date:   2015-06-18T08:44:33Z

refactor ConstructTemplate() to make ARQ for constructing quards similar
to that for triples.

commit 5076b1ed0844d0a1e7c57b539b64af3d831ee039
Author: confidencesun confidence@gmail.com
Date:   2015-06-19T08:22:38Z

new QueryExecution operations: execConstrucQuads(),
execConstructDataset()

commit d0ce13b2587905859c9ed854f5114b8c86c2125c
Author: confidencesun confidence@gmail.com
Date:   2015-06-19T08:53:07Z

add licence info for ExampleConstructQuads; retain QuadAcc unchanged

commit d58625693e9439ee0c9164b56993b44f34c2a383
Author: confidencesun confidence@gmail.com
Date:   2015-06-21T13:16:18Z

fix bugs for default graphs; add some examples in
ExampleConstructQuads.java

commit 5e56c1f2b0e2b0b2f6a1e7fda9fe17b6254176da
Author: confidencesun confidence@gmail.com
Date:   2015-06-21T13:28:15Z

commit ExampleConstructQuads.java

commit 1348bf5498543f747f1b4707f011a46bfcca90e1
Author: confidencesun confidence@gmail.com
Date:   2015-07-22T06:16:15Z

Merge pull request #8 from apache/master

pull master up to date

commit e58b62cb2e288cc71754776e00179cd011ecdf5f
Author: confidencesun confidence@gmail.com
Date:   2015-07-22T07:07:10Z

Merge remote-tracking branch 'origin/JENA-491'

commit 6e4379e5d4ab94d5689813edeef1edfa496f9d33
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T09:41:55Z

Merge pull request #9 from apache/master

pull master 2015-07-24

commit 5b73280fc9ecbfe8526230031080a4bb6c8cbec3
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T10:39:48Z

1) remove all @author; 2) remove unnecesary blank lines

commit 7d0986fbde189afa79c8cf52a81a56802f37aff5
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T21:40:12Z

better way to print datasets

commit 44d8010659bbc813dddee9ffca8ef529f716ad11
Author: confidencesun confidence@gmail.com
Date:   2015-07-24T23:39:32Z

No need to write the package name - add an import

commit e398c4e73e6ebb907c1b9acd584f965050cbc4ca
Author: confidencesun confidence@gmail.com
Date:   2015-07-27T00:54:40Z

fix graph uri in the example of construct quads

commit 1ce04970fdf72c1b5bf2d209349ad4fec4390b65
Author: confidencesun confidence@gmail.com
Date:   2015-07-28T19:40:08Z

Merge pull request #10 from apache/master

pull master 2015-07-28

commit 9920b52b5614e48dca4bf5f96bc493b466a991bd
Author: confidencesun confidence@gmail.com
Date:   2015-07-28T19:41:24Z

Merge pull request #11 from 

[jira] [Resolved] (JENA-1009) tdbloader2 does not handle files beginning with a -

2015-08-15 Thread Andy Seaborne (JIRA)

 [ 
https://issues.apache.org/jira/browse/JENA-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1009.
-
   Resolution: Fixed
 Assignee: Andy Seaborne
Fix Version/s: Jena 3.0.1

 tdbloader2 does not handle files beginning with a -
 -

 Key: JENA-1009
 URL: https://issues.apache.org/jira/browse/JENA-1009
 Project: Apache Jena
  Issue Type: Bug
  Components: TDB
Affects Versions: Jena 3.0.0
Reporter: Andy Seaborne
Assignee: Andy Seaborne
Priority: Minor
 Fix For: Jena 3.0.1


 {{tdbloader2 -loc=DB2 -\- -D.nt}}
 gives 
 {noformat}
 readlink: invalid option -- 'D'
 Try 'readlink --help' for more information.
 {noformat}
 so {{readlink -f -\- ...}} should be needed.
 The call to {{CmdNodeTableBuilder}} will need a {{-\-}} as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-15 Thread Qihong Lin
Hi,

Please check my updates of the 3 tasks blow:

1) jena/arq: in master branch (to be merged first)
In PR 89, I added some more tests in TestAPI and TS_Script. The bug of
construct quad projection on exeConstructTriples() has been fixed,
with the tests of 4 cases (commit 03a321f).

2) jena/fuseki: in JENA-491 branch
In PR 91, see commit 0eb28d8. You can try out
org.apache.jena.fuseki.TestQuery.query_construct_01()/query_construct_quad_01()

3) doc: in jena web page (wiki)
I can see the staging page [1]. But when I try the Improve this Page
with [1], it redirects me to [2]. I can not find construct_quad.mdtext
under [2]. I also try to open [3], with Not Found error. Could you
help me please?

regards,
Qihong

[1] http://jena.staging.apache.org/documentation/query/construct-quad.html
[2] https://cms.apache.org/jena/wc/edit/anonymous-LWMAVL/trunk/
[3] http://jena.apache.org/documentation/query/construct-quad.html

On Tue, Aug 11, 2015 at 10:35 AM, Ying Jiang jpz6311...@gmail.com wrote:
 Hi Qihong,

 You may have received the reminder email from Google that the final
 evaluation of the GSoC project is approaching. The soft deadline is
 17 August, with the hard one on 21 August. It means there're only 2
 weeks left for your remaining work. The tests of arq need improving,
 as Andy points out. You can also deliver the Fuseki part in the other
 branch for review in the mean time. Meanwhile, the documentation can
 be composed in jena web page (wiki). In order to save time, I suggest
 the 3 parts of the work go on simultaneously:
 1) jena/arq: in master branch (to be merged first)
 2) jena/fuseki: in JENA-491 branch
 3) doc: in jena web page (wiki)

 Best regards,
 Ying Jiang


 On Mon, Aug 10, 2015 at 9:58 PM, Andy Seaborne a...@apache.org wrote:
 I've managed to integrate the latest updates.

 The scripted ones look, at first glance OK, but the data isn't very rich.

 Also, please can we have some API tests in TestAPI.  These are JUnit tests
 in java.  These should be have comprehensive coverage.

 I also tried out execConstructTriples(), I noticed that the result is from
 all graphs.  When just triples are asked for, only those in the default
 graph should be returned.  Template.getTriples calls Quad.asTriple.  But it
 needs to deal with just the default graph, and c can't rely on
 Quad.asTriple.

 Andy


 On 10/08/15 12:44, Qihong Lin wrote:

 Hi,

 I've enriched the syntax tests with short form and default graph
 cases.

 For execution tests, I add the test support in QueryTest for construct
 quad with the scripts files and data files in TRIG (see
 jena-arq/testing/ARQ/Construct/*.trig). I think construct quad should
 be part of the construct of ARQ. So I add the execution tests in
 jena-arq/testing/ARQ/Construct/manifest.ttl.

 The fuseki part of construct quad has been implemented (not committed
 yet). I'll submit the code as soon as the PR 89 [1] being merged.
 Anything to be improved for PR 89 from your reviews?

 regards,
 Qihong

 [1] https://github.com/apache/jena/pull/89


 On Thu, Aug 6, 2015 at 8:55 PM, Andy Seaborne a...@apache.org wrote:

 Hi - looking better - I see the syntax tests I provided.

 Does that set of tests cover all cases of the new syntax?

 Next, we need execution tests for ARQ.

 There will need to be execute tests in jena-arq as well. These can be
 Junit tests in java and do not need to be external script files.
 This is separate from testing in Fuseki.



 Do you have any other constraints on your time over the next 2 weeks?

  Andy


 On 06/08/15 04:18, Qihong Lin wrote:


 Hi,

 I've fixed the bugs related to syntax checks. Please see my latest
 commits. Here're the output of the syntax files through qparse (you
 can also run ExampleConstructQuads.java to get the results). Are
 these with the expected behaviors, especially for
 syntax-quad-construct-07.arq?

 run-construct-quad-test:  File: syntax-quad-construct-01.arq
 PREFIX : http://example/

 CONSTRUCT { GRAPH :g { :s :p :o } } WHERE {}  Output of qparse
 --file syntax-quad-construct-01.arq PREFIX  : http://example/

 CONSTRUCT { GRAPH :g { :s :p :o .} } WHERE {  }  File:
 syntax-quad-construct-02.arq PREFIX : http://example/

 CONSTRUCT { GRAPH ?g { ?s ?p ?o } } WHERE { ?s ?p ?o }  Output of
 qparse --file syntax-quad-construct-02.arq PREFIX  :
 http://example/

 CONSTRUCT { GRAPH ?g { ?s ?p ?o .} } WHERE { ?s  ?p  ?o } 
 File: syntax-quad-construct-03.arq PREFIX : http://example/

 CONSTRUCT { :s :p :o } WHERE {}  Output of qparse --file
 syntax-quad-construct-03.arq PREFIX  : http://example/

 CONSTRUCT { :s :p :o . } WHERE {  }  File:
 syntax-quad-construct-04.arq PREFIX : http://example/

 CONSTRUCT { GRAPH ?g { :s :p :o } ?s ?p ?o } WHERE { GRAPH ?g { ?s ?p
 ?o } }  Output of qparse --file syntax-quad-construct-04.arq
 PREFIX  : http://example/

 CONSTRUCT { GRAPH ?g { :s :p :o .} ?s ?p ?o . } WHERE { GRAPH ?g { ?s
 ?p  ?o } }