[jira] [Commented] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274809#comment-16274809
 ] 

ASF GitHub Bot commented on JENA-1437:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/322


> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274808#comment-16274808
 ] 

ASF subversion and git services commented on JENA-1437:
---

Commit 9d2a65785f9ad59bc9c2debd2e01b9594113f191 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=9d2a657 ]

JENA-1437: Merge commit 'refs/pull/322/head' of github.com:apache/jena

This closes #322.


> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274806#comment-16274806
 ] 

ASF subversion and git services commented on JENA-1437:
---

Commit 304dc0551f45b5d86174da714be9d63529b9f533 in jena's branch 
refs/heads/master from [~c...@moonvine.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=304dc05 ]

JENA-1437-multiLingual

Corrects issue reported in JENA-1437

> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1437.
-
   Resolution: Fixed
Fix Version/s: Jena 3.6.0

> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274807#comment-16274807
 ] 

ASF subversion and git services commented on JENA-1437:
---

Commit 304dc0551f45b5d86174da714be9d63529b9f533 in jena's branch 
refs/heads/master from [~c...@moonvine.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=304dc05 ]

JENA-1437-multiLingual

Corrects issue reported in JENA-1437

> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (JENA-1437) text:multilingualSupport true vs false inconsistent results

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne reassigned JENA-1437:
---

Assignee: Andy Seaborne

> text:multilingualSupport true vs false inconsistent results
> ---
>
> Key: JENA-1437
> URL: https://issues.apache.org/jira/browse/JENA-1437
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>  Labels: patch
> Fix For: Jena 3.6.0
>
>
> If {{text:multilingualSupport false}} then
> {{?s text:query ("some string" "lang:lang-code")}}
> may be expected to return matches for the {{text:defaultField}} restricted to 
> the given {{lang-code}}.
> However, if {{text:multilingualSupport true}} then the same query always 
> returns zero results owing to an improper rewriting of the query string with 
> a field spec of:
> {{"null_lang-code:some string"}}.
> OTOH, explicit mention of the {{text:predicate}} corresponding to the 
> {{text:defaultField}}, e.g., {{rdfs:label}}, yields the expected results:
> {{?s text:query (rdfs:label "some string" "lang:lang-code")}}
> Should be fixed with a proper rewriting of the _query-string_ to:
> {{"text:defaultField_lang-code:some string"}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jena pull request #322: JENA-1437-multiLingual

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/322


---

[jira] [Resolved] (JENA-1438) rdf:langString argument to text:query silently ignored

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1438.
-
   Resolution: Fixed
Fix Version/s: Jena 3.6.0

> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.6.0
>
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274798#comment-16274798
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/320


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (JENA-1441) jena-text tracing for development

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1441.
-
   Resolution: Done
Fix Version/s: Jena 3.6.0

> jena-text tracing for development
> -
>
> Key: JENA-1441
> URL: https://issues.apache.org/jira/browse/JENA-1441
> Project: Apache Jena
>  Issue Type: New Feature
>  Components: Jena
>Affects Versions: Jena 3.6.0
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Trivial
> Fix For: Jena 3.6.0
>
>
> This issue is for the addition of some log4j tracing and a configuration item 
> associated with development in  jena-text. The tracing is in TextQueryPF and 
> TextIndexLucene to track calls to exec and the subsequent processing as well 
> as the add, update and delete of Lucene documents.
> The _trace-level_ is used so as to not interfere with the current 
> _debug-level_ items that are familiar  to developers.
> The configuration item {{text:cacheQueries false ;}} on 
> {{text:TextIndexLucene}} allows to bypass use of the {{queryCache}} in 
> TextQueryPF.query(...) during development. This configuration item is not for 
> general use and need not be documented further.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1441) jena-text tracing for development

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274796#comment-16274796
 ] 

ASF subversion and git services commented on JENA-1441:
---

Commit e427c417f61051eb4e10ec15ae8b670c5b4b72d1 in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=e427c41 ]

JENA-1441: Merge commit 'refs/pull/319/head' of github.com:apache/jena

This closes #319.


> jena-text tracing for development
> -
>
> Key: JENA-1441
> URL: https://issues.apache.org/jira/browse/JENA-1441
> Project: Apache Jena
>  Issue Type: New Feature
>  Components: Jena
>Affects Versions: Jena 3.6.0
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Trivial
> Fix For: Jena 3.6.0
>
>
> This issue is for the addition of some log4j tracing and a configuration item 
> associated with development in  jena-text. The tracing is in TextQueryPF and 
> TextIndexLucene to track calls to exec and the subsequent processing as well 
> as the add, update and delete of Lucene documents.
> The _trace-level_ is used so as to not interfere with the current 
> _debug-level_ items that are familiar  to developers.
> The configuration item {{text:cacheQueries false ;}} on 
> {{text:TextIndexLucene}} allows to bypass use of the {{queryCache}} in 
> TextQueryPF.query(...) during development. This configuration item is not for 
> general use and need not be documented further.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274799#comment-16274799
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/319


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274797#comment-16274797
 ] 

ASF subversion and git services commented on JENA-1438:
---

Commit 89145b0ddb8b37fe9d5df3fd0aec448fba6ddacb in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=89145b0 ]

JENA-1438: Merge commit 'refs/pull/320/head' of github.com:apache/jena

This closes #320.


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1441) jena-text tracing for development

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274795#comment-16274795
 ] 

ASF subversion and git services commented on JENA-1441:
---

Commit ed67ef7b76fae551793723d906703ce1f6977657 in jena's branch 
refs/heads/master from [~c...@moonvine.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=ed67ef7 ]

JENA-1441 remove unneeded isTraceEnabled() and isDebugEnabled() calls

> jena-text tracing for development
> -
>
> Key: JENA-1441
> URL: https://issues.apache.org/jira/browse/JENA-1441
> Project: Apache Jena
>  Issue Type: New Feature
>  Components: Jena
>Affects Versions: Jena 3.6.0
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Trivial
> Fix For: Jena 3.6.0
>
>
> This issue is for the addition of some log4j tracing and a configuration item 
> associated with development in  jena-text. The tracing is in TextQueryPF and 
> TextIndexLucene to track calls to exec and the subsequent processing as well 
> as the add, update and delete of Lucene documents.
> The _trace-level_ is used so as to not interfere with the current 
> _debug-level_ items that are familiar  to developers.
> The configuration item {{text:cacheQueries false ;}} on 
> {{text:TextIndexLucene}} allows to bypass use of the {{queryCache}} in 
> TextQueryPF.query(...) during development. This configuration item is not for 
> general use and need not be documented further.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274793#comment-16274793
 ] 

ASF subversion and git services commented on JENA-1438:
---

Commit eff7e533c3ee48a7413bd1f5c248f9dfea09ac78 in jena's branch 
refs/heads/master from [~c...@moonvine.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=eff7e53 ]

JENA-1438 rdf:langString args

JENA-1438 allow rdf:langString arguments to text:query

> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274794#comment-16274794
 ] 

ASF subversion and git services commented on JENA-1438:
---

Commit eff7e533c3ee48a7413bd1f5c248f9dfea09ac78 in jena's branch 
refs/heads/master from [~c...@moonvine.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=eff7e53 ]

JENA-1438 rdf:langString args

JENA-1438 allow rdf:langString arguments to text:query

> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jena pull request #319: Jena 1441 tracing

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/319


---

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/320


---

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[Andy Seaborne (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274782#comment-16274782
 ] 

Andy Seaborne commented on JENA-1438:
-

That works for me.

> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (JENA-1441) jena-text tracing for development

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne reassigned JENA-1441:
---

Assignee: Andy Seaborne

> jena-text tracing for development
> -
>
> Key: JENA-1441
> URL: https://issues.apache.org/jira/browse/JENA-1441
> Project: Apache Jena
>  Issue Type: New Feature
>  Components: Jena
>Affects Versions: Jena 3.6.0
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Trivial
>
> This issue is for the addition of some log4j tracing and a configuration item 
> associated with development in  jena-text. The tracing is in TextQueryPF and 
> TextIndexLucene to track calls to exec and the subsequent processing as well 
> as the add, update and delete of Lucene documents.
> The _trace-level_ is used so as to not interfere with the current 
> _debug-level_ items that are familiar  to developers.
> The configuration item {{text:cacheQueries false ;}} on 
> {{text:TextIndexLucene}} allows to bypass use of the {{queryCache}} in 
> TextQueryPF.query(...) during development. This configuration item is not for 
> general use and need not be documented further.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (JENA-1438) rdf:langString argument to text:query silently ignored

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne reassigned JENA-1438:
---

Assignee: Andy Seaborne

> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Assignee: Andy Seaborne
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: CMS diff: Jena Full Text Search

[Chris Tomlinson]

Hi Andy,

The current commit is cumulative. The commit just prior to this one addressed 
all of Osma’s comments - which included my raising JENA-1437 
 and JENA-1438 
. This commit contains my 
changes to reflect those two issues as being fixed along with all my prior 
updates.

If there is a better procedure for making a series of updates to docs under CMS 
I’m happy to learn.

Thank you for your help with this,
Chris


> On Dec 1, 2017, at 6:10 AM, Andy Seaborne  wrote:
> 
> Chris - does this contain the previous one?
> 
> If so, are Osma's comments resolved?
> 
> If it's all good to go, I'll apply it because chnages can continue and are 
> not frozen on a release.  I haven't had the time to check through the 
> proposed changes and I'm not deeply familiar with the text indexing so I'm 
> relying on others to verify them.
> 
>Andy
> 
> On 30/11/17 17:28, Chris Tomlinson wrote:
>> This commit updates the jena-text documentation to be consistent with the 
>> resolved JENA-1437 and JENA-1438 issues.
>> Regards,
>> Chris
>>> On Nov 30, 2017, at 5:00 PM, Chris Tomlinson  wrote:
>>> 
>>> Clone URL (Committers only):
>>> https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Fquery%2Ftext-query.mdtext
>>> 
>>> Chris Tomlinson
>>> 
>>> Index: trunk/content/documentation/query/text-query.mdtext
>>> ===
>>> --- trunk/content/documentation/query/text-query.mdtext (revision 
>>> 1816662)
>>> +++ trunk/content/documentation/query/text-query.mdtext (working copy)
>>> @@ -1,5 +1,7 @@
>>> Title: Jena Full Text Search
>>> 
>>> +Title: Jena Full Text Search
>>> +
>>> This extension to ARQ combines SPARQL and full text search via
>>> [Lucene](https://lucene.apache.org) 6.4.1 or
>>> [ElasticSearch](https://www.elastic.co) 5.2.1 (which is built on
>>> @@ -64,7 +66,21 @@
>>> ## Table of Contents
>>> 
>>> -   [Architecture](#architecture)
>>> +-   [External content](#external-content)
>>> +-   [External applications](#external-applications)
>>> +-   [Document structure](#document-structure)
>>> -   [Query with SPARQL](#query-with-sparql)
>>> +-   [Syntax](#syntax)
>>> +-   [Input arguments](#input-arguments)
>>> +-   [Output arguments](#output-arguments)
>>> +-   [Query strings](#query-strings)
>>> +-   [Simple queries](#simple-queries)
>>> +-   [Queries with language tags](#queries-with-language-tags)
>>> +-   [Queries that retrieve 
>>> literals](#queries-that-retrieve-literals)
>>> +-   [Queries with graphs](#queries-with-graphs)
>>> +-   [Queries across multiple 
>>> `Fields`](#queries-across-multiple-fields)
>>> +-   [Queries with _Boolean Operators_ and _Term 
>>> Modifiers_](#queries-with-boolean-operators-and-term-modifiers)
>>> +-   [Good practice](#good-practice)
>>> -   [Configuration](#configuration)
>>> -   [Text Dataset Assembler](#text-dataset-assembler)
>>> -   [Configuring an analyzer](#configuring-an-analyzer)
>>> @@ -108,6 +124,7 @@
>>> 
>>> The text index uses the native query language of the index:
>>> [Lucene query 
>>> language](http://lucene.apache.org/core/6_4_1/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description)
>>> +(with [restrictions](#input-arguments))
>>> or
>>> [Elasticsearch query 
>>> language](https://www.elastic.co/guide/en/elasticsearch/reference/5.2/query-dsl.html).
>>> 
>>> @@ -134,6 +151,64 @@
>>> By using Elasticsearch, other applications can share the text index with
>>> SPARQL search.
>>> 
>>> +### Document structure
>>> +
>>> +As mentioned above, text indexing of a triple involves associating a Lucene
>>> +document with the triple. How is this done?
>>> +
>>> +Lucene documents are composed of `Field`s. Indexing and searching are 
>>> performed
>>> +over the contents of these `Field`s. For an RDF triple to be indexed in 
>>> Lucene the
>>> +_property_ of the triple must be
>>> +[configured in the entity map of a TextIndex](#entity-map-definition).
>>> +This associates a Lucene analyzer with the _`property`_ which will be used
>>> +for indexing and search. The _`property`_ becomes the _searchable_ Lucene
>>> +`Field` in the resulting document.
>>> +
>>> +A Lucene index includes a _default_ `Field`, which is specified in the 
>>> configuration,
>>> +that is the field to search if not otherwise named in the query. In 
>>> jena-text
>>> +this field is configured via the `text:defaultField` property which is 
>>> then mapped
>>> +to a specific RDF property via `text:predicate` (see [entity 
>>> map](#entity-map-definition)
>>> +below).
>>> +
>>> +There are several additional `Field`s that will be included in the
>>> +document that is passed to the Lucene `IndexWriter` depending on the
>>> 

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274557#comment-16274557
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user xristy commented on the issue:

https://github.com/apache/jena/pull/320
  
Thank you for approving. I'll be traveling this coming week and won't be 
able to add test cases until week after at the earliest. I'd like to fold that 
into a future issue if that works.


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jena issue #320: JENA-1438 rdf:langString args

[xristy]

Github user xristy commented on the issue:

https://github.com/apache/jena/pull/320
  
Thank you for approving. I'll be traveling this coming week and won't be 
able to add test cases until week after at the earliest. I'd like to fold that 
into a future issue if that works.


---

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274554#comment-16274554
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user xristy commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154380929
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -347,11 +352,15 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 log.warn("Text query string is not a literal " + list) ;
 return null ;
 }
-
-if (x.getLiteralDatatype() != null && 
!x.getLiteralDatatype().equals(XSDDatatype.XSDstring)) {
--- End diff --

Thank you for the tips. I tried to avoid changing code that was present. I 
plan to raise another issue or two in jena-text and will be glad to visit some 
of these cases to try and use RDF functionality rather than bare Java 
functionality. It certainly will make the code clearer.


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

[xristy]

Github user xristy commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154380929
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -347,11 +352,15 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 log.warn("Text query string is not a literal " + list) ;
 return null ;
 }
-
-if (x.getLiteralDatatype() != null && 
!x.getLiteralDatatype().equals(XSDDatatype.XSDstring)) {
--- End diff --

Thank you for the tips. I tried to avoid changing code that was present. I 
plan to raise another issue or two in jena-text and will be glad to visit some 
of these cases to try and use RDF functionality rather than bare Java 
functionality. It certainly will make the code clearer.


---

Re: CMS diff: Jena Full Text Search

[Andy Seaborne]

Chris - does this contain the previous one?

If so, are Osma's comments resolved?

If it's all good to go, I'll apply it because chnages can continue and 
are not frozen on a release.  I haven't had the time to check through 
the proposed changes and I'm not deeply familiar with the text indexing 
so I'm relying on others to verify them.


Andy

On 30/11/17 17:28, Chris Tomlinson wrote:

This commit updates the jena-text documentation to be consistent with the 
resolved JENA-1437 and JENA-1438 issues.

Regards,
Chris


On Nov 30, 2017, at 5:00 PM, Chris Tomlinson  wrote:

Clone URL (Committers only):
https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Fquery%2Ftext-query.mdtext

Chris Tomlinson

Index: trunk/content/documentation/query/text-query.mdtext
===
--- trunk/content/documentation/query/text-query.mdtext (revision 1816662)
+++ trunk/content/documentation/query/text-query.mdtext (working copy)
@@ -1,5 +1,7 @@
Title: Jena Full Text Search

+Title: Jena Full Text Search
+
This extension to ARQ combines SPARQL and full text search via
[Lucene](https://lucene.apache.org) 6.4.1 or
[ElasticSearch](https://www.elastic.co) 5.2.1 (which is built on
@@ -64,7 +66,21 @@
## Table of Contents

-   [Architecture](#architecture)
+-   [External content](#external-content)
+-   [External applications](#external-applications)
+-   [Document structure](#document-structure)
-   [Query with SPARQL](#query-with-sparql)
+-   [Syntax](#syntax)
+-   [Input arguments](#input-arguments)
+-   [Output arguments](#output-arguments)
+-   [Query strings](#query-strings)
+-   [Simple queries](#simple-queries)
+-   [Queries with language tags](#queries-with-language-tags)
+-   [Queries that retrieve literals](#queries-that-retrieve-literals)
+-   [Queries with graphs](#queries-with-graphs)
+-   [Queries across multiple `Fields`](#queries-across-multiple-fields)
+-   [Queries with _Boolean Operators_ and _Term 
Modifiers_](#queries-with-boolean-operators-and-term-modifiers)
+-   [Good practice](#good-practice)
-   [Configuration](#configuration)
 -   [Text Dataset Assembler](#text-dataset-assembler)
 -   [Configuring an analyzer](#configuring-an-analyzer)
@@ -108,6 +124,7 @@

The text index uses the native query language of the index:
[Lucene query 
language](http://lucene.apache.org/core/6_4_1/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description)
+(with [restrictions](#input-arguments))
or
[Elasticsearch query 
language](https://www.elastic.co/guide/en/elasticsearch/reference/5.2/query-dsl.html).

@@ -134,6 +151,64 @@
By using Elasticsearch, other applications can share the text index with
SPARQL search.

+### Document structure
+
+As mentioned above, text indexing of a triple involves associating a Lucene
+document with the triple. How is this done?
+
+Lucene documents are composed of `Field`s. Indexing and searching are performed
+over the contents of these `Field`s. For an RDF triple to be indexed in Lucene 
the
+_property_ of the triple must be
+[configured in the entity map of a TextIndex](#entity-map-definition).
+This associates a Lucene analyzer with the _`property`_ which will be used
+for indexing and search. The _`property`_ becomes the _searchable_ Lucene
+`Field` in the resulting document.
+
+A Lucene index includes a _default_ `Field`, which is specified in the 
configuration,
+that is the field to search if not otherwise named in the query. In jena-text
+this field is configured via the `text:defaultField` property which is then 
mapped
+to a specific RDF property via `text:predicate` (see [entity 
map](#entity-map-definition)
+below).
+
+There are several additional `Field`s that will be included in the
+document that is passed to the Lucene `IndexWriter` depending on the
+configuration options that are used. These additional fields are used to
+manage the interface between Jena and Lucene and are not generally
+searchable per se.
+
+The most important of these additional `Field`s is the `text:entityField`.
+This configuration property defines the name of the `Field` that will contain
+the _URI_ or _blank node id_ of the _subject_ of the triple being indexed. 
This property does
+not have a default and must be specified for most uses of `jena-text`. This
+`Field` is often given the name, `uri`, in examples. It is via this `Field`
+that `?s` is bound in a typical use such as:
+
+select ?s
+where {
+?s text:query "some text"
+}
+
+Other `Field`s that may be configured: `text:uidField`, `text:graphField`,
+and so on are discussed below.
+
+Given the triple:
+
+ex:SomeOne skos:prefLabel "zorn protégé a prés"@fr ;
+
+The following is an abbreviated illustration a Lucene document that Jena will 
create and
+request Lucene to index:

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274293#comment-16274293
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154325977
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -309,14 +310,18 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 return null ;
 }
 
+String lang = o.getLiteralLanguage();
 RDFDatatype dt = o.getLiteralDatatype() ;
-if (dt != null && dt != XSDDatatype.XSDstring) {
-log.warn("Object to text query is not a string") ;
-return null ;
+if (lang.isEmpty()) {
--- End diff --

Comment: Testing for datatype `RDF.dtLangString` is also possible.


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274294#comment-16274294
 ] 

ASF GitHub Bot commented on JENA-1438:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154326766
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -347,11 +352,15 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 log.warn("Text query string is not a literal " + list) ;
 return null ;
 }
-
-if (x.getLiteralDatatype() != null && 
!x.getLiteralDatatype().equals(XSDDatatype.XSDstring)) {
--- End diff --

Comment:
In RDF 1.1, the data type of a literal is never null.

There are functions like `Util.isLangString` (in RDF 1.1: rdf:langString) 
and `Util.isSimpleString` (in RDF 1.1, xsd:string) that mask the RDF1.0/RDF 1.1 
mode setting (not that Jena claims to support RDF 1.0 any more).


> rdf:langString argument to text:query silently ignored
> --
>
> Key: JENA-1438
> URL: https://issues.apache.org/jira/browse/JENA-1438
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.5.0
> Environment: N/A
>Reporter: Code Ferret
>Priority: Minor
>
> Queries of the form:
> {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
> {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
> {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

[afs]

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154326766
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -347,11 +352,15 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 log.warn("Text query string is not a literal " + list) ;
 return null ;
 }
-
-if (x.getLiteralDatatype() != null && 
!x.getLiteralDatatype().equals(XSDDatatype.XSDstring)) {
--- End diff --

Comment:
In RDF 1.1, the data type of a literal is never null.

There are functions like `Util.isLangString` (in RDF 1.1: rdf:langString) 
and `Util.isSimpleString` (in RDF 1.1, xsd:string) that mask the RDF1.0/RDF 1.1 
mode setting (not that Jena claims to support RDF 1.0 any more).


---

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

[afs]

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/320#discussion_r154325977
  
--- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
@@ -309,14 +310,18 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
 return null ;
 }
 
+String lang = o.getLiteralLanguage();
 RDFDatatype dt = o.getLiteralDatatype() ;
-if (dt != null && dt != XSDDatatype.XSDstring) {
-log.warn("Object to text query is not a string") ;
-return null ;
+if (lang.isEmpty()) {
--- End diff --

Comment: Testing for datatype `RDF.dtLangString` is also possible.


---