[jira] [Commented] (JENA-1525) Add to for each jar module.

[Christopher Johnson (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438865#comment-16438865
 ] 

Christopher Johnson commented on JENA-1525:
---

PR: [https://github.com/apache/jena/pull/400]

https://github.com/apache/jena/pull/400/commits/188e00e3be792e71e4839d5db269fbde71468c4c

> Add  to  for each jar module.
> -
>
> Key: JENA-1525
> URL: https://issues.apache.org/jira/browse/JENA-1525
> Project: Apache Jena
>  Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438860#comment-16438860
 ] 

ASF GitHub Bot commented on JENA-1524:
--

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/401

 [JENA-1524] org.apache.jena.system is split by org.apache.jena.arq and 
org.apache.jena.core

per @afs 

> this renames of "jena-core:org.apache.jena.system" as 
"jena-core:org.apache.jena.sys", and puts an adapter class `JenaInit` in 
"jena-arq:org.apache.jena.system" that has two functions to call the real init 
and shutdown. 
> 
> `JenaInit` will be deprecated prior to removal quite quickly (in a very 
few release cycles).
> 
> This way the impact is lessened: `org.apache.jena.system.Txn` is not 
repackaged. The adapter class approach does not work for calls from jena-core 
to jena-arq without reflection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena rename-core-system

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #401


commit d82328d905b0f8ae40f60ffe800728824975
Author: Christopher Hanna Johnson 
Date:   2018-04-15T21:24:12Z

 [JENA-1524] org.apache.jena.system is split by org.apache.jena.arq and 
org.apache.jena.core




> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #401: [JENA-1524] org.apache.jena.system is split by org.a...

[christopher-johnson]

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/401

 [JENA-1524] org.apache.jena.system is split by org.apache.jena.arq and 
org.apache.jena.core

per @afs 

> this renames of "jena-core:org.apache.jena.system" as 
"jena-core:org.apache.jena.sys", and puts an adapter class `JenaInit` in 
"jena-arq:org.apache.jena.system" that has two functions to call the real init 
and shutdown. 
> 
> `JenaInit` will be deprecated prior to removal quite quickly (in a very 
few release cycles).
> 
> This way the impact is lessened: `org.apache.jena.system.Txn` is not 
repackaged. The adapter class approach does not work for calls from jena-core 
to jena-arq without reflection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena rename-core-system

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #401


commit d82328d905b0f8ae40f60ffe800728824975
Author: Christopher Hanna Johnson 
Date:   2018-04-15T21:24:12Z

 [JENA-1524] org.apache.jena.system is split by org.apache.jena.arq and 
org.apache.jena.core




---

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438850#comment-16438850
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user christopher-johnson closed the pull request at:

https://github.com/apache/jena/pull/399


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438849#comment-16438849
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user christopher-johnson commented on the issue:

https://github.com/apache/jena/pull/399
  
it may be clearer to close this PR and submit a new one with "system" to 
"sys" changes to `org.apache.jena.core` rather than try to merge with this one 
since there is no overlap.   


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #399: [JENA-1524] renames jena-arq org.apache.jena.system ...

[christopher-johnson]

Github user christopher-johnson closed the pull request at:

https://github.com/apache/jena/pull/399


---

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438801#comment-16438801
 ] 

ASF GitHub Bot commented on JENA-1524:
--

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/400

[JENA-1524] Add  to  for each jar 
module

See comments here: 
https://github.com/apache/jena/pull/399

It is possible that there are more artifacts that might want this.

FYI: This does not include the following top level projects:
apache-jena, apache-jena-libs, apache-jena-osgi, jena-elephas, 
jena-examples, jena-extras, jena-fuseki1, jena-fuseki, jena-integration-tests, 
jena-iri, jena-jdbc, jena-maven-tools, jena-permissions, jena-sdb, 
jena-shaded-guava


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena automatic-modules

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #400


commit 669f75891d237f441ceab93f5083076c0a10a468
Author: Christopher Hanna Johnson 
Date:   2018-04-15T18:32:11Z

[JENA-1524] Add  to  for each jar 
module




> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #400: [JENA-1524] Add to

[christopher-johnson]

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/400

[JENA-1524] Add  to  for each jar 
module

See comments here: 
https://github.com/apache/jena/pull/399

It is possible that there are more artifacts that might want this.

FYI: This does not include the following top level projects:
apache-jena, apache-jena-libs, apache-jena-osgi, jena-elephas, 
jena-examples, jena-extras, jena-fuseki1, jena-fuseki, jena-integration-tests, 
jena-iri, jena-jdbc, jena-maven-tools, jena-permissions, jena-sdb, 
jena-shaded-guava


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena automatic-modules

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #400


commit 669f75891d237f441ceab93f5083076c0a10a468
Author: Christopher Hanna Johnson 
Date:   2018-04-15T18:32:11Z

[JENA-1524] Add  to  for each jar 
module




---

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438760#comment-16438760
 ] 

ASF GitHub Bot commented on JENA-1524:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/399
  
Hi there - could you please split out the automatic module name name part 
then we can get that into the codebase soon and separately from the API impact 
of the rest?

I've create JENA-1525 for the automatic module name.

For the package split:

The problematic classes are `JenaInit` (functions init() and to a lesser 
extent shutdown()) and the interface JenaSubsystemLifecycle in jena-core, and 
`Txn` in jena-arq.  The rest of the jena-core classes are only used by 
extensions of Jena and by other jena components, not by applications. There is 
a chance 3rd party use but it is going to be very uncommon as far as I know. 
`Serializable` is jena-internal for wiring up RIOT (in jena-arq) into the code 
engine.  

Of the classes, `Txn` is more important for applications, and its use 
encouraged in general user code. `JenaInit` normally isn't called by 
application code but can be to be sure or to force initialization before 
calling into internal code very early in the application startup, before proper 
Jena code.

I think it is less disruptive to do the split as a rename of 
"jena-core:org.apache.jena.system" as "jena-core:org.apache.jena.sys", then put 
an adapter class `JenaInit` in "jena-core:org.apache.jena.system"  that has two 
functions to call the real `init` and `shutdown`. We immediately deprecate 
"jena-arq:JenaInit" prior to removal quite quickly (in a very few release 
cycles).

This way the impact is lessened: `Txn` is not repackaged. The adapter class 
approach does not work for calls from jena-core to jena-arq without reflection.


> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #399: [JENA-1524] renames jena-arq org.apache.jena.system to org....

[afs]

Github user afs commented on the issue:

https://github.com/apache/jena/pull/399
  
Hi there - could you please split out the automatic module name name part 
then we can get that into the codebase soon and separately from the API impact 
of the rest?

I've create JENA-1525 for the automatic module name.

For the package split:

The problematic classes are `JenaInit` (functions init() and to a lesser 
extent shutdown()) and the interface JenaSubsystemLifecycle in jena-core, and 
`Txn` in jena-arq.  The rest of the jena-core classes are only used by 
extensions of Jena and by other jena components, not by applications. There is 
a chance 3rd party use but it is going to be very uncommon as far as I know. 
`Serializable` is jena-internal for wiring up RIOT (in jena-arq) into the code 
engine.  

Of the classes, `Txn` is more important for applications, and its use 
encouraged in general user code. `JenaInit` normally isn't called by 
application code but can be to be sure or to force initialization before 
calling into internal code very early in the application startup, before proper 
Jena code.

I think it is less disruptive to do the split as a rename of 
"jena-core:org.apache.jena.system" as "jena-core:org.apache.jena.sys", then put 
an adapter class `JenaInit` in "jena-core:org.apache.jena.system"  that has two 
functions to call the real `init` and `shutdown`. We immediately deprecate 
"jena-arq:JenaInit" prior to removal quite quickly (in a very few release 
cycles).

This way the impact is lessened: `Txn` is not repackaged. The adapter class 
approach does not work for calls from jena-core to jena-arq without reflection.


---

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438743#comment-16438743
 ] 

ASF GitHub Bot commented on JENA-1524:
--

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/399

[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys

The changes are superficial, but will break existing implementations.  The 
thinking pattern here is shallow, and there may be better ways to restructure 
the `org.apache.jena.system` package (like merging the split in a new project). 
  

Since this PR is JPMS related, I also added the Automatic-Module-Name to 
`` for most of the projects.  This ModuleFinder mechanism is 
documented 
[here](https://docs.oracle.com/javase/10/docs/api/java/lang/module/ModuleFinder.html#of(java.nio.file.Path...)).
  These names are consistent with semantics described in [this 
specification](https://docs.oracle.com/javase/specs/jls/se10/html/jls-6.html#jls-6.5)
 and follow the conventions of other Apache projects like 
`org.apache.commons.io`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena split-system

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #399


commit ee9fd831f588d02b500a78811b9a78c418cfc89e
Author: Christopher Hanna Johnson 
Date:   2018-04-15T13:35:51Z

[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys
adds Automatic-Module-Name to manifestEntries




> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #399: [JENA-1524] renames jena-arq org.apache.jena.system ...

[christopher-johnson]

GitHub user christopher-johnson opened a pull request:

https://github.com/apache/jena/pull/399

[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys

The changes are superficial, but will break existing implementations.  The 
thinking pattern here is shallow, and there may be better ways to restructure 
the `org.apache.jena.system` package (like merging the split in a new project). 
  

Since this PR is JPMS related, I also added the Automatic-Module-Name to 
`` for most of the projects.  This ModuleFinder mechanism is 
documented 
[here](https://docs.oracle.com/javase/10/docs/api/java/lang/module/ModuleFinder.html#of(java.nio.file.Path...)).
  These names are consistent with semantics described in [this 
specification](https://docs.oracle.com/javase/specs/jls/se10/html/jls-6.html#jls-6.5)
 and follow the conventions of other Apache projects like 
`org.apache.commons.io`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/christopher-johnson/jena split-system

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #399


commit ee9fd831f588d02b500a78811b9a78c418cfc89e
Author: Christopher Hanna Johnson 
Date:   2018-04-15T13:35:51Z

[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys
adds Automatic-Module-Name to manifestEntries




---

[jira] [Commented] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[A. Soroka (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438681#comment-16438681
 ] 

A. Soroka commented on JENA-1524:
-

Thanks for the report, [~christopher-johnson].

Both packages contain public API. This would be a breaking change.

Do you have a PR for discussion?

 

> org.apache.jena.system is split by org.apache.jena.arq and 
> org.apache.jena.core
> ---
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Jena
>Affects Versions: Jena 3.7.0
>Reporter: Christopher Johnson
>Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and 
> org.apache.jena.core since org.apache.jena.system can be read from both.  
> This cannot be resolved with --patch-module since arq and core provide 
> different implementations.  Suggestion is to make a distinction by renaming 
> system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1488) SelectiveFoldingFilter for jena-text

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438679#comment-16438679
 ] 

ASF GitHub Bot commented on JENA-1488:
--

Github user kinow commented on the issue:

https://github.com/apache/jena/pull/395
  
Thanks for testing it @osma ! If there are no objections until next weekend 
I will merge it. With 3.7.0 out, we probably have some more time for testing, 
and then update the documentation. In the meantime, will jump back to JENA-632 
:D


> SelectiveFoldingFilter for jena-text
> 
>
> Key: JENA-1488
> URL: https://issues.apache.org/jira/browse/JENA-1488
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Text
>Affects Versions: Jena 3.6.0
>Reporter: Osma Suominen
>Assignee: Bruno P. Kinoshita
>Priority: Major
>
> Currently there's some support for accent folding in jena-text, because 
> Lucene provides an ASCIIFoldingFilter. When this filter is enabled, a search 
> for "deja vu" will match the literal "déjà vu" in the data.
> But we can't use it here at the National Library of Finland (for Finto.fi / 
> Skosmos), because it folds too much! In the Finnish alphabet, in addition to 
> the Latin a-z (which are in ASCII) we use the letters åäö and these should 
> not be folded to ASCII. So we need a Lucene analyzer that can be configured 
> with an exclude list, something like 
>  
> new SelectiveFoldingFilter(String excludeChars) 
>  
> and that can be also be configured via the Jena assembler just like other 
> analyzers supported by jena-text. 
>  
> This was also briefly discussed on the skosmos-users mailing list: 
> [https://groups.google.com/d/msg/skosmos-users/x3zR_uRBQT0/Q90-O_iDAQAJ] 
> Apparently Norwegians have the same problem...
> I've discussed this with [~kinow] and he has some initial code to implement 
> this feature, so I think we can turn this into a PR fairly soon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

[kinow]

Github user kinow commented on the issue:

https://github.com/apache/jena/pull/395
  
Thanks for testing it @osma ! If there are no objections until next weekend 
I will merge it. With 3.7.0 out, we probably have some more time for testing, 
and then update the documentation. In the meantime, will jump back to JENA-632 
:D


---

[jira] [Created] (JENA-1524) org.apache.jena.system is split by org.apache.jena.arq and org.apache.jena.core

[Christopher Johnson (JIRA)]

Christopher Johnson created JENA-1524:
-

 Summary: org.apache.jena.system is split by org.apache.jena.arq 
and org.apache.jena.core
 Key: JENA-1524
 URL: https://issues.apache.org/jira/browse/JENA-1524
 Project: Apache Jena
  Issue Type: Bug
  Components: Jena
Affects Versions: Jena 3.7.0
Reporter: Christopher Johnson


a JPMS module cannot require both org.apache.jena.arq and org.apache.jena.core 
since org.apache.jena.system can be read from both.  This cannot be resolved 
with --patch-module since arq and core provide different implementations.  
Suggestion is to make a distinction by renaming system to sys in either one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)