CMS diff: Command-line and other tools for Jena developers
Clone URL (Committers only): https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Ftools%2Findex.mdtext Markus Neumann Index: trunk/content/documentation/tools/index.mdtext === --- trunk/content/documentation/tools/index.mdtext (revision 1841038) +++ trunk/content/documentation/tools/index.mdtext (working copy) @@ -41,7 +41,7 @@ ### Common Issues with Running the Tools -If you receive errors stating that a class is not found then it is most likely that `JENAROOT` is not set correctly. As a quick sanity check you can try the following to see if it is set appropriately: +If you receive errors stating that a class is not found then it is most likely that `JENA_HOME` is not set correctly. As a quick sanity check you can try the following to see if it is set appropriately: **On Linux / Mac** @@ -51,9 +51,9 @@ - `cd %JENA_HOME%` -If this command fails then `JENAROOT` is not correctly set, please ensure you have set it correctly and try again. +If this command fails then `JENA_HOME` is not correctly set, please ensure you have set it correctly and try again. -Windows users may experience problems if trying to run the tools when their `JENAROOT` path contains spaces in it, there are two workarounds for this: +Windows users may experience problems if trying to run the tools when their `JENA_HOME` path contains spaces in it, there are two workarounds for this: 1. Move your Jena install to a path without spaces 1. Grab the latest scripts from [master][1] where they have been fixed to safely handle this. Future releases will include this fix and resolve this issue
Possible TAVERNA update in the NAR Web Server Issue
Forwarded with permission: Forwarded Message Subject:Possible TAVERNA update in the NAR Web Server Issue Date: Sat, 6 Oct 2018 18:12:24 -0400 From: Gary Benson To: andy.seabo...@topquadrant.com, narwbsrv , Dominik Seelow Dear Dr. Seaborne, An article about the TAVERNA software was published in the Web Server issue of Nucleic Acids Research in 2013. [...] Because the software receives heavy usage, We're writing to ask if you'd be interested in submitting an update for the 2019 Web Server issue published in July. The deadline for manuscript submission is January 31, 2019. If you're interested, your manuscript would undergo standard review and standard publication charges would apply. Because this would be an update, the manuscript would best include a general introduction to your online tools, and a description of major changes since the last publication. If required, we can give you more space than the standard 4-5 pages, however, be aware that the publisher charges an extra £100 per page over 10 pages. For planning purposes, we would appreciate a response one way or the other within the next week or so. Sincerely, Gary Benson and Dominik Seelow Executive Editors Nucleic Acids Research Web Server Issue Boston, MA, USA and Berlin, Germany
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641101#comment-16641101
]
ASF GitHub Bot commented on JENA-1515:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r223217292
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Minor: different style. There is more of this later.
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jena pull request #479: JENA-1515 - Ensures values added to subQuery are not...
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r223217292
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Minor: different style. There is more of this later.
---
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641098#comment-16641098 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217155 --- Diff: jena-maven-tools/pom.xml --- @@ -20,7 +20,6 @@ 4.0.0 jena-maven-tools maven-plugin - 3.7.0-SNAPSHOT --- End diff -- There have been some problems in the past which is why the top POM has this module commented out. ``` ``` Does jena-maven-tools now work in the build? It would be great if it did. > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #480: JENA-1602 - added mechanism to add inserts or delete...
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217083 --- Diff: jena-extras/jena-querybuilder/.gitignore --- @@ -0,0 +1 @@ +/.project_old --- End diff -- This seem to be some issue, not for the codebase. ---
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641100#comment-16641100 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217083 --- Diff: jena-extras/jena-querybuilder/.gitignore --- @@ -0,0 +1 @@ +/.project_old --- End diff -- This seem to be some issue, not for the codebase. > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #480: JENA-1602 - added mechanism to add inserts or delete...
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217180 --- Diff: jena-maven-tools/pom.xml --- @@ -30,7 +29,7 @@ org.apache.jena jena -3.7.0-SNAPSHOT +3.9.0-SNAPSHOT --- End diff -- Any reason not to have 3.10.0-SNAPSHOT? ---
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641099#comment-16641099 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217180 --- Diff: jena-maven-tools/pom.xml --- @@ -30,7 +29,7 @@ org.apache.jena jena -3.7.0-SNAPSHOT +3.9.0-SNAPSHOT --- End diff -- Any reason not to have 3.10.0-SNAPSHOT? > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #480: JENA-1602 - added mechanism to add inserts or delete...
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217155 --- Diff: jena-maven-tools/pom.xml --- @@ -20,7 +20,6 @@ 4.0.0 jena-maven-tools maven-plugin - 3.7.0-SNAPSHOT --- End diff -- There have been some problems in the past which is why the top POM has this module commented out. ``` ``` Does jena-maven-tools now work in the build? It would be great if it did. ---
[jira] [Updated] (JENA-1613) When registering an incompatible Datatype a warning should be logged
[ https://issues.apache.org/jira/browse/JENA-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated JENA-1613: Description: Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and there is an existing datatype registered for the type.getJavaClass() was: Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and there is an existing datatype registered for the type.getJavaClass() ; and > When registering an incompatible Datatype a warning should be logged > > > Key: JENA-1613 > URL: https://issues.apache.org/jira/browse/JENA-1613 > Project: Apache Jena > Issue Type: Improvement > Components: Core >Affects Versions: Jena 3.8.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Classes that extend AdhocDatatype (or Basedatatype) and want to allow > multiple instances of the datatype class to be considered equal must do the > following: > # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel > litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel > litLabel2). > # Override Object.equals(Object obj) > # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( > LiteralLabel lit ) > There should be a warning in the log if TypeMapper.register(RDFDatatype type > ) is called and there is an existing datatype registered for the > type.getJavaClass() > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1613) When registering an incompatible Datatype a warning should be logged
[ https://issues.apache.org/jira/browse/JENA-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated JENA-1613: Description: Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and there is an existing datatype registered for the type.getJavaClass() ; and was: Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and: # There is an existing datatype registered for the type.getJavaClass() ; and # There registered type.isEquals( type.registeredType ) is false. > When registering an incompatible Datatype a warning should be logged > > > Key: JENA-1613 > URL: https://issues.apache.org/jira/browse/JENA-1613 > Project: Apache Jena > Issue Type: Improvement > Components: Core >Affects Versions: Jena 3.8.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Classes that extend AdhocDatatype (or Basedatatype) and want to allow > multiple instances of the datatype class to be considered equal must do the > following: > # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel > litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel > litLabel2). > # Override Object.equals(Object obj) > # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( > LiteralLabel lit ) > There should be a warning in the log if TypeMapper.register(RDFDatatype type > ) is called and there is an existing datatype registered for the > type.getJavaClass() ; and > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Deleted] (JENA-1614) When registering an incompatible Datatype a warning should be logged
[ https://issues.apache.org/jira/browse/JENA-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren deleted JENA-1614: > When registering an incompatible Datatype a warning should be logged > > > Key: JENA-1614 > URL: https://issues.apache.org/jira/browse/JENA-1614 > Project: Apache Jena > Issue Type: Improvement >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Classes that extend AdhocDatatype (or Basedatatype) and want to allow > multiple instances of the datatype class to be considered equal must do the > following: > # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel > litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel > litLabel2). > # Override Object.equals(Object obj) > # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( > LiteralLabel lit ) > There should be a warning in the log if TypeMapper.register(RDFDatatype type > ) is called and: > # There is an existing datatype registered for the type.getJavaClass() ; and > # There registered type.isEquals( type.registeredType ) is false. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (JENA-1613) When registering an incompatible Datatype a warning should be logged
[ https://issues.apache.org/jira/browse/JENA-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren reassigned JENA-1613: --- Assignee: Claude Warren > When registering an incompatible Datatype a warning should be logged > > > Key: JENA-1613 > URL: https://issues.apache.org/jira/browse/JENA-1613 > Project: Apache Jena > Issue Type: Improvement > Components: Core >Affects Versions: Jena 3.8.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Classes that extend AdhocDatatype (or Basedatatype) and want to allow > multiple instances of the datatype class to be considered equal must do the > following: > # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel > litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel > litLabel2). > # Override Object.equals(Object obj) > # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( > LiteralLabel lit ) > There should be a warning in the log if TypeMapper.register(RDFDatatype type > ) is called and: > # There is an existing datatype registered for the type.getJavaClass() ; and > # There registered type.isEquals( type.registeredType ) is false. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (JENA-1614) When registering an incompatible Datatype a warning should be logged
Claude Warren created JENA-1614: --- Summary: When registering an incompatible Datatype a warning should be logged Key: JENA-1614 URL: https://issues.apache.org/jira/browse/JENA-1614 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.8.0 Reporter: Claude Warren Assignee: Claude Warren Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and: # There is an existing datatype registered for the type.getJavaClass() ; and # There registered type.isEquals( type.registeredType ) is false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (JENA-1613) When registering an incompatible Datatype a warning should be logged
Claude Warren created JENA-1613: --- Summary: When registering an incompatible Datatype a warning should be logged Key: JENA-1613 URL: https://issues.apache.org/jira/browse/JENA-1613 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.8.0 Reporter: Claude Warren Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: # Override BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). # Override Object.equals(Object obj) # Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) There should be a warning in the log if TypeMapper.register(RDFDatatype type ) is called and: # There is an existing datatype registered for the type.getJavaClass() ; and # There registered type.isEquals( type.registeredType ) is false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641073#comment-16641073 ] ASF GitHub Bot commented on JENA-1602: -- GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/480 JENA-1602 - added mechanism to add inserts or deletes based on model or triple collections Fix for JENA-1602 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1602-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit ee62b6540f795ddeb7ef7ee2eed2f2ac0d223d5b Author: Claude Warren Date: 2018-09-30T10:01:22Z closes JENA=1602 commit 311843dd22bc5ea2b11d10ae9011645f797c504d Author: Claude Warren Date: 2018-10-07T12:10:53Z Merge branch 'master' into 1602-fix commit 27691564775e52da291e3ae18c8b5989415ea9b8 Author: Claude Warren Date: 2018-10-07T14:09:56Z added license and removed dead code > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #480: JENA-1602 - added mechanism to add inserts or delete...
GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/480 JENA-1602 - added mechanism to add inserts or deletes based on model or triple collections Fix for JENA-1602 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1602-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit ee62b6540f795ddeb7ef7ee2eed2f2ac0d223d5b Author: Claude Warren Date: 2018-09-30T10:01:22Z closes JENA=1602 commit 311843dd22bc5ea2b11d10ae9011645f797c504d Author: Claude Warren Date: 2018-10-07T12:10:53Z Merge branch 'master' into 1602-fix commit 27691564775e52da291e3ae18c8b5989415ea9b8 Author: Claude Warren Date: 2018-10-07T14:09:56Z added license and removed dead code ---
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641040#comment-16641040 ] ASF GitHub Bot commented on JENA-1515: -- GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/479 1515/fix closes JENA-1515 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1515/fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 439f6ba0d690923cdcbb86c0780f6f8d0f5d6cd7 Author: Claude Warren Date: 2018-09-30T11:18:08Z added subquery values test commit a499b58a76704125f63a8407ffb2795b03e4d213 Author: Claude Warren Date: 2018-09-30T11:53:31Z fixes JENA-1515 commit e736bdfb1851a1069bd2dbd2d14c6eae1e259a97 Author: Claude Warren Date: 2018-10-07T11:24:17Z Merge branch 'master' into 1515/fix > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #479: 1515/fix
GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/479 1515/fix closes JENA-1515 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1515/fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 439f6ba0d690923cdcbb86c0780f6f8d0f5d6cd7 Author: Claude Warren Date: 2018-09-30T11:18:08Z added subquery values test commit a499b58a76704125f63a8407ffb2795b03e4d213 Author: Claude Warren Date: 2018-09-30T11:53:31Z fixes JENA-1515 commit e736bdfb1851a1069bd2dbd2d14c6eae1e259a97 Author: Claude Warren Date: 2018-10-07T11:24:17Z Merge branch 'master' into 1515/fix ---
Re: of isomorphism and AdhocDatatypes
On further investigation I think I see what Andy was talking about. Classes that extend AdhocDatatype (or Basedatatype) and want to allow multiple instances of the datatype class to be considered equal must do the following: 1. overide BaseDatatype.isEqual(LiteralLabel litLabel1, LiteralLabel litLabel2) to call isEqualByTerm(LiteralLabel litLabel1, LiteralLabel litLabel2). -- this is the part I misunderstood in Andy's earlier post. 2. Override Object.equals(Object obj) 3. Override Object.hashCode(), potentially calling BaseDatatype.getHashCode( LiteralLabel lit ) I had missed the first step. I think there should be a warning in the log if TypeMapper.register( RDFDatatype type ) is called and: 1. there is an existing datatype registered for the type.getJavaClass() and 2. there registered type.isEquals( type.registeredType ) is false. I'll open an enhancement for this change. Claude On Mon, Oct 1, 2018 at 12:01 PM Andy Seaborne wrote: > > > > On 01/10/18 07:52, Claude Warren wrote: > > I resolved it by following the Don't Do That pattern and not loading the > > datatype twice. > > > > Event with hashCode and equals on the datatype it does not match as the > > datatype equality is checked with ==. I will find and document the issue > > here. > > Good - my cursory look at the code showed only use of Objects.equals. > > > But I am leaning toward the type registry issuing a warning when a > > datatype is registered a second time. > > As long as parsing unknown datatypes isn't impacted. > > Andy > > > > > Claude > > > > On Fri, Sep 28, 2018 at 9:45 AM Andy Seaborne wrote: > > > >> Claude - > >> > >> Did you resolve this? > >> > >> In experimentation, I found a subtype of AdhocDatatype had to implement > >> .hashCode and .equals. > >> > >> Andy > >> > > > > -- I like: Like Like - The likeliest place on the web LinkedIn: http://www.linkedin.com/in/claudewarren
