[GitHub] [jena] seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-47270 Sorted the 501 thing... will look at the tests tomorrow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jena] rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text URL: https://github.com/apache/jena/pull/536#issuecomment-479984285 @DamienFontaine Thanks, doc changes added and visible on the staging site - http://jena.staging.apache.org/documentation/query/text-query.html We typically only publish the site to production when a release happens so this won't show up in the public site until the next release happens This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JENA-1690) Add support SurroundQueryParser to jena-text
[ https://issues.apache.org/jira/browse/JENA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810073#comment-16810073 ] ASF subversion and git services commented on JENA-1690: --- Commit 1856962 from Rob Vesse in branch 'site/trunk' [ https://svn.apache.org/r1856962 ] Docs for JENA-1690 > Add support SurroundQueryParser to jena-text > > > Key: JENA-1690 > URL: https://issues.apache.org/jira/browse/JENA-1690 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Rob Vesse >Priority: Major > Fix For: Jena 3.11.0 > > > See [pull request 536|https://github.com/apache/jena/pull/536]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [jena] seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-479940586 :+1: thanks @afs I've removed the new extras module. I made the Prometheus provider the default for now - I think we may as well seeing as Prometheus stuff is included in `jena-fuseki-core` now. Does that make sense? I'll have a look at the 501 error thing later - or maybe can delete the `SimpleMetricsProvider` given that it can't be scraped via http (not sure when anyone would use it for real t.b.h) ... and the testing. Hope to get to it later or tomorrow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jena] afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint
afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-479937698 @claudew - yes, sorry. @Claudenw - would you be able to help out with the L issues here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jena] afs edited a comment on issue #534: [WIP] Proof of concept for prometheus endpoint
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479922355
Licensing
@claudenw - would you be able to help out with the L issues here?
The LICENSE and NOTICE for the combined binary artifacts (3 of them) wil
need to include BSD-related text.
At the moment, they get autogenerated but we need to put specific text in.
jena-fuseki-server
jena-fuseki-war
jena-fuseki-fulljar
See jena-fuseki-webapp/src/resources/META-INF/ which puts in LICENSE and
NOTICE into a jar but I think we need to do it in the shading step for external
resources like BSD-licnesed binaries.
Packaging
It is easier to add maven modules later than retire them.
Prometheus is sufficiently common I think including in Fuseki core for now
is easier for users.
Proposal: moving it to
jena-fuseki-core::org.apache.jena.fuseki.metrics.prometheus (and the
ServiceLoader file similarly)
and now have the jena-prometheus (which is out of sequence in the build
currently).
Testing
If `jena-prometheus` is not available I get a `500 server error` and a
stacktrace, not 501 (running Fuseki main+Prometheus)
```
[12:47:13] INFO Server :: Start Fuseki (port=3030)
[12:47:18] WARN HttpChannel :: /$/metrics/ds
org.apache.jena.fuseki.servlets.ActionErrorException: SimpleMeterRegistry
isn't scrapeable
at org.apache.jena.fuseki.servlets.ServletOps.error(ServletOps.java:143)
at
org.apache.jena.fuseki.servlets.ServletOps.errorNotImplemented(ServletOps.java:116)
at
org.apache.jena.fuseki.metrics.SimpleMetricsProvider.scrape(SimpleMetricsProvider.java:36)
at
org.apache.jena.fuseki.ctl.ActionMetrics.perform(ActionMetrics.java:51)
at org.apache.jena.fuseki.ctl.ActionMetrics.doGet(ActionMetrics.java:42)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
```
Some tests of the metrics code would be good. Testing the server is tricky
because you have to have a server and `jena-fuseki-core` isn't a whole server.
test can go into jena-fuseki-main for functional testing and ideally
jena-fuseki-webapp (just to test web.xml/shiro.ini setup).
Code comment
The direct adding of `MeterRegistry` to everywhere `DataAccessPointRegistry`
is created feels wrong :-) but this does not have to be looked at now. The
current way works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] claudew commented on issue #534: [WIP] Proof of concept for prometheus endpoint
claudew commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-479935807 @afs I think you meant @claudenw (Claude Warren), not @claudew (Claude Whitmyer). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jena] afs edited a comment on issue #534: [WIP] Proof of concept for prometheus endpoint
afs edited a comment on issue #534: [WIP] Proof of concept for prometheus
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-479922355
Licensing
@claudew - would you be able to help out with the L issues here?
The LICENSE and NOTICE for the combined binary artifacts (3 of them) wil
need to include BSD-related text.
At the moment, they get autogenerated but we need to put specific text in.
jena-fuseki-server
jena-fuseki-war
jena-fuseki-fulljar
See jena-fuseki-webapp/src/resources/META-INF/ which puts in LICENSE and
NOTICE into a jar but I think we need to do it in the shading step for external
resources like BSD-licnesed binaries.
Packaging
It is easier to add maven modules later than retire them.
Prometheus is sufficiently common I think including in Fuseki core for now
is easier for users.
Proposal: moving it to
jena-fuseki-core::org.apache.jena.fuseki.metrics.prometheus (and the
ServiceLoader file similarly)
and now have the jena-prometheus (which is out of sequence in the build
currently).
Testing
If `jena-prometheus` is not available I get a `500 server error` and a
stacktrace, not 501 (running Fuseki main+Prometheus)
```
[12:47:13] INFO Server :: Start Fuseki (port=3030)
[12:47:18] WARN HttpChannel :: /$/metrics/ds
org.apache.jena.fuseki.servlets.ActionErrorException: SimpleMeterRegistry
isn't scrapeable
at org.apache.jena.fuseki.servlets.ServletOps.error(ServletOps.java:143)
at
org.apache.jena.fuseki.servlets.ServletOps.errorNotImplemented(ServletOps.java:116)
at
org.apache.jena.fuseki.metrics.SimpleMetricsProvider.scrape(SimpleMetricsProvider.java:36)
at
org.apache.jena.fuseki.ctl.ActionMetrics.perform(ActionMetrics.java:51)
at org.apache.jena.fuseki.ctl.ActionMetrics.doGet(ActionMetrics.java:42)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
```
Some tests of the metrics code would be good. Testing the server is tricky
because you have to have a server and `jena-fuseki-core` isn't a whole server.
test can go into jena-fuseki-main for functional testing and ideally
jena-fuseki-webapp (just to test web.xml/shiro.ini setup).
Code comment
The direct adding of `MeterRegistry` to everywhere `DataAccessPointRegistry`
is created feels wrong :-) but this does not have to be looked at now. The
current way works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint
seaninryan commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-479907207 @afs - w.r.t. licenses for `HdrHistogram` and `LatencyUtils` - what's involved there? Downloading and copying in the `LICENCE` files from their github projects or something else? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (JENA-1690) Add support SurroundQueryParser to jena-text
[ https://issues.apache.org/jira/browse/JENA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-1690. - Resolution: Done Assignee: Rob Vesse Fix Version/s: Jena 3.11.0 Merged with [https://github.com/apache/jena/commit/6254f27cbc2aaba863f44bd70a91516c5095ff8e] > Add support SurroundQueryParser to jena-text > > > Key: JENA-1690 > URL: https://issues.apache.org/jira/browse/JENA-1690 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Rob Vesse >Priority: Major > Fix For: Jena 3.11.0 > > > See [pull request 536|https://github.com/apache/jena/pull/536]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
CMS diff: Jena Full Text Search
Clone URL (Committers only): https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Fquery%2Ftext-query.mdtext Damien Fontaine Index: trunk/content/documentation/query/text-query.mdtext === --- trunk/content/documentation/query/text-query.mdtext (revision 1856904) +++ trunk/content/documentation/query/text-query.mdtext (working copy) @@ -952,6 +952,11 @@ "(john jon jonathan~) peters*". This is useful for performing wildcard or fuzzy queries on individual terms in a phrase. +* `SurroundQueryParser`: Provides positional operators (w and n) +that accept a numeric distance, as well as boolean +operators (and, or, and not, wildcards (* and ?), quoting (with "), +and boosting (via ^). + The query parser is specified on the `TextIndexLucene` resource:
[GitHub] [jena] rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
rvesse commented on issue #536: Add support SurroundQueryParser to jena-text URL: https://github.com/apache/jena/pull/536#issuecomment-479810329 Merged, thanks again for the contribution If you have chance to update the docs to mention this new capability that would also be great - http://jena.apache.org/getting_involved/index.html#improving-the-website The easiest way to do this is just to go the relevant page of the docs and hit the "Improve this Page" link in the top corner and your edits will generate a patch that will be sent to us for review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jena] rvesse merged pull request #536: Add support SurroundQueryParser to jena-text
rvesse merged pull request #536: Add support SurroundQueryParser to jena-text URL: https://github.com/apache/jena/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
