[GitHub] grahamtriggs commented on issue #533: Feature/sdborder
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-465710002 @afs Ooops! I've added the Apache header to both of those files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] grahamtriggs commented on issue #533: Feature/sdborder
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-465351735 @afs Hi - I've added some basic tests: 1) There is a test to check that scopes added to the ScopeBase are returned in the correct order 2) There is a simple test of the DISTINCT optimization to see if the SQL generates a GROUP BY 3) There is a simple test of the ORDER optimization to see if the SQL generates an ORDER BY I've also moved where the ORDER optimization is applied to the post-processing (alongside the LIMIT/OFFSET handling), as it is more cleanly applied there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] grahamtriggs commented on issue #533: Feature/sdborder
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464205740 Functionally, the LinkedHastSet (order of Scope), and DISTINCT / GROUP BY translation are tested multiple times during the existing tests - the code is exercised and affects the SQL generated without breaking any of the tests. The ORDER BY translation currently isn't because it's disabled by default, but it could be turned on for the tests (and again it doesn't break any existing tests). I'll have a think about what tests could be included to ensure that the SQL translations occur as expected, beyond just testing the execution of the query. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
