[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98128730 Hm. That does sound weird. I'll take a look and straighten it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/54#issuecomment-98128625
Looks good but I'm having a problem with {{OntResourceImpl.AsMapper}}.
This is removed in {{OntResourceImpl}] but still in use in {{OntClassImpl}},
{{EnumeratedClassImpl}}, {{BooleanClassDescriptionImpl}}, {{DataRangeImpl}}.
Maybe some other changes didn't get committed/pushed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129164 Created JENA-929 to help track this long-term. Just mention JENA-929 in comments and the JIRA wil be updated automatically. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129632 Yep-- Git weirdness. I think that should square it. I'm not mentioning the Jira issue here because Git mistakes don't seem like part of the long-term record. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98129734 Right-- I just amended the commit to fully excise AsMapper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user afs commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133080 Got it - it's clean now. I remove unused imports, replaced Statement.Util and some Triple statics by rewriting the few uses in place e.g. Statement::getSubject. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/54#issuecomment-98133375 Thanks! P.S. Sorry about unused imports and the like. That was sloppy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Deprecating Map1 in favor of Java8 Function
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/54 Deprecating Map1 in favor of Java8 Function Deprecating Map1 in favor of Java8 Function. I believe I have managed to avoid mangling any public contracts presented by Jena. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena DeprecateMap1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 42499d0d4fc157f083b75f878f57919e7e220b4f Author: ajs6f aj...@virginia.edu Date: 2015-04-30T19:27:16Z Deprecating Map1 in favor of Java8 Function --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
