[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...

2015-09-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/92


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...

2015-09-06 Thread afs
Github user afs commented on the pull request:

https://github.com/apache/jena/pull/92#issuecomment-138095533
  
Changes applied.  Thank you very much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...

2015-09-05 Thread afs
Github user afs commented on the pull request:

https://github.com/apache/jena/pull/92#issuecomment-138002455
  
The changes to what look like hand-written vocabularies look good.

Some of these files appear to have been autogenerated by schemagen (e.g the 
ones where the model is `static private m_model` already).

1. As they are private, the compiler will treat them as "effectively final" 
anyway.
1. The files may get overwritten.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---