[GitHub] jena pull request: JENA-508: Partial implementation of Xpath3 func...

[afs]

Github user afs commented on the pull request:

https://github.com/apache/jena/pull/144#issuecomment-219678956
  
Tests: exprStrNormalizeUnicode10, exprStrNormalizeUnicode11

I don't know why they are failing either. May be it's because the version 
of Unicodein Java is not new enough.

I've commented these out for the moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: JENA-508: Partial implementation of Xpath3 func...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/144


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: JENA-508: Partial implementation of Xpath3 func...

[ales004]

GitHub user ales004 opened a pull request:

https://github.com/apache/jena/pull/144

JENA-508: Partial implementation of Xpath3 functions (fn:normalize-space, 
fn:normalize-unicode and fn:round-half-to-even)

I implemented the three Xpath3 functions:
* fn:normalize-space
* fn:normalize-unicode
* fn:round-half-to-even

I tested the functionality taking the examples from the specs (xpath or 
unicode). 
I still have one problem with 2 tests exprStrNormalizeUnicode10 and 
exprStrNormalizeUnicode11 that are not passing. I wrote in the comment of the 
test my findings but I am not sure how to go on from here. Someone could help?

Also while creating fn:round-half-to-even I realized that fn:round-half is 
not following the Xpath3 specs. I thus changes also the fn:round-half 
implementation. Still as I saw that the function used for fn:round-half we used 
for SPARQL ROUND, I decided to separate the two functions. Not sure if also 
SPARQL ROUND should be implemented following the Xpath 3 spec. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ales004/jena master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 3b00217180f86c7570b4a1fb33d9f0078a1132ae
Author: ales004 
Date:   2016-05-02T17:31:12Z

Implemented fn:normalize-space.

First implementation of fn:normalize-space: function and tests.

commit 62394644c624f637f5ff7084b151cc404802e569
Author: ales004 
Date:   2016-05-02T20:00:22Z

Implemented fn:normalized-unicode

First implementation of fn:normalized-unicode with tests. Some doubt remain 
for part of the implementation.

commit 858de20d1e73c0c0c7ca5c3d77b7ac32bda05ba3
Author: ales004 
Date:   2016-05-02T22:30:21Z

Implemented fn:round (xpath3) and fn:round-to-half-even

I implemented fn:round-to-half-even. While implementing it, I realized that 
the fn:round function was not following the xpath3 directive and I thus changed 
it. Still as the round function (without fn) is used in SPARQL and SPARQL 1.1 
seems to be based on Xpath2 (true?), I created a new roundxpath3 function that 
is implementing the xpath3 specs.

commit d5b72f11ca9c8dfae2f607368ea94c745b0b4dcc
Author: ales004 
Date:   2016-05-09T20:55:25Z

Merge remote-tracking branch 'upstream/master'

commit 32437591754328acacede6ea2a0f5fcae693ac44
Author: ales004 
Date:   2016-05-10T19:06:18Z

Merge remote-tracking branch 'upstream/master'

commit 886e5118f591acca28544ab3c0cb2316000b04d6
Author: ales004 
Date:   2016-05-14T14:38:29Z

Merge remote-tracking branch 'upstream/master'

commit b6922449f515541352385e4c4d9bad4435927430
Author: ales004 
Date:   2016-05-14T15:46:26Z

Solved a problem in the round_half_even test (I was not using float)

Tried to solve the problems on the test 10 and 11 for the NormalizeUnicode 
function but could not solve it fully.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---