[GitHub] jena pull request: JENA-624: Correction to transaction begin for D...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: JENA-624: Correction to transaction begin for D...

[afs]

Github user afs commented on the pull request:

https://github.com/apache/jena/pull/103#issuecomment-161800617
  
This is important to get in and i don't want it to miss the release so 
applied as-is.  Also applied a test in `end()` for being called multiple times.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: JENA-624: Correction to transaction begin for D...

[afs]

Github user afs commented on the pull request:

https://github.com/apache/jena/pull/103#issuecomment-160771514
  
Are there some tests for this?

I noticed that `DatasetGraphInMemory.abort` does not call anything. Note 
the contract for transactions is that `end()` is optional for write 
transactions (see javadoc).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: JENA-624: Correction to transaction begin for D...

[ajs6f]

GitHub user ajs6f opened a pull request:

https://github.com/apache/jena/pull/103

JENA-624: Correction to transaction begin for DatasetGraphInMemory

Correction to transaction begin for DatasetGraphInMemory to include default 
graph as well as quad table.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajs6f/jena CorrectionToDatasetGraphInMemory

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #103


commit c9b292293d307de305700981adb3d2d6d424d732
Author: ajs6f 
Date:   2015-11-30T18:23:34Z

Correction to transaction begin for DatasetGraphInMemory to include default 
graph as well as quad table.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---