GitHub user ehedgehog opened a pull request:
https://github.com/apache/jena/pull/43
Test that TextDocProducer with buffered state has opportunity to flush
before dataset commits.
When a TextDatasetGraph commits, it finish()es the attached
TextDocProducer. If that producer
has buffered state whose flushing may read/write the quads of the dataset,
this must happen
before the two-phase commit protocol runs. Pull Request #42 arranged that
this was true.
This Pull Request adds a test to TestTextDatasetAssembler which opens,
writes, and commits
to a dataset with a TextDocProducer which does a quad add to the dataset,
without the commit
failing.
(To see the failure this protects against, edit TextDatasetGraph's commit
method to call the
monitor's finish() method at the end of the commit() rather than the
beginning.)
[Sorry, there's a bunch of tab/space layout noise in the diffs; it's much
easier to track with ?w=1]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/epimorphics/jena-config-doc-producer revised-B
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
commit 36933e64fb51cdf50b53a1ff1b09e79934a21430
Author: Chris Dollin ehog.he...@googlemail.com
Date: 2015-03-17T12:02:44Z
The behaviour of TextDatasetGraph's
two-phase commit did not have a test to ensure that a TextDocProducer with
state
did not fail when closed because that state was not flushed.
CustomDyadicTextDocProducer
is now exercised in TestTextDatasetAssembler with a begin-add-commit-close
to ensure that finish() is called before the rest of the commit process.
commit f07c4c38bd24cd4622026dafeca85869fc7d4380
Author: Chris Dollin ehog.he...@googlemail.com
Date: 2015-03-17T12:06:54Z
Layout changes to eliminate space debris in pull request.
commit 6a017a982a5d408c55a64839a3d0ed84a49ded63
Author: Chris Dollin ehog.he...@googlemail.com
Date: 2015-03-17T13:41:39Z
Layout change -- spaces to tabs, to reduce PR diffsize.
commit 652dd4a7203988c44228a4576e42af2176f85bbc
Author: Chris Dollin ehog.he...@googlemail.com
Date: 2015-03-17T13:48:54Z
More layout change -- introducing to reduce PR diffsize.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
