[GitHub] jena pull request #398: JENA-1523: Allow internal variables names in variabl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/398


---

[GitHub] jena pull request #398: JENA-1523: Allow internal variables names in variabl...

[afs]

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/398#discussion_r181455972
  
--- Diff: 
jena-arq/src/main/java/org/apache/jena/riot/tokens/TokenizerText.java ---
@@ -739,16 +739,21 @@ private String readWordSub(boolean 
leadingDigitAllowed, boolean leadingSignAllow
 return readCharsAnd(leadingDigitAllowed, leadingSignAllowed, 
extraCharsWord, false);
 }
 
-static private char[] extraCharsVar = new char[]{'_', '.', '-', '?', 
'@', '+'};
+// This array adds the other characters that can occurs in an internal 
variable name.
+// Variable a creeated with SPARQL-illegal syntax to encsure they do 
not clash with
--- End diff --

Fixed!


---

[GitHub] jena pull request #398: JENA-1523: Allow internal variables names in variabl...

[ajs6f]

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/398#discussion_r181455157
  
--- Diff: 
jena-arq/src/main/java/org/apache/jena/riot/tokens/TokenizerText.java ---
@@ -739,16 +739,21 @@ private String readWordSub(boolean 
leadingDigitAllowed, boolean leadingSignAllow
 return readCharsAnd(leadingDigitAllowed, leadingSignAllowed, 
extraCharsWord, false);
 }
 
-static private char[] extraCharsVar = new char[]{'_', '.', '-', '?', 
'@', '+'};
+// This array adds the other characters that can occurs in an internal 
variable name.
+// Variable a creeated with SPARQL-illegal syntax to encsure they do 
not clash with
--- End diff --

typos, can be line-changed to:
```
Variables are created with SPARQL-illegal syntax to ensure that they do not 
clash with
```


---

[GitHub] jena pull request #398: JENA-1523: Allow internal variables names in variabl...

[afs]

GitHub user afs opened a pull request:

https://github.com/apache/jena/pull/398

JENA-1523: Allow internal variables names in variable parsing.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afs/jena var-databag

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #398


commit 6a9ad3401cb3cf3326489adc2be4d89d2dc40b8e
Author: Andy Seaborne 
Date:   2018-04-13T16:53:48Z

JENA-1523: Allow internal variables names in variable parsing.




---