rvesse commented on issue #536: Add support SurroundQueryParser to jena-text
URL: https://github.com/apache/jena/pull/536#issuecomment-466525608
 
 
   Pinging @osma @xristy 
   
   Not that it's a blocker for this PR but anytime I see this kind of code 
pattern in Jena (and Java in general) I think that we really should be using 
the `ServiceLoader` pattern.  This would make stuff like this dynamically 
extensible so we can have some basic defaults out of the box with an easy 
drop-in mechanism to discover user provided extensions.  And text search does 
seem to be an area where end users want to do a lot of customisation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to